[00:12:13] (CR) Adamw: [C: 2] "it's no prettier :p" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87289 (owner: Mwalker) [00:14:47] #1104: (K) Tech Task #1104 Review DI and Drupal modules for errors that store ct.country into civi_address.country: O:K|TS:B|P:MH|T:TT Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1104 [00:14:47] #889: (K) Created #1103 and #1104 to address this issue. ... -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/889 [00:15:52] #889: (K) *Deployed* -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/889 [00:30:52] #764: (K) P:SH -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/764 [00:34:46] #903: (K) P:SH -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/903 [00:34:46] #1008: (K) P:SH -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1008 [00:51:45] #456: (K) As of today, I can't reproduce this issue. Movi... -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/456 [00:51:45] #456: (K) O:K|TS:DR -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/456 [00:51:45] #456: (K) AT:K|TS:ID -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/456 [00:52:50] #456: (K) TS:PD -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/456 [00:52:50] #456: (K) *Deployed* -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/456 [00:54:45] #829: (K) Changed estimate just for the number of things ... -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/829 [00:54:45] #904: (K) P:SH -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/904 [01:07:44] #1039: (K) P:SH -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1039 [01:07:45] #1043: (K) P:H -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1043 [01:08:44] #1059: (K) P:SH -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1059 [01:09:45] #1067: (K) P:SH -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1067 [02:12:28] (PS1) Adamw: WIP (FR #1048) Knob to throttle campaign traffic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87306 [02:12:40] (CR) jenkins-bot: [V: -1] WIP (FR #1048) Knob to throttle campaign traffic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87306 (owner: Adamw) [02:15:14] (PS2) Adamw: WIP (FR #1048) Knob to throttle campaign traffic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87306 [02:16:28] (PS3) Adamw: WIP (FR #1048) Knob to throttle campaign traffic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87306 [02:16:37] (CR) jenkins-bot: [V: -1] WIP (FR #1048) Knob to throttle campaign traffic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87306 (owner: Adamw) [03:05:18] (PS1) Mwalker: (FR #1077) Make banner logs work again [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87308 [03:05:45] #1077: (MW) https://gerrit.wikimedia.org/r/87308 -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1077 [03:05:45] #1077: (MW) TS:PCR -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1077 [06:16:46] #1105: (AW) Tech Defect #1105 failmail is now lobotomized: O:AW|TS:B|P:SH|T:TD Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [06:16:46] #1105: (AW) ->Sprint 32 -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [06:18:51] #1105: (AW) Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [06:57:33] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87308 (owner: Mwalker) [07:59:29] meganhernandez: morning! [07:59:58] Just looking at the Adyen snafu; did the thumbtack results show significance? [08:03:16] meganhernandez: I get this, http://www.thumbtack.com/labs/abba/#adyen=960%2C1734&gc=1034%2C1789&abba%3AintervalConfidenceLevel=0.95&abba%3AuseMultipleTestCorrection=true [08:03:29] the p-value is .15, so we just don't have enuf data [08:03:53] (just looking at conversion) [08:04:18] even impressions->clicks was a p-value of .15... [08:12:44] morning awight [08:13:01] where did you get the number of trials? [08:13:14] i used the number of impressions: http://www.thumbtack.com/labs/abba/#ayden=950%2C853300&global+collect=1034%2C839000&abba%3AintervalConfidenceLevel=0.95&abba%3AuseMultipleTestCorrection=true [08:13:48] ah you used clicks [08:14:37] meganhernandez: I don't think impressions -> donations is fair... [08:14:46] trying to formulate why... [08:14:59] yes [08:16:22] because when you multiply the two (semi)random processes together, an unlucky streak in one step will influence the results for the next step. [08:16:30] Sometimes that's ok [08:16:33] maybe... [08:17:05] but in this case, the steps should in theory be totally independent-- the impressions->clicks step should not have been biased, because we used the same banner (presumably) [08:17:13] so we need to factor that out, [08:17:32] and i think the right way to do it is to look at the second step in isolation, clicks->donations [08:19:43] well except that the ayden banner had more impressions, so had more chance for people to click in the first place [08:20:19] so if the two banners actually ran 50/50, the way you're talking about would seem more fair [08:20:21] right? [08:21:12] I get the first sentence, but not the connection you are making about 50/50 making anything more fair [08:21:19] cos, nothing will ever be 50/50... [08:21:34] Sorry I do not know the correct terminology for this stuff [08:22:03] but the bias in the first half of the test is noticeable, like you're saying, so we need to factor that out somehow. [08:22:22] (and I think this amount of bias is totally normal... this is the "random walk" effect) [08:22:49] (the WP article on that is good, i just noticed) [08:24:43] digression... but I guess I don't know the exact formula for how to compensate for the adyen banner having an clickthrough advantage due to random luck [08:25:45] it definitely isn't correct to skip over the clicks tho, when comparing donations [08:26:51] I'll work on making this argument better, another day... I am just realizing that this is an issue in all of our analysis [08:27:38] For this Adyen thing, though, don't you agree that looking at the clickthrough and conversion rates in isolation from each other is a valid way of looking at the problem? [08:27:52] If that's true, then I think we simply don't have significance yet... [08:30:15] yes, we look at both [08:30:17] Dammit. I know these are called independent events, cos the success of clickthrough has no effect at all on the conversion, but I am dying trying to find the principle that they cannot be analyzed together [08:31:06] but even if we compare just the credit card conversion, ayden still looks behind. 39% vs 44% [08:31:17] but yes, i have let tests run much longer to get a bigger difference [08:31:24] i'm fine to put this back up for longer [08:31:32] I see that it's behind, but p=.15 for each step [08:31:51] i can let it run longer today, but it seems like ayden will still stay behind [08:32:03] but we're not losing a ton by leaving it up [08:32:09] Can we run this by Sayhar? I think he must have thought about this issue [08:32:44] It's fine that Adyen is behind, it should not make a difference to the quality of the result [08:32:44] sure, we have thought about it a ton. i do think it makes sense to look at both don/imp & conversion [08:33:00] I think it has to do with the type of test [08:33:20] if we are testing banner, sure, cos the banner influences the state of mind, etc for the rest of the test [08:33:33] but if the banners are the same, we have to take that factor out entirely [08:35:05] The part that surprised me was, adyen is winning in clickthrough with exactly the same margin and p-value as it is losing in conversion [08:36:15] But one way of looking at that is, both steps of the test are roughly the same randomness... [08:36:59] so if the clickthrough is using an algorithm that is giving A vs B 50% of the time, then the conversion is behaving exactly the same, like a 50/50 thing [08:37:15] ... which does not look 50/50 at this size N, of course [08:39:47] wait, where do you see adyen winning in click through? [08:40:55] err sorry i was wrong. same principle tho [08:43:40] it is late for you! baby keeping you up? [08:45:06] hehe. I'm trying to knock out a thing before vacation starting Friday [08:45:24] oh where you going? [08:45:32] or staycation with fan ? [08:45:34] fam? [08:45:36] It's super boring code testing stuff, sorry if I have too much input on this topic [08:45:42] ;) [08:46:05] Just to show off the booblump to my extended family [08:47:13] nice [08:47:29] I wanna get the knob I mocked-up today ready for you to play with next week... [08:47:43] Otherwise, I fear it will never happen [08:48:13] It should really simplify coordination between CN admins, I hope [08:49:08] yeah let's have peter get a good look at it [08:49:10] lol "staycation", for some reason I haven't heard that one yet [08:49:25] that is my life :p [08:49:32] he has spent a lot of time helping figure out allocations [08:49:54] staycations can be awesome [08:50:02] poor guy! doing an fantastic job at it tho [08:50:15] yeah he's doing great [08:50:37] getting peter on FT was one of our greatest accomplishments this year! [08:52:28] Yes! Let's do that again, for -tech! [08:52:45] that's the idea [09:30:18] Whoohoo! The blank banner knob works [09:43:40] ah, FT is fr-tech /me was wondering how he wasn't fulltime [09:48:13] (PS4) Adamw: WIP (FR #1048) Knob to throttle campaign traffic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87306 [17:09:15] (PS1) Adamw: Schema for campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87360 [17:12:32] (PS2) Adamw: Schema for campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87360 [17:25:19] (PS1) Adamw: (FR #1048) Campaign throttle knob [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87365 [17:27:20] (PS1) Adamw: WIP (FR #1048) Allocations perform campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87366 [17:28:21] (Abandoned) Adamw: WIP (FR #1048) Knob to throttle campaign traffic [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87306 (owner: Adamw) [17:54:52] (CR) Mwalker: [C: 1] "(2 comments)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 (owner: Adamw) [17:56:21] (CR) Mwalker: [C: 1] Schema for campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87360 (owner: Adamw) [18:05:44] #1106: (AW) Tech Task #1106 Spike: define requirements for FR cron: O:AW|TS:B|P:NtH|T:TT Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1106 [18:32:35] (PS1) Adamw: Bugfix for damaged queue failmails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87428 [18:32:45] mwalker: U have a minute for that ^^ ? [18:33:01] has been tested locally. [18:33:44] we really need a stub stomp... [18:38:19] (CR) Mwalker: "(1 comment)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87428 (owner: Adamw) [18:39:15] (CR) jenkins-bot: [V: -1] Bugfix for damaged queue failmails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87428 (owner: Adamw) [18:47:00] (PS3) Adamw: Schema for campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87360 [18:47:01] (PS2) Adamw: WIP (FR #1048) Allocations perform campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87366 [18:47:02] (PS2) Adamw: (FR #1048) Campaign throttle knob [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87365 [18:50:41] (CR) Adamw: [C: -2] "Err, please don't say the series must be deployed as a whole ;) It's pretty meticulously not like that... I'm moving this patch to the e" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 (owner: Adamw) [19:04:19] (PS3) Adamw: (FR #1048) Allocations perform campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87366 [19:04:26] (CR) jenkins-bot: [V: -1] (FR #1048) Allocations perform campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87366 (owner: Adamw) [19:07:01] (PS3) Adamw: Campaign checkbox to balance all banner weights [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 [19:07:16] (CR) jenkins-bot: [V: -1] Campaign checkbox to balance all banner weights [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 (owner: Adamw) [19:08:46] #1048: (AW) TS:PCR -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1048 [19:08:46] #1048: (AW) Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1048 [19:12:55] (PS4) Adamw: (FR #1048) Allocations perform campaign throttling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87366 [19:13:15] (PS4) Adamw: Campaign checkbox to balance all banner weights [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 [19:13:25] (CR) Adamw: Campaign checkbox to balance all banner weights [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 (owner: Adamw) [20:01:12] (CR) Adamw: "(1 comment)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87428 (owner: Adamw) [20:25:45] (CR) Adamw: [C: 1] "(4 comments)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87308 (owner: Mwalker) [20:37:45] #1107: (AW) Tech Task #1107 CiviCRM: security upgrade: O:AW|TS:B|P:MH|T:TT Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1107 [20:37:46] #1107: (AW) ->Sprint 32 -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1107 [20:37:46] #1107: (AW) TS:DR -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1107 [20:37:46] #1107: (AW) AT:AW|TS:ID -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1107 [20:39:47] (CR) Mwalker: [C: 2 V: 2] Bugfix for damaged queue failmails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87428 (owner: Adamw) [20:39:48] (CR) jenkins-bot: [V: -1] Bugfix for damaged queue failmails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87428 (owner: Adamw) [20:45:46] #1108: (MW) Tech Task #1108 WTH is wrong with paypal in china: O:MW|TS:B|P:NtH|T:TT Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1108 [20:51:43] (PS1) Adamw: Update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87443 [20:51:44] (CR) jenkins-bot: [V: -1] Update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87443 (owner: Adamw) [20:51:52] K4-713: or mwalker: ^^ [20:52:14] ? [20:52:28] If you have a second, I'm upgrading Civi and would like a ++ [20:52:37] aaaha. [20:53:11] size... zero? [20:53:20] eh it's a submodule [20:53:31] * K4-713 facepalms slightly [20:53:34] ... see if I can link to the submodule patch [20:54:16] Wait, how did you do that without CR at the submodule level? [20:54:27] hehe looks like I did not upload [20:54:53] Like, you have to merge it before you can get the right hash... right? [20:55:05] (PS1) Adamw: Merge remote-tracking branch 'origin/contrib' into HEAD [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/87444 [20:55:11] (CR) jenkins-bot: [V: -1] Merge remote-tracking branch 'origin/contrib' into HEAD [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/87444 (owner: Adamw) [20:55:12] That's it [20:55:33] * K4-713 frowns again [20:55:40] dammit [20:56:15] https://git.wikimedia.org/commitdiff/wikimedia%2Ffundraising%2Fcrm%2Fcivicrm/cc05ce6cd406fbd5fedfa49bda6ebfd2f428d970 [20:57:53] "170 files modified" [20:57:56] um, you could also compare the release against origin/contrib :( [20:57:57] http://downloads.sourceforge.net/project/civicrm/civicrm-stable/4.2.12/civicrm-4.2.12-drupal.tar.gz?r=http%3A%2F%2Fsourceforge.net%2Fprojects%2Fcivicrm%2Ffiles%2Fcivicrm-stable%2F4.2.12%2F&ts=1380833074&use_mirror=softlayer-dal [20:58:58] So... this looks pretty major. [20:59:21] It's... an minor version upgrade [20:59:55] We usually test upgrades like these against a replica of prod... [20:59:56] I can also apply the patch for the SA only [21:00:56] ...and then at least turn off all the jenkins stuff while the schema changes are running. [21:01:17] Once we have an idea, from the test upgrade, of how long it's going to run schema updates. [21:02:12] (CR) Siebrand: [C: 1] "(1 comment)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 (owner: Adamw) [21:02:47] (PS1) Adamw: Apply upstream security patch https://github.com/civicrm/civicrm-core/pull/1708.diff [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/87446 [21:02:57] K4-713: let's do this for now ^^ [21:03:08] other upgrades can wait [21:04:06] (CR) Katie Horn: [C: 2 V: 2] Apply upstream security patch https://github.com/civicrm/civicrm-core/pull/1708.diff [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/87446 (owner: Adamw) [21:04:16] awight: I'm good with that. [21:04:17] (PS1) Adamw: update civicrm submodule for SA [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87447 [21:04:43] (CR) jenkins-bot: [V: -1] update civicrm submodule for SA [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87447 (owner: Adamw) [21:05:08] (CR) Adamw: [C: 2 V: 2] update civicrm submodule for SA [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87447 (owner: Adamw) [21:05:15] (CR) jenkins-bot: [V: -1] update civicrm submodule for SA [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87447 (owner: Adamw) [21:05:37] Jeff_Green: ok u may stand down ;) K4-713 talked me out of schematic suicide [21:05:50] ha ok [21:25:41] !log updated civicrm 6affe8a9cee57f76602a25d60d96edc7eaaae4b2 to 7690ee9f80c6e53d946195e453cf17e197f3138a [21:25:54] Logged the message, Master [21:27:21] (PS5) Adamw: Campaign checkbox to balance all banner weights [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 [21:27:30] (CR) Adamw: "@Siebrand: thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 (owner: Adamw) [21:27:32] (CR) Siebrand: [C: -1] "(1 comment)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87365 (owner: Adamw) [21:28:44] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87251 (owner: Adamw) [21:30:53] (CR) Adamw: "(1 comment)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87365 (owner: Adamw) [21:31:23] K4-713: any clever techniques to force a failmail? [21:31:34] hmm [21:31:42] ...sabotage. [21:31:54] aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaawight@wikimedia.org. :p [21:31:58] ;) Yes I could inject mq manually but it's scary [21:32:03] nice [21:35:45] #1109: (AW) Tech Defect #1109 Donatewiki: decimal point silently removed: O:AW|TS:B|P:MH|T:TD Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1109 [21:35:45] #1109: (AW) AT:PC -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1109 [21:38:41] (CR) Siebrand: "(1 comment)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87365 (owner: Adamw) [21:42:40] (PS1) Adamw: production stomp is fussy about /queue/ prefix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87454 [21:42:41] (CR) jenkins-bot: [V: -1] production stomp is fussy about /queue/ prefix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87454 (owner: Adamw) [21:43:03] mwalker: 1-liner? ^^ [21:43:44] I am really getting annoyed at jenkins bot [21:43:49] NO KIDDING [21:43:57] (CR) Mwalker: [C: 2 V: 2] production stomp is fussy about /queue/ prefix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87454 (owner: Adamw) [21:43:58] Is it doing that on every repo? [21:43:58] (CR) jenkins-bot: [V: -1] production stomp is fussy about /queue/ prefix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87454 (owner: Adamw) [21:44:03] no [21:44:13] (CR) Adamw: [C: 2 V: 2] production stomp is fussy about /queue/ prefix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87454 (owner: Adamw) [21:44:43] marktraceur: when you get a moment; could you look at the jenkins bot for us in wikimedia/fundraising/crm and tell us why it's unable to merge changes with the current state of the repo [21:44:54] Sure [21:45:02] It usually means a rebase is necessary [21:45:23] in this case -- unlikely; because we can merge without rebase [21:45:43] e.g.; the change is a simple branch off the tip of master [21:45:58] !log updated crm from 7690ee9f80c6e53d946195e453cf17e197f3138a to cf90889b3728e1bfb2175574640a18511d60e2b9 [21:46:10] Logged the message, Master [21:48:45] (PS1) Mwalker: Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 [21:48:46] (CR) jenkins-bot: [V: -1] Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [21:49:02] marktraceur: e.g. ^ [21:49:18] Wait. [21:49:21] Patchset one? [21:49:27] * marktraceur is confused and will look shortly [21:51:05] (CR) Adamw: "(1 comment)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/87365 (owner: Adamw) [21:52:45] #1107: (AW) TS:PCR -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1107 [21:52:45] #1107: (AW) TS:PD -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1107 [21:52:45] #1107: (AW) *Deployed* -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1107 [21:52:45] #1097: (AW) *Deployed* -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1097 [21:53:45] #1105: (AW) TS:DR -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [21:53:45] #1105: (AW) AT:AW|TS:ID -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [21:53:45] #1105: (AW) TS:PCR -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [21:54:49] (PS1) Katie Horn: takes an xml file downloaded from iso.org and generates a php array of valid country codes. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/87460 [21:58:45] #1105: (AW) Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [21:58:45] #1105: (AW) TS:PD -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [21:58:45] #1105: (AW) *Deployed* -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1105 [21:59:45] #1107: (AW) Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1107 [22:00:59] (CR) Adamw: [C: 2 V: 2] "(2 comments)" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/87460 (owner: Katie Horn) [22:31:35] (PS1) Adamw: stupid typeo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87469 [22:31:36] (CR) jenkins-bot: [V: -1] stupid typeo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87469 (owner: Adamw) [22:34:29] (CR) Katie Horn: [C: 2 V: 2] "hurrr." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87469 (owner: Adamw) [22:35:00] (CR) jenkins-bot: [V: -1] stupid typeo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87469 (owner: Adamw) [22:36:31] (CR) Adamw: [C: 2 V: 2] stupid typeo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87469 (owner: Adamw) [22:38:05] !log updated crm from cf90889b3728e1bfb2175574640a18511d60e2b9 to b4392c76d21287f835076f761436fc7386845a19 [22:38:15] Logged the message, Master [22:47:45] #1110: (AW) Tech Defect #1110 Rejected message: take correlation id from normalized msg?: O:AW|TS:B|P:SH|T:TD Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1110 [22:50:45] #876: (AW) -:1i|TS:PD -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/876 [22:54:14] Agh, forgot about your jenkins question [22:54:51] marktraceur: no worries -- just please fix it! its terribly annoying [22:54:57] (or tell us what we're doing wrong) [22:55:48] Will do [22:56:10] (PS2) MarkTraceur: Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [22:56:10] * marktraceur tries [22:56:11] (CR) jenkins-bot: [V: -1] Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [22:56:13] Huh. [22:56:26] I know! [22:56:29] That's miraculous. [22:56:36] Miraculously bad, but still [22:58:47] * marktraceur looks for zuul config [23:00:00] Hrm [23:00:45] Oh [23:01:04] mwalker: Someone copied the test configs for fundraising-tools and used them for fundraising-crm [23:01:15] So of course it won't work because you're pulling the wrong git repository [23:01:33] oh; thats fun [23:01:38] * mwalker hopes it doesn't blame back to him [23:01:41] I'll submit a patch [23:02:02] Guess again :) [23:02:32] jeremy posthelweight [23:02:33] ! [23:02:39] or however you spell his name [23:02:48] So close. [23:04:10] postlethwaite* ? [23:04:40] French for "in this name, after 'le', there's 'thwaite'" [23:04:43] ding, ding, ding! :) [23:05:53] Alternatively, Italian for "mail the thwaite" [23:06:48] (PS3) MarkTraceur: Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [23:06:49] (CR) jenkins-bot: [V: -1] Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [23:06:58] CRap [23:07:33] (PS4) MarkTraceur: Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [23:08:50] (CR) jenkins-bot: [V: -1] Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [23:08:58] noooo :( [23:09:25] at least it's not immediately failing though this time [23:09:48] That was because there were a bunch of things queuede [23:09:50] queued* [23:09:53] But I see the error now [23:10:04] It's trying to update a git repository that doesn't exist I think [23:11:41] Oh, durr [23:11:49] Because the directory *exists* but isn't a git repo [23:11:52] Bug in zuul [23:11:55] I'll report it [23:13:23] whooo [23:16:12] nice work! [23:16:19] mwalker: https://bugs.launchpad.net/zuul/+bug/1235005 [23:17:17] can we fix it locally? [23:17:27] presumably just by manually cloning down the repo [23:17:47] Probably, but I'd rather hashar did it [23:17:56] I'm not sure I have the right spot, or what I'd break if I did that [23:20:00] (PS5) MarkTraceur: Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [23:20:19] (CR) jenkins-bot: [V: -1] Dummy commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/87457 (owner: Mwalker) [23:20:47] mwalker, awight_: Moar country-code quizzings. [23:20:53] Do either of you think... [23:21:02] no [23:21:07] ...oh. [23:21:09] that requires too much effort [23:21:14] okay then. [23:21:17] :p [23:21:20] :) [23:21:33] No, I was going to ask: Is saving non-iso codes other than XX useful in any way? [23:21:50] not that I can think of [23:22:12] Like, does... A1 tell you anything special that you care about losing? I mean, you said it was a proxy earlier, but we don't care about that in contribution_tracking or beyond, do we? [23:22:53] no; I only care about it in Centralnotice [23:22:57] k [23:23:14] and even then I have it because it's a curiosity I like to track :) [23:23:27] I'll just save everything we can't pin down accurately as XX, then. [23:28:58] mwalker: can you refresh that funky page? I cannot reproduce the error, and api docs match what I'm doing in hook_menu. So I jiggled the registry and cache... [23:30:37] refreshed -- still get it -- and I cleared my local cache / cookies / local storage [23:30:45] you dont get it I take it? [23:30:47] mwalker: also, does it seem to hang about 5 seconds, or returns immediately? [23:30:50] no [23:30:55] WTF [23:31:26] I waited 2.93seconds apparently [23:31:44] Hmm. 8 seconds for me [23:32:00] try https://civicrm.wikimedia.org/admin/import_checks just for fun [23:32:17] that should behave exactly the same way [23:32:24] oooh; that's fun [23:32:25] Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'offline2civicrm_import_checks_form' not found or invalid function name in drupal_retrieve_form() (line 798 of/srv/org.wikimedia.civicrm/drupal/includes/form.inc). [23:32:29] WHJAT [23:32:31] WFM [23:34:20] I can still get into config/thank_you and config/wmf_common [23:41:44] Card #1111 oooo, bad luck [23:41:45] #1111: (AW) Tech Defect #1111 Drupal: inconsistent menu issues: O:AW|TS:B|P:NtH|T:TD Description changed -- https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/1111