[00:03:04] (CR) Adamw: "please uncommit the submodule bump" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92815 (owner: Katie Horn) [00:05:57] (CR) Adamw: [C: 2] Fix for wmf_civicrm_mark_refund Zero is a valid count with a rowcount of 1. The very next "if" always errors. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92815 (owner: Katie Horn) [00:06:07] (CR) Adamw: [C: -1] Fix for wmf_civicrm_mark_refund Zero is a valid count with a rowcount of 1. The very next "if" always errors. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92815 (owner: Katie Horn) [00:07:05] (PS2) Adamw: Fix for wmf_civicrm_mark_refund [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92815 (owner: Katie Horn) [00:07:16] (CR) Adamw: [C: 2 V: 2] Fix for wmf_civicrm_mark_refund [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92815 (owner: Katie Horn) [01:07:08] !log crm updated from 06348e7eea3c914e9444af588e0d7ffeb640366c to dca2c8cc0eaa503e6d0c9921952cb85855e3b110 [01:07:26] Logged the message, Master [09:17:55] (CR) Helder.wiki: "(1 comment)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/92777 (owner: Mwalker) [14:54:42] i wonder what the deduper does [17:15:22] (CR) Mwalker: [C: 2] revert annoying TRIGGER logging from civi core. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/92673 (owner: Adamw) [18:18:27] (PS1) Katie Horn: Make the queue server connection reusable As it currently stands, making a new connection for every message is blowing up the only job that uses sendSTOMP, besides being crazy-inefficient. That has to stop. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92918 [18:19:26] K4-713: Two newlines :) [18:19:45] * marktraceur nitpicks even with teams he's not in [18:23:45] marktraceur++ [18:24:18] marktraceur: https://gerrit.wikimedia.org/r/92808 needs some newline too [18:27:14] marktraceur: fix https://gerrit.wikimedia.org/r/92808 too? kthx! [18:27:43] * marktraceur not fixing jack [18:27:50] Gotta watch the deploy fail spectacularly [18:28:15] yeah, that's too much wall of text for me [18:28:23] and i need foods [18:33:51] (CR) Mwalker: "(1 comment)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92918 (owner: Katie Horn) [18:35:04] (PS2) MarkTraceur: Make the queue server connection reusable As it currently stands, making a new connection for every message is blowing up the only job that uses sendSTOMP, besides being crazy-inefficient. That has to stop. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92918 (owner: Katie Horn) [18:35:11] Fine [18:35:14] I did it [18:54:51] (CR) Mwalker: [C: 2] (FR #989) recurring error handling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/91333 (owner: Adamw) [21:10:25] (PS1) Katie Horn: Removing a super-annoying log line, and preventing a frequent warning. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92981 [21:12:06] (CR) Mwalker: [C: 2 V: 2] Removing a super-annoying log line, and preventing a frequent warning. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92981 (owner: Katie Horn) [22:58:03] (CR) Adamw: [C: 2 V: 2] "In the future, let's just use queue2civicrm_stomp()->getConnection()" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/92918 (owner: Katie Horn)