[00:01:13] <K4-713>	 hm.
[00:01:33] <K4-713>	 WD php: Notice: Undefined index: language in wmf_civicrm_message_contact_insert() (line 707 of /srv/org.wikimedia.civicrm/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module).
[00:02:23] <awight>	 that one doesn't scare me as much as WD php: Notice: Undefined index: contact_id in                          [notice]
[00:02:26] <awight>	 recurring_import_subscr_payment() (line 303 of
[00:02:28] <awight>	 /srv/org.wikimedia.civicrm/sites/all/modules/queue2civicrm/recurring/recurring.module).
[00:03:12] <K4-713>	 Lots of "undefined" in there...
[00:03:27] <mwalker>	 K4-713: since I'm looking at this right now; we should probably get Sue to write another Thank You letter
[00:03:46] <mwalker>	 I'll write an email about that actually
[00:03:51] <K4-713>	 Megan usually does that bit...
[00:04:05] <K4-713>	 ...she may already have started down that road and not mentioned it, actually.
[00:06:28] <K4-713>	 awight: What do we want to do about these notices?
[00:07:28] <awight>	 OMG this is another paypal thank-you hole.
[00:07:33] <awight>	 that contribution_id thing
[00:07:35] <awight>	 fixing now
[00:07:44] <K4-713>	 "Thank-you Hole".
[00:08:03] <K4-713>	 Suddenly I want to buy a bar.
[00:08:05] <awight>	 yeah, "undefined index contact_id"
[00:08:18] <awight>	 oh nvm fuck stale comment
[00:08:19] <awight>	 argh
[00:09:22] <K4-713>	 disabling qc again.
[00:10:35] <awight>	 why?
[00:10:46] <awight>	 either way
[00:11:10] <awight>	 just saying, did you see how many warnings we had earlier today?
[00:17:59] <K4-713>	 Well, if it's about to be way better in a few minutes, I want more messages on that run. :)
[00:27:44] <grrrit-wm>	 (PS1) Adamw: recurring payments were not triggering post-import hooks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/93139
[00:27:51] <awight>	 K4-713: more better ^^
[00:27:55] <awight>	 there will be one more installment...
[00:28:13] <K4-713>	 looking
[00:28:26] <awight>	 I just discovered that paypal import is forcing preferred_language=en_US
[00:28:47] <K4-713>	 does the message actually have a better idea?
[00:28:54] <awight>	 no
[00:28:59] <awight>	 but i want NULL
[00:29:03] <K4-713>	 aha
[00:29:05] <K4-713>	 Yes.
[00:29:07] <K4-713>	 Good.
[00:29:37] <K4-713>	 ...so long as something falls from NULL to Readable.
[00:31:08] <awight>	 holy handgrenade.  It is actually defaulting to "current language of running script"
[00:39:54] <awight>	 !log updated crm from da3448df1404311620adc50b4d4ca28abfd2f3cb to 272966e353244e668a64c54ca4fa6f344079f4bf
[00:40:06] <morebots>	 Logged the message, Master
[00:44:13] <K4-713>	 awight: Should I reenable?
[00:44:28] <K4-713>	 oh.
[00:44:43] <K4-713>	 nvm
[00:47:15] <K4-713>	 awight: Didn't you do some of this?
[00:47:16] <K4-713>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/554
[00:47:37] <K4-713>	 Like... make it a manual task? :p
[00:47:46] <K4-713>	 Gah, nvm. Deleting.
[00:56:38] <awight>	 hehe, I lost that opportunity
[01:16:49] <grrrit-wm>	 (PS1) Adamw: Guess donor language from contribution_tracking if necessary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/93148
[11:27:18] <Reedy>	      19 PHP Warning:  Missing argument 3 for CentralNoticeCampaignLogPager::testBooleanChange(), called in /usr/local/apache/common-local/php-1.23wmf1/extensions/Centra
[11:27:19] <Reedy>	 lNotice/CentralNoticeCampaignLogPager.php on line 250 and defined in /usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.
[11:27:19] <Reedy>	 php on line 309
[11:27:19] <Reedy>	      19 PHP Warning:  Missing argument 3 for CentralNoticeCampaignLogPager::testBooleanChange(), called in /usr/local/apache/common-local/php-1.23wmf1/extensions/Centra
[11:27:19] <Reedy>	 lNotice/CentralNoticeCampaignLogPager.php on line 249 and defined in /usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.
[11:27:19] <Reedy>	 php on line 309
[11:27:21] <Reedy>	      19 PHP Warning:  Missing argument 3 for CentralNoticeCampaignLogPager::testBooleanChange(), called in /usr/local/apache/common-local/php-1.23wmf1/extensions/Centra
[11:27:24] <Reedy>	 lNotice/CentralNoticeCampaignLogPager.php on line 247 and defined in /usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.
[11:27:26] <Reedy>	 php on line 309
[11:28:23] <Reedy>	 	 * @param array $oldrow Required because this is a stupid heirarchy -- @see CentralNoticeBannerLogPager
[11:28:29] <Reedy>	 	private function testBooleanChange( $param, $row, $oldrow ) {
[11:29:05] <Reedy>	 Said parameter is unusd
[11:29:08] <Reedy>	 I'm confused
[11:29:43] <Reedy>	 It's only used on those 3 lines
[11:36:50] <grrrit-wm>	 (PS1) Reedy: Remove unused parameter from testBooleanChange to fix warnings [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/93156
[11:37:26] <grrrit-wm>	 (PS1) Reedy: Remove unused parameter from testBooleanChange to fix warnings [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/93157
[11:37:49] <Reedy>	 the next question being is head of wmf_deploy what 1.23wmf1 is using