[00:07:56] dangit. [00:23:53] mwalker: Is https://gerrit.wikimedia.org/r/#/c/93602/1 not deployed yet? [00:24:02] Nov 22 19:00:35 mw1058: PHP Warning: Missing argument 3 for CentralNoticeCampaignLogPager::testBooleanChange(), called in /usr/local/apache/common-local/php-1.23wmf4/extensions/CentralNotice/CentralNoticeCampaignLogPager.php on line 250 and defined in /usr/local/apache/common-local/php-1.23wmf4/extensions/CentralNotice/CentralNoticeCampaignLogPager.php on line 309 [00:24:03] Nov 22 19:00:35 mw1058: PHP Warning: Missing argument 3 for CentralNoticeCampaignLogPager::testBooleanChange(), called in /usr/local/apache/common-local/php-1.23wmf4/extensions/CentralNotice/CentralNoticeCampaignLogPager.php on line 251 and defined in /usr/local/apache/common-local/php-1.23wmf4/extensions/CentralNotice/CentralNoticeCampaignLogPager.php on line 309 [00:24:22] interesting [00:24:27] let me look [00:24:42] I was going through http://etherpad.wikimedia.org/p/ApacheErrors and WTFd [00:25:11] I also noticed there was no bug for it [00:26:06] apparently it never made it into the deploy branch [00:26:25] which means that we haven't done a centralnotice deploy since Nov 4... which seems unlikely [00:27:01] but... is true [00:27:11] ok; I'll push it next next monday [00:28:12] (PS1) Mwalker: Cache Hide Requests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/97150 [00:28:21] (PS1) Mwalker: Do not mobilify hide links [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/97151 [00:28:38] (CR) Mwalker: [C: 2] "Approved by adam in the other branch" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/97150 (owner: Mwalker) [00:28:49] (Merged) jenkins-bot: Cache Hide Requests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/97150 (owner: Mwalker) [00:28:49] (CR) Mwalker: [C: 2] "Approved by adam in the other branch" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/97151 (owner: Mwalker) [00:29:01] (Merged) jenkins-bot: Do not mobilify hide links [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/97151 (owner: Mwalker) [01:22:27] (PS1) Aude: Allow query campaign api to work for campaigns with space in their names [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/97170 [01:24:39] (CR) PiRSquared17: [C: 1] "Thanks." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/97170 (owner: Aude) [01:27:11] cool!