[00:00:24] #1234: (MW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1234 [00:00:24] #1234: (MW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1234 [00:00:24] #1234: (MW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1234 [00:00:44] oy eah? cool ^^ [00:02:43] ya [00:02:51] at least its not throwing errors any more [00:02:57] but I am suspicious of the stuff in the DB [00:10:24] #1066: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1066 [00:10:24] #1066: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1066 [00:10:24] #1066: (AW) P:E -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1066 [00:55:55] (PS1) Adamw: (FR #1066) Overly specific hack to bubble up DB_Error details [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/99286 [00:56:11] mwalker: urgentish thing ^^ [00:56:34] I presume you've also upstreamed it? [00:56:56] eh? [00:56:58] noway [00:57:03] it's a hack... [00:57:23] #1066: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1066 [00:57:48] wth kind of syntax is this!? catch(Exception$e) { [00:57:54] why does that even work? [00:57:59] let's not look too closely [00:58:15] PHP should not work [00:58:21] (CR) Mwalker: [C: 2] "This looks hacky as shit; but whatever" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/99286 (owner: Adamw) [00:58:53] lol [00:59:44] That makes for 5 occurrences of the word "hack" in that patch [01:00:47] we're just making damn sure [01:00:52] doggammit. There is an undeployed Civi upgrade on that branch [01:02:09] gawd. Sorry your joke worked on me, earlier. Yes, I've upstreamed. [01:03:30] (PS1) Adamw: (FR #1066) Overly specific hack to bubble up DB_Error details [wikimedia/fundraising/crm/civicrm] (deployment) - https://gerrit.wikimedia.org/r/99290 [01:03:56] that is annoying. [01:04:26] (Abandoned) Adamw: (FR #1066) Overly specific hack to bubble up DB_Error details [wikimedia/fundraising/crm/civicrm] (deployment) - https://gerrit.wikimedia.org/r/99290 (owner: Adamw) [01:07:44] !log updated crm from daff8fa245084ff372490d1d6d85313078943fae to 0e7f22692b19eaa8deb3eae0d34ec077b7ab22d7 [01:07:59] Logged the message, Master [01:08:14] Okay. Someone blow up the database... [01:09:23] #1066: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1066 [01:09:23] #1066: (AW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1066 [01:09:23] #1066: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1066 [01:11:19] you were saying? [01:17:22] #1238: (AW) Tech Task #1238 Never print Civi errorpage HTML to console: O:AW|TS:B|P:E|TT:CT|NT:Y|NV:Y|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1238 [01:17:22] #1238: (AW) ->Sprint 36 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1238 [01:17:29] mwalker: I was praying for lightning to strike again. But first, I realized there is another problem with error instrumentation. (^^) [01:19:28] ok [01:29:22] #1239: (AW) Tech Task #1239 Replace all calls to Civi BAO objects with API calls: O:AW|TS:B|P:SH|TT:CT|NT:Y|NV:Y|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1239 [01:31:23] #1239: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1239 [03:53:28] (PS1) Adamw: (FR #1238) Always throw an exception, do not display the fatal error page. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/99319 [03:53:32] mwalker|away: if you become alive, please take a look at this ^^. It would be nice to capture tonight's fail. [03:54:22] #1238: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1238 [03:54:22] #1238: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1238 [03:54:22] #1238: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1238 [03:57:23] #1238: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1238 [04:08:23] mwalker|away: nvm, I'm unconvering more problems :[ [18:35:23] #1240: (MW) Tech Task #1240 CentralNotice: Fix memory problems in GlobalAlloc: O:MW|TS:B|P:SH|TT:CT|NT:Y|NV:Y|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1240 [18:35:23] #1240: (MW) ->Sprint 36 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1240 [23:33:57] (PS1) Katie Horn: Disabling all form classes other than RapidHTML, and setting RapidHTML to be the new default. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/99555 [23:37:14] (CR) Mwalker: [C: 2 V: 2] Disabling all form classes other than RapidHTML, and setting RapidHTML to be the new default. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/99555 (owner: Katie Horn)