[00:03:45] <the-wub_>	 Now Firefox's start page is imitating our message :) http://i.imgur.com/9qCklxj.png
[00:08:20] <ori-l>	 "If everyone reading this gave $280 million, we would only have to fundraise from one donor a year."
[00:12:30] <marktraceur>	 Wow, math is amazing
[00:14:52] <meganhernandez>	 hey ori-l sorry i missed you a while ago
[00:15:18] <ori-l>	 meganhernandez: np, i wasn't sure whom to ping about the issue, so i e-mailed fundraising@ about it
[00:16:11] <meganhernandez>	 oh weird, i don't think i got it
[00:16:58] <ori-l>	 huh, let me make sure i e-mailed the right address
[00:17:13] <ori-l>	 fundraising@wikimedia.org?
[00:19:52] <jvandavier>	 that a donor email address, actually. let me look for it, ori-l
[00:20:32] <ori-l>	 the subject was "Ok to show Wikimedia Shop link to all visitors?"
[00:20:54] <jvandavier>	 found it - i'll forward it to the appropriate parties
[00:21:16] <ori-l>	 thanks! iappreciate it
[00:21:47] <jvandavier>	 yep yep
[01:46:46] <awight>	 Good times... https://docs.google.com/spreadsheet/ccc?key=0AsgE6161uGWMdG9oU0VYQ2Q1VzhQRnBCLWVmOFRvTEE&usp=sharing
[01:47:05] <awight>	 Has slander been doing that all day?
[02:09:12] <slander>	 #917: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/917
[20:08:51] <grrrit-wm>	 (PS1) Katie Horn: More debug lines near the formchooser logic. This should help debug a problem we're only seeing in prod. Easy to turn off by setting the appropriate gateway LogDebug global to false. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/100623
[20:09:14] <K4-713>	 mwalker: ^^
[20:09:18] * K4-713  grumbles

[20:11:29] <grrrit-wm>	 (CR) Mwalker: [C: 2] More debug lines near the formchooser logic. This should help debug a problem we're only seeing in prod. Easy to turn off by setting the app [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/100623 (owner: Katie Horn)
[22:11:45] <K4-713>	 !log updated payments cluster to 321df2d84cc9c77292b5d
[22:12:00] <morebots>	 Logged the message, Master
[22:36:50] <grrrit-wm>	 (PS1) Adamw: WIP (FR #917) Convert dangerous queries to use the Civi db connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100696
[22:38:12] <slander>	 #917: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/917
[22:47:55] <grrrit-wm>	 (PS1) Katie Horn: More ffname cleanup. Now checks the form array in the donor's session to see if a form has been successfully loaded on a previous click, and if so, defaults to that ffname. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/100702
[22:48:42] <K4-713>	 mwalker: ^ rar.
[22:49:48] <grrrit-wm>	 (PS1) Mwalker: Adding contact information for recurring subscriptions in paypal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100703
[22:49:57] <mwalker>	 K4-713: rar ^ :0
[22:54:17] <grrrit-wm>	 (CR) Mwalker: [C: 2] More ffname cleanup. Now checks the form array in the donor's session to see if a form has been successfully loaded on a previous click, and [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/100702 (owner: Katie Horn)
[22:58:41] <grrrit-wm>	 (PS2) Mwalker: Adding contact information for recurring subscriptions in paypal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100703
[22:59:24] <mwalker>	 awight: you may be interested to know that you broke email address insertion for paypal recurring contacts back in SVN revision 2002
[22:59:43] <mwalker>	 I think that ^ fixes it
[23:08:34] <K4-713>	 !log updated payments cluster to 2c44e6dc531
[23:08:49] <morebots>	 Logged the message, Master
[23:33:50] <awight>	 mwalker: s..v..n.  !
[23:34:16] <mwalker>	 I know!
[23:34:22] <mwalker>	 it took us a long time to discover it!
[23:36:05] <awight>	 mwalker: omg that commented out thing...
[23:38:03] <awight>	 Sweet.  I've even been refactoring the comment ;)
[23:40:31] <awight>	 mwalker: can you link me to the commit you discovered?  I ran git log -p on that file and don't see what you're talking about.
[23:41:02] <mwalker>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/577
[23:41:06] <awight>	 thx
[23:42:12] <awight>	 rev 2003?  I'm still not seeing it.
[23:43:16] <awight>	 looks unrelated, at least.
[23:44:58] <mwalker>	 well; ok, maybe it wasn't 2003; but it was the card
[23:45:04] <mwalker>	 the commit message is "        refactor q2c and rg to use functions moved to wmf_civicrm in last commit
[23:45:04] <mwalker>	 FR      #577     "
[23:45:13] <awight>	 But... why do you think this is the issue?
[23:45:34] <mwalker>	 because nothing ever adds the contact email address anywhere in recurring queue consumption for paypal
[23:45:39] <mwalker>	 and it used to at this point
[23:45:39] <awight>	 I see that git blame shows I refactored the comment, but if you look at the patch, the line was already commented.
[23:45:42] <mwalker>	 until you comment it out
[23:45:48] <mwalker>	 oh
[23:45:59] <mwalker>	 you still have the svn repo around?
[23:46:02] <awight>	 :(
[23:46:04] <awight>	 hell no
[23:46:08] <mwalker>	 the codereview link doesn't work for me
[23:46:27] <mwalker>	 I get Repository Wikimedia does not exist!
[23:46:28] <awight>	 the git repo has all those commits tho
[23:50:20] <grrrit-wm>	 (CR) Adamw: Adding contact information for recurring subscriptions in paypal (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100703 (owner: Mwalker)
[23:50:30] <mwalker>	 ok; point
[23:50:31] <awight>	 mwalker: I would merge that fix, but I don't understand why u wanted to revive the try/catch around tagging Review
[23:50:37] <mwalker>	 oh
[23:50:41] <mwalker>	 because I copied it from somewhere else
[23:50:45] <awight>	 yeees
[23:50:45] <mwalker>	 also; you may be correct
[23:51:02] <awight>	 nah, unlikely
[23:51:10] <mwalker>	 there is handling for adding this contact information if we're updating the ct table
[23:51:13] <mwalker>	 which seems strange
[23:51:23] <awight>	 we don't actually give a fuck about Review, but adding extra code seems wrong...
[23:51:38] <awight>	 mwalker: yeah that is a bad smell
[23:52:38] <awight>	 Sadness... I think I finally got the transaction stapled down.
[23:53:35] <awight>	 But, the only approach which held any hope was to rewrite all dangerous queries using the Civi DAO layer.
[23:53:46] <grrrit-wm>	 (PS3) Mwalker: Adding contact information for recurring subscriptions in paypal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100703
[23:54:01] <mwalker>	 so you rewrote all the queries?
[23:54:02] <mwalker>	 guch
[23:54:07] <mwalker>	 are you still sane?
[23:54:10] <awight>	 Didyu see my audit spreadsheet?  It might be useful to have such a thing, in general.
[23:54:19] <awight>	 Nah I narrowed it down to about ten queries.
[23:54:23] <awight>	 Praise allah.
[23:56:29] <mwalker>	 no; didn't see your spreadsheet
[23:57:05] <awight>	 https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AsgE6161uGWMdG9oU0VYQ2Q1VzhQRnBCLWVmOFRvTEE&usp=drive_web#gid=0
[23:58:35] <grrrit-wm>	 (CR) Adamw: [C: 2] "That's quite a clutch catch. Looks like it's been broken since the beginning of time!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100703 (owner: Mwalker)