[00:10:35] <grrrit-wm>	 (PS6) Adamw: Update and add to tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/101237
[00:12:22] <grrrit-wm>	 (PS10) Adamw: (FR #917) Convert dangerous queries to strictly use the Civi db connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100696
[00:13:31] <grrrit-wm>	 (PS1) Adamw: (FR #1249) Make schema match production [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/102356
[00:19:07] <grrrit-wm>	 (PS5) Adamw: Process each message in a DB transaction (controlled by global setting) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/99743
[00:19:21] <grrrit-wm>	 (PS5) Adamw: Move common dequeue error handling into Queue::dequeue_loop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/99766
[00:48:53] <grrrit-wm>	 (CR) Mwalker: [C: 2] Bugfixes and error handling for commit dcbfae0f15689b2e48cc811af6db04ce5a3ca10f [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/102338 (owner: Adamw)
[00:55:51] <grrrit-wm>	 (PS11) Adamw: (FR #917) Convert dangerous queries to strictly use the Civi db connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100696
[17:36:17] <Thehelpfulone>	 anyone from the fundraising team around? The current CN banners that are showing in the UK have "If everyone gave $3" instead of "If everyone gave �3" on them
[17:36:53] <jvandavier>	 thanks Thehelpfulone, let me....find someone
[17:37:45] <jvandavier>	 odd, i'm getting £3
[17:37:50] <jvandavier>	 but maybe there's a test
[17:38:55] <Thehelpfulone>	 https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B13_121319_twn1_enYY
[17:39:10] <Thehelpfulone>	 and https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B13_121319_twn2_enYY
[17:39:16] <Thehelpfulone>	 it's not on the initial banner - it's when you scroll down
[17:39:25] <Thehelpfulone>	 it's hard coded as $3:         <span class="{{{banner}}}-nag-link"><img src="//upload.wikimedia.org/wikipedia/donate/3/37/Information-icon-yellow.png" style="vertical-align: top;"/> If we all gave $3,<br/>the fundraiser would<br/>be over in an hour.</span>
[17:39:31] <jvandavier>	 oh
[17:39:33] <jvandavier>	 i see
[17:39:38] <jvandavier>	 K4-713, any ideas? ^
[17:40:06] <Thehelpfulone>	 I found the banner causing the problem but couldn't figure out how to fix it myself unfortunately
[17:40:22] <K4-713>	 Ah, yeah, that's totally a the-wub thing, but he seems not to be around.
[17:40:57] <K4-713>	 It's probably eyeball-deep in templates somewhere on meta.
[17:42:00] <jvandavier>	 emailing him now to see if i can get his attention
[17:43:46] <K4-713>	 Actually... Isn't it strange that this isn't even a localized message?
[17:44:31] <jvandavier>	 what do you mean?
[17:45:34] <K4-713>	 Well... I'd have thought that all the banner text would go through translation. But, I guess I don't know how they typically put these things together.
[17:46:12] <K4-713>	 Ah! Hello, the-wub_.
[17:46:31] <the-wub_>	 hi K4-713 :)
[17:46:50] <K4-713>	 Apparently there's a stray "$3" running in the UK.
[17:47:21] <marktraceur>	 Let's give it some food and send it to a loving home
[17:47:25] <K4-713>	 (09:39:29 AM) Thehelpfulone: it's hard coded as $3:         <span class="{{{banner}}}-nag-link"><img src="//upload.wikimedia.org/wikipedia/donate/3/37/Information-icon-yellow.png" style="vertical-align: top;"/> If we all gave $3,<br/>the fundraiser would<br/>be over in an hour.</span>
[17:47:34] <jvandavier>	 lol
[17:47:43] <K4-713>	 ;)
[17:48:53] <the-wub_>	 hrmmm... why didn't I spot that earlier?
[17:53:40] <the-wub_>	 fixed
[19:30:02] <grrrit-wm>	 (CR) Mwalker: [C: 2] (FR #1093) Support queue item download [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100419 (owner: Adamw)
[19:30:21] <awight>	 woot
[19:31:36] <mwalker>	 awight: we should probably also have 'upload json blob' capability
[19:32:42] <awight>	 true.  Editing currently sucks, cos you can't add more fields
[19:33:02] <awight>	 There's a card for something like upload, in https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1245
[19:34:38] <awight>	 mwalker: What do you think about https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1113 ? Turns out this functionality already exists in mw-core
[19:35:14] <mwalker>	 I added another comment after you :) Special:MyLanguage only exists on wikis with the translate extension installed
[19:35:43] * awight  does not want to ask, if Translate is not installed, what are we doing for translation...

[19:35:52] <mwalker>	 on foundation wiki?
[19:35:59] <mwalker>	 the-wub copies them over by hand I believe
[19:36:08] <awight>	 Fucking Landingpagecheck is on wmfwiki huh
[19:36:37] <awight>	 ok well good for us for resisting the future
[19:37:01] <mwalker>	 there have been several long drawn out arguments apparently on if we should have translate on all wikis
[19:37:08] <mwalker>	 but I'm not sure why they failed
[19:37:17] <awight>	 hehe I might have some idears
[19:37:40] <Jamesofur>	 ^
[19:38:27] <awight>	 :p you would rather chew a limb off?
[19:39:51] <Jamesofur>	 I actually think it's helped things a lot on meta
[19:40:14] <Jamesofur>	 BUT ... there have been lots of issues and I have a feeling it would fuddle things up a lot on wikis where they don't have people knowing the ins and outs
[19:40:42] <awight>	 k, that is a generous assessment
[19:40:48] <Jamesofur>	 heheh
[19:40:54] <Jamesofur>	 I try to be generous where I can ;)
[19:41:07] <awight>	 I lost a bit of my life just reviewing code that interacted w/ the Translate extension
[19:41:49] <Jamesofur>	 but yeah, there are a lot of frustrating bugs which I can only deal with easily because I  know the ins and outs of getting around them and it still frustrates the hell out of me and confuses everyone else (despite my attempts to explain to them)
[19:44:50] <awight>	 mwalker: one more question, u commented on https://gerrit.wikimedia.org/r/#/c/99613 that this is for ThankYou pages, but I do not see yet what SLC has to do with TY.
[19:45:19] <mwalker>	 any wiki page can be a landing page
[19:45:33] <awight>	 so we change the ThankYouPage global to route through SLC?
[19:45:34] <mwalker>	 I needed SLC to be able to accept a language argument as part of the URL path instead of as a parameter
[19:45:38] <mwalker>	 *nods*
[19:45:47] <awight>	 okdokey
[19:46:25] <grrrit-wm>	 (CR) Adamw: [C: 2] FR #1113 Rather more intelligent thank you link generation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/99612 (owner: Mwalker)
[19:48:17] <grrrit-wm>	 (PS2) Adamw: WIP (FR #1113) checks for translation existence [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/91338
[19:57:06] <slander>	 #770: (AW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/770
[19:58:13] <grrrit-wm>	 (CR) Mwalker: [C: 2] (FR #1249) Make schema match production [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/102356 (owner: Adamw)
[19:59:06] <slander>	 #1249: (MW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1249
[19:59:06] <slander>	 #1250: (AW) Tech Task #1250 Fix "n/a" address fields: O:AW|TS:B|P:NtH|TT:CT|NT:Y|NV:Y|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1250
[20:17:32] <grrrit-wm>	 (CR) Mwalker: [C: 2] (FR #917) Convert dangerous queries to strictly use the Civi db connection [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/100696 (owner: Adamw)
[20:17:41] <grrrit-wm>	 (PS6) Mwalker: Process each message in a DB transaction (controlled by global setting) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/99743 (owner: Adamw)
[20:20:42] <grrrit-wm>	 (CR) Mwalker: [C: 2] Process each message in a DB transaction (controlled by global setting) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/99743 (owner: Adamw)
[20:21:01] <grrrit-wm>	 (PS6) Mwalker: Move common dequeue error handling into Queue::dequeue_loop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/99766 (owner: Adamw)
[20:22:18] <grrrit-wm>	 (CR) Mwalker: [C: 2] "no idea why we need this; but ok" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/102336 (owner: Adamw)
[20:29:38] <grrrit-wm>	 (CR) Adamw: "Yep, it's explained in the card. The Civi database is not dropped during unit testing, it's only protected by a transaction. Therefore, " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/102336 (owner: Adamw)
[20:37:58] <grrrit-wm>	 (CR) Mwalker: Move common dequeue error handling into Queue::dequeue_loop (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/99766 (owner: Adamw)
[20:39:46] <awight>	 !log update crm from 7deaa1e1a6354de545fedb0e90b85f117e7df0bd to ce73eaa0ea6019f76c63d0cca097bf828eb933e2
[20:40:01] <morebots>	 Logged the message, Master
[20:48:46] <grrrit-wm>	 (PS7) Adamw: Move common dequeue error handling into Queue::dequeue_loop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/99766
[20:55:06] <slander>	 #1093: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1093
[20:55:07] <slander>	 #1249: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1249
[20:58:06] <slander>	 #1251: (J) Triage Item #1251 BPay biller/reference used multiple times, not in Civi: -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1251
[21:40:47] <grrrit-wm>	 (CR) Mwalker: [C: 2] Move common dequeue error handling into Queue::dequeue_loop [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/99766 (owner: Adamw)
[21:42:29] <grrrit-wm>	 (CR) Mwalker: [C: 2] Update and add to tests [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/101237 (owner: Adamw)
[21:44:05] <slander>	 #917: (MW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/917
[22:30:05] <slander>	 #1185: (AW) TS:PCR|MtRtDo:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1185
[22:30:06] <slander>	 #1185: (AW) Looks like the amazon listener is still bork: ... TS:ID|MtPCRo:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1185
[22:36:36] <grrrit-wm>	 (PS1) Adamw: update SmashPig submodule [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/102578
[22:36:42] <grrrit-wm>	 (CR) Adamw: [C: 2] update SmashPig submodule [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/102578 (owner: Adamw)
[22:36:47] <grrrit-wm>	 (CR) Adamw: [V: 2] update SmashPig submodule [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/102578 (owner: Adamw)