[19:15:31] (PS1) Adamw: PayPal does not use a resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/105731 [20:19:42] !log crm updated from 81d06d3d21c26c38fb80cd027f8b66308ca3fac7 to 6964b1e4a337b93a89c10cf119eb81f3512bcbba [20:19:59] Logged the message, Master [20:21:54] !log crm updated from 6964b1e4a337b93a89c10cf119eb81f3512bcbba to d32118b16a45f2d80388c615df262a0854974478 [20:22:11] Logged the message, Master [20:49:27] (PS1) Adamw: fixe a typo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/105823 [21:10:04] (PS1) Adamw: Explicitly initialize CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/105825 [21:10:42] mwalker: K4|food: pleeze review the above 2 patches? [21:14:32] #1287: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1287 [21:18:43] (CR) Mwalker: [C: 2] Explicitly initialize CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/105825 (owner: Adamw) [21:19:17] (CR) Mwalker: [C: 2] fixe a typo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/105823 (owner: Adamw) [21:23:31] !log crm updated from d32118b16a45f2d80388c615df262a0854974478 to 92a58a634bcc78bc53f7eae0af45f75693a37187 [21:23:49] Logged the message, Master [21:25:33] awight: Ha, I was late to this party. Anything you still need? [21:28:19] K4-713: not for this second [21:28:34] K4-713: buuut... I'm about to deploy the transaction patch, now [21:28:40] oho [21:29:05] * K4-713 straps in [21:29:21] Yes. in the unlikely event of an acid bath landing... [21:37:53] !log updated crm from 92a58a634bcc78bc53f7eae0af45f75693a37187 to 8e264d4b2baa7f6d7e7cfef09280f923ee400c58 [21:38:10] Logged the message, Master [21:43:58] awight: WHY IS IT SO QUIET. [21:44:20] K4-713: I KNOW [21:44:33] >_> [21:44:35] <_< [21:44:39] I'm about to enable the transactionality, cos... i'm suspicious ;) [21:44:58] K4-713: but, quiet is related to having actually written tests for every code path I touched... [21:45:06] Fancy. [21:45:08] ;) [21:45:30] Oh what a difference a few assertions make... [21:45:45] it's pretty comfy [21:46:03] transactions enabled. this should make a loud noise [21:46:43] * K4-713 blinks, wonders if my email works [21:47:21] qc run yet? [21:47:59] yeah, I'm really getting suspicious now though. I forgot to add loglines for the transaction? That's not like me :x [21:48:19] It must've run by now. [21:48:33] 2 minutes... [21:49:42] K4-713: there are no loglines about transactionality, so there was deploy error I guess [21:50:21] d'oh [21:50:47] K4-713: holy crap. It works. [21:50:53] 21:47:42 WD wmf_common: Beginning DB transaction [info] [21:50:59] 21:47:43 WD wmf_common: Committing DB transaction [info] [21:51:45] Baller. [21:51:54] If that data is in there, you win today. [21:56:23] #917: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/917 [22:12:18] (PS1) Adamw: Fix regression: don't freak out if a subscription payment arrive out-of-order [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/105841 [22:14:03] K4-713: mwalker: priority review? ^^ [22:15:02] (CR) Katie Horn: [C: 2 V: 2] Fix regression: don't freak out if a subscription payment arrive out-of-order [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/105841 (owner: Adamw) [22:15:06] done [22:16:00] thanks! [22:16:47] !log crm updated from 8e264d4b2baa7f6d7e7cfef09280f923ee400c58 to 41e624c124dce0bd6e0d2a0f72e0cd91ee34f3fa [22:17:04] Logged the message, Master [23:06:48] (PS1) Adamw: Act out grudge against some annoying loglines [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/105855 [23:22:23] #1290: (AW) Tech Supertask #1290 Testing: run crm SimpleTests from continuous integration: NT:Y|NV:Y|IU:N|T:TS Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1290 [23:26:22] #1291: (AW) Tech Task #1291 Clean up CRM tests so we can discriminate success or failure: O:AW|TS:B|P:SH|TT:CT|NT:Y|NV:Y|IU:N|P-TS:#TrcSfci|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1291 [23:27:22] #1292: (AW) Tech Task #1292 Make it possible to run CRM simpletests from drush: O:AW|TS:B|P:SH|TT:CT|NT:Y|NV:Y|IU:N|P-TS:#TrcSfci|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1292 [23:28:23] #1293: (AW) Tech Task #1293 Document testing framework: O:AW|TS:B|P:SH|TT:CT|NT:Y|NV:Y|IU:N|P-TS:#TrcSfci|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1293 [23:29:23] #1294: (AW) Tech Task #1294 Integrate CRM tests with WMF CI: O:AW|TS:B|P:SH|TT:CT|NT:Y|NV:Y|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1294 [23:29:23] #1294: (AW) P-TS:#TrcSfci -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1294 [23:52:08] (PS1) Adamw: Bad function signature [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/105868