[00:00:31] (CR) Katie Horn: [C: -1] "Yeah, this is going to take another pass. -1 until next patchset. Not... that it's going to hurt anything. It had been completely exploded" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/116004 (owner: Katie Horn) [00:33:38] (PS2) Katie Horn: Beating up our unit tests until they pass. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/116004 [00:35:06] mwalker: This one should be... relatively... something? ^^ [00:35:58] I have, however, annoyingly committed a change in DonationData (outside of the tests), so the next deploy might be hilarious. [00:44:45] K4-713, ah... we'll probably need to change how the extra's work -- or you might have to talk to hashar [00:45:00] because the test server localsettings has not enabled things like globalcollect [00:46:36] I don't think we're on the test server. [00:46:54] If we are, they're all just going to fail anyway (like they have been) [00:47:52] well; the jobs run on gallium [00:47:59] and that's currently what's failing [00:48:32] we MIGHT be able to convince gallium to run fundraising jobs like this on lutetium; but I'm not sure jeff is going to go for that given that lutetium has live data [00:53:42] (PS1) Adamw: DO NOT DO ANYTHING: Order id blah blah whatever, squishme when you're done. [extensions/DonationInterface] (sandbox/K4/oid_madness) - https://gerrit.wikimedia.org/r/116021 [00:57:37] (PS1) Adamw: DO NOT DO ANYTHING: squash of oid_madness for review [extensions/DonationInterface] (sandbox/K4/oid_madness) - https://gerrit.wikimedia.org/r/116023 [00:57:41] (Abandoned) Adamw: DO NOT DO ANYTHING: Order id blah blah whatever, squishme when you're done. [extensions/DonationInterface] (sandbox/K4/oid_madness) - https://gerrit.wikimedia.org/r/116021 (owner: Adamw) [00:59:04] mwalker: Yeah, I don't want fundraising tests anywhere near a prod system. [00:59:20] anyways; lutetium wasn't supposed to be prod! :p [00:59:38] Powerful creds + automation = ...international wire fraud. [01:00:11] There may be a group that we can run wherever, though. [01:00:17] I mean, once we make one. [01:01:39] My biggest goal with this is that we (I) would have something that we (I) could at least use locally. [01:04:58] Other issue: We're probably going to have some tests that won't be able to run with... data we can commit to a public repo. [01:05:37] I honestly don't know how anxious I should feel about those fakey credit card numbers that the gateways issue. [01:15:04] Heh. That TestConfiguration.php.dist file that you have to copy over... seems to have nothing interesting in it. [01:16:04] Nuking that and just committing the data somewhere else would probably help a lot with... everything. [01:35:35] (CR) Adamw: "Great improvements! Merge it..." (21 comments) [extensions/DonationInterface] (sandbox/K4/oid_madness) - https://gerrit.wikimedia.org/r/116023 (owner: Adamw) [19:40:45] (CR) Adamw: [C: 1] "This looks great, however Jenkins fails because of some ContributionTracking schema migration crap: https://integration.wikimedia.org/ci/j" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/116004 (owner: Katie Horn) [22:10:30] (PS1) Adamw: Don't need to break the sqlite parser [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/116165 [22:12:06] K4-713: pls review the above ^^ -- it's preventing your DI tests from running [22:20:02] (PS1) Adamw: drop SmashPig submodule. It's an independent project [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/116168 [22:32:36] (PS1) Adamw: put stupid entrypoint scripts into source control [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/116169 [22:32:59] Jeff_Green: ^^ [22:55:22] * jeremyb waves mwalker :-) [22:55:35] hi jeremy [22:55:43] you're being annoying [22:55:55] wow. [22:56:27] I just figured I'd be direct -- I just want my 2 factor auth reset [23:00:54] mwalker: right, but surely we shouldn't leave what you said out there on a list without correcting it? other people might think it's a secure way to do things and then use it as a precedent? [23:01:15] well; we don't seem to have a secure way of doing it [23:01:29] the best I had was my GPG key [23:01:33] *I have [23:01:43] we do. go talk to an op in teh office. if they're not sure how to reset it i can probably dig up instructions for them [23:01:50] the* [23:02:13] ah; but which op do I talk to? they're not all created equal [23:02:26] and it's been said that we shouldn't submit these requests via IRC [23:02:27] in this case op means root [23:02:43] not all ops have root on all servers [23:03:00] and I know that wikitech is special [23:03:37] there are people like hashar with limited root on a few special boxes (like the jenkins box or like ori used to be) [23:03:38] so; email is still the best way to go; someone with the authority can read that; and then post a reply so that we can begin the identity transaction [23:04:00] but most people with root anywhere have root everywhere [23:04:55] not entirely true; most of them dont have root on fundraising boxes [23:05:03] frack is separate [23:05:50] and I'm assuming that labs is as well [23:05:56] i don't think so [23:07:26] anyway, first just see if you can find one. dzahn and ori should both have sufficient perms as examples [23:10:09] ori may have permissions; but that's not an action he should be doing [23:10:16] daniel is either in a meeting [23:10:19] or not in the office [23:10:23] and this isn't a real time request [23:10:38] right re ori. but if you're in a rush... [23:10:44] for all I know; OIT should handle this for me [23:10:49] real time request? means you're not in a rush? [23:10:53] no, it's definitely not OIT [23:11:15] nope; not in a rush -- I have nothing I need to edit on wikitech today; but... I don't want it to become a rush [23:11:21] being proactive! :D [23:11:42] it might be though; they handle creation of accounts and assigning of rights on the main cluster [23:11:57] huh? [23:12:02] assiging rights how? [23:15:10] any staff role; so the 'Staff' group, or 'translation-admin' or whatever; if I need that for my job; the request goes through OIT [23:25:49] mwalker: right, that's unrelated to root. that's actually a subset of Steward [23:28:27] so, definitely not OIT. a good rule of thumb would be if they have root on palladium (new sockpuppet) they should have root on virt1 [23:28:49] or if they can view/commit to the private puppet repo [23:31:01] re rush, was typing before: ok. in that case then I think you could probably either use video chat with an op or somehow use your prod ssh key to verify the request. put a file in your home on bast1001 with date in filename and request in the file itself? [23:31:45] as it happens, IIRC, the last time someone needed to reset tokens it was also a friday night and it was actually done Monday morning [23:32:04] mwalker [23:32:41] maybe; I'll let whoever picks it up make that call [23:33:13] I am amused; it's easier to get my cluster SSH key revoked and reinstated than it apparently is for me to get my two factor auth on labs redone [23:33:14] well the point is you have more options if you can wait til monday [23:33:22] aye; so email! [23:33:25] it's high latency [23:34:16] more people know how to do cluster key replacement than labs tokens. partly because the sheer number of times labs tokens has been done is so much smaller [23:36:16] *and because it's not documented anywhere apparently [23:36:43] I could figure it out by looking at the code; but I'm sort of hoping ryan or marc knows how to do it [23:37:04] nah, i'm sure we have a record somewhere [23:37:10] (maybe in the wrong place) [23:38:49] huh, people key [[Key Wikimedia software projects]] updated on wikitech :) [23:44:11] that's an interesting page [23:44:15] that I didn't know existed [23:44:36] of course s/people key/people keep/ [23:45:51] (CR) Katie Horn: [C: 2 V: 2] Don't need to break the sqlite parser [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/116165 (owner: Adamw) [23:47:57] (PS1) Adamw: typo in fallback algorithm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116177 [23:48:56] (PS1) Adamw: queue2civi test msg insert defaults to the active queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116178 [23:50:47] (PS1) Adamw: default to English when donor lang not availble. for now. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116179 [23:51:52] (CR) Mwalker: [C: 2] typo in fallback algorithm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116177 (owner: Adamw) [23:53:03] (CR) Mwalker: [C: 2] queue2civi test msg insert defaults to the active queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116178 (owner: Adamw) [23:56:50] (CR) Mwalker: [C: -1] default to English when donor lang not availble. for now. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116179 (owner: Adamw) [23:58:45] (PS2) Adamw: default to English when donor lang not availble. for now. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116179