[00:24:28] (CR) Adamw: few more tweaks in an attempt to get Jenkins to run our tests (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/116265 (owner: Adamw) [00:32:11] (PS1) Mwalker: Make address fields text fields in the DB [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116670 [00:33:14] (PS1) Mwalker: Make address fields text fields in the db [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/116671 [00:34:21] (PS2) Mwalker: Make address fields text fields in the DB [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116670 [00:56:55] #1406: (AW) O:AW|TS:B|P:E|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1406 [00:56:55] #1406: (AW) ->Sprint 42 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1406 [01:11:55] #1407: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1407 [01:22:57] #1408: (AG) BG:#Maef|T:BC Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1408 [01:24:56] #1409: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1409 [01:26:56] #1410: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1410 [01:29:57] #1399: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1399 [01:40:19] (CR) Adamw: [C: 2] Make address fields text fields in the db [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/116671 (owner: Mwalker) [01:40:25] (CR) Adamw: [V: 2] Make address fields text fields in the db [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/116671 (owner: Mwalker) [01:40:48] (CR) Adamw: [C: -1] "Please add the submodule bump." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116670 (owner: Mwalker) [01:42:55] #1399: (AW) BG:#Maef|BC:#Aq -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1399 [01:42:55] #1407: (AW) BG:#Maef|BC:#Aq -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1407 [15:21:57] ContactPageFundraiser is moving further towards being killed [15:22:44] No one has replied back from the email I sent to the named address [15:23:27] kill kill kill [15:29:39] I've got to give at least a week to reply I guess ;) [18:04:37] (PS1) Katie Horn: Big Order ID Refactor * DO NOT MERGE. This work is incomplete. * This commit has potential to be very disruptive. * GC seems to be okay with either OID generation method now. * Batch operations should work at this point, too * Still must refactor paypal, [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/116768 [19:55:37] #1373: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1373 [20:00:38] #1382: (AG) Not critical -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1382 [20:49:10] That moment when you run across a piece of code that you know was written by you, but you can't remember doing it or why on Earth you thought that was necessary. [20:56:10] (PS1) Ori.livneh: Try geoiplookup.wikimedia.org only if client used IPv6 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/116857 [20:56:35] Oh. Cool. [20:56:57] mwalker: Did you know that was on the way? ^^ [20:57:35] ish [20:57:46] there's been some discussion about how we use geoip [20:57:55] I thought we were going to start putting it in a cookie though [21:04:14] (CR) Ori.livneh: "The 'af' key will be set as part of the new, cookie-based approach. It is not yet set in production, but there is no harm in checking for " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/116857 (owner: Ori.livneh) [21:05:17] :) [21:06:25] (CR) Mwalker: [C: 2] Try geoiplookup.wikimedia.org only if client used IPv6 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/116857 (owner: Ori.livneh) [21:06:33] (Merged) jenkins-bot: Try geoiplookup.wikimedia.org only if client used IPv6 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/116857 (owner: Ori.livneh) [21:10:38] #794: (AG) From Jessica: While QA:ing the banners for the ... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/794 [21:43:27] (PS1) Ori.livneh: Decode geolocation data from GeoIP cookie, if present [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/116866 [21:49:22] (CR) Mwalker: [C: 2] Decode geolocation data from GeoIP cookie, if present [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/116866 (owner: Ori.livneh) [21:58:08] (PS1) Ori.livneh: Make GeoIP script URL configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/116868 [22:00:22] (CR) Adamw: [C: 2] "TODO: bump submodule" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/116670 (owner: Mwalker) [22:00:39] (CR) Mwalker: [C: 2] Make GeoIP script URL configurable [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/116868 (owner: Ori.livneh) [22:06:02] Oh, hm, atgomez should probably be in the staff channel, right? [22:06:39] Or at least invited? [22:07:09] rdwrer: yes, thx [22:08:07] atgomez: You will need to register your nick. [22:08:39] /msg nickserv register [22:09:00] You should get an email about completing the registration [22:09:09] also, http://meta.wikimedia.org/wiki/IRC/Cloaks [22:09:29] Not necessary for the staff channel, but a nice process [22:10:39] rdwrer yes.. but i should probably do the rest of that [22:23:12] (PS1) Ori.livneh: Try geoiplookup.wikimedia.org only if client used IPv6 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/116879 [22:23:18] (PS1) Ori.livneh: Decode geolocation data from GeoIP cookie, if present [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/116880 [22:23:25] (PS1) Ori.livneh: Make GeoIP script URL configurable [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/116881 [22:26:26] (PS1) Mwalker: Merge remote-tracking branch 'gerrit/master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/116886 [22:26:50] (CR) Mwalker: [C: 2 V: 2] Merge remote-tracking branch 'gerrit/master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/116886 (owner: Mwalker) [22:30:49] meganhernandez: Are you on? [22:34:52] ccogdill: Are you around? Might need some extra eyeballs around 4pm. [22:35:09] sure, k4-7131 [22:35:14] how can I help? [22:35:41] ccogdill: It sounds like we're getting a Central Notice deploy today at 4pm. [22:35:59] Should be minor changes, but we should pay extra close attention to the campaigns, just in case. [22:36:30] okay I can keep an eye out. anything in particular I should watch out for? [22:37:20] Ah... I suppose if we suddenly get a flood of people saying that they are geolocating to somewhere strange... [22:37:34] ...or, any new noise coming from problemsdonating... [22:38:04] okay, sounds good! [22:38:13] Thanks for your help here. [22:38:25] I'll let you know if I see anything... and if I don't I'll ping you around 4:30 with an all clear :) [22:38:28] thanks for the heads up! [22:39:28] ccogdill: Sure. Just to be clear, though, the deploy window isn't even over until 4:30, and we usually don't call things tentatively settled until an hour after the code has been deployed. [22:39:34] I'll let you know when it actually goes out. [22:39:45] k [22:43:18] atgomez: In the interests of recording unscheduled interruptions: We are apparently doing a CentralNotice deploy at 4pm. [22:43:39] K4-7131 just catching up on that. thanks! [22:44:39] K4-7131, ccogdill, it's actually more likely we're going to see people not getting geolocated (e.g. locating to country XX) rather than locating somewhere else [22:44:47] so our banner counts will plummit [22:45:51] hmm okay [22:46:23] atgomez: You should be able to do /join #wikimedia-staff now [22:46:30] Beware, there be distractions at times. [22:46:42] Gee. Wouldn't it be neat if we had some kind of... internal dashboard where we could just... glance... [22:47:49] [22:47:52] K4-7131 if only... [22:47:53] :P [22:47:57] heh. [22:48:13] So, yes: This is a perfect example of our #1 use case for that. [22:48:35] In case anybody ever implies that it's just a bunch of bells and whistles. [22:49:04] noted. I'll add this as a metric we'd like to be tracking when we track such things [22:50:05] I guess one of the important aspects of it, is that it would bring lots of metrics together in one place. [22:50:16] mmmm metrics [22:50:18] nom nom [22:50:28] Lots of us just look at the thing we're supposed to take care of, and then it's sort of a pain to figure out how to get somebody else's numbers. [22:50:37] ...once you figure out you need those. [22:59:38] #578: (AG) BC:#Iit -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/578 [23:52:38] #1382: (AG) T:TT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1382 [23:52:39] #1382: (AG) P:NtH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1382 [23:53:38] #1382: (AG) BG:#Idda -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1382