[00:08:23] (PS4) Mwalker: Script to restart orphaned GC recurring jobs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/115559 [00:19:03] (CR) Mwalker: Script to restart orphaned GC recurring jobs (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/115559 (owner: Mwalker) [00:19:21] (PS5) Mwalker: Script to restart orphaned GC recurring jobs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/115559 [00:19:37] #1440: (MW) O:MW|TS:B|P:NtH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1440 [00:49:04] (CR) Adamw: [C: 2] Script to restart orphaned GC recurring jobs (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/115559 (owner: Mwalker) [00:53:11] (PS4) Mwalker: More configurable thank you generator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/115582 [00:56:26] mwalker: you know, I'm starting to think that in the distant future, we should use an approach more like wmf_communication\Job, creating a new template rather than inlining exceptional cases. [00:56:45] Unfortunately, that will be unfeasibly expensive in the mwext:Translate world [00:56:55] yeuuuup [00:57:14] awight, so... do you want to deploy that? [00:57:17] or... should I? [00:57:31] And, I guess the proof of the pudding is whether our lame future recurringProblems can share the exact same wording... [00:57:44] mwalker: err, I am not excited to consider deploying at this moment. [00:57:55] * awight checks testing calendar [00:58:10] grr. *nothing* on the calendar. [00:58:15] Is that no longer a thing? [00:58:30] Entries only seem to appear after the fact :-/ [00:58:37] *shrugs* [00:58:45] I just assume we're always testing [00:59:14] and given that with this I'll just stop the QC; I think it's OK [00:59:23] mwalker: remind me about "#recurringCancel" [00:59:40] there is some other templating thing that happens to the twig stuff?? [00:59:44] uh; that's a link to somewhere on foundationwiki [00:59:51] nono; that's in the twig stuff [01:00:03] but but... all other links have been expanded. [01:00:21] ah crap; did I miss that? [01:00:28] what file? [01:00:34] the replacement is '/\[#recurringCancel ((?:(?!\]).)*)\]/' => '$1', [01:00:47] https://gerrit.wikimedia.org/r/#/c/115582/4/sites/all/modules/thank_you/templates/html/thank_you.it.html,unified [01:01:13] and with that, we should a) stop committing damn templates like u said, or b) put error-checking in the thing to find unexhausted template typos [01:02:05] it needs to be error checking [01:02:11] this comes from a badly translated thingy [01:02:12] https://meta.wikimedia.org/w/index.php?title=Special:Translate&group=page-Fundraising%2FTranslation%2FThank+you+email+20131202&language=it&action=page&filter= [01:02:32] yup [01:08:38] (PS5) Mwalker: More configurable thank you generator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/115582 [01:09:14] (PS1) Katie Horn: Found and altered the one place in the code that might explain these infrequent and weird loglines I'm seeing sometimes in the payments.error log (in production). If this changes things: Transactions that hit this block get stuck until they are manually u [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/118046 [01:09:42] awight, ok; fixed the italian [01:17:22] mwalker: o-m-g sorry, I just noticed that the #typo was not even introduced by your patch. [01:18:34] ya... even more reason to have that automated error checking [01:19:05] (CR) Adamw: [C: 2] More configurable thank you generator [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/115582 (owner: Mwalker) [01:36:18] awight, so... was there a reason you didn't want to deploy today? just not wanting to change any new moving parts? [01:37:02] mwalker: No, I'm trying to focus on a small thing to finish it today... [01:37:12] I'm happy to support/do deployment if you need the help [01:37:32] Did I miss any CR? [01:37:33] nah; I can do it -- I was just wondering if you wanted to since you did everyhting else today :p [01:37:37] nope; dont think so [01:38:42] haha I barely lifted a hand. Actually, I was pretty much glued to this seat. Looking forward to family awaking from a nap. [01:38:52] actually; jeff wanted to be in the loop on civi deploys for the next couple of days; so I'll wait till morning [01:39:21] mwalker: anything shaking out re: barium cutover? [01:39:50] uh; I cant recall if Jeff fixed barium's MTA; but if he did it's back on me to transfer the jobs over to the new jenkins [01:41:13] Woot! [01:56:11] (PS3) Adamw: Massage watchdog calls and inline documentation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/114911 [01:56:14] (CR) jenkins-bot: [V: -1] Massage watchdog calls and inline documentation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/114911 (owner: Adamw) [01:56:39] (PS4) Adamw: Massage watchdog calls and inline documentation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/114911 [01:56:41] (CR) jenkins-bot: [V: -1] Massage watchdog calls and inline documentation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/114911 (owner: Adamw) [01:58:18] (PS5) Adamw: Massage watchdog calls and inline documentation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/114911 [01:58:26] ciao [06:04:33] (CR) Mwalker: [C: 2] Found and altered the one place in the code that might explain these infrequent and weird loglines I'm seeing sometimes in the payments.erro [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/118046 (owner: Katie Horn) [06:05:49] (CR) Mwalker: [C: 2] Massage watchdog calls and inline documentation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/114911 (owner: Adamw) [08:08:28] (PS1) Mwalker: Introducting jQuery.Payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/118055 [08:08:30] (PS1) Mwalker: WIP: WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/118056 [08:08:37] (CR) jenkins-bot: [V: -1] Introducting jQuery.Payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/118055 (owner: Mwalker) [18:25:04] (CR) Addshore: [C: -1] Wrapping some debugging stuff in a debugging global from localsettings. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/24515 (owner: Katie Horn) [18:31:00] pizzzacat: You missed glowing praise from Ironholds in -staff :) [18:32:34] aw what!? [18:32:57] 2014-03-11 - 11:26:33 with the excellent assistance of sherah and rdwrer [18:33:11] (re: the thing he was hacking on in Python) [18:33:26] Though I guess I could berate him equally for not being in here [18:33:39] :p that's generous [18:34:36] Yeah, not sure why he poked the two frontend people, but whatever [21:05:41] #1441: (AG) O:AG|TS:B|P:E|TT:S|IU:N|->Sprint 44|BG:#SPME|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1441 [21:24:34] (PS1) Adamw: typo [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/118205 [21:37:50] (CR) Mwalker: [C: 2] typo [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/118205 (owner: Adamw) [21:37:56] (CR) Mwalker: [V: 2] typo [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/118205 (owner: Adamw) [22:09:00] !log updating fundraising civicrm from a1ca31664f771a48963425893b2b927a5148119b to f0837090e918b7016c07cb366b33c8d8f0d1c661 for thank you and recurring [22:41:52] #1412: (AG) BG:#Idda -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1412 [22:41:52] #1418: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1418 [22:45:52] #1419: (AG) BG:#Maef|BC:#Mioit -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1419 [22:48:52] #1432: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1432 [22:48:52] #1405: (AG) BG:#Idda -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1405 [22:49:52] #1413: (AG) BG:#Idda -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1413 [22:49:52] #1423: (AG) BG:#Idda -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1423 [22:49:52] #1421: (AG) BG:#Idda -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1421 [22:49:52] #1414: (AG) BG:#Idda -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1414 [22:49:52] #1424: (AG) BG:#Idda -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1424 [22:49:52] #1432: (AG) N:Ccrgsbpg Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1432