[00:14:51] #1243: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1243 [00:14:51] #1215: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1215 [00:14:51] #1186: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1186 [00:14:52] #1011: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1011 [00:14:52] #1000: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1000 [00:14:52] #807: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/807 [00:14:52] #662: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/662 [00:14:53] #1214: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1214 [00:19:51] #1471: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1471 [00:19:51] #1469: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1469 [00:23:51] #1468: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1468 [00:23:51] #1468: (AG) This is blocked until the WP forms are ready B:B -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1468 [00:28:51] #40: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/40 [00:32:51] #1472: (S) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1472 [00:37:51] #1475: (S) AT:S -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1475 [12:51:28] (PS1) Pcoombe: Add Malay and Ukrainian to detail_languages for aggregation [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/119740 [16:40:00] (PS1) Pcoombe: iDeal and Sofort forms - change amount options to match what we now use elsewhere [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/119775 [16:46:06] (CR) Ssmith: [C: 2 V: 2] iDeal and Sofort forms - change amount options to match what we now use elsewhere [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/119775 (owner: Pcoombe) [16:46:29] hee [16:46:44] mwalker: You there for real? [16:47:05] yepyep [16:47:16] what can I do for you? [16:47:25] Did you by any chance experiment with installing and using apollomq? [16:49:19] no; that was all Adam [16:49:28] awight was trying to tell me last night, that it was 100% drop-in replacement and that I should do it on my local instead of trying to run down activemq... which appealed to me at the time, because *everything* amq has right now looks totally brokeass. [16:49:49] Like, really brokeass. [16:49:53] hmm [16:50:00] well; Apollo is a fork of AMQ [16:50:07] and supports the STOMP protocol [16:50:07] It's like the 'net equivalent of a ghost town. [16:50:19] Yeah... I have a broker running on my local. [16:50:36] But apparently there's an extra layer of security that we... didn't need before. [16:50:40] Ah well. [16:50:48] for AMQ or Apollo? [16:50:51] Apollo. [16:51:06] erm... don't know what to tell you on that then... [16:51:09] Server's complaining that the username/pw is invalid. [16:51:27] ...which is... you know, strange. [16:51:29] its not apollo / admin? [16:51:29] At all. [16:51:37] No, I mean, for sending messages. [16:51:42] oh [16:51:43] I can get in to the console. [16:51:45] uh... [16:51:48] Exactly. [16:51:54] make sure you've enabled the STOMP protocol? [16:52:01] and it's on the right port? [16:52:26] (you can try telnetting to the STOMP port too to see what it's doing; that's how I debug my install) [16:52:51] Yeah, it's on the right port. [16:53:01] That's how I know it's complaining about un/pw. [16:53:18] Also, it's in the verbose broker run command, just in case you missed it everywhere else. [16:54:06] hmm... new in STOMP 1.2 is authentication [16:54:19] * K4-713 facepalms [16:54:28] Okay, F this for the moment, then. [16:54:49] http://activemq.apache.org/apollo/documentation/user-manual.html#Authentication [16:55:51] * K4-713 bookmarks this for much later [16:58:51] heh [17:07:41] mwalker: How's the skiing? [17:07:51] great! [17:07:54] I'm tiring dad out [17:07:58] hehe [17:08:08] and occasionally bouncing down the slope :p [17:09:15] Oh, it wouldn't be fun if that didn't happen sometimes. [17:09:40] I know! [17:09:52] I tried to convince dad we should take snowboarding lessons too [17:09:58] Oh man. [17:10:02] but apparently he likes his tailbone [17:10:07] I hear that's easier if you never learned to ski. [17:10:21] probably [17:10:24] Like, everything that will kill you skiing, keeps you upright on a snowboard. [17:10:26] going down the slope sideways [17:10:45] hmm [17:10:57] "Lean forward as far as possible... no, *all* your weight on the front foot..." [17:11:25] that's not all that different... [17:11:25] huh. wth, paypal audit. [17:14:23] I understand it's one of those things you have to experience before the profundity is apparent. [17:15:22] I'm probably never going to do it myself... when snowboarding first became popular, I'd already been skiing for a few years, and those snowboard jerks were *awful*. [17:15:30] Just... terrible. [17:15:50] I sometimes get off the couch [17:15:58] and sit in a chair [17:16:06] and other times I sit on the couch [17:16:16] and look at skiing photos [17:16:21] My favorite incident was a whole group of 'em, camping on the hill right at the bottom of a jump. They were invisible until you were airborne. [17:16:27] :[ [17:16:37] pizzzacat: bahaha [17:16:47] I once heard of a guy who skiid [17:17:18] This makes it less likely that you spend a significant amount of time with a broken [critical body part] in the cold. [17:17:19] it's weird that I lived in Colorado Springs and the PNW and have never been skiing or snowboarding! [17:17:20] K4-713, that happens with skiiers too; cant account for stupidity [17:17:35] pizzzacat, shaaaaame [17:17:48] though; you're like kaldari if I recall and dont enjoy the cold? [17:18:00] mwalker: Yes, but there was a time in which all the n00b stupidity was pretty much totally contained in the "snowboarders" group... [17:18:11] I am deeply prejudiced as a result. [17:19:24] I'm …ok with the cold …sometimes, but I'm more of the boring lady who stays in the hot tub while everyone skiis and reads a book. :-/ [17:19:27] pizzzacat: That is weird. There are these three resorts right next to eachother in the cascades, all catering to different skill levels. Like, 90 minutes from Seattle (if that). [17:19:35] mainly I just don't do things that are concussive [17:19:51] I'm not gonna lie: I thought I was gonna die up there a couple times. [17:19:55] yeah! I know. I know… I've snowshoed though! [17:20:04] haha haha [17:20:22] isn't that why people do it?! it's so scary [17:20:47] It all starts with "And for some reason, by bindings didn't release and I had ejected both poles and couldn't reach my boot which was somehow above my head..." [17:21:11] "...and the sun was setting, and I couldn't see *anyone*." [17:21:29] pizzzacat, never saw the point of snowshoeing [17:21:33] I'd rather XC ski [17:21:48] K4-713, oooh; I did something similar my first day here [17:21:48] I never got the point of XC. [17:21:54] Seems like a lot of work. ;) [17:22:01] mostly, it's faster than walking [17:22:05] that's about it [17:22:14] mwalker: ARGH, pretzel crashes are awful. [17:22:20] yeah… I do remember jumping down the mountain after a very strenuous uphill trek, thinking, "snowboarding this would probably be reallllly fun…" [17:22:30] mine involved me upside down in a tree [17:22:34] ! [17:22:34] snowshoeing is like a lame person's snowboarding [17:22:39] haha wat [17:23:03] Did you impacting the tree cause the snow in the tree to fall on you with perfect comedic timing? [17:23:10] (because that happens) [17:23:29] I was traversing an avalanche zone which had wiped out a slope; and didn't make a turn fast enough; and ended up upside down on the slope with my skis caught in some tree branches [17:23:32] sadly; the tree did not fall on me [17:23:43] Dang. [17:23:47] I know! [17:24:04] Did anybody at least see it happen? [17:24:12] ya; dad was with me [17:24:15] I usually feel weirdly better when somebody does. [17:24:38] at least if something bad happens in that case; there's someone to call the rescue peoples [17:25:41] seriously. [17:25:53] This is probably all marginally better with the advent of cellphones, too. [17:26:05] ...unless you're somewhere totally insane. [17:26:27] speaking of which; I'm very angry at my phone right now [17:26:41] it decided; even though I'd told it to not use data 100 bajillion times [17:26:43] to use data [17:26:48] at the rate of 15$ / MB [17:26:59] AGH [17:27:05] which; over the course of an hour and a half costed me $200 [17:27:07] What network? [17:27:18] I'm on T-Mobile in the US [17:27:24] over here; iono [17:27:39] Do they let you do that cool thing where you can retroactively sign up for international data? [17:27:59] (as long as you get it before the end of the billing cycle) [17:28:06] I've no idea; I'll have to call tmo when I'm back in the US [17:28:15] and be angry that their firmware clearly has a bug [17:28:27] Heh. "Bug". [17:28:36] *sigh*; no kidding [17:29:06] 15$/MB... *grumble* [17:29:06] AT&T is pretty badass about this stuff, with the retroactive international add-ons. [17:29:13] You should say that. [17:29:24] I might [17:29:56] there's a whole bunch of crap associated with this bill though that I'm going to have to bring up [17:30:10] because I thought I was on a different plan anyways which is significantly cheaper interantionally [17:31:05] Do you know off the top of your head, what version of activemq we are currently running? [17:31:33] I'm logged in to the prod console, and it's not giving anything up. [17:31:35] pretty sure it's a custom patched version of 5.9 [17:31:47] 5.9, really. [17:31:59] ya; jeff and I went through an upgrade process a while ago [17:32:14] What did you have to patch? [17:32:28] Anything I need to worry about for local testing? [17:33:01] I had to patch a resource check bug on startup [17:33:16] it's not going to affect you unless you keep scads of data in your queues and restart things [17:34:54] Yeah, I... shouldn't do those things. [17:35:01] >_> [17:35:01] <_< [17:35:45] ok; so symptom of the bug is AMQ not starting because it thinks it doesn't have enough disk space [17:35:58] solution is to tell it that the store can take up more space [17:43:03] This is genuinely terrible: https://activemq.apache.org/getting-started.html#GettingStarted-StartingActiveMQ [17:43:16] Note how every place they say "Then Type:" there is NOTHING AFTER THAT. [17:43:38] yep [17:43:45] Even in the source. I looked. [17:43:46] what problem are you having? [17:44:07] Installing ActiveMQ. :p [17:44:19] ...but seriously. [17:44:34] I have the files. [17:45:25] The difficulty is that it seems that all the official docs are damaged beyond the ability to... use them at all. [17:45:47] yaay [17:45:54] so... you can run it by hand [17:46:00] I want to. [17:46:02] run ./bin/activemq [17:46:44] 'tis spewing a help file. [17:47:08] Which seems to be genuinely helpful. For a change. [18:00:51] mwalker: ...do you remember how Jeff finally found the amq admin console default password? [18:00:56] I remember it took, like, 4 hours. [18:01:24] * K4-713 eats own hand [18:05:20] Ha. I did find how to turn off the pw entirely on my local. Some jetty conf xml. [18:09:43] pizzzacat: ...I think we are stuck without CR for the rest of today. [18:09:54] CR? [18:09:59] Code review. [18:10:01] (I probably should have thought that through more completely) [18:10:12] oh [18:10:22] Unless awight has some kind of spasm. [18:10:46] I'm ok with that, today [18:10:51] but you perhaps are less so [18:11:02] Yeah, I sort of wanted to... do. Things. [18:11:11] ...you know: At work. [18:11:22] wat that is rly weird K4 [18:11:29] * K4-713 eats remaining hand in frustration [18:11:39] haha how are you even typing [18:11:41] kdznbfgm fgkxdbmkg szset [18:11:43] oh toes [18:11:54] I guess sharpen up those skills [18:12:04] Strongbad makes it look so easy. [18:12:13] hehe [18:12:16] (I installed Dragon in, like, two seconds) [18:12:24] (not really) [18:12:46] (I don't think they make an ubuntu version) [18:13:12] * pizzzacat googles Dragon [18:13:20] aha [18:13:24] I think it makes hilarious emails. [18:13:56] I had voice recognition on my answering machine for a while. [18:14:03] one of my favorite tweets was something like "my new speech to text app is pretty damn a carrot" [18:14:05] It usually converted "Katie" into "Sweetie". [18:14:14] Which made things excellent. [18:14:47] "Hi sweetie, it's your doctor" and such. [18:14:56] pahaha [18:15:03] have you seen Her? [18:15:10] No, but I want to. [18:15:51] you should. [18:17:27] For a second, I thought you were talking about that old MC Hammer song. [18:20:44] haahaha [18:20:53] you would. [18:21:18] I can neither confirm nor deny that song's presence on my ipod. [18:53:51] #1439: (AG) Adam - this needs to be completed before end of... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1439 [18:55:51] #1478: (AG) T:BC Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1478 [18:56:51] #1478: (AG) BG:#RGDE -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1478 [18:56:52] #1478: (AG) N:Bmde Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1478 [18:57:51] #1475: (AG) BG:#RGDE|BC:#Bmde -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1475 [18:57:51] #1474: (AG) BG:#RGDE|BC:#Bmde -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1474 [18:58:51] #1473: (AG) BG:#Maef|BC:#Iit -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1473 [18:58:51] #1472: (AG) BG:#Maef|BC:#Iit -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1472 [19:00:51] #1470: (AG) BG:#Maef|BC:#Iit -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1470 [19:00:52] #1471: (AG) BG:#Maef|BC:#Iit -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1471 [19:00:52] #1469: (AG) BG:#IT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1469 [19:01:51] #1468: (AG) BG:#SPME(i -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1468 [19:01:51] #1462: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1462 [19:06:51] #1445: (AG) P:SH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [19:09:52] #1445: (AG) N:AGruic Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [19:10:51] #1445: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [19:49:39] K4-713, did you get your AMQ install figured out? [19:49:55] Yes, but I am about to murder something for totally unrelated reasons. [19:50:04] anything I can help with? [19:50:16] It seems to be something damaged on my local install of civi. [19:50:41] Prod isn't having this issue. [19:50:46] ah... drush rr; drush updatedb are all the mystic magic I know of [19:51:13] I am about to commit something really stupid; You'll like it. [19:51:14] Really. [19:52:14] (once I clean up all the outrageous profanity in die() statements I just peppered around the whole thing to try to figure out why the hell no civi queries were coming back with anything better than empty arrays) [19:53:27] ...oooh, yeah, can't commit that. Language. [19:53:51] #1463: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1463 [19:53:51] #1463: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1463 [19:54:34] swear-word pseudocode? I like when I miss context around here. [19:55:20] awight: You know anything about some civicrm_semaphore table that ruins everything? [19:57:48] K4-713: err WHAT [19:57:49] no [19:57:52] will look [19:58:37] interesting, I've been wondering how Civi deals with multiple instances accessing a database, pretty sure there is no semaphore/mutex of any type [19:58:41] It's probably an update that got stuck mid-process at some point or some dang grumblegrumbleargh. [19:58:49] what are the symptoms? [19:58:51] #1389: (AG) O:AW -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1389 [19:59:23] Nothing in wmf_civicrm.module returns anything other than an empty [explative]ing array. [19:59:38] There is no civicrm_semaphore. [19:59:50] K4-713: can u paste an example? [19:59:51] #1389: (AG) P:MH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1389 [20:00:06] nope [20:00:16] or point me to the bug report or something? [20:00:24] I am... oh wait. [20:00:24] and, is this dev box or production? [20:00:28] my own. [20:00:36] ah [20:00:43] Which is why I suspect some freaking update got stuck somewhere. [20:00:51]

Uncaught exception thrown in shutdown function.

PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table &#039;civicrm.semaphore&#039; doesn&#039;t exist: DELETE FROM {semaphore} [20:01:01] wt..f.. [20:01:02] ...running the gc_wr1 script. [20:01:11] that is a drupal table, in that case. [20:01:20] so check yr *settings.php [20:01:20] no, it's a civi dao query. [20:01:24] but but... [20:01:27] curly braces... [20:01:29] I know. [20:01:37] yeah drupal table. [20:01:43] can u check settings? [20:01:58] CRM_Core_DAO::executeQuery does it, though. [20:02:06] errrrr... [20:02:12] doubting that [20:02:34] I'm dying right after that call. [20:02:37] there is no reference to semaphore in the civicrm module [20:02:57] yeah it really looks like you have your *settings.php configured to use the wrong database for drupal stuff [20:03:11] The rest of everything runs. [20:03:24] Like, my civi instance on port 81. [20:03:39] Not sure how I can have bad conf if that works. [20:03:46] grep UF_DSN sites/default/civicrm.settings.php [20:04:03] cos there's stupid ass two places where the drupal DSN is set [20:04:09] ... [20:04:25] And that has zero effect on the frontend? [20:04:29] right :-/ [20:04:42] What the [redacted]. [20:04:42] hehe my hands are tied to emit expletives in this channel [20:04:51] I see you are coping as well [20:05:24] CIVICRM_DSN should be your civicrm database, and CIVICRM_UF_DSN should be the drupal db [20:05:30] don't kill the messenger [20:05:36] "UF"??? [20:05:46] CIVICRM_UF_DSN is drupal... [20:06:00] And the other one is fine too. [20:06:02] lol I just lost the ability to type in English for a second [20:06:04] Awesome. [20:07:11] Riddle me this: If I'm using CRM_Core_DAO::executeQuery, I shouldn't have to push the db on to the db stack, right? [20:07:17] well, my only clue so far is that Drupal does PDO, Civi does not, and it's a drupal table [20:07:21] oh derp [20:07:35] you're in hot pursuit [20:07:41] What to know the genuinely stupid thing? [20:07:44] This works in prod. [20:08:01] correct, u should not have to push a db [20:08:05] Verified 1,000,000 times in jenkins logs. [20:08:13] Argh, I was not. [20:08:20] but I think you're right that something is failing to pop before returning control to drupal. [20:08:26] what is the exact thing you're running? [20:08:49] I'll commit it. Once I stop cussing and dying all over. [20:08:59] lol for reals [20:10:31] K4-713: oh and a side note, sadly we should actually get rid of the db switcher. [20:11:20] The transactionality stuff I did mostly eliminated all code where we used the nice drupal DB interface, cos we need to always work through civi's internal db connection. i.e., only use that crappy CRM_Core_DAO::executeQuery [20:12:41] (PS1) Katie Horn: Allows the wr1 processor to find contributions in civi from either an order_id or a contribution_tracking id. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/119816 [20:12:53] awight: ^^ [20:12:56] k [20:13:22] hey, can u CR my patch from yesterday? [20:13:30] Also, remind me to make a bigass card with "testing framework for audit scripts" in the title. [20:13:30] not quid pro quo but... [20:13:36] yes. [20:13:48] that is a big card. [20:15:27] argh, first pass thru, that code looks fine [20:16:04] The best part? I had to die (and cuss) in wmf_civicrm_dao_to_list to even SEE the error that I pasted up there. [20:16:13] whoa [20:16:23] Otherwise, it just swallows the freaking thing. [20:16:25] that's a big hint actually [20:16:33] I think the error does not happen *unless* u die [20:16:42] * K4-713 squints [20:16:46] * K4-713 squints more [20:17:01] if you die, then you are in a pushed db world, then when all the drupal death stuff happens you are effed [20:17:35] so the original symptom was that dao_to_list was returning emptiness? [20:17:36] * K4-713 facepalms self into a hole in the ground [20:17:44] Yes. Always emptyness. [20:17:54] I could take the query and run it manually, and get results. [20:18:02] ... /me tries to remember how to debug this crap [20:18:27] ...crap. I hate to eat lunch real fast before a 2pm meeting. [20:18:41] no worries! [20:18:47] I hate lunch too :p [20:18:58] I'll be online all afternoon [20:19:45] did you notice that Civi's executeQuery has the most insane call syntax of anything ever written? [20:19:51] Dang. These... never return false. I wonder how long that's been going on. [20:19:58] That's kind of important. [20:20:22] ...says so in the function documentatoin. [20:20:51] oooooooo. [20:20:55] agreed [20:21:24] I can't help but notice, that cf1d9b5 happened right about the time that Caitlin started saying that refunds stopped coming in . [20:21:57] yeah i was surprised nothing was obviously engulfed in flames after that [20:22:25] ...which makes total sense. It's looking for a strict false to come back if there's nothing there. It's been assuming the whole time that all the refunds are already in. [20:22:33] aha! [20:22:47] u could test for false-ish now... [20:22:53] Not really. [20:23:01] either way [20:23:29] They're reading empty arrays as... not-falseish. [20:23:55] true-esque. :p [20:24:11] that's why they call u K-- [20:24:24] This would also explain your allegations of a zillion duplicate messages from the wr1 audit. [20:24:28] ...I think. [20:24:51] But, okay. Really need to lunch now. [20:24:53] we should log a summary line for that [20:24:59] back in... I have no idea how long. [20:25:09] but I retract my allegations, cos that was actually around the correct number [20:25:21] 2% of total or so coming through WR1 [20:25:34] qc would still catch the dupes. [20:25:40] So, that still makes sense. [20:26:54] no i mean, the volume of queue messages was roughly on target so it doesn't look like there was a huge dupe leak. [20:33:03] K4|gone: merchantreference is the contribution_id, or the contribution_tracking.id ? [20:35:28] K4|gone: oh nvm, I see. [20:36:47] (CR) Adamw: "Found two bugs. I'm really concerned about the first one tho, cos it should have thrown a db error. If we're suppressing errors we have " (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/119816 (owner: Katie Horn) [20:43:43] awight: I'm not convinced about one of those things you mentioned in comments, as I ran the query manually in mysql and it came back as expected. [20:43:49] Otherwise, this looks helpful.. [20:43:54] :p [20:46:22] Ugh. Not going to be able to know for sure for a couple hours, though. [20:49:05] (CR) Katie Horn: [C: -1] "I'm not done with this yet." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/119816 (owner: Katie Horn) [21:11:41] K4-713: right? the id thing is really weird. There's no way that query can run... [21:22:53] #1472: (AG) TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1472 [21:27:06] (CR) Krinkle: "I assume this is supposed to be an array, not an object? It's not placeholding the cookie (becuase that defaults safely to empty string, m" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/118356 (owner: Mwalker) [21:27:28] (CR) Krinkle: obj.Apply on IE doesn't handle nulls (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/118356 (owner: Mwalker) [21:28:46] (CR) Adamw: "@Krinkle: you're right, this was fixed in https://gerrit.wikimedia.org/r/#/c/118393/" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/118356 (owner: Mwalker) [21:30:53] #1479: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1479 [21:31:07] (CR) Krinkle: "Ah, interesting. I got here via git blame, maybe I want back too far or have an outdated copy. Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/118356 (owner: Mwalker) [21:31:53] #1479: (AW) TA:C -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1479 [21:31:58] Krinkle: hehe, yeah we like to workaround git blame and attribute really bad code to one another for fun :p [22:35:20] Geeze, wait for mwalker|away to be on vacation and start beating up CentralNotice. [22:35:57] I see how it is. [22:48:51] #1328: (AW) N:Wlfsdlc Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1328 [22:48:52] #1328: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1328 [22:49:14] mwalker|away: your "{}" was all fucked up. [22:49:30] ; [23:00:52] #1480: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|TA:C|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1480 [23:30:52] #1479: (AW) N:cdwiat -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1479 [23:32:52] #998: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/998 [23:34:51] #1455: (AW) TA:C|N:dcdnhse Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1455 [23:35:51] #1463: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1463 [23:36:51] #1463: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1463 [23:58:52] #1481: (C) O:C|T:TI Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1481