[00:02:31] <K4-713>	 ...
[00:02:38] <K4-713>	 It's still getting a pile of dupes.
[00:02:52] <slander>	 #1270: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1270
[00:05:32] <awight>	         // the following causes tons of errors. Don't.
[00:05:33] <awight>	         // paymentMethod = 'r' + paymentMethod;
[00:05:36] <awight>	 interesting.
[00:05:59] <awight>	 that is from https://donate.wikimedia.org/w/index.php?title=Template:2012FR/Form-section/Processing/Default&action=edit
[00:06:12] <awight>	 which... makes the DI normalization prime suspect.
[00:06:51] <K4-713>	 I don't know about that. Upstream of payments shouldn't ever send "r"-anything. They should send "cc" and "recurring=1".
[00:06:51] <slander>	 #1271: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1271
[00:06:52] <slander>	 #1260: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1260
[00:07:01] <K4-713>	 But.
[00:07:10] <awight>	 K4-713: yeah exactly, which is what I "discovered"
[00:07:30] <K4-713>	 This still doesn't answer my "are we actually sending people to recurring cc forms" question.
[00:07:49] <K4-713>	 Knowing how strange it's been, that seems like a weird decision.
[00:08:30] <K4-713>	 yay failmail.
[00:08:32] <K4-713>	 Timeout.
[00:08:51] <slander>	 #1259: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1259
[00:09:22] <awight>	 K4-713: if the XML does not have recurring, then we are not sending people to recurring forms. ?
[00:09:34] <K4-713>	 huh?
[00:09:51] <slander>	 #1253: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1253
[00:09:55] <K4-713>	 No, we could totally be accidentally making them do a one-time transaction instead of an intended recurring one.
[00:10:05] <awight>	 K4-713: you said, the XML is not recurring, but utm_source is?
[00:10:11] <K4-713>	 yes
[00:10:13] <awight>	 hmm that doesn't make sense to me
[00:10:24] <K4-713>	 What? It's just the other side of the possibility coin.
[00:10:33] <K4-713>	 They were either meant to be recurring, or not.
[00:10:38] <awight>	 I think I found a bug already, but no idea why it hasn't been affecting us for months.
[00:10:49] <K4-713>	 ...
[00:10:51] <slander>	 #1212: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1212
[00:10:57] <awight>	         $payment_method_family = PaymentMethod::getUtmSourceName(
[00:10:57] <awight>	             $this->getVal( 'payment_method' ),
[00:10:57] <awight>	             $this->getVal( 'recurring' )
[00:10:57] <awight>	         );
[00:10:57] <K4-713>	 What makes you think it hasn't been?
[00:11:07] <awight>	 right.  if it has been, then this is the bug :)
[00:11:20] <awight>	 getVal('recurring') is gonna return fucking '0' or something
[00:11:33] <awight>	 which the code in PaymentMethod is not smart enuf to decode as a fuzzy boolean.
[00:11:39] <K4-713>	 And you think that the getter doesn't handle falseish properly?
[00:11:44] <K4-713>	 right.
[00:11:46] <K4-713>	 unit test
[00:11:54] <K4-713>	 Or rather: Make a card.
[00:13:51] <slander>	 #1211: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1211
[00:14:04] <awight>	 K4-713: encarded.
[00:14:09] <K4-713>	 Thanks much.
[00:14:17] * K4-713  goes to finish off this payments deploy

[00:14:22] <K4-713>	 s632
[00:14:24] <K4-713>	 oops
[00:14:26] <awight>	 hehe
[00:14:26] <K4-713>	 ha
[00:14:33] <awight>	 pager code again...
[00:14:51] <slander>	 #1485: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1485
[00:14:51] <slander>	 #1210: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1210
[00:17:14] <K4-713>	 !log synchronized payments to 9227c8f1b7a128bb5585
[00:17:20] <morebots>	 Logged the message, Master
[00:17:29] <K4-713>	 ...friday, at 5:17pm local...
[00:17:38] * K4-713  ruins own weekend

[00:18:15] <awight>	 K4-713: you are nuts
[00:18:24] <K4-713>	 atgomez: DD in ES is possibly fixed now.
[00:18:37] <atgomez>	 woo!!
[00:18:48] <K4-713>	 I'd have somebody try it, though. :/
[00:18:56] <atgomez>	 but... how... :(
[00:19:17] <K4-713>	 Don't we have any friends in Spain?
[00:19:31] <K4-713>	 ...shoo.
[00:19:31] <atgomez>	 someone probably does?
[00:19:49] <atgomez>	 maybe we should post that ew think it's fixed to that thread and then ask them to test it or turn it off?
[00:19:58] <atgomez>	 unless we really know someone
[00:19:59] <atgomez>	 i don't
[00:20:19] <K4-713>	 I'm genuinely not sure what they usually do for real-life QA.
[00:20:37] <K4-713>	 awight: You know what's neat that also just happened?
[00:20:40] <atgomez>	 ha ok. best thing is probably to reply on the thread and let team europe take it from there.
[00:21:03] <atgomez>	 because peter can turn it off if it doesn't work
[00:21:18] <K4-713>	 atgomez: I think I'm going to send that email at the end of the vigilant hour.
[00:21:19] <atgomez>	 also, it's def 121am there... nobody is goign to test it for us
[00:21:30] <atgomez>	 K4-713 what is this Vigilant Hour of which you speak?
[00:21:57] <K4-713>	 So, after a deploy, the general rule of thumb is "hang out for an hour and make sure it's stable".
[00:22:09] <atgomez>	 cool.
[00:22:17] <K4-713>	 I don't really consider it done until after that hour.
[00:22:20] <atgomez>	 yeah totally
[00:22:23] <K4-713>	 I might have to take it back.
[00:22:54] <atgomez>	 want to take a break and look at some mingle thoughts i have? if not, definitely not a problem
[00:22:54] <K4-713>	 awight: But that other cool thing? Universal log prefixes just also happened.
[00:22:58] <grrrit-wm>	 (PS4) Adamw: Add a UI for attaching mixins to banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120157
[00:23:05] <K4-713>	 (It's just that I've been talking about doing that forEVER...)
[00:23:09] <grrrit-wm>	 (CR) Adamw: Add a UI for attaching mixins to banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120157 (owner: Adamw)
[00:23:52] <awight>	 K4-713: yes!
[00:23:55] <K4-713>	 atgomez: Ah, I'm also babysitting the nightly audit mess.
[00:24:02] <atgomez>	 meh
[00:24:05] <K4-713>	 It's being kind of jerky.
[00:24:05] <awight>	 I think I threw a little party yesterday when I saw it was merged
[00:24:11] <K4-713>	 :)
[00:24:28] <awight>	 U saw the Jenkins timeout settings, right?
[00:24:30] <awight>	 K4-713: ^
[00:24:44] <K4-713>	 awight: Yeah, I did.
[00:24:46] <K4-713>	 Deliberate.
[00:24:49] <awight>	 k i will go now.
[00:25:15] <K4-713>	 I'm, ah, waiting for this to go... http://ganglia.wikimedia.org/latest/graph_all_periods.php?c=Fundraising%20eqiad&h=silicon.frack.eqiad.wmnet&r=hour&z=small&jr=&js=&st=1395440731&v=1&m=ActiveMQ%20QueueSize%20donations&vl=Messages&z=large
[00:25:25] * K4-713  goes to give civi a nightmare

[00:32:02] <K4-713>	 What the...
[00:40:28] <K4-713>	 ARGH.
[00:41:18] <grrrit-wm>	 (PS1) Adamw: add Date Diet mixin based on https://meta.wikimedia.org/w/index.php?title=MediaWiki:CentralNotice/Resources/BannerShowHideCountDate.js&oldid=6907253 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120167
[00:41:27] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] add Date Diet mixin based on https://meta.wikimedia.org/w/index.php?title=MediaWiki:CentralNotice/Resources/BannerShowHideCountDate.js&oldid=6907253 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120167 (owner: Adamw)
[00:43:38] <grrrit-wm>	 (PS2) Adamw: add Date Diet mixin based on https://meta.wikimedia.org/w/index.php?title=MediaWiki:CentralNotice/Resources/BannerShowHideCountDate.js&oldid=6907253 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120167
[00:48:39] <grrrit-wm>	 (PS1) Katie Horn: wr1 sadface alleviation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/120169
[00:48:45] <K4-713>	 awight: It burns.
[00:48:49] <K4-713>	 ^^
[00:48:50] <awight>	 ok...
[00:49:03] <awight>	 aaauuuughhh!!!
[00:49:08] <K4-713>	 See?!?
[00:49:14] <awight>	 what IS it
[00:49:43] <K4-713>	 Wellp, I'm going to go jump in front of a bus. :p
[00:49:52] <atgomez>	 nooooo
[00:57:21] <grrrit-wm>	 (Abandoned) Katie Horn: wr1 sadface alleviation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/120169 (owner: Katie Horn)
[01:23:27] <grrrit-wm>	 (PS1) Katie Horn: wr1: Helps if I'm using the right query for the id I actually have. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/120176
[01:23:59] <K4-713>	 awight: ^^
[01:24:15] <K4-713>	 I'm not sure I can facepalm any harder than I have been doing all week, so I'll just...
[01:25:15] <K4-713>	 http://img2.wikia.nocookie.net/__cb20130516202211/adventuretimewithfinnandjake/images/5/5f/Bunny_facepalm_by_shlj23-d4s3yaj.jpg
[01:26:23] <awight>	 K4-713: don't blame yourself.  It's all traceable back to simpletest and its flawedness.
[01:26:46] <K4-713>	 I hope we get time to do something else.
[01:28:17] <grrrit-wm>	 (CR) Adamw: [C: 2] "oh, dear!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/120176 (owner: Katie Horn)
[01:33:22] <K4-713>	 awight: Thanks for the CR support so late on a Friday.
[01:33:38] <K4-713>	 !log updated prod civi to 21b69b3d5df6cd22
[01:33:45] <morebots>	 Logged the message, Master
[01:33:58] <awight>	 K4-713: np.  I was about to give you my gerrit login.
[01:34:03] <K4-713>	 bahaha
[01:34:12] <awight>	 but it's *not me*, seeee?
[01:34:28] <K4-713>	 Good news, though: When I use the correct query, it works.
[01:34:38] <K4-713>	 Weird, right?
[01:34:45] * K4-713  needs new brainglasses

[01:36:07] <awight>	 hehe :(
[01:36:19] <awight>	 so you'll know if it works in just 30 minutes?
[01:37:59] <K4-713>	 It does. It passed.
[01:38:03] <K4-713>	 Just now.
[01:38:15] <K4-713>	 No more queue mountains.
[01:39:20] * awight  makes like Machibuse

[01:39:33] <K4-713>	 Running again to make sure it can see the work it just did...
[01:45:41] <K4-713>	 Aside from exactly three mystery transactions that are probably getting caught in the damaged queue or something: Yes.
[01:45:53] <K4-713>	 (Since there were, like, 10k, that's not so bad)
[01:46:26] <awight>	 10-4!
[07:04:16] <grrrit-wm>	 (Abandoned) Adamw: WIP flesh out source metadata headers [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/109705 (owner: Adamw)
[21:11:48] <grrrit-wm>	 (PS1) Amire80: Show rtl collapsible arrow in rtl languages [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120312
[21:58:12] <grrrit-wm>	 (CR) Siebrand: [C: -1] "i18n/L10n reviewed." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120157 (owner: Adamw)