[04:46:02] (PS2) 01tonythomas: Updated Special: Version/Credits/CentralNotice [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120375 [07:21:55] (CR) Siebrand: [C: 2] Updated Special: Version/Credits/CentralNotice [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120375 (owner: 01tonythomas) [07:22:03] (Merged) jenkins-bot: Updated Special: Version/Credits/CentralNotice [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120375 (owner: 01tonythomas) [15:01:48] (CR) Mwalker: [C: -1] "Interesting start; it definitely fixes part of the problem (for the selection drop down); but each individual log also has a dropdown arro" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120312 (owner: Amire80) [15:57:29] morning mbeat! hope you had a good weekend :) [18:34:14] #1486: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1486 [18:40:14] #1487: (AW) O:AW|TS:B|P:E|TT:OA|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [18:40:14] #1487: (AW) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [18:40:14] #1487: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [18:40:14] #1487: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [18:46:14] #1487: (AW) N:PrshkhcUi Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [18:48:14] #1488: (AG) O:AG|TS:B|P:MH|TT:S|IU:N|TA:DI|->Sprint 45|BG:#Maef|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1488 [18:48:14] #1454: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [18:48:14] #1454: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [18:49:15] #1454: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [20:17:34] awight: Okay, what's up? I've got about an hour before I have to drastically switch gears. [20:18:10] K4-713: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1436 [20:18:32] * K4-713 makes happy interested noises [20:18:36] yah complete CR is not required, but I'd like your input before we end up deploying and reverting ;) [20:18:45] haha, fair enough. [20:19:27] The way we disable jobs is changed, so that we aren't losing the previous max_batch_size settings... [20:19:44] awight: Is this meant to cover all jobs with a dequeue loop, or just qc and... unsub? [20:19:59] another contentious thing I did is to decouple the donations and recurring queues [20:20:10] K4-713: all jobs that already have a dequeue loop [20:20:16] k [20:20:21] I know you didn' [20:20:27] didn't want me to decouple them... [20:20:32] ...I guess that might only be qc and unsub. [20:20:43] Actually, I'm fine with them being decoupled. [20:20:45] also, recurring and refund [20:21:06] cool. [20:21:08] I don't think recurring ever has the realtime demands that the main donations queue has. [20:21:18] right, agreed. [20:21:25] Just... sometime that day. ;) [20:21:32] we should be able to prioritize the shit out of the main queue [20:21:38] yep [20:22:25] * K4-713 cusses at gerrit for the scroll-less window avalanche for the 100th time [20:28:12] awight: I think while I'm doing this, I'm going to poke the globalcollect audit script a few more times. Try to get one everything-runthrough from... october or something. [20:28:33] mwalker, pizzzacat: ^^ [20:28:33] shore [20:28:33] So, if it failmails, it's me. [20:28:41] I would have assumed :p [20:29:31] Oh, I know... but I like to tell people beforehand, anyway. [20:29:49] Makes me look more deliberate. Or something. [20:30:33] * awight takes notes [20:30:43] I usually just turn the failmail hose on myself [20:31:19] But if everybody gets them, you look busy. :D [20:31:30] lol /me furiously takes more notes [20:34:14] #1487: (AG) Thanks :) -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [20:34:14] #1487: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [20:34:15] #1487: (AG) TA:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [20:35:20] #1487: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [20:37:14] #1487: (AW) TA:NR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1487 [20:55:34] awight: Here's a fun one. [20:55:50] wr1 files... are very very occasionally, functionally empty. [20:55:57] yeah [20:56:01] 802 bytes. [20:56:11] hehe, paypal audit files are often zero bytes, for no reason [20:56:37] I sort of want to add something to the jenkins downloady thingy to sound an alarm when the file is under 1k. Like, ever. [20:56:52] At this point, it's basically impossible. [20:57:09] K4-713: What kind of alarm? And, why impossible? [20:57:18] Continuous fundraising. [20:57:40] Just the required header-ish info gets you to exactly 802 bytes. [20:58:01] We haven't had an actual day of zero activity in... [20:58:06] er. [20:58:09] I don't think I understand. Why would this be an alarm condition? [20:58:15] Just the improbability? [20:58:24] Yeah, there's... no way. [20:58:31] hehe a very low way [20:58:54] Even if we turn everything off, we're still going to get late-settling payment types, refunds, chargebacks... recurring... [20:58:58] How about leaving that to the source_type dashboard? [20:59:12] source_type dashboard? [20:59:30] You mean... one of the many things that doesn't exist yet? [20:59:31] like, highlight the event if there are 0% of donations coming in through auditing [20:59:34] yes :) [20:59:46] Actually, we would like to be in a place where that's true. [20:59:56] Using the listener... [21:00:01] But, empty audit files means we are incapable of picking up the pieces. [21:00:21] ok well I think it's totally fair to alert on an empty audit file [21:00:25] Somebody should have eyeballs on, every time we get a stub. [21:00:30] yep [21:01:10] Ah, atgomez. Fun one for you. [21:01:26] We're missing some nightly audit files from GC. [21:01:50] fwiw, in PayPal the approach I took was, if the audit file is empty, delete it and let the next day's job try again. [21:02:04] But I'd like a failmail anyway. [21:02:16] awight: I think we do an empty check... but the problem is that it's not technically empty. [21:02:37] yeah in your case, I totally agree with your instinct to yell loudly [21:03:32] awight: I think we only have 30 days to kick somebody when their end chokes. [21:21:46] (CR) Katie Horn: [C: 1] "I like where this is going. Comments ensue." (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/119546 (owner: Adamw) [21:22:16] awight: ^ [21:22:28] And, I'm running off for a while. [21:22:38] If I'm not back in about an hour: Avenge me. [21:38:14] #1489: (AW) TA:C -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1489 [21:38:14] #1489: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1489 [21:39:35] (CR) Adamw: (FR #1436) Add a job time limit to queue processing modules (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/119546 (owner: Adamw) [21:54:14] #1490: (AW) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [21:54:14] #1490: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [21:54:14] #1490: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [21:54:14] #1490: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [21:54:14] #1490: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [22:21:59] (PS1) Adamw: Revert "Hush stdout logging unless we are running from a console" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/120647 [22:22:11] mwalker: ^^ [22:23:18] (CR) Mwalker: [C: 2] Revert "Hush stdout logging unless we are running from a console" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/120647 (owner: Adamw) [23:29:14] #1490: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [23:29:14] #1490: (AW) JGreen want to do this the right way ;) TS:ID|MtPCRo:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [23:31:14] #1491: (AW) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1491 [23:31:14] #1491: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1491 [23:31:14] #1491: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1491 [23:38:45] (CR) Adamw: [C: 2 V: 2] Add Malay and Ukrainian to detail_languages for aggregation [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/119740 (owner: Pcoombe) [23:41:26] (PS1) Adamw: update DjangoBannerStats submodule [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/120707 [23:41:39] (CR) Adamw: [C: 2] update DjangoBannerStats submodule [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/120707 (owner: Adamw) [23:41:44] (CR) Adamw: [V: 2] update DjangoBannerStats submodule [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/120707 (owner: Adamw) [23:43:10] !log update tools from de586ae4ad03be52da1bb24177ea4bf7cdbd2c94 to 2cfc441a9e5d2de3cc892d0077603579b220ac0e [23:43:16] Logged the message, Master [23:56:14] #1492: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1492