[00:53:24] (PS6) Mwalker: WIP: More worldpay; token query [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121111 [00:53:35] (CR) jenkins-bot: [V: -1] WIP: More worldpay; token query [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121111 (owner: Mwalker) [01:19:47] (PS7) Mwalker: WIP: More worldpay; token query [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121111 [01:19:54] (CR) jenkins-bot: [V: -1] WIP: More worldpay; token query [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121111 (owner: Mwalker) [01:31:03] (PS1) Katie Horn: WIP: Added the (renamed) antifraud hook to the WorldPay workflow. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121568 [01:33:09] (PS2) Katie Horn: WIP: Added the (renamed) antifraud hook to the WorldPay workflow. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121568 [01:38:18] (PS8) Mwalker: More worldpay; token & auth queries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121111 [01:38:23] (CR) jenkins-bot: [V: -1] More worldpay; token & auth queries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121111 (owner: Mwalker) [01:49:41] (CR) Katie Horn: "Progress!" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121111 (owner: Mwalker) [01:51:09] (CR) Katie Horn: [C: 2 V: 2] More worldpay; token & auth queries [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121111 (owner: Mwalker) [01:52:06] (PS3) Katie Horn: WIP: Added the (renamed) antifraud hook to the WorldPay workflow. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121568 [01:57:03] (CR) Mwalker: [C: 2] WIP: Added the (renamed) antifraud hook to the WorldPay workflow. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121568 (owner: Katie Horn) [07:14:16] (PS1) Katie Horn: Added the cvv and avs antifraud tests to WorldPay. Advanced our ability to unit test fraud filters (but it clearly still needs work). [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121587 [07:14:24] (CR) jenkins-bot: [V: -1] Added the cvv and avs antifraud tests to WorldPay. Advanced our ability to unit test fraud filters (but it clearly still needs work). [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121587 (owner: Katie Horn) [07:15:40] (CR) Katie Horn: [C: -1] "...or not." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121587 (owner: Katie Horn) [11:34:48] #1507: (PC) O:PC|T:TI Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1507 [13:59:46] (PS1) Siebrand: Migrate amazon_gateway.i18n.php to JSON i18n [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121670 [14:00:38] (CR) Siebrand: "There's a follow-up in https://gerrit.wikimedia.org/r/#/c/121670/ . Because of the reason this was omitted, it feels as if there may be a " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121076 (owner: Siebrand) [14:01:20] (CR) Siebrand: "Self merging this, because it should have been in already." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121670 (owner: Siebrand) [14:01:26] (CR) Siebrand: [C: 2] Migrate amazon_gateway.i18n.php to JSON i18n [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121670 (owner: Siebrand) [14:01:42] (Merged) jenkins-bot: Migrate amazon_gateway.i18n.php to JSON i18n [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121670 (owner: Siebrand) [15:26:48] #1498: (AW) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [15:26:48] #1498: (AW) P:E -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [15:27:46] Jeff_Green: quick favor--can you disable the dedupe cronjob? [15:27:48] #1498: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [15:28:12] (context: ^^) [15:29:48] #1498: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [15:36:09] awight: yeah, one sec [15:36:18] sorry, stupid IRC client buried again [15:37:20] should be disabled now [15:39:39] Jeff_Green: thanks! see you online in a few. [16:42:17] (PS1) Pcoombe: Change email address inputs in GC forms to use type="email" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121690 [17:08:06] (PS2) Katie Horn: Added the cvv and avs antifraud tests to WorldPay. Advanced our ability to unit test fraud filters (but it clearly still needs work). [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121587 [17:19:05] Heeeey awight. [17:21:42] K4-713: yeees, hello :) [17:21:50] I C U are virtual for the moment [17:21:58] I am virtual for the whole... thing. [17:22:09] ah, excellent choice sir [17:22:45] I think I was working for... well, from 7am until sometime inadvisably after midnight last night. [17:24:05] So... if we get WP to a testable, show-offable, cc-payment-makable point today, don't be particularly surprised if I just sort of evaporate. [17:24:36] By "show-offable" I certainly don't mean "deployed somewhere". [17:24:46] I mean screensharing. ;) [17:29:12] awight: I wanted to ask, though, how the qc modifications for WP are looking. [17:29:56] oh heh. Nothing at all. [17:30:14] I'll go look at the DI module [17:30:15] Sounds like mwalker|away got unblocked on some silly configuration problem for our account on WP's end, so doing an end-to-end test is actually... not that far-fetched. [17:30:26] rad [17:31:07] fyi, my other two priorities for the day are * deal with the QC deadlock, and * get the-wub able to deploy CRM Thank-you letters [17:31:36] I don't think the stomp messages are going to be that especially different, and oh: I probably need to hack in some kind of stomp short-circuit for unit tests now, don't I. [17:32:05] dang. [17:32:58] awight: Yeah, the qc deadlock is probably... more of a big deal. [17:33:54] I was thinking so. Although, the workaround (disable the dedupe script) probably does the trick for now. [17:34:14] oh. [17:34:26] Now that you mention it, yeah. [17:34:54] It was a pretty random guess, that might not be the issue... But it sure seems to have worked so far. [17:35:31] Guh. [17:36:26] In the area of unit testing DI: Would it be more useful, do you think, to beat up stomp message sending, or curl? [17:36:31] We need to do both. [17:36:35] oh hrm [17:36:44] ...probably curl first. [17:36:44] Yeah I don't see how we can do just one or the other... [17:37:00] That's going to surface more fundamental problems, I feel. [17:37:10] Luckily, stomp is done using a hook, so that might be really easy to disable. [17:37:28] Yeah. I think I know what I want to do for curl. [17:37:38] And, testing stomp messages manually is... possible. [17:37:51] yeah, okay. [17:38:00] dummy communication with third parties it is. [17:38:25] FWIW, I did manage to get the CRM unit test environment worked out, and also wrote some drush jobs which will read and process a message directly from a json file. [17:38:34] If you feel like CR'ing that... [17:38:51] That might keep my eyeballs from melting, yes. :) [17:39:39] Did you see I overrode the log functions, too? [17:39:46] In DI unit testing. [17:39:49] Oh? Awesome. [17:40:09] Now we can test things that should cause the error.log to turn over, and make sure that happens. [17:40:26] And, you know, the opposite. [17:41:56] PHP's lack of multiple inheritance, though, is really bumming me out all of a sudden. [17:42:22] That would be insanely useful for those test adapters. [17:42:34] Oh god. I usually do composition instead. [17:43:04] But yeah, donno how you would do that in DI. [17:43:21] copy/paste festival... [17:43:30] * K4-713 is not happy about that [17:43:49] That festival sucks. They have no rides or funnel cakes. [17:44:08] admission is free up front, but u pay later. [17:44:33] Seriously. [17:44:47] I am very open to alternatives. [17:45:18] ...you know, hopefully ones that don't require either re-writing DI in a totally different style all of a sudden, or... making all the private members public. [17:45:53] Somebody tried to make all the private members public once... for testing. [17:45:59] IMO, "private" access has no business existing. "protected" is the tightest we should go [17:46:36] Sorry: I probably meant "!public" instead of strictly private. [17:46:45] Ah, I see the festival y're referring to. [17:47:22] It's all... overloading grandparent object... stuff. [17:47:55] I'm really hoping there's some stupidly simple way to do this that I'm not aware of that somebody will burn me for not knowing. [17:48:11] That means I have to do less work. [17:48:58] Argh. You are looking at what we doctors call an incredibly large wart. [17:49:13] Just, https://gerrit.wikimedia.org/r/#/c/121587/2/tests/includes/test_gateway/test.adapter.php,unified ? [17:49:17] or is there more... [17:51:33] Nope. All the horribleness is currently contained in one file. [17:51:47] I wanted to establish some kind of quarantine. [17:53:13] It's going to get worse, too. [17:53:20] Then hopefully better. [17:57:11] (CR) Adamw: [C: 2] Added the cvv and avs antifraud tests to WorldPay. Advanced our ability to unit test fraud filters (but it clearly still needs work). (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121587 (owner: Katie Horn) [17:57:22] (Merged) jenkins-bot: Added the cvv and avs antifraud tests to WorldPay. Advanced our ability to unit test fraud filters (but it clearly still needs work). [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121587 (owner: Katie Horn) [17:57:54] Damn, and with that, the deadlock rears its head again. [18:07:51] #1498: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [18:07:51] #1498: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [18:51:48] #1498: (AW) N:iac Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [20:18:48] #1498: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [20:26:48] #1498: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [20:27:36] pizzzacat1: mwalker: K4-713: anyone want to fight to the front of the line to review https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 ? This is blocking GRabbit's work. [20:38:38] Bueller? [20:45:58] (PS1) Mwalker: WorldPay Deposit Request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121846 [20:46:48] #1508: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [20:49:55] (CR) Mwalker: [C: 1] "This is a great change; but I'm worried that the styling is going to break on ie6/7/8 (non HTML 5 aware browsers). Have you tested that at" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121690 (owner: Pcoombe) [20:51:08] Good Grief. I got way more done before 9am, than I did after. [20:52:27] K4-713: want to sip caffeine bull over a nice CR thing? [20:52:32] ya; that was me earlier in the week [20:53:47] * awight elephant waves arms to see if is real [20:53:51] hmm [20:54:04] you three can just say "no", also [20:54:22] pizzzacat1: K4-713: mwalker: anyone up for CR? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [20:54:44] awight: Is that WP? [20:55:25] hehe, no that is getting Giant Rabbit to help us with all the other backlog [20:55:32] it is the blocker to any of that. [20:56:38] awight how can I help? [20:56:50] pizzzacat: if u feel like CR'ing the above... [20:57:28] u [20:57:29] m [20:57:57] irl [20:58:50] awight am I missing the repo? [21:08:40] (CR) Adamw: [C: 2] WorldPay Deposit Request (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121846 (owner: Mwalker) [21:09:36] (CR) Adamw: WorldPay Deposit Request (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121846 (owner: Mwalker) [21:09:42] (Merged) jenkins-bot: WorldPay Deposit Request [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121846 (owner: Mwalker) [21:18:29] K4-713: mwalker: what is the plan for encoding payment_instrument in WP queue messages? [21:19:00] as in the payment_method and payment_submethod? [21:19:13] I think for now, it's going to be cc [21:19:15] we get back card type from worldpay; so I was going to drop that into payment_submethod probably [21:19:33] ...but we need a code for the two french cards. [21:19:51] K4-713: cool. Just that I was noticing there is no field for method, yet. I'd rather have DI set that, than make assumptions in the CRM. [21:20:12] huh? [21:20:18] K4-713: sorry, I was wrong, I see it now. [21:20:47] Yeah, we have to be sending payment_submethod. [21:21:27] But, uh... cc and all the existing cards should be the same as the ones we use in GC. [21:21:49] yep. actually, it looks like nothing needs to happen in the QC to integrate with WP. [21:22:09] ... [21:22:11] * K4-713 blinks [21:22:17] that's what I said! [21:22:20] That's... [21:22:24] Can you test that? [21:22:36] can do. [21:22:50] Uh, what about new payment [instruments or whatever] for the new card types? [21:22:56] let me download one of my unmerged patches which makes testing possible :p [21:22:59] ...whatever we decide to call them. [21:23:29] yeah lemme know what u call them and I'll write migrations. [21:24:48] #1508: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [21:24:48] #1508: (AW) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [21:25:39] (PS4) Adamw: drush commands to interpret JSON files as messages and feed to *_import functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121290 [21:25:49] #1508: (AW) Need the new credit card type names AT:AW|B:B -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [21:30:56] (PS1) Adamw: Make queue2civicrm_import accept messages in many formats [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121862 [21:31:26] (PS5) Adamw: drush commands to interpret JSON files as messages and feed to *_import functions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121290 [21:34:46] (PS1) Katie Horn: Moving the post-transaction addData to a place that makes a little more sense. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121868 [21:36:12] (CR) Adamw: [C: 1] Moving the post-transaction addData to a place that makes a little more sense. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121868 (owner: Katie Horn) [21:38:20] (PS4) Adamw: PHPUnit tests under Drupal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/120735 [21:39:49] #1454: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [21:39:49] #1454: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [21:41:15] Just heard a great Bowie cover: Peter Schilling - Major Tom (Voellig Losgeloest) [21:48:50] #1508: (AW) P-TS:#IW -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [21:49:49] #1508: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [21:50:04] K4-713: tl;dr of the queue consumer stuff is that you can do end-to-end testing with the QC already, unknown credit card types will just get the generic "Credit Card" instrument. [21:50:41] awight: Rad. [21:59:06] awight: So, the two new card types we are going to need, are Carte Bancaire and Carte Bleue. [21:59:49] #1454: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [21:59:57] awight: The other cards are currently abbrev'd for the submethod code, right? [22:00:54] K4-713: great. We have 'cb' for bleue already, however, the GC adapter is overloading the same code for bancaire. Suggestions? [22:01:03] I assume we do care to discriminate? [22:01:38] Yeah, I mean, we should be able to. [22:01:52] I'll look at the GC documentation to see if the issue is on their end. [22:02:28] It might be. I know I've seen it written as Carte Bleue/Carte Bancaire somewhere before. [22:04:07] http://en.wikipedia.org/wiki/Carte_Bleue -- apparently, Carte Bleue is an instance of the broader "banking card" system [22:04:31] Hmmmmn. [22:04:50] Groupement des Cartes Bancaires CB ("CB Bank card Group"), also known as simply CB, is France's national interbank network [22:04:52] Awesomely, I can't find a map of WP codes that includes it. [22:05:16] "CB Carte Blanche" [22:05:24] * K4-713 headdesks slightly [22:06:06] Carte Bleue VISA is a brand often associated with CB. In fact, all Carte Bleue cards are part of CB but not all CB cards are Carte Bleue (they could also be MasterCard). CB offers the ATM and EFTPOS networking infrastructure, while Carte Bleue is the debit card or mode of payment. [22:06:13] eughhh [22:06:30] CB/CB/Visa :) [22:07:34] To make things more awesome, the CB that WP sends us appears to be a totally other thing that is associated with Diners. [22:10:35] I'm grepping their integration doc-- hopefully this is a typo :( CB [22:10:37] Carte Blanche [22:11:27] I did find MerchantServices-DevGuide_08.54.01b (1).pdf -> pg 248, CreditCardType [22:12:36] nvm, blanche was phased out in the '80s [22:12:55] K4-713: so, what I'm suspecting is that we might not actually see "CB", but will see "Visa" instead [22:14:12] That's what I copied the line in from, yes [22:14:25] sorry, what context? [22:14:29] "CB" ? [22:14:47] Oh, not GC. WP's card type docs. [22:14:58] The CB = Carte Blanche [22:15:00] What is the doc title? [22:15:01] oh [22:15:02] dear [22:15:21] The othe rthing is, I'm seeing that "Carte Bleue is the debit card or mode of payment" [22:15:25] so... it's not even a CC [22:15:55] I can write a note asking PPena to chase this down, if you want to stop thinking about it [22:16:34] Oh man, the marketing practically writes itself. "We're giving you the Carte Blanche to go shopping." [22:17:13] wow. Yes unfortunately that deal spontaneously vaporized in a cloud of coke, in the late '80s [22:18:02] The WP docs call it CC all over the place. [22:18:13] I know... [22:18:28] And, we're never going to get it anywhere else, it seems... [22:23:00] K4-713: Okay, I don't see card type returned by any WP apis except "BIN", which I doubt we're going to use. [22:23:12] Therefore, there is no submethod available. [22:23:23] CreditCardType? [22:23:57] for which API? [22:25:28] Argh, PT has it as well, why did I... [22:26:07] Okay, back to writing Pats [22:34:50] #1508: (AW) B:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [23:07:48] #1439: (AW) AT:(s|O:AW|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1439 [23:07:48] #1439: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1439 [23:11:50] #1445: (AW) N:SaGranuic Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [23:11:50] #1445: (AW) O:AW|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [23:11:50] #1445: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [23:11:50] #1445: (AW) AT:AG -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [23:43:37] (PS1) Mwalker: WP result codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121896 [23:43:46] K4-713, ^ [23:43:52] the not very exciting patch [23:44:03] on it [23:44:12] it's totally awesome that you made the unit tests pass~ [23:44:17] so, *high five* [23:45:03] Thanks. That nearly killed me. [23:45:06] heh [23:46:14] mwalker: I guess my only comment about the return map is that it's sometimes helpful to have the incredibly lame error descriptions in comments for every code range, but... it's not a blocking issue. [23:46:39] I can provide the list in the code? [23:46:40] (CR) Katie Horn: [C: 2 V: 2] WP result codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121896 (owner: Mwalker) [23:46:58] might as well [23:47:52] mwalker: I'm going to do something annoying with curl later today. [23:48:29] Basically it's "throw all the curl functions in a wrapper so we can override everything in the tests". [23:48:58] Then we can do things like... save canned XML responses for the purposes of error handling. [23:49:11] I like! [23:49:13] also... [23:49:20] I was wondering how to go about saving the outbound XML [23:49:29] I'm going to have to mark some fields for redactoin [23:49:29] We probably shouldn't. [23:49:49] Actually, I think we deliberately don't because cvv. [23:50:00] right; that's the field I'll need to redact [23:50:25] I guess their responses don't echo much, do they? [23:50:27] Or, do they? [23:50:32] but I know from my debugging efforts that a lot of my problems were resolved by seeing what fields were and weren't sent in the xmlr equest [23:50:39] no; they don't echo much [23:50:44] sux. [23:50:45] Okay. [23:50:57] Let me think about that one. [23:51:00] basically just the transaction type, and some other metadata like customerid [23:52:31] I guess if we added an option to the transaction structure to say we want to log outbound, and then ensure that we remove sensitive nodes... [23:53:49] (PS1) Mwalker: Description for WP result codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121897 [23:54:06] K4-713, ^ [23:55:07] (CR) Katie Horn: [C: 2 V: 2] Description for WP result codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121897 (owner: Mwalker) [23:55:22] Yay, convenience. :) [23:55:32] heh [23:55:35] ok [23:55:39] what should I work on now? [23:56:16] Oh, woah. We totally blew it on having a standup today. [23:56:31] Also, it's apparently 5pm. [23:56:36] I'm thinking about actually doing the form verification on the api call [23:56:51] yes -- pizzzacat and I might have talked about it; and then decided to see if you remembered [23:56:59] and I know; :( [23:57:05] but! it is really nice out toda [23:57:14] I sorta want to go home and work from balcony [23:57:15] Yeah, I'm ignoring everything today. Until I can test moar things. [23:57:31] ok; so you're in unit test land? [23:57:47] I was in "weird clerical BS land" for a while. [23:58:04] so many ducts! [23:58:34] I'm so close to a good form y'all! I decided to say f-it to wireframes and just go for it [23:58:35] haha [23:58:49] That's the spirit! :D [23:59:11] Wireframes have only ever made my life worse. [23:59:35] I prefer to go straight from crayon drawings to the real thing.