[00:00:14] srsly. I usually do that but I think some people kinda wanted to see wireframes and I had originally said "ok!" [00:00:28] but I decided less work is better [00:00:30] :p [00:00:37] pizzzacat: Everybody thinks they want wireframes. [00:00:57] What they want is a fully functional wireframe with no surprises going forward. [00:01:04] it's way easier to build html forms in code than to draw them in photoshop etc [00:07:20] pizzzacat: Serious. But the second you make a clickable button, people think it does things. [00:07:40] ..aw, gone. [00:09:40] (CR) Mwalker: Make queue2civicrm_import accept messages in many formats (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121862 (owner: Adamw) [00:13:41] (CR) Adamw: Make queue2civicrm_import accept messages in many formats (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121862 (owner: Adamw) [00:13:56] mwalker: but don't let that stop you from reviewing the successor patches... [00:15:14] awight: Huh. You feed arrays in there again? I thought you took that out. [00:15:29] * K4-713 grins maniacally [00:15:56] K4-713: no kidding. [00:16:15] Turns out, Stomp_Frame was not the best choice of required type hint [00:16:35] * awight opens the window in K4-713's laboratory [00:16:54] * K4-713 airs out slightly [00:17:21] clearly it's time to start using SmashPigs class for these things! :D [00:17:22] * mwalker ducks [00:17:24] Oh speaking of Beaker, anyone (who already owns the movie) need a copy of Muppets From Space? [00:17:50] I like your qualification there [00:18:09] I have the DVD... I think. [00:18:11] "I already own the movie... but I lost it, long ago, and the reciept" [00:18:18] hah [00:18:27] "You cant prove anything!" [00:18:48] Gonzo is my jam. [00:19:14] * K4-713 wonders why I keep referring to things/people that are not songs, as "my jam"  [00:20:25] Raspberry is my jam [00:20:48] * mwalker spontaneously wonders what the formal definition of 'a jam' is [00:22:04] awight, so; if you're still thinking about these things (and I note you have a couple of different ways of doing that data extraction); I'm happy to +2 it [00:22:11] or you can massage this mess further [00:22:49] because I thought 121290 was fine; with the possible exception of your message extraction [00:23:04] mwalker: I am fine with a mergeball. [00:23:30] I do want to revisit 121862, but since it's only an enhancement, it's pretty much safe for prime-time [00:23:40] fair 'nuf [00:23:53] Bloody hideous, as u pointed out. [00:24:03] (CR) Mwalker: [C: 2] "OK; we've agreed that my complaint is for a future TODO" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121862 (owner: Adamw) [00:24:38] (CR) Mwalker: [C: 2] "TODO: Figure out the message body data extraction" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121290 (owner: Adamw) [00:25:27] awight, also; now that this runs under php unit; is this something that we can have jenkins run? [00:25:45] mwalker: yes. but there are no tests yet, the PHPUnit patch only provides the framework. [00:25:56] and: hell yes. [00:26:56] oh, K4-713: mwalker: a thought I had, or stole from K a long time ago and rehydrated, is that it would be incredibly slick to have a small trickle of test payments constantly running through the system. [00:27:43] mwalker: can you elaborate on the TODO above? [00:27:53] extraction from the .json files? [00:27:57] nono [00:28:04] the Stomp_Frame vs Array thing [00:28:10] oh right. [00:28:19] wondering cos the todo was on another patch [00:28:32] aye; that patch had some uglyness along those lines too [00:28:47] u no like json_decode(file_get_contents ?? [00:28:49] :P [00:28:57] no; that's fine [00:29:48] I'm thinking though that we should do the json_decode( $msg->body )extraction in stomp loop rather than in the queue process function [00:29:59] that way the process functions can just be dealing with arrays [00:30:07] I want to go further, and *never* use arrays. [00:30:48] Where did I take notes on that... https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1506 [00:31:08] I want to make field name typos impossible, and eliminate default values [00:31:16] and, hide wire serialization [00:31:30] awight: I totally want to keep revisiting the idea of dummy payments moving around. [00:31:32] plus some other stuff, like make messages indestructible. [00:31:49] K4-713: yeah I really like that. I'll make a card right this very second [00:32:14] Please can we call it "Duck Race" somehow? [00:32:48] #1509: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1509 [00:33:07] It's... I used to live in this small town, and once a year everybody paid to have a rubber duck in this town-wide duck race in the river that went through... [00:33:10] I've said too much. [00:33:23] erp. it has been memorialized in the card, already. [00:33:49] Oh good. [00:33:53] K4-713, iz ok; my dad's tiny town in AK did both that for the 4th of July; and took bets on when the river would melt [00:34:01] hehe [00:34:14] I like the paper boat with candle thing. How did that ever work? [00:34:18] I haven't seen a good duck race in about 15 years. [00:36:48] #1509: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1509 [00:38:38] (CR) Mwalker: [C: 2] PHPUnit tests under Drupal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/120735 (owner: Adamw) [00:42:17] Woot! [00:45:49] #1510: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1510 [00:49:48] #1509: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1509 [00:52:50] #1406: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1406 [00:52:50] #1406: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1406 [00:52:50] #1406: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1406 [00:52:50] #1406: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1406 [00:52:50] #1406: (AW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1406 [00:52:51] #1406: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1406 [00:52:51] #1454: (AW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [00:52:52] #1454: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [00:55:49] #1511: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1511 [00:56:51] #1511: (AW) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1511 [01:16:38] (PS1) Adamw: update thank-you templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121908 [01:19:41] Tom Tom Club - Wordy Rappinghood [01:19:43] oh wow. [01:38:49] #1373: (AW) Bug reports would be much appreciated. We are ... Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1373 [02:39:13] (CR) Mwalker: [C: 2] Moving the post-transaction addData to a place that makes a little more sense. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121868 (owner: Katie Horn) [05:49:40] (PS1) Katie Horn: Safer/more useful/++awesome phpunit tests * Made a wrapper for potentially dangerous curl functions (don't have to worry about somebody running unit tests on a dev machine with 3rd party creds anymore) * Overrode the curl_exec wrapper such that it will re [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121916 [05:49:47] (CR) jenkins-bot: [V: -1] Safer/more useful/++awesome phpunit tests * Made a wrapper for potentially dangerous curl functions (don't have to worry about somebody running unit tests on a dev machine with 3rd party creds anymore) * Overrode the curl_exec wrapper such that it will re [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121916 (owner: Katie Horn) [06:09:58] (PS2) Katie Horn: Safer/more useful/++awesome phpunit tests * Made a wrapper for potentially dangerous curl functions (don't have to worry about somebody running unit tests on a dev machine with 3rd party creds anymore) * Overrode the curl_exec wrapper such that it will re [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121916 [06:18:14] * K4-713 looks around... high-fives self