[07:49:33] (PS1) Siebrand: Migrate to JSON i18n [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/122299 [09:39:47] (CR) Raimond Spekking: [C: 2] Migrate to JSON i18n [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/122299 (owner: Siebrand) [09:39:54] (Merged) jenkins-bot: Migrate to JSON i18n [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/122299 (owner: Siebrand) [12:03:49] (CR) Pcoombe: [C: 2] update thank-you templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/121908 (owner: Adamw) [14:10:32] (CR) Pcoombe: "Great point. I've just looked into it and done some testing to confirm." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121690 (owner: Pcoombe) [14:19:07] (CR) Mwalker: [C: 2] "cool" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121690 (owner: Pcoombe) [17:33:55] (CR) Mwalker: [C: 2] Safer/more useful/++awesome phpunit tests * Made a wrapper for potentially dangerous curl functions (don't have to worry about somebody runn (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121916 (owner: Katie Horn) [17:34:04] (CR) jenkins-bot: [V: -1] Safer/more useful/++awesome phpunit tests * Made a wrapper for potentially dangerous curl functions (don't have to worry about somebody running unit tests on a dev machine with 3rd party creds anymore) * Overrode the curl_exec wrapper such that it will re [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121916 (owner: Katie Horn) [17:35:53] (PS3) Mwalker: Safer/more useful/++awesome phpunit tests * Made a wrapper for potentially dangerous curl functions (don't have to worry about somebody running unit tests on a dev machine with 3rd party creds anymore) * Overrode the curl_exec wrapper such that it will re [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121916 (owner: Katie Horn) [17:36:11] (CR) jenkins-bot: [V: -1] Safer/more useful/++awesome phpunit tests * Made a wrapper for potentially dangerous curl functions (don't have to worry about somebody running unit tests on a dev machine with 3rd party creds anymore) * Overrode the curl_exec wrapper such that it will re [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121916 (owner: Katie Horn) [17:40:16] (CR) Mwalker: [C: 2] (FR #1323) ignore debits unless it is a refund [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/114054 (owner: Adamw) [18:40:29] (PS1) Katie Horn: Removal of all test data from the DonationData object. Finally. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122454 [19:27:16] (CR) Mwalker: [C: 2 V: 2] Safer/more useful/++awesome phpunit tests * Made a wrapper for potentially dangerous curl functions (don't have to worry about somebody runn [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/121916 (owner: Katie Horn) [19:27:59] (CR) Mwalker: [C: 2] Removal of all test data from the DonationData object. Finally. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122454 (owner: Katie Horn) [19:54:48] #1439: (AW) TS:DR|MtIDo:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1439 [19:54:49] #1151: (AW) BG:#SPME(i|O:AW|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [19:54:49] #1151: (AW) ->Sprint 45|P-TS:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [20:26:48] #1483: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1483 [20:26:48] #1483: (AG) N:D4PDel Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1483 [20:36:08] !log updated crm from 5151d97044ce2fff7299cee8920ee9bd3dbbdf54 to e726e4213f1d65cae7276f91379eb1b229b19134 [20:36:13] Logged the message, Master [20:47:00] (PS1) Katie Horn: curl_getinfo actually defaults $opt to 0, not null. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122553 [20:50:51] (CR) Mwalker: [C: 2] curl_getinfo actually defaults $opt to 0, not null. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122553 (owner: Katie Horn) [20:50:57] (Merged) jenkins-bot: curl_getinfo actually defaults $opt to 0, not null. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122553 (owner: Katie Horn) [20:56:23] (PS1) Mwalker: WIP: Worldpay form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122559 [21:00:23] (PS2) Mwalker: WIP: Worldpay form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122559 [21:13:48] #1507: (AG) TS:B -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1507 [21:13:48] #1507: (AG) T:TT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1507 [21:13:48] #1507: (AG) TT:CT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1507 [21:13:48] #1507: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1507 [21:13:48] #1507: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1507 [21:13:49] #1507: (AG) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1507 [21:14:48] #1507: (AG) P:SH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1507 [21:14:48] #1483: (AG) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1483 [21:19:48] #1445: (AG) Adam can you thrown an estimate on this one ple... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [21:20:19] atgomez: ^^ that is already done [21:20:35] ok. can you put an estimate on it and move it to deployed? :) [21:20:38] We're not touching that card cos you put intro text on it saying it's just for reference. [21:20:42] there was no work in the card. [21:20:45] oh ok. sorry. gotcha [21:20:53] This is redundant to #1132, #576, possibly #710 [21:20:56] sorry [21:21:06] yeah.. i was still investigating. is that a true thing? or was there actual work around it? [21:21:14] i have been digging at that one on and off [21:21:45] atgomez: this is where the work happened, I believe? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1132 [21:22:03] cool. i'll delete the card [21:22:22] thank you [21:22:37] oh, dear... maybe not. [21:22:55] these comments are much newer than the work,. [21:23:12] K4-713: sorry to interrupt: didn't you just fix GC wr1 refund import, again? [21:23:36] awight: ...I did. Why do you ask in that ominous sort of way? [21:24:04] K4-713: hehe, I'm checking own sanity before I dig around for the card. [21:24:07] * K4-713 looks for evidence of explosions [21:24:26] No, as far as I know, it's floating. [21:25:37] crap, I don't see a card. [21:25:43] awight yeah i'm thinking there's more detangling to be done. it seemed redundant, and caitlin was running into some problems that seem rendant but eren't [21:27:11] atgomez: I don't see the patch, but I believe K4-713! [21:27:23] I guess I can go poke at source-metadata... [21:28:24] yeah i mean, this isn't a super big deal. i know i need to figure out what's going on with all those cards and clean it up [21:28:48] #1445: (AG) ->Sprint 45 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [21:29:22] i may have been WAY off in thinking they were redundant when i was trying to figure this out before. [21:29:22] That felt good. According to the source metadata, this bug was fixed around 2014-03-18 17:18:25 UTC [21:29:23] :/ [21:29:51] ok. so i was just wrong on the redunand thing. Sorry for tripping you up on mingle [21:30:47] atgomez: aaargh, actually disregard my last bleating [21:30:48] #1445: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [21:31:01] hahaha more goats? [21:32:25] that video was great--even formative [21:32:44] atgomez: so, I can't explain how the refunds thing got fixed, but I do see lots of recent ones. [21:32:59] magic. [21:33:00] U might ask K4-713 for an explanation--after worldpay is over :p [21:33:10] exactly what i was thinking :) [21:33:12] unicorns may have been disappeared. [21:33:36] for now, happy to leave the cards hanging around for a later fixing [21:33:45] 3/18? Yeah, that was when the wr1 got repaired. [21:34:18] I just re-ran the past. [21:34:18] really? Cos the landmark I found was just when source m/d was added [21:34:25] what... was fixed? [21:34:40] I don't see any patches in globalcollect_audit which would explain this [21:34:53] Okay, let me back up. What are you looking at? [21:34:55] was it the "." in order_id? I though that was a brief window [21:35:05] GC refunds were not coming in for several months. [21:35:06] That was a cutover. [21:35:22] meaning, no downtime? k. [21:35:23] And, the patch wasn't in the gc module itself. [21:35:34] ah, mark_refund? [21:35:44] erm... /me flounders on dry land a bit more [21:35:46] It was out in some "do I already exist" queries that got "optimized" in December. [21:35:59] aja [21:36:04] ok thanks [21:36:23] wmf_common somewhere. [21:41:07] (PS1) Katie Horn: Ditching the $opt parameter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122573 [21:42:20] mwalker: try this? ^ [21:42:40] (PS3) Mwalker: Worldpay form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122559 [21:43:14] (CR) Mwalker: [C: 2] Ditching the $opt parameter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122573 (owner: Katie Horn) [21:43:22] (PS4) Mwalker: Worldpay form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122559 [21:43:48] K4-713, I've got this to the point where you or pizzzacat can do the magic make the errors appear on the form stage: https://gerrit.wikimedia.org/r/#/c/122559/ [21:44:03] I'm next going to add data constraints [21:45:24] sooo coool! SFFDs stretchers can become wheelchairs [22:54:01] http://creditcardjs.com/credit-card-type-detection seems like the sort of thing y'all may want. [22:57:20] marktraceur: thanks for the link! I think we don't worry about type, cos we are skirting this big legal hassle (PCI compliance) by never actually handling CC#s [22:57:35] mwalker / Jeff_Green does any one of you know the fate of tampa pdf servers? [22:57:53] & in the few cases where we do have fields for CC#, we send it along to the payment processor, w/o needing to know its type [22:57:55] should have asked in -pdfhack :/ [22:58:00] Heh, that's nice. :) [22:58:04] matanya, eventually we will get rid of them [22:58:12] but right now; we do not have the replacement service running [22:58:14] so we're stuck [22:58:32] mwalker: tampa is going out in weeks, what is eventually ? [22:58:36] (and I'm somewhat blocked on getting a server with ubuntu 14.04 -- which apparently I now have, but have not had time to play with it) [22:58:50] marktraceur: here's a cool thing along those lines, https://github.com/stripe/jquery.payment [22:59:05] sorry to hear you have been through the FR mill ;) [22:59:07] matanya, good question; I dont know; I'm stuck doing an integration for fundraising that is 100% of my time [22:59:38] Wow [22:59:38] we can shut it down and see who claims :) [22:59:48] matanya, we have probably 2 weeks of work left for the new service; not including any user feedback time [22:59:51] * marktraceur likes jquery.payment. [23:00:05] matanya, aye; and if all else fails; we can push traffic (for book generation) to pediapress [23:00:18] mwalker: you have replacement in eqiad [23:00:47] for mwlib? I was only aware of servers allocated for my new service [23:01:27] https://rt.wikimedia.org/Ticket/Display.html?id=6340 ? [23:03:31] ah; yes; I knew about this [23:03:46] it's the server I need to push to in order to load test the new service [23:03:49] it's not for mwlib [23:04:05] what hosts mwlib? pdf2,3? [23:04:10] ya [23:07:10] so we have a problem thanks for clarify [23:07:47] yes; we do not yet have a replacement for mwlib; and there were no plans made to move the mwlib servers to eqiad [23:08:13] I estimate that it'll take 3 weeks to move my service to production if all 14.04 bugs have been worked out [23:08:21] (that's a week of test time on beta) [23:08:28] (plus 2 weeks of random bug fixes) [23:08:43] it's not that hard to install mwlib; but it is messy and has to be done by hand [23:08:47] both jeff and I know how to do it [23:08:53] (and there are decent isntructions) [23:09:58] (PS5) Mwalker: Worldpay form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122559 [23:10:24] (PS1) Mwalker: Constraint validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122603 [23:10:36] (PS6) Mwalker: Worldpay form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122559 [23:10:39] mwalker: but we don't want to do that, i guess [23:10:41] (PS2) Mwalker: Constraint validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122603 [23:10:51] ok, lets hope you will be there on time [23:11:03] heh; what's the official drop dead date? [23:11:06] for pmtpa [23:13:03] i think april 30 [23:13:05] not sure [23:15:05] whooo [23:15:06] 1 month [23:15:13] we still have a fundraising server to move too [23:15:38] K4-713, ^ [23:15:48] #1474: (AG) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1474 [23:17:12] mwalker: What server are you talking about? [23:17:25] aluminium [23:17:39] I thought that was eqiad, because: Element. [23:17:50] In fact, I'm pretty sure I saw it in DC. [23:17:58] hopefully! [23:18:47] Actually, no: I know it's not pmtpa, because that one day they ran over the links, we were all fine except for how the payments cluster blew up because the mediawiki db failover didn't actually... work. [23:19:37] Also: ganglia. :)