[00:08:52] (PS6) Mwalker: WIP: Add error handling [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122618 [00:14:52] (PS7) Mwalker: WorldPay add error handling [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122618 [01:11:22] (CR) Jforrester: Add the B/C i18n shim (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/122267 (owner: Siebrand) [01:12:01] (PS1) Alex Monk: Fix mistake in Ie6a4a95f causing conflict with CentralAuth [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/123153 [01:12:30] (CR) Jforrester: [C: 2] Fix mistake in Ie6a4a95f causing conflict with CentralAuth [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/123153 (owner: Alex Monk) [01:12:44] (CR) Alex Monk: Add the B/C i18n shim (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/122267 (owner: Siebrand) [01:13:43] (Merged) jenkins-bot: Fix mistake in Ie6a4a95f causing conflict with CentralAuth [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/123153 (owner: Alex Monk) [04:51:47] (CR) Siebrand: Add the B/C i18n shim (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/122267 (owner: Siebrand) [06:07:12] (CR) Siebrand: "Thanks for noticing, Alex!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/123153 (owner: Alex Monk) [09:09:45] (CR) Siebrand: "This fixes bug 63344." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/123153 (owner: Alex Monk) [16:53:18] (Abandoned) Katie Horn: Wrapping some debugging stuff in a debugging global from localsettings. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/24515 (owner: Katie Horn) [17:02:40] mwalker: Okay, I think I've detangled your pending commits. Reviewing those now. [17:02:56] kk; thx! [17:40:07] (PS1) Ssmith: WIP worldpay forms sans validated errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123346 [17:40:22] (CR) jenkins-bot: [V: -1] WIP worldpay forms sans validated errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123346 (owner: Ssmith) [17:47:49] #1151: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [17:57:08] (PS2) Adamw: WIP WorldPay auditing script [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/122619 [18:39:48] #1512: (C) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1512 [18:55:38] (CR) Mwalker: [C: -1] "The biggest problem I see is the use of glyphicon; you'll have to talk to Lisa/Megan/and Legal about it because of the licensing. Accordin" (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123346 (owner: Ssmith) [19:00:27] (CR) Mwalker: "Hmm; looking again; apparently Twitter might have licensed it already under different terms (you still need to check with legal). However;" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123346 (owner: Ssmith) [19:04:48] #1513: (C) O:C|T:TI Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [19:18:29] (CR) Katie Horn: [C: 2 V: 2] Worldpay form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122559 (owner: Mwalker) [19:21:48] #1513: (MW) I can confirm for both of these (via test email... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [19:23:58] (CR) Katie Horn: Constraint validation (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122603 (owner: Mwalker) [19:26:05] (CR) Mwalker: Constraint validation (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122603 (owner: Mwalker) [19:30:37] (CR) Katie Horn: [C: 2 V: 2] Constraint validation (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122603 (owner: Mwalker) [19:33:48] ...ugh. We need unit tests for the orphan slayer. [19:37:24] awight|fud: When you get back, can you explain to me how to use your spiffy new transaction metadata in civi to see how many transactions are being recorded from which processes? [19:37:33] ...preferably via a wiki page. [19:38:28] I want to see if we're still catching orphans on 1004 or not. [20:09:55] K4-713: this is a good start: https://wikitech.wikimedia.org/wiki/Fundraising/Queue_messages [20:11:57] awight: Er, kinda? I know what the messages look like, I just don't know where you stash the data once it gets to civi. [20:15:48] K4-713: select gateway, source_type, source_host, count(*) from wmf_contribution_extra group by gateway,select gateway, source_type, source_host, count(*) from wmf_contribution_extra group by gateway, source_type, source_host; [20:16:34] awight: Marvelous. Thank you. [20:17:05] Does that exist somewhere other than this chat window? [20:17:05] K4-713: I'm looking for the page of queries you sent pizzzacat recently... [20:17:13] heh. Fun SQL on collab? [20:17:14] I'll wikify it, just looking for a good home [20:17:17] ok yes that one [20:21:06] K4-713: that qury I sent was damaaged. one sec [20:21:55] K4-713: https://collab.wikimedia.org/wiki/Fundraising/Engineering/Fun_SQL_Queries#Source_metadata [20:22:06] 2 [20:22:08] woooot. [20:22:14] ccogdill: 2? [20:22:18] That was weird. [20:22:21] :) [20:22:32] haha ugh. my computer typing things into colloquy when I’m trying to wake it up [20:22:45] this happens like once a month with me :( [20:23:11] Very strange. [20:23:28] But, at least it's just a number, and not... your browsing history. [20:49:14] (PS1) Adamw: update Thank You templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/123439 [21:03:48] #1512: (AG) T:TT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1512 [21:07:49] #1512: (C) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1512 [21:07:49] #1512: (AG) TS:B|TT:CT|N:GDDrbBNlb Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1512 [21:07:49] #1512: (AG) T:TI|TT:(s|TS:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1512 [21:14:49] #1514: (AG) H:N|T:S Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1514 [21:27:02] (PS1) Ssmith: delete glyphicons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123446 [21:27:20] (CR) jenkins-bot: [V: -1] delete glyphicons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123446 (owner: Ssmith) [21:40:50] #1515: (AG) T:BG Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1515 [21:40:50] #1515: (AG) N:OS Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1515 [21:40:50] #1011: (AG) BG:#OS -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1011 [21:42:50] #1461: (AG) O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1461 [21:43:50] #1484: (AG) ->Sprint 47 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1484 [21:52:32] (PS1) Mwalker: WorldPay: Donations now complete through Deposit! [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123453 [21:55:19] (CR) Katie Horn: [C: 2 V: 2] "After staring suspiciously at your do_transaction edits for a surprisingly long time, I have concluded that this is way better off than we" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123090 (owner: Mwalker) [22:05:49] #1395: (AG) P:MH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1395 [22:09:42] (CR) Katie Horn: [C: 2 V: 2] WorldPay add error handling (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/122618 (owner: Mwalker) [22:14:57] (CR) Katie Horn: [C: 2 V: 2] WorldPay: Donations now complete through Deposit! [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123453 (owner: Mwalker) [22:15:08] Whew! [22:15:58] (CR) Mwalker: "Also; worldpay.js has some linting errors that are correctable." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123346 (owner: Ssmith) [22:51:41] (PS3) Adamw: preliminary WorldPay auditing script [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/122619 [22:52:21] (PS4) Adamw: preliminary WorldPay auditing script [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/122619 [23:10:16] (PS1) Ssmith: linting issues resolved [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123473 [23:10:19] (CR) jenkins-bot: [V: -1] linting issues resolved [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123473 (owner: Ssmith) [23:19:07] (PS1) Ssmith: fix random file changes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123475 [23:26:12] (PS2) Ssmith: WIP worldpay forms sans validated errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123346 [23:27:01] (PS2) Ssmith: delete glyphicons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123446 [23:35:01] (CR) Mwalker: [C: 2] WIP worldpay forms sans validated errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123346 (owner: Ssmith) [23:35:46] (PS2) Mwalker: fix random file changes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123475 (owner: Ssmith) [23:35:55] (Abandoned) Mwalker: fix random file changes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123475 (owner: Ssmith) [23:36:07] (CR) Mwalker: [C: 2] delete glyphicons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123446 (owner: Ssmith) [23:38:49] #1516: (AG) O:AG|TS:B|P:NtH|TT:CT|IU:N|TA:C|BG:#Maef|BC:#Mioit|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1516 [23:39:12] (PS1) Mwalker: WorldPay: Use the Sale API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123479 [23:40:48] #1490: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [23:41:48] #1151: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [23:48:16] (PS1) Ssmith: Merge "delete glyphicons" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123483 [23:49:00] (PS2) Mwalker: WorldPay: Use the Sale API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123479 [23:49:58] (PS3) Mwalker: WorldPay: Use the Sale API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123479 [23:50:57] pizzzacat, I'm hoping worldpay looks better on your computer than it does on mine... [23:52:38] uh waht [23:52:44] send me a screencap? [23:59:01] (PS5) Adamw: preliminary WorldPay auditing script [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/122619 [23:59:55] pizzzacat: I wanted to talk to you about the future of payments form templates.