[00:00:02] [00:00:48] #1490: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1490 [00:00:48] #1151: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [00:01:48] #1151: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [00:02:26] K4-713: I want to be in on that [00:02:45] si vous plait [00:03:05] Well, actually, I mostly want to find out how I should go about solving a problem I'm currently having, without having to re-solve it later. [00:03:12] oh heh ok [00:03:47] But, as that is going to require something like a grand vision of the future, I... figured we should probably coordinate on that. [00:04:26] But, ah... not so grand a vision that I couldn't theoretically solve my problem in the next couple of days. [00:04:32] TOO GRAND. [00:06:25] ...why do I have an alarm called "Potatoes" on my computer? [00:06:30] QUICK! [00:06:48] Apparently the potatoes are going off. [00:06:52] Hey, if anyone gets bored this week, I have a legit WorldPay patch for review, https://gerrit.wikimedia.org/r/122619 [00:07:05] K4-713: they are not known for requiring urgent action. Until now. I like it. [00:07:22] I don't know what to do! aaaahaha [00:07:41] sit on the couch and sprout? [00:08:12] * K4-713 dies of giggling about potato urgency [00:08:27] I blame ironholds. [00:08:35] (PS1) Mwalker: Adding result codes to log output [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123489 [00:08:40] I should set traps like this for myself more often. [00:08:58] droogs, I can provide excuses for my behavior but first I must leave the office and not come back. [00:09:02] Until tomorrow. [00:09:19] Seems fair. [00:09:21] Actually, anyone have a reason to care if I work Thurs vs Fri? [00:09:23] ...what did you do? [00:09:48] oh. sick I think. And family is sitting in a blacked-out house, I need to rub sticks together and get 20# of ice. [00:09:57] Eeeek [00:09:59] K4-713 sorry I missed your ominous message [00:10:03] No worries. :) [00:10:33] what's up? [00:10:54] So, I have this problem. [00:11:03] (totally unrelated to potatoes) [00:11:17] (reading..) [00:11:20] hehe [00:11:51] Basically, there are several blocks of code that are currently copy/pasted into, like, 80 templates or something. [00:12:30] YES AMAGAAA [00:12:31] These blocks of code which contain raw links (no htmlentities), are spronking up my unit test vision. [00:12:38] (PS1) Mwalker: Making state default but disabled [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123490 [00:12:40] ok [00:12:56] time to talk Bigger Refactor? [00:13:20] Basically making the pages that use those templates, unparseable by DomDocument. [00:13:21] So. [00:13:37] (k4; fyi: i have another stack of review for you :p -- small this time though) [00:13:58] I want to take out the 80++ copies of the things that are making me sad, and replace it with a reference to the same thing in one place. [00:14:11] I'd like to do that, in a way that you can also reuse, pizzzacat. [00:14:17] So. [00:14:26] yeayyy [00:14:42] I'm not feeling protective over whatever if you're wondering. [00:14:58] * pizzzacat hands you a machete [00:15:12] Nah, it's not that. I just want to solve this in a way that's compatible with what you've got in mind. [00:15:24] These are blocks that probably all the forms are going to need. [00:15:44] ah ok. [00:16:03] what will that look like on your end? [00:17:01] Well, I can show you the problem. :) [00:17:11] Just search the codebase for "noscript". [00:17:42] ...that's one of the blocks I'm talking about. [00:19:28] My first impulse was to solve this via a replacement token in RapidHTML. [00:20:05] ah yeah. [00:20:06] But, I'm not sure that's the right answer for, you know... the future. [00:20:13] The Future [00:20:19] * K4-713 puts on sunglasses [00:20:40] * pizzzacat puts on sunglasses too [00:20:52] * pizzzacat takes them off: sunburned around the glasses area [00:21:11] anyway yeah [00:21:46] 8) [00:22:21] do you want to like…..pair on this *ducks* [00:22:26] ? [00:22:34] Ha! Er... maybe? [00:22:38] (PS1) Mwalker: Getting rid of WP API warning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123492 [00:22:48] What the heck: Sure. [00:22:50] or were you thinking about doing it like asap rightnow omg [00:23:25] I need jumping-into-codebase muscles. today was kinda hard. [00:23:34] I was thinking that we might come up with a migration strategy for moving copy/paste hell into something reasonable, and that I could sort of... proof it. [00:23:38] With one form. [00:23:46] dude that would be amazing. [00:23:57] and I need to get this crossbrowsertesting.com thing. [00:24:08] because mwalker mentioned his form looks whack [00:24:28] so I need to be able to do simple checks [00:24:58] Would it be more reusable if I put the html... snippets... in external html files, or somewhere in the php? [00:25:01] oh looks like I have a login/password combo to use yay [00:25:32] how big are the snippets and how many of them? [00:25:43] I've identified two so far. [00:26:12] I think in the php isn't too crazy. [00:26:47] One is the set of noscript nodes, and one is that group of links that's supposed to be unobtrusive, below the payment form. [00:27:03] Containing problemsdonating, ways to give... that kind of thing. [00:27:09] ah yes that. [00:28:30] Okay, how about I start out by putting it in the php, in the form parent class. [00:28:35] So, RapidHTML's mom. [00:29:05] makes sense.. it's on every form (or to be)? [00:29:10] It should be. [00:29:15] k [00:30:07] So, I'll just start with one and play with it until it looks like it's not going to blow up anywhere we don't want to make a mess. [00:31:05] If it doesn't look horrifying, we can start migrating with gusto. [00:31:35] Though I... can't imagine how this would make things worse. [00:31:41] -_- [00:33:29] ha famous last words. no it should be ok [00:35:08] :) [00:40:05] Gads. It's like a ghost town in the Gateway_Form class. [00:40:27] protected function generateTumbleweeds() { [00:40:51] heh [00:41:15] what do you expect to see there? more work and less going to other places? [00:41:56] It's sort of sad, actually. There are a ton of functions that create reusable/optional blocks, and they all say "this function is not used in any RapidHTML forms". [00:42:21] Which basically means "We haven't used this code since October 2011". [00:42:27] :-/ [00:42:38] I think I know what happened. [00:44:25] what happened? [00:46:13] There used to be a big thick line between "Production" and "Engineering". [00:46:35] When that was the case, I think production was being encouraged to write static HTML. [00:48:36] This is one of those places where we're better off with teamwork. [00:49:54] In fact, if you're getting the sense that we're deliberately telling you to stand in the middle of all the places where there used to be big thick lines, that's probably because it's true. [00:54:58] (PS1) Mwalker: Agghhhh; silly status codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123499 [00:55:34] ok. want to work tomorrow? wait I'm in meetings from like 11-4 [00:55:50] (it may not seem like it; but I'm very happy with this integration test suite they gave me) [00:56:05] mwalker: What's it written in? [00:56:19] oh; it's just a bunch of CC numbers that I'm supposed to try and use [00:56:25] Oooooh. [00:56:28] and I'm supposed to be doing the right things with the responses [00:56:37] So, I had a thought. [00:56:50] hokay [00:57:20] About unit testing in a way that would mean we're actually contacting test environments. [00:57:33] We could only do it locally, on dev boxes... [00:58:08] Because we can't actually commit either test card data or creds anywhere, and I don't want anything to be automated that can go out into the world. [00:58:33] So, basically, that... but written in a way that wouldn't faceplant jenkins. [01:03:06] (PS1) Mwalker: Allow circumvention of fraud/authorization for [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123500 [01:03:21] you're going to hate me for ^ [01:07:52] * K4-713 squints [01:08:54] * K4-713 squints harder [01:09:49] Actually, there may be an easier way to do that. [01:09:59] And it's just localsettings. [01:11:11] (CR) Ssmith: [C: 2 V: 2] Allow circumvention of fraud/authorization for [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123500 (owner: Mwalker) [01:11:21] Agh... [01:11:36] Just turn off all the extras! [01:12:00] I need to circumvent something internal to my gateway class too [01:12:03] it's not just the fraud rules [01:12:15] it's the entire AuthorizeForFraud call [01:12:37] ...ah. [01:13:10] harumph. [01:27:35] Good grief, how is it already 6:30? [01:28:02] yeah srsly [01:28:11] ok really leaving. [01:28:16] * pizzzacat disappears into a cloud [01:44:16] mwalker: Just read your email. [01:44:30] they might have been trolling me [01:44:34] but I cant tell for sure [01:45:01] Can I get you something tomorrow? An encouraging cake, perhaps? Or a baseball bat? [01:46:06] heh; nah; I'm good [01:46:19] I'm holding out for the pizza party [01:46:28] Fair enough. [01:48:32] Hey, do you know how we're supposed to add new messages now that we're in json translation land? [01:49:08] uh... nope [01:49:59] Yeah, I didn't get that memo either. [01:50:13] ...alrighty then. [02:00:18] eff it, I'm just getting rid of the noscript redirect for now. [02:00:40] That link doesn't work and I don't have a good alternative until I find out what's going on with the Ways to Give pages. [02:00:54] They'll have to live with a message. [02:04:40] heh [02:04:51] good riddance to it too [03:50:29] (PS1) Katie Horn: Taking care of some HTMLEntities in the cc-vmad form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123515 [04:04:49] (PS1) Katie Horn: Unit tests can assert things about form HTML output [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123517 [09:39:14] (PS1) Siebrand: Add $wgMessagesDirs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123560 [10:55:03] (CR) Pcoombe: [C: 2] update Thank You templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/123439 (owner: Adamw) [12:23:13] (CR) Nikerabbit: [C: 2] Add $wgMessagesDirs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123560 (owner: Siebrand) [12:23:21] (Merged) jenkins-bot: Add $wgMessagesDirs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123560 (owner: Siebrand) [17:00:51] (CR) Katie Horn: [C: -1] "I'm not done with this yet. Please don't merge until at least the next patchset." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123517 (owner: Katie Horn) [17:26:31] (PS1) Mwalker: Finish move to Sale API and set payment_submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123676 [17:29:46] (CR) Mwalker: [C: 2] Taking care of some HTMLEntities in the cc-vmad form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123515 (owner: Katie Horn) [18:28:46] (PS2) Katie Horn: Unit tests can assert things about form HTML output [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123517 [19:38:48] (Abandoned) Mwalker: Making state default but disabled [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123490 (owner: Mwalker) [20:32:36] (PS2) Mwalker: Getting rid of WP API warning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123492 [20:32:53] (PS2) Mwalker: Agghhhh; silly status codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123499 [20:32:59] (PS2) Mwalker: Allow circumvention of fraud/authorization for [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123500 [20:33:01] (PS2) Mwalker: Finish move to Sale API and set payment_submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123676 [20:49:48] #1517: (K) O:K|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1517 [20:50:48] #1517: (K) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1517 [20:59:48] #1518: (K) O:K|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1518 [21:00:51] #1519: (AG) AT:S|O:AG|TS:B|P:MH|TT:CT|IU:N|->Sprint 46|BG:#IT|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1519 [21:00:51] #1520: (K) O:K|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1520 [21:01:48] #1522: (K) O:K|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1522 [21:01:48] #1521: (AG) AT:S -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1521 [21:01:49] #1469: (AG) AT:(s|O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1469 [21:01:49] #1523: (K) O:K|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1523 [21:01:49] #1524: (K) O:K|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1524 [21:35:07] (CR) Mwalker: [C: -1] Unit tests can assert things about form HTML output (8 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123517 (owner: Katie Horn) [21:52:48] #1157: (AG) ->Sprint 46|BG:#SPME(i|P-TS:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1157 [21:52:48] #1147: (AG) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1147 [21:53:49] #1148: (AG) ->Sprint 46|BG:#SPME(i|O:AG|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1148 [21:53:49] #1148: (AG) AT:AG|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1148 [21:55:50] #1149: (AG) BG:#SPME(i|O:AG|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1149 [21:55:50] #1149: (AG) AT:AG|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1149 [21:55:50] #1508: (AG) ->Sprint 46 Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [21:56:49] #1508: (AG) This is redundant to #1149 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [21:56:49] #1508: (AG) P-TS:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1508 [21:57:49] #1155: (AG) K4 has an RT ticket out for this. ->Sprint 46|BG:#SPME(i -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1155 [21:57:49] #1155: (AG) O:AG|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1155 [21:57:49] #1155: (AG) AT:AG|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1155 [21:59:49] #1152: (AG) ->Sprint 46|BG:#SPME(i|P:WNH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1152 [21:59:49] #1152: (AG) P-TS:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1152 [22:00:48] #1152: (AG) Looks like this will be proprietary, so whateve... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1152 [22:01:50] #1370: (AG) ->Sprint 47 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1370 [22:03:13] (PS1) Mwalker: Adding WorldPay Card Types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/123794 [22:07:50] #1438: (AG) O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1438 [22:10:48] #1448: (AG) O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1448 [22:11:48] #1491: (AG) ->Sprint 47 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1491 [22:12:49] #1314: (AG) Adam! Can you please clarify what the problems ... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1314 [22:18:50] #1525: (AG) O:AG|TS:B|P:SH|TT:CT|IU:N|->Sprint 46|BG:#Maef|BC:#Iit|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1525 [22:22:05] (PS1) Mwalker: Make submethod validation actually work! [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123796 [22:29:47] (PS1) Mwalker: Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 [22:55:19] (PS1) Mwalker: Actually throw errors on validation fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123800 [22:55:48] #1526: (AG) O:AG|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1526 [22:55:48] #1526: (AG) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1526 [22:56:30] pizzzacat, in your form validation work; if you can somehow make the server side return look nice; that would be great: https://gerrit.wikimedia.org/r/#/c/123800/ [22:57:00] also; there's this that I have no idea what to do with (maybe K4-713 has some ideas): https://gerrit.wikimedia.org/r/#/c/123797/ [22:57:49] #1527: (AG) AT:S|O:AG|TS:B|P:NtH|TT:CT|IU:N|->Sprint 46|BG:#IT|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1527 [23:01:48] #1528: (AG) O:AG|TS:B|P:MH|TT:CT|IU:N|BG:#IT|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1528 [23:02:48] #1529: (AG) O:AG|TS:B|P:SH|TT:CT|IU:N|BG:#IT|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1529 [23:05:48] #1529: (AG) AT:S -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1529 [23:06:48] #1528: (AG) AT:S -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1528 [23:06:48] #1525: (AG) AT:K -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1525 [23:17:48] #1513: (MW) T:TT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:17:49] #1513: (MW) P:MH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:17:49] #1513: (MW) P:E -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:17:49] #1513: (MW) AT:MW -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:18:48] #1513: (MW) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:20:58] mwalker, sure adding to my list [23:21:19] thanks pizzzacat :) [23:21:30] yep yep [23:41:27] (PS1) Mwalker: FR#1513 Correct template variables and TRY symbol [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/123805 [23:42:13] K4-7131, can you move https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513?tab=All into the backlog (and then into the pending CR column) [23:42:48] #1513: (MW) https://gerrit.wikimedia.org/r/#/c/123805/ -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:43:17] Hmm... atgomez is missing. [23:44:08] Should be done now. [23:44:20] Oh, wait. [23:44:24] Pending. [23:44:26] ...just kidding. [23:44:51] #1513: (K) TS:B -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:44:51] #1513: (K) AT:(s|O:K|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:44:51] #1513: (K) AT:K|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:44:51] #1513: (K) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [23:45:04] thanks K4-7131! [23:45:08] also; I hate gmail [23:45:20] seriously; if you cant open a document; dont open it in the stupid preview pane [23:45:30] and in fact; I'd really rather it never open shit in the preview pane [23:45:49] I figured out the "validation" [23:45:53] wanna see?