[00:08:26] (PS2) Ssmith: linting issues resolved [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123473 [00:33:17] (CR) Mwalker: [C: -1] linting issues resolved (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123473 (owner: Ssmith) [00:34:12] (Abandoned) Mwalker: Merge "delete glyphicons" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123483 (owner: Ssmith) [00:48:48] #1513: (C) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [00:49:47] (PS1) Ssmith: A bunch of little fixes. Validation, mostly. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123813 [16:15:06] (CR) Katie Horn: [C: 2 V: 2] "Well, that's some good news. Yay for one less API Call." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123479 (owner: Mwalker) [17:20:25] atgomez: I could use a bit of help with the triage resolution, when you have time... [17:20:48] awight sure! i'm in a meeting. maybe 10 min? [17:20:51] np [17:21:48] #1289: (AW) T:TT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1289 [17:44:30] awight my computer is being ridiculous. i'll brb and then we can talk triage! [17:44:36] K4-713: mwalker: http://www.cs.uwp.edu/staff/lincke/infosec/notes/ApplicationControls.ppt [17:46:27] awight hokay! [17:47:23] hey pizzzacat could you close PPena's GC spreadsheet from the server? she's got a new version and wants to delete that one [17:48:48] #1466: (AG) N:S4-W -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1466 [17:52:43] atgomez: I don't have it open actually! [17:52:56] hmmm [17:53:03] PPena we both have the spreadsheet closed [17:53:22] atgomez cool will try to delet [17:53:24] thanks [17:54:00] atgomez still not possible [17:54:06] :( [17:54:11] neither of us have it open [17:54:21] atgomez pizzzacat just remmeber to use the JAN_MARCH instead, for all 3 months worth of data, ok? :) [17:54:43] PPena, what is this in reference to? [17:55:00] pizzzacat it's the GC data that we were looking at yesterday [17:55:04] pizzzacat that exl data from GC that I showed you yesterday [17:55:06] are they sending you this month's spreadsheet and you're just wanting to overwrite the old one? [17:55:16] Ive uploaded the files on the server so u , as you asked [17:55:23] right, just wondering what you're referring to re: JAN_MARCH [17:55:32] pizzzacat yea it's the new one including march [17:55:34] but the latest version JAn-feb was wrong, and I've saved a JAn_MARCH new report [17:55:41] ah, gotcha. [17:55:45] ok [17:55:57] I thought maybe I missed something earlier in the conversation since I just got here :) [17:56:14] is the new sheet correct? [17:58:33] PPena, where on the server are you putting things? [17:58:57] your directory on lutetium? [17:59:03] same place I highited on the email yesretday [17:59:24] oh, ok, Google Drive. [17:59:32] pizzzacat nope. Public Server Payment Processing/Current Vendors/Global Collect/Traffic Report [18:00:03] thats were all the GC report with the status code breakdown currently live [18:00:07] ah yeah ok. [18:00:14] cool [18:00:35] thanks, I was thinking about those google docs. I don't have any of these open. are you still having trouble? [18:03:48] #1494: (AG) T:TT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1494 [18:04:48] #1494: (AG) P:WNH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1494 [18:14:49] #1530: (AG) BG:#Maef|T:BC Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1530 [18:16:48] #1453: (AG) BC:#Dcml -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1453 [18:18:48] #1242: (AG) BG:#Maef|BC:#Dcml -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1242 [18:49:38] mwalker: K4-713: hey, can I get in on dequeueing the CR? [18:52:46] awight, by all means probably -- k4 hasn't touched most of it [18:53:05] dissed :p [18:53:56] (PS2) Adamw: Adding result codes to log output [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123489 (owner: Mwalker) [18:54:02] (CR) Adamw: [C: 2] Adding result codes to log output [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123489 (owner: Mwalker) [18:55:53] (PS3) Adamw: Getting rid of WP API warning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123492 (owner: Mwalker) [18:56:06] (CR) Adamw: [C: 2] Getting rid of WP API warning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123492 (owner: Mwalker) [18:57:18] (CR) Adamw: [C: 2] "without knowing anything at: ok." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123499 (owner: Mwalker) [18:58:16] (CR) Adamw: [C: 2] Allow circumvention of fraud/authorization for (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123500 (owner: Mwalker) [18:58:57] (PS3) Adamw: Agghhhh; silly status codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123499 (owner: Mwalker) [18:59:48] (CR) Adamw: [C: 2] Agghhhh; silly status codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123499 (owner: Mwalker) [19:00:04] (PS3) Adamw: Allow circumvention of fraud/authorization for [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123500 (owner: Mwalker) [19:00:10] (CR) Adamw: [C: 2] Allow circumvention of fraud/authorization for [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123500 (owner: Mwalker) [19:00:28] (PS3) Adamw: Finish move to Sale API and set payment_submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123676 (owner: Mwalker) [19:01:17] wow; jenkins is backed the heck up today [19:01:45] oh [19:01:50] zuul isn't submitting the jobs [19:02:22] (CR) Adamw: [C: -1] "Please normalize the card type before jamming into payment_submethod." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123676 (owner: Mwalker) [19:02:49] #1531: (K) O:K|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1531 [19:04:05] (CR) Adamw: [C: 2] Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 (owner: Mwalker) [19:04:52] mwalker: what did you find there? jenkins was murdered in the kitchen, with a butterknife? [19:05:22] (CR) Katie Horn: "New patchset coming momentarily." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123517 (owner: Katie Horn) [19:05:25] dunno; apparently krinkle is investigating [19:06:57] (CR) Adamw: "Actually, can you explain what it means to append an empty error?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 (owner: Mwalker) [19:07:07] (CR) Adamw: [C: -1] Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 (owner: Mwalker) [19:07:59] (PS3) Katie Horn: Unit tests can assert things about form HTML output [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123517 [19:09:30] K4-713: ^^ is this ready for CR? [19:10:05] awight: yes [19:10:55] rad. [19:29:33] (Merged) jenkins-bot: Adding result codes to log output [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123489 (owner: Mwalker) [19:29:42] (Merged) jenkins-bot: Getting rid of WP API warning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123492 (owner: Mwalker) [19:29:46] (Merged) jenkins-bot: Agghhhh; silly status codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123499 (owner: Mwalker) [19:29:53] it's alaiiiiive! [19:29:54] (Merged) jenkins-bot: Allow circumvention of fraud/authorization for [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123500 (owner: Mwalker) [19:34:56] dang [19:36:15] (CR) Adamw: [C: 2] Unit tests can assert things about form HTML output (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123517 (owner: Katie Horn) [19:39:38] (PS1) Ssmith: More specific credit card validation. Not pretty but it works. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123911 [19:41:37] (Merged) jenkins-bot: Unit tests can assert things about form HTML output [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123517 (owner: Katie Horn) [19:46:49] #522: (AG) Do we have a physical card wall? Do we want one... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/522 [21:30:18] (PS2) Adamw: Make submethod validation actually work! [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123796 (owner: Mwalker) [21:30:24] (CR) Adamw: [C: 2] Make submethod validation actually work! [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123796 (owner: Mwalker) [21:31:27] (Merged) jenkins-bot: Make submethod validation actually work! [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123796 (owner: Mwalker) [21:33:11] (CR) Adamw: [C: -1] "This is sort of a WIP: window.alert..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123800 (owner: Mwalker) [21:36:49] (Abandoned) Ssmith: A bunch of little fixes. Validation, mostly. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123813 (owner: Ssmith) [22:06:48] #585: (AG) BC:#Dcml -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/585 [22:07:15] (PS1) Ssmith: cleaned up cc validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019 [22:07:36] awight: ^ that one is better, sorry for the needless review [23:38:22] (PS2) Ssmith: More specific credit card validation. Not pretty but it works. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123911 [23:38:24] (PS2) Ssmith: cleaned up cc validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019