[00:01:41] (CR) Adamw: [C: -1] More specific credit card validation. Not pretty but it works. (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123911 (owner: Ssmith) [00:05:01] atgomez: you know anything about the appeal to get more FR proofreaders? [00:05:15] It seems to be untranslated, which is incredibly embarrassing if true: http://en.wikipedia.org/wiki/?banner=B14_0123_proofreadreq&uselang=ar [00:05:36] awight nope [00:06:07] http://he.wikipedia.org/wiki/?banner=B14_0123_proofreadreq [00:06:26] atgomez: would you mind poking production about that? [00:07:14] so... let me reiterate. there's this banner about proofreading [00:07:18] and that part only comes in english? [00:07:31] hehe yeah. [00:07:58] I first noticed by looking here: http://frdata.wikimedia.org/banner/B14_0123_proofreadreq/ [00:50:48] #1532: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1532 [00:51:48] #1532: (AW) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1532 [00:53:48] #1533: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1533 [00:54:48] #1533: (AW) N:MDtwoP5 Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1533 [00:54:48] #1533: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1533 [00:54:48] #1533: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1533 [00:57:28] (PS1) Adamw: (FR #1533) fix error in unit tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124040 [00:57:48] #1533: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1533 [00:57:48] #1533: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1533 [00:58:14] (CR) Katie Horn: [C: 2 V: 2] "Yay!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124040 (owner: Adamw) [00:59:49] #1533: (AW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1533 [01:00:50] #1533: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1533 [01:16:34] (PS4) Mwalker: Finish move to Sale API and set payment_submethod [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123676 [01:18:29] (CR) Mwalker: "Ya; basically the WorldPay.js currently looks for any errors returned (no return is considered good) -- so by placing this thing with no d" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 (owner: Mwalker) [01:19:12] (CR) Mwalker: "Yep; Pizzzacat is working on something nicer; so depending on who gets there first one of us will have to rebase :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123800 (owner: Mwalker) [01:19:37] mwalker wat [01:19:54] there was an error in my original wp.js [01:20:03] it couldn't detect if there was an error thrown by the server [01:20:08] so I submitted a fix for it [01:20:26] but somewhere in your massive pile of stuff to do (or have done) is a nicer error handling patch [01:20:34] yeah it's in there [01:20:35] in which you might have fixed my original bug; or not [01:20:51] gotcha. [01:40:06] (PS1) Adamw: Clean up minfraud handling in tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124043 [01:49:43] (CR) Adamw: [C: 2] Finish move to Sale API and set payment_submethod (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123676 (owner: Mwalker) [01:51:03] (CR) Adamw: "Is this a recoverable error? Should we be resetting the session or something?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 (owner: Mwalker) [01:51:57] (CR) Mwalker: "It's recoverable if they load the form. K4 informs me that there is a message that we have for this already so I'll put that in." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 (owner: Mwalker)