[14:48:53] jessicarobell: http://lists.wikimedia.org/pipermail/wikiar-l/2014-April/000912.html [14:50:18] Thank you Nemo_bis! [17:06:54] (CR) Mwalker: "Sorry Hoo; thanks for doing this!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/122222 (owner: Hoo man) [17:34:34] (Abandoned) Mwalker: Adding WorldPay Card Types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/123794 (owner: Mwalker) [18:09:52] (PS1) Katie Horn: Sending the STOMP message if there's a chance we've been successful. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124367 [18:10:56] K4|meeting: when u have the time, https://gerrit.wikimedia.org/r/124043 [18:11:54] (PS2) Adamw: Clean up minfraud handling in tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124043 [18:17:20] K4|meeting: hrm. Does that phpunit.xml actually do anything? [18:17:33] it looks stale and possibly like it never worked? [18:17:40] (CR) Hoo man: "> I have a concern with this though; since we know that the first call will sometimes fail when content has just been created; why will th" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/122222 (owner: Hoo man) [18:18:23] awight: Uh, no... idea. [18:18:41] Blow it away and check if the tests pass? :p [18:19:12] (PS1) Adamw: remove unused phpunit.xml [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124371 [18:19:27] * K4-713 twiddles [18:19:53] Huh. Guess so. [18:20:02] (CR) Katie Horn: [C: 2 V: 2] remove unused phpunit.xml [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124371 (owner: Adamw) [18:28:39] awight, lunch? [18:28:54] mwalker: si. [20:17:43] #1534: (AW) O:AW|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1534 [20:17:43] #1534: (AW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1534 [20:17:43] #1534: (AW) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1534 [20:17:43] #1534: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1534 [20:43:13] (PS1) Jliu: Allow ZenDesk ticket search by keyword to csv file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/124461 [20:58:39] (PS2) Mwalker: Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 [20:59:04] (PS3) Mwalker: Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 [21:00:28] (CR) Mwalker: [C: 2] "Fair points; this is generic function so the attempt to read from the slave first makes sense." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/122222 (owner: Hoo man) [21:00:33] (CR) Adamw: [C: -1] "Thank you, this is great! The only blocker is that we need a new permission to access the form. Our Civi admins do not have Drupal admin" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/124461 (owner: Jliu) [21:20:28] (CR) Mwalker: Sending the STOMP message if there's a chance we've been successful. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124367 (owner: Katie Horn) [21:24:28] (PS1) Mwalker: Send STOMP messages after the big metatransaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124464 [21:24:42] (CR) Mwalker: "I submit https://gerrit.wikimedia.org/r/124464 for consideration instead" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124367 (owner: Katie Horn) [21:34:59] K4|errand: interesting edge case: headers are not captured by ob_- functions :( [21:37:15] K4|errand: did you look at my ancient patch to decouple the view and controllers, see for example https://gerrit.wikimedia.org/r/#/c/63932/7/paypal_gateway/paypal.adapter.php,unified -- that would solve this issue. [21:38:50] sigh, maybe another time. [21:39:46] (PS1) Adamw: WIP more tests for WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 [21:39:54] awight, she went to the post office; so she'll be back in a bit [21:39:59] however; I have a question for you! [21:40:04] yessir [21:40:14] what do you want in the Reciept# field (aka Merchant Reference) [21:40:31] ctid? [21:40:32] oh, good question. If we get otderId back, it doesn't really matter. [21:40:39] ^orderid [21:41:10] do you get customerid back anywhere? [21:41:20] (that's currently where I map ctid to) [21:41:42] (CR) Jliu: "Thanks, Adam! Very helpful." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/124461 (owner: Jliu) [21:41:53] originators_transaction_reference [21:42:10] hmm; that's intuitive [21:42:14] receipt_number [21:42:17] those are the field names [21:42:22] docs are no more help than that [21:42:45] according to your call, those map to order_id and transaction_reference [21:42:50] (CR) jenkins-bot: [V: -1] WIP more tests for WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [21:43:07] yepyep; I'm just wondering if there was an obvjously named customer_id field [21:43:17] no [21:43:35] ok; i'll throw the ctid in it then [21:43:36] See https://gerrit.wikimedia.org/r/#/c/122619/5/audit/worldpay/TransactionReconciliationFile.py,unified line 87 [21:43:55] Sure, why not ;) [21:44:35] actually, the mapping seems backwards I realized. But we'll go with their answer and find out if the real data matches. [21:44:39] its a 60 character alpha field; so I could probably fit a haiku in there too [21:45:00] receipt_number is the one that looks like it should map to order_id [21:45:15] would you mind checking your call notes? [21:45:31] that's what I wrote down; reciept# -> transaction ref [21:45:31] tho yeah, it really doesn't matter cos the first batch is going to melt down anyway. [21:45:35] original trxn -> order id [21:45:37] ok [21:45:57] hehe there is no original, but the levenshtein edit distance is smaller than the other way around [21:46:18] trust [21:46:21] *truth [22:08:12] mwalker: https://gerrit.wikimedia.org/r/#/c/116153/ [22:37:33] (Abandoned) Katie Horn: Sending the STOMP message if there's a chance we've been successful. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124367 (owner: Katie Horn) [22:38:56] (CR) Katie Horn: [C: 2] Send STOMP messages after the big metatransaction [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124464 (owner: Mwalker) [22:56:47] (PS1) Adamw: Make it possible to test http headers [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124489 [22:57:47] K4|errand: turns out the headers were already being captured by FauxResponse... see ^^ [22:57:55] Ah, that's nice. [22:59:04] that patch is pretty awful, let me know if you think of a cleaner way to jam header tests into perform_these_checks. [23:00:02] (CR) Katie Horn: [C: 2] "Worksforme." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124489 (owner: Adamw) [23:00:12] ...so there. [23:00:16] :p [23:00:25] wanna do that to the minfraud test patch, too? [23:00:30] Oh, sure. [23:02:08] ... [23:02:17] * awight tops off the sippy bird [23:02:23] What the hell is that, a parrot? https://gerrit.wikimedia.org/r/#/c/124371/ [23:02:42] I... [23:02:48] A WHAT [23:02:48] Some kind of... bird-dolphin from an 80s Sierra game? [23:03:07] Gerrit Code Review's... avatar? [23:03:11] I have only played space quest, starring leisure suit larry [23:03:25] erm hehe WHAT AVATAR [23:03:25] That was Roger Wilco. [23:03:52] srsly, what is that and how do I get my mutant inventory item? [23:03:54] I think it's an extinct animal [23:04:16] Save Early, Save Often! [23:05:20] Did you ever play Monkey Island? Because they did an amazing fake death scene that looked like a Sierra game once. [23:05:50] no... but that one sierra game I had was absolutely amazing. [23:06:00] Space Quest? [23:06:06] yes, III. It was also unreasonably difficult. [23:06:11] oh yes. [23:06:40] I just recently fired up dosbox and played King's Quest IV on my tv at home. [23:06:41] And if i recall could not be loaded onto hard drive, so... i made it to the third floppy [23:07:16] 11-year-old K4 was ecstatic. [23:19:01] (CR) Katie Horn: [C: 2] "Some grumbles, but no blocking issues. Merging." (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124043 (owner: Adamw) [23:20:07] K4-713: mwalker: I found two different lists of valid currencies in worldpay. [23:20:14] ... [23:20:14] Is the short list the real one? [23:20:20] getCurrencies() [23:20:32] Where were the two lists? [23:20:40] This is the longer list, stage_iso_currency_id [23:20:48] Ah, okay. [23:20:51] I guess we just added every code in case stuff? [23:20:53] awight, the list in getCurrencies is the list of currencies we can settle into [23:20:56] So, I think getCurrencies are the ones we have. [23:20:56] K [23:21:03] oh. wait, settle or charge? [23:21:06] And the staging function handles what we could have. [23:21:24] no worries. thanks [23:22:40] Side note: If you think of a way to make that line between supported in the account and supported at all by the third party more clear / harder to screw up... [23:22:43] ish... we can make a transaction in any currency; but we have to tell worldpay what currency we want to exchange into (which is the list in getCurrencies) [23:23:07] huh [23:23:21] mwalker: fwiw, getCurrencies is the list used to validate donation currency_code [23:23:27] Is there a... currency... settle... fallback... map... thingy? [23:23:30] so, we cannot charge in any other currency as it stands [23:48:52] (PS1) Adamw: Bugfix: we would fail if the xml was compact [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124499 [23:54:18] (CR) Mwalker: [C: 2] Bugfix: we would fail if the xml was compact [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124499 (owner: Adamw)