[00:26:44] (PS1) Mwalker: WorldPay Settlement Currencies (or default) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124504 [00:33:45] (CR) Katie Horn: [C: 2] "We need more tests." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124504 (owner: Mwalker) [00:36:22] (PS2) Mwalker: FR#1513 Correct template variables and TRY symbol [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/123805 [01:33:24] mwalker: jfyi, I ran the worldpay form output through a validator and it totally destroyed us. There's really crazy stuff like "
s outside of tables. [01:33:41] I suppose I just nominated myself to clean up this hot mess. [01:35:29] interesting [01:35:33] wonder how that's happening [01:35:40] MW itself validates pretty cleanly [01:37:09] ah nvm about the escaped single-quotes, that was an artifact of my print statement. [01:39:01] (PS2) Adamw: WIP more tests for WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 [01:39:08] (CR) jenkins-bot: [V: -1] WIP more tests for WorldPay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [18:42:25] #1468: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1468 [18:57:57] (CR) Mwalker: [C: 2] Set the GeoIP cookie client-side even if request failed [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/118693 (owner: Ori.livneh) [21:57:24] (PS1) Mwalker: Merge remote-tracking branch 'origin/master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/124755