[00:06:56] <K4-713>	 !log updated payments to 70dce8f4bc7
[00:07:01] <morebots>	 Logged the message, Master
[00:08:09] <awight>	 !log updated crm from e726e4213f1d65cae7276f91379eb1b229b19134 to e3f285984f786ca9a05ded1662aba415b0259856
[00:08:14] <morebots>	 Logged the message, Master
[00:14:03] <grrrit-wm>	 (PS1) Mwalker: We can now read JSON I18n files from the hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/125046
[00:18:44] <grrrit-wm>	 (PS1) Ssmith: fixing gerrit/etc weirdness [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048
[00:19:02] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] fixing gerrit/etc weirdness [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048 (owner: Ssmith)
[00:22:34] <grrrit-wm>	 (PS2) Ssmith: fixing gerrit/etc weirdness [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048
[00:22:38] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] fixing gerrit/etc weirdness [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048 (owner: Ssmith)
[00:24:13] <grrrit-wm>	 (CR) Adamw: [C: 2] "Real fancy!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048 (owner: Ssmith)
[00:24:44] <grrrit-wm>	 (PS3) Adamw: use div layout instead of broken table elements [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048 (owner: Ssmith)
[00:24:46] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] use div layout instead of broken table elements [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048 (owner: Ssmith)
[00:24:52] <grrrit-wm>	 (CR) Adamw: [C: 2] use div layout instead of broken table elements [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048 (owner: Ssmith)
[01:01:14] <grrrit-wm>	 (PS1) Mwalker: Allow anyone to use the WorldPay JS API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125055
[01:02:16] <grrrit-wm>	 (CR) Katie Horn: [C: 2] Allow anyone to use the WorldPay JS API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125055 (owner: Mwalker)
[01:08:39] <K4-713>	 !log updated payments to e1d00b61a703
[01:08:42] <morebots>	 Logged the message, Master
[01:13:22] <grrrit-wm>	 (PS4) Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466
[01:13:29] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw)
[01:14:36] <grrrit-wm>	 (PS1) Adamw: Stop using $wgOut. Non-essential fix. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125057
[02:10:15] <grrrit-wm>	 (PS1) Mwalker: WIP: Move token call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125065
[02:10:28] <grrrit-wm>	 (PS4) Mwalker: Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797
[02:10:34] <grrrit-wm>	 (PS3) Mwalker: Actually throw errors on validation fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123800
[02:10:38] <grrrit-wm>	 (PS2) Mwalker: WIP: Move token call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125065
[02:16:12] <grrrit-wm>	 (PS5) Mwalker: Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797
[02:21:18] <grrrit-wm>	 (PS6) Mwalker: Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797
[02:21:53] <grrrit-wm>	 (PS7) Mwalker: Dont continue if API token validation has failed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797
[02:22:42] <grrrit-wm>	 (Abandoned) Mwalker: Actually throw errors on validation fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123800 (owner: Mwalker)
[02:23:33] <grrrit-wm>	 (PS3) Mwalker: WIP: Move token call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125065
[02:25:47] <grrrit-wm>	 (PS4) Mwalker: WIP: Move token call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125065
[02:29:44] <grrrit-wm>	 (PS5) Mwalker: Do GenerateToken call after form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125065
[02:31:53] <grrrit-wm>	 (PS6) Mwalker: Do GenerateToken call after form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125065
[02:34:40] <grrrit-wm>	 (CR) Mwalker: [C: -1] "I like it; but assign the call results locally so we don't make it 80 million times in one function :p" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125057 (owner: Adamw)
[02:35:21] <grrrit-wm>	 (CR) Mwalker: "I'm guessing this is going to break once https://gerrit.wikimedia.org/r/#/c/125065/ happens?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw)
[07:34:04] <grrrit-wm>	 (CR) Adamw: [C: -2] "Probably, this patch won't be working by the time the token thing is merged :p Anyway, marking -2 for now cos the form rendering output b" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw)
[07:38:20] <grrrit-wm>	 (Abandoned) Adamw: Stop using $wgOut. Non-essential fix. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125057 (owner: Adamw)
[07:40:05] <grrrit-wm>	 (CR) Adamw: "Great!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125065 (owner: Mwalker)
[07:51:50] <grrrit-wm>	 (CR) Adamw: "There are only two blockers here: providing UI error strings in translation, and I had a question about the validation_personal function s" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123911 (owner: Ssmith)
[08:04:28] <grrrit-wm>	 (CR) Adamw: [C: 2] "This is great!" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019 (owner: Ssmith)
[08:06:36] <grrrit-wm>	 (CR) Adamw: "Looks like this patch should be abandoned and its descendants rebased." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123473 (owner: Ssmith)
[15:57:25] <slander>	 #1538: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1538
[16:02:57] <grrrit-wm>	 (CR) Adamw: [C: 2] "Thanks for making the improvement!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/125015 (owner: Peterh)
[16:17:48] <grrrit-wm>	 (CR) Adamw: [C: 2] "Great solution!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/125016 (owner: Peterh)
[17:25:22] <PPena>	 mwalker|away K4-713  hi
[17:25:31] <PPena>	 mwalker|away K4-713  you guys are created at Payment trust
[17:54:15] <grrrit-wm>	 (Abandoned) Ssmith: linting issues resolved [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123473 (owner: Ssmith)
[20:47:35] <grrrit-wm>	 (PS3) Ssmith: More specific credit card validation. Not pretty but it works. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123911
[21:01:37] <grrrit-wm>	 (PS3) Ssmith: cleaned up cc validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019
[21:01:40] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] cleaned up cc validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019 (owner: Ssmith)
[21:03:53] <grrrit-wm>	 (Abandoned) Ssmith: use div layout instead of broken table elements [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125048 (owner: Ssmith)
[21:04:25] <slander>	 #1539: (AG) O:AG|TS:B|P:SH|TT:CD(|IU:N|TA:C|BG:#Maef|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1539
[21:06:32] <grrrit-wm>	 (PS4) Ssmith: cleaned up cc validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019
[21:52:57] <grrrit-wm>	 (CR) Mwalker: [C: -1] More specific credit card validation. Not pretty but it works. (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123911 (owner: Ssmith)
[21:55:26] <slander>	 #1494: (AG) T:Ow|BC:(s|BG:(s|O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1494
[21:56:25] <slander>	 #1499: (AG) T:NFw|BC:(s|BG:(s|O:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1499
[21:56:25] <slander>	 #1499: (AG) P:H -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1499
[21:56:27] <grrrit-wm>	 (CR) Mwalker: "Hmm... I may be confused; it looks like you're showing and hiding error divs; but those divs don't seem to have content in them yet? Where" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019 (owner: Ssmith)
[21:57:25] <slander>	 #1435: (AG) T:NFw|TT:(s|IU:(s|BG:(s|O:(s|E:(s|MtBo:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1435
[21:57:25] <slander>	 #1433: (AG) T:NFw|TT:(s|IU:(s|BG:(s|O:(s|E:(s|MtBo:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1433
[21:57:25] <slander>	 #1422: (AG) T:NFw|TT:(s|IU:(s|BG:(s|O:(s|E:(s|MtBo:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1422
[22:08:59] <grrrit-wm>	 (PS1) Mwalker: Do not fraud check authorize with full amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125338
[22:10:08] <grrrit-wm>	 (PS2) Mwalker: Do not fraud check authorize with full amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125338