[00:13:57] (PS1) Ssmith: Finishing form touches. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125362 [00:14:25] #1524: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1524 [00:15:25] #1518: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1518 [00:15:26] #1520: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1520 [00:15:26] #1517: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1517 [00:15:26] #1522: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1522 [00:15:26] #1523: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1523 [00:15:26] #1531: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1531 [00:18:25] #1485: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1485 [00:18:25] #1538: (AG) TA:C -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1538 [00:19:25] #1538: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1538 [00:19:25] #1538: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1538 [00:21:17] (CR) Adamw: [C: 2] Dont continue if API token validation has failed (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123797 (owner: Mwalker) [00:21:25] #1534: (AG) BG:#Maef|BC:#Iit -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1534 [00:22:35] (CR) Adamw: [C: 2] Do GenerateToken call after form validation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125065 (owner: Mwalker) [00:23:25] #1513: (AG) TA:C -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [00:23:25] #1513: (AG) TT:CD( -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [00:23:25] #1513: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1513 [00:24:25] #1502: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1502 [00:24:42] (CR) Adamw: More specific credit card validation. Not pretty but it works. (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123911 (owner: Ssmith) [00:25:25] #1532: (AG) Adam can you add more color here when you get a... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1532 [00:25:55] (CR) Adamw: [C: 2] cleaned up cc validation (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019 (owner: Ssmith) [00:26:58] (CR) Mwalker: cleaned up cc validation (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019 (owner: Ssmith) [00:28:57] (CR) Adamw: [C: 2] Finishing form touches. (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125362 (owner: Ssmith) [00:33:05] (CR) Mwalker: [C: 2] "The stuff I was complaining about is for future work!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124019 (owner: Ssmith) [00:37:45] (CR) Mwalker: [C: 2] "Complains resolved later in the patch chain." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/123911 (owner: Ssmith) [00:41:26] #1445: (AG) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1445 [00:51:25] #1447: (AG) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1447 [01:40:33] (CR) Katie Horn: [C: 2] Do not fraud check authorize with full amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125338 (owner: Mwalker) [17:52:23] K4|meeting: does this URL remind u of anything? http://wikimediafoundation.org/cgi-bin/paywiki.cgi [17:52:52] awight: The... extreme past? [17:53:05] It's "the extreme past", isn't it? [17:53:08] ok... so it was a thing [17:53:22] Kill it with fire? [17:53:36] Where did you find the link? [17:53:38] extreme if u attempt to send money from there, or if u get mixed up with fly genes. Then it is a pretty rocky ride. [17:53:48] In live recurring payments. [17:53:55] ... [17:54:18] Like, referenced in IPN messages? [17:54:48] ...for subscriptions that started in the long forgotten past? [17:54:54] I'd believe that. [17:55:02] probably, I'm still trying to put th epieces together. [17:55:39] At this point, I want to figure out how we heard about these payments at all. I'm guessing auditing injected them... [17:56:48] U think we can ask for a redirect from that crazy URL? [17:57:35] More importantly, we need to get a dump of all existing subscriptions... either that, or we synthesize them as they come in through auditing. [17:57:43] omg [17:58:21] The dump of all existing subscriptions might be something I have to do manually. [17:58:40] NNOooooo there is plenty to live for, don't do it! [17:58:43] But, last time I did that, I don't think the data was used for anything, and it took... like, a day. [17:58:58] hehe. Is that data still somewhere? [17:59:14] And it was *really important* that I get the data at the time. [17:59:25] lol I know it always is. [17:59:31] Yeah, it's available... [17:59:35] internally. [17:59:41] <_< [17:59:44] great. that's all i need, probably. [17:59:44] >_> [17:59:55] it can be... 2 years old, that's fine. [18:00:03] It's not. [18:00:42] Okay, apparently I can't get to the share anymore. [18:00:45] Can't even see it. [18:00:47] nice [18:00:57] Not really. [18:01:17] why would you still need access to this place where you previously stored all the important infos... [18:01:24] there is a new server now :) [18:01:24] This is how it starts. Then my door card won't work... [18:01:26] #1540: (AW) O:AW|TS:B|P:SH|TT:OA|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1540 [18:01:34] hehe I don't think it will be that subtle [18:15:46] (PS1) Ssmith: Fix form layout and switch position of expiration date and cvv. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125433 [18:17:26] #1541: (AW) O:AW|TS:B|P:NtH|TT:S|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [20:09:25] (CR) Mwalker: [C: 2] Fix form layout and switch position of expiration date and cvv. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125433 (owner: Ssmith) [20:26:14] (PS5) Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 [20:26:21] (CR) jenkins-bot: [V: -1] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [20:28:59] awight, reading the streamline / emis docs... what in the flip does "Merchants are advised to arrange an alternative method for data collection in the event of a line failure." even mean!? [20:29:01] gah [20:29:21] mwalker: sounds like they used to have satellites. [20:41:11] mwalker: quick question. [20:41:35] the tokenization patch from yesterday is run on submit, right? [20:44:02] awight, yepyep [20:45:22] okay. Then there is no explanation for how the GC and WP forms currently render empty during testing. [20:53:28] mwalker: if you have the current code, can u try to pull up a GC payments form? [20:54:00] awight; yep; I can pull it up [20:54:08] and I'm running master right now [20:54:50] mwalker: I get this: (RL) [21:03:35] mwalker: Possibly quick question: How can you tell the difference between the WP responses in the logs? I'm looking for a dummy AuthorizePaymentForFraud response on my local that I can clean for unit tests, but I'm not sure what to look for. [21:03:41] Some antifraud-related node, maybe? [21:04:14] ...CVNMatch looks likely, actually, nvm. [21:26:56] (PS6) Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 [21:27:20] (CR) Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [21:27:44] K4-713: pizzzacat: ^^ if you have a moment. It would be great to get this into the trunk so we can catch regressions... [21:28:19] woot [21:28:33] (CR) jenkins-bot: [V: -1] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [21:28:34] Er, I'm racing the clock a bit already. [21:28:40] ...ooo. [21:29:36] argh. 21:28:32 The node with id 'selected-amount' does not have value '€1.55'. It has value €1.55 [21:33:12] (CR) Ssmith: [C: 1 V: 1] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [21:33:28] (PS7) Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 [21:34:38] mwalker: pls review this when you can ^^ [21:44:25] #1542: (AW) O:AW|TS:B|P:NtH|TT:S|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1542 [21:50:26] (PS1) Katie Horn: Adding a mechanism through which we can clean and log outbound requests. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125516 [21:51:39] mwalker: ^^woot. Passed. [21:51:55] So, once that gets merged, am I deploying? [21:52:21] pizzzacat, awight: Same question. [21:52:37] Anything that needs to get merged before I start rolling that up? [21:52:51] nope I submitted the final form tweaks this morning. all set to go. [21:52:57] :) [21:53:07] (as long as that's merged in, I don't even know) [21:53:27] Ah, we should probably check, then. Heh. [21:53:36] yeah :) [21:53:51] I don't see anything, but sometimes I don't get added for review, I've noticed. [21:54:17] K4-713: did you see my request above? UI tests would be good to prevent regressions. [21:54:30] I've gone spelunking one too many times to keep that patch alive. [21:54:34] Yeah, that's... like, the only thing I see that's today-recent. [21:54:35] Done with that. [21:54:53] I'm reviewing #125516 now. [21:55:19] kk. Trade initiated. [21:55:44] we'll call the deal by its codename, Quid Pro Quo [21:55:46] (Translation: I'm reviewing your UI test thingy) [21:56:10] Oh, can we abbrev. that in the future? [21:56:19] It'll go: "CR?" [21:56:23] "QPQ, then" [21:56:32] "lol" [21:56:47] * awight gives prereviewed shake [21:57:02] MY GOD WHY DO THEY LET US HANDLE THE MONEY [21:57:23] ...boring? [21:57:37] * K4-713 almost falls off chair [21:57:39] so... easy to forget about... [22:00:47] K4-713 I will pay more attention to who is getting added to CR. I think what's happening is I just let the bot assign to subscribers, which apparently you are not [22:01:00] (CR) Adamw: [C: 2] "Nice instrumentation!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125516 (owner: Katie Horn) [22:01:16] pizzzacat: you should secretly add K4-713 to the reviewer-bot config. [22:01:27] K4-713: make own life hell? https://www.mediawiki.org/wiki/Git/Reviewers [22:01:59] K4-713: and, I have a RL question when you have exited the zone. [22:02:26] I found one thing that is mildly bad, but not really a big deal... Hangon. [22:06:44] (CR) Katie Horn: [C: -1] "Just a couple minor things. I'll wait. :)" (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [22:10:17] K4-713: OK thx. I still have a question tho :) [22:10:27] Oh, right. [22:28:26] #1543: (AW) O:AW|TS:B|P:SH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1543 [22:50:52] (PS8) Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 [22:50:54] (CR) jenkins-bot: [V: -1] UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [22:51:56] (PS9) Adamw: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 [22:54:26] #1512: (C) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1512 [23:03:26] #1544: (C) O:C|T:TI Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1544 [23:10:17] (PS1) Mwalker: Make sure we always create UTF-8 XML [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125532 [23:10:25] (CR) jenkins-bot: [V: -1] Make sure we always create UTF-8 XML [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125532 (owner: Mwalker) [23:19:48] K4-713: mwalker: sorry-- either of you know if PayPal's IPN history time filter in in any particular time zone? [23:20:11] * K4-713 resists urge to say PPT [23:20:16] lol [23:20:25] I'm not totally sure. [23:20:28] babylonian? [23:20:31] I *think* it's UTC. [23:20:36] But that makes too much sense. [23:21:41] PDT. [23:22:02] ... [23:22:10] Is that somehow attached to your account? [23:22:17] I don't even want to know. [23:22:46] (PS2) Mwalker: Make sure we always create UTF-8 XML [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125532 [23:24:18] (CR) Ssmith: [C: 2 V: 2] Make sure we always create UTF-8 XML [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/125532 (owner: Mwalker) [23:25:11] (PS10) Mwalker: UI test for WorldPay, calls the GenerateToken API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/124466 (owner: Adamw) [23:25:44] !log synchronized payments to b3211631dada043 [23:25:50] Logged the message, Master [23:26:01] mwalker: ^^ [23:26:43] Looks like I can add the UTF8 thing now. [23:27:06] Then if it hoses something, I can take it back. [23:27:19] Just in case. [23:28:26] kk [23:28:29] pizzzacat, https://payments.wikimedia.org/index.php?title=Special:WorldPayGateway&appeal=JimmyQuote&ffname=worldpay&recurring=&uselang=en&language=en¤cy=USD&country=US&gateway=worldpay&amount=3&payment_method=cc [23:28:35] 1) high five! [23:28:41] 2) what's with the gradient on top? [23:29:22] Aw, I don't have that. [23:30:41] hmm... so actually the problem is not the gradient; but more why the background of the page is white [23:30:46] the gc page is a light blue [23:31:25] #1544: (AG) T:TT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1544 [23:31:25] #1544: (AG) TA:DI -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1544 [23:31:25] #1544: (AG) TT:CD( -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1544 [23:31:25] #1544: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1544 [23:31:25] #1544: (AG) P:E -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1544 [23:31:46] STOMP transaction has no place to go for status failed :( [23:31:51] we still can't submit payments in USD [23:32:15] Also we should clean up that message. [23:32:25] #1544: (AG) TS:B -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1544 [23:32:25] #1544: (AG) We should turn this off ASAP and then investiga... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1544 [23:33:32] so; two additional UI things... the state drop down is not preserving the value (it always presents State); and we might want to consider a 'working' indication after form submission because it can take some time [23:34:04] FINAL STATUS: 'complete:process' [23:34:19] Yes, Both of those things. [23:35:42] !log synchronized payments to af35b7b175bbe23 [23:35:47] Logged the message, Master [23:36:14] ^^ that's the UTF-8 change [23:36:22] yepyep [23:36:28] we apparently dont have much GC activity today [23:36:32] the log is not very exciting [23:36:38] It's... sad, right? [23:37:14] atgomez: Want to see something cool? [23:37:24] sure do! [23:38:38] https://payments.wikimedia.org/index.php?title=Special:WorldPayGateway&appeal=JimmyQuote&ffname=worldpay&recurring=&uselang=fr¤cy=EUR&country=FR&gateway=worldpay&amount=3&payment_method=cc [23:38:42] atgomez: ^^ [23:39:55] (geeze, these orphan rectifier errors are driving me nuts) [23:41:03] inadvertantly; I just rediscovered that credit cards really don't care about the name on the card [23:41:12] They don't. [23:41:18] I wish they did.