[00:20:26] #1148: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1148 [00:20:26] #1148: (AW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1148 [00:20:27] #1148: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1148 [00:20:27] #1149: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1149 [00:21:26] #1498: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [00:21:26] #1498: (AW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [00:21:26] #1498: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1498 [00:58:25] #1395: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1395 [00:58:25] #1394: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1394 [00:59:26] #1390: (AW) ->Sprint 46 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1390 [00:59:26] #1390: (AW) O:AW|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1390 [13:38:14] meganhernandez: mind fixing https://donate.wikimedia.org/w/index.php?title=Special:FundraiserLandingPage&appeal=Appeal-Adrianne&utm_medium=memorial&utm_campaign=memorial_adrianne_wadewitz ? [13:38:29] there's no such thing as "Wikimedia Education Foundation" [13:41:00] or jessicarobell ^ [13:46:17] Hi twkozlowski! I am guessing it should be referring to the "Wiki Education Foundation" not 'Wikimedia". I will have a look at this. Thanks! [13:47:01] jessicarobell: Yes, just as it does two paragraphs above :-) [13:48:02] you are right twkozlowski :) [13:56:24] i think it was just a typo, we'll get that fixed. thanks for taking a look twkozlowski [14:01:45] Sure. [15:22:01] really, using a death to fundraise? :O [17:22:24] (PS1) Katie Horn: Bandaged the RapidHTML dropdown sticky mechanism. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126024 [17:22:59] awight, pizzzacat ^^ that fixes the dropdown issues we've been having, and tests for it. [17:23:29] K4-713: what was the dropdown issue? [17:24:16] K4-713: fwiw, the "value" attribute on select tags is not a thing [17:24:21] afaik [17:24:25] Oh, the value of the select was being assigned, but the option as selected wasn't being set... so the form looked like nothing... yes, exactly. [17:25:07] awight: That line in the tests? I left that in from what I copied from. [17:25:18] I am aware it does nothing. [17:25:25] that's... a bad idea? [17:25:35] So, when we fix this, it'll tell us where the silly tests are. [17:25:38] we don't want to be testing for something that is wrong [17:25:54] The thing is, it's... just nothing. [17:26:04] It neither hurts nor helps the forms. [17:26:09] no, it makes us _require_ a broken thing [17:26:16] when we fix it, the test will fail. [17:26:38] Yes. And then we'll know we were testing the wrong thing in other tests, and fix that too. [17:26:47] This makes sense in my head. If you want to ding me for it, go ahead. [17:27:05] jesus. [17:27:11] I'm not dinging you. [17:27:18] I'm dinging the bad line of code. [17:27:55] (CR) Adamw: [C: 2] "This is great. Withholding "ding" mentioned inline." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126024 (owner: Katie Horn) [17:27:56] I think I left it there to make the point that RapidHTML is silly. [17:28:14] ok it should be commented "we are testing for broken thing" [17:28:52] meanwhile, this morning's PayPal audit has three recurring payments in a row missing their subscription id. [17:29:10] :/ [17:29:22] Can we tell how old the subscriptions are? [17:29:25] maybe the person assigned to cooking the books got distracted and started cooking meth instead. [17:29:38] I'm in their console, unable to find the stupid transactions at all. [17:29:44] Maybe they all quit after heartbleed? [17:30:10] no they probably couldn't log in to cancel cos their password was changed by bot.net [17:31:00] ha [17:32:10] ...have you spot-checked the missing subscription payments for timing? [17:32:34] I would kind of like to know if they're backwards by a few hours, or... missing for months. [17:32:40] eh? [17:32:58] so far, they seem to be one-time payments... [17:33:00] I mean, we know that sometimes the subscription initialization message comes in later than the first payment. [17:33:04] Wait, what? [17:33:20] I thought you said they were recurring. [17:33:24] well... one is. the next one looks very recurringly [17:33:35] lemme... get back to you with some conclusions [17:33:39] So... a one-time payment... is missing a subscription id? [17:33:50] it's being reported as recurring in the audit file [17:34:03] buh [17:34:27] What is making you think it's not? [17:34:44] Paypal's questionable search mechanisms in the console? [18:32:25] #1550: (AG) O:AG|TS:B|P:MH|TT:CT|IU:N|BG:#RGDE|BC:#Icodf|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1550 [19:01:49] pizzzacat: u don't need to review the Petition stuff at this point... [19:04:11] ah, thanks awight! [19:04:42] it was all PHP and mediawiki conventions... [19:05:25] #1541: (AW) N:Swswdaaoms Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [19:29:25] #1541: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [19:32:25] #1541: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [19:32:55] atgomez: thanks btw for adding the source_type documentation! [19:33:08] awight no problem! [19:35:19] K4-713: basic write-up of the subscription thing we were talking about, https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [19:35:25] #1551: (AG) O:AG|TS:B|P:SH|TT:CT|IU:N|BG:#Maef|BC:#Iit|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1551 [19:35:25] #1541: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [19:36:32] awight: Nifty. [19:37:24] #1541: (AG) I got some feedback from Caitlin/Donor Services... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [19:37:28] Something to keep in mind, designing the dummy subscription mechanism? We should make it easy to... either reverse that process or add the new subscription data to the appropriate place when/if we actually get the subscription start notification. [19:37:43] But, that seems easier than my first impulse all of a sudden. [19:38:25] #1541: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [19:38:26] K4-713: ditto! I added two lines about that just now. [19:38:30] I guess the situation I'd like to avoid, is... a 1:1 ratio of dummy subscriptions to subscription payments. [19:38:48] absolutely, I wanna keep the failmail, even. [19:38:52] Aye. [19:39:04] Worksforme. Letsdoit. [19:39:26] k. I'm researching the API call first... [19:39:26] Nospacesseemsmoreefficient. Sometimes. [19:40:10] and screw vwls s wll [19:40:53] on that note, am I forwarding something everyone else received as well? probably. http://www.design.caltech.edu/erik/Misc/Twain_english.html [19:41:02] K4-713 does your eat24 thing have an ETPA? [19:41:16] It said 45 minutes from order time. [19:41:24] * awight gnaws hoof [19:41:32] ... what time was that? [20:44:25] #1552: (AW) T:NFw Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1552 [20:46:25] #1553: (AW) T:NFw Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1553 [21:26:25] #1541: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [21:32:25] #1541: (AW) This wouldn't restart subscriptions. It would ... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [21:33:25] atgomez: ^^ I think you're right, that donors might need some explanatory text when we reconnect these orphaned subscriptions... [21:39:25] #1512: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1512 [21:39:25] #1537: (AG) ->Sprint 47 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1537 [21:42:25] #1395: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1395 [21:44:13] (CR) Adamw: Allow ZenDesk ticket search by keyword to csv file (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/124461 (owner: Jliu) [21:45:05] (CR) Adamw: [C: 2] "Thank you!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/124461 (owner: Jliu) [21:50:25] #1395: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1395 [21:50:25] #1395: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1395 [21:52:55] K4-713: can u take a quick look at "Considerations" in https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1394? [21:53:25] #1394: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1394 [21:54:25] #1541: (C) I think it's best to go with Adam's plan. We ar... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [21:55:34] ccogdill: wrt the reconnected subscription thing, it would be technically possible to include a note, still. [21:57:50] awight: Looking. [21:57:57] thx [21:58:06] ...that's a good idea. [21:58:23] I guess the only place it gets annoying, is... hm. [21:58:27] ... as much as i like overloading poor queue headers [21:58:48] So, we re-queue things, and that constitutes punching the reset button on the TTL, or... [21:58:50] Actually. [21:59:08] awight you mean a note in the TY letter? [21:59:16] We always send a timestamp along in the actual message, right? [21:59:56] ccogdill: yeah I agree that we are just doing people a service, but if they haven't seen our TY letter in... years... it would still be a possibly well-received courtesy. [22:00:00] K4-713: yes [22:00:10] It would be neat if TTL was sort of... an overall time spent bouncing around in the queues. Not just the time spent in that one. [22:00:10] that's the source_enqueued_time [22:00:28] agreed [22:00:33] awight: :) [22:00:43] awight my only concern is that we have back to back months with “oops, we messed up on reccuring” in the TY letter [22:00:53] I’m worried people to whom it doesn’t even apply will get concerned [22:00:58] source_enqueued_time is the one original timestamp; the activemq builtin timestamp is refreshed every re-enqueuement [22:01:03] because our donors are like that... [22:01:14] understandably [22:01:14] ccogdill: that would be really embarrassing, it's true... [22:01:26] ccogdill: not including a note is doable as well :) [22:01:32] let’s see how it goes [22:01:42] if people freak out over the first few days we can add it in, yeah? [22:01:48] hehe excellent [22:01:51] :) [22:01:59] ccogdill: as long as you promise to share the really juicy letters [22:02:02] do you have any idea how many subs we’re talking about? [22:02:03] <_< [22:02:04] >_> [22:02:09] and Ill make a special doc just for you :p [22:02:12] ccogdill: no :(, not yet [22:02:22] mmkay, if you find out let me know! [22:02:47] okay, I'll make a note to do so [22:03:27] cool, thanks [22:05:26] #1390: (AW) N:IQaamwaT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1390 [22:05:26] #1394: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1394 [22:05:26] #1394: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1394 [22:05:26] #1394: (AW) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1394 [22:05:26] #1394: (AW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1394 [22:06:25] #1541: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1541 [22:12:15] !log crm updated from e3f285984f786ca9a05ded1662aba415b0259856 to 7dafce5f8fe265fb0ab6c96e01e59fc4362ea5b4 [22:12:21] Logged the message, Master [23:26:25] #1454: (AW) Note that db tests will not run under Jenkins, ... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1454 [23:33:05] slander: config [23:33:05] Configuration: [{"jobs": "mingle: {'source': 'https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/feeds/WOjFYsRs1T04NhsqTdnSOA.atom', 'class': 'mingle'}", "irc": {"maxlen": 200, "host": "irc.freenode.net", "realname": "FR Mingle notification bot", "nick": "slander", "pass": "p***word", "port": 6667, "channel": "#wikimedia- [23:33:05] fundraising"}, "poll_interval": 60}] [23:33:10] K4-713: ^^ [23:35:02] kk [23:35:15] Nice password. [23:39:04] Haha [23:47:31] awight: http://googleonlinesecurity.blogspot.com/2014/04/google-services-updated-to-address.html [23:53:34] (PS1) Mwalker: Fix wonky WorldPay form loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126173 [23:59:25] #1395: (AW) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1395 [23:59:49] (CR) Katie Horn: [C: 2] "Works. :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126173 (owner: Mwalker)