[00:50:27] #1561: (AW) FCbmBcircwastcrMcpmwtaeatPfMccbvMciCajSBepmGIhcabMAtMbitBmWIaetbMTtMfsiacfBTtBcsbcSMccbvGIhcabMAtMbitBmAthvi:1WIvarpTtMbidTIvarpTtMbihSMcsmwGIhcabFAtFbitTmAtFbcrtmwftarAttari$WIvarpTtFbidTtbcctt"SM... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1561 [00:50:27] #1561: (AW) FCbmBcircwastcrMcpmwtaeatPfMccbvMciCajSBepmGIhcabMAtMbitBmWIaetbMTtMfsiacfBTtBcsbcSMccbvGIhcabMAtMbitBmAthvi:1WIvarpTtMbidTIvarpTtMbihSMcsmwGIhcabFAtFbitTmAtFbcrtmwftarAttari$WIvarpTtFbidTtbcctt"SM... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1561 [00:50:27] #1561: (AW) AT:AW|FCbmBcircwastcrMcpmwtaeatPfMccbvMciCajSBepmGIhcabMAtMbitBmWIaetbMTtMfsiacfBTtBcsbcSMccbvGIhcabMAtMbitBmAthvi:1WIvarpTtMbidTIvarpTtMbihSMcsmwGIhcabFAtFbitTmAtFbcrtmwftarAttari$WIvarpTtFbidTtbc... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1561 [00:50:51] WTF [00:51:23] I was going to say, that was fun. Take a peek at the cukes: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1561 [00:51:25] #1561: (AW) FCbmBcircwastcrMcpmwtaeatPfMccbvMciCajSBepmGIhcabMAtMbitBmWIaetbMTtMfsiacfBTtBcsbcSMccbvGIhcabMAtMbitBmAthvi:1WIvarpTtMbidTIvarpTtMbihSMcsmwGIhcabFAtFbitTmAtFbcrtmwftarAttari$WIvarpTtFbidTtbcctt"SM... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1561 [01:09:34] (PS1) Katie Horn: Breaking out the WP css from the js, to correct some timing issues. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126888 [01:10:43] (CR) Mwalker: [C: 2] Breaking out the WP css from the js, to correct some timing issues. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126888 (owner: Katie Horn) [01:10:49] (Merged) jenkins-bot: Breaking out the WP css from the js, to correct some timing issues. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126888 (owner: Katie Horn) [01:24:33] (PS1) Ssmith: Closed open divs and changed test definitions. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126891 [01:29:03] (PS6) Ssmith: Updates based on feedback from iteration #1. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126178 [01:29:11] (CR) jenkins-bot: [V: -1] Updates based on feedback from iteration #1. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126178 (owner: Ssmith) [01:29:44] (PS4) Ssmith: Forms: French labels shortened, fixed top margin. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126772 [01:29:50] (CR) jenkins-bot: [V: -1] Forms: French labels shortened, fixed top margin. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126772 (owner: Ssmith) [01:29:52] (PS2) Ssmith: Closed open divs and changed test definitions. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126891 [01:50:19] (PS7) Ssmith: Updates based on feedback from iteration #1. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126178 [01:51:50] (Abandoned) Ssmith: Closed open divs and changed test definitions. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126891 (owner: Ssmith) [01:52:15] (Abandoned) Ssmith: Forms: French labels shortened, fixed top margin. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126772 (owner: Ssmith) [04:56:38] (CR) Adamw: [C: 2] "Nice squashing and fixes!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/126178 (owner: Ssmith) [15:11:15] hey folks [15:11:32] hey. we were just talking about whether or not banners need to come down [15:11:37] are you running banners? [15:11:42] as of 10-15' ago? [15:12:05] Jeff_Green: ^ [15:12:14] apparently more like 45 min ago [15:12:37] Yes we started about 45 mins ago, desktop & mobile banners in the US [15:12:45] The uptick started maybe 30 ago, looks like? [15:12:55] stop that [15:13:18] we're in the middle of an outage; I'm not sure if it's the root cause, but it's certainly not helping [15:13:22] but our mobile impression numbers look REALLY low. and i got a server error message about 3 times when I was checking the allocations in central notice [15:13:31] tons of uncached /wiki/Special:HideBanners?duration=1209600&category=fundraising [15:13:37] should i disable the campaigns? [15:13:46] yes [15:14:46] the US desktop & mobile campaigns are down now [15:14:59] thanks [15:16:20] fyi the-wub and jessicarobell i just put in the calendar we took down the campaigns [15:16:44] thanks meganhernandez. :( [15:19:22] ill take down the low level campaigns too the-wub & jessicarobell [15:19:35] are you sure you don't run banners anymore? [15:19:41] I still see tons of requests [15:19:52] ok. [15:20:42] we still get a trail for about an hour after we take banners down [15:20:50] it should slow down a lot more after about the first 15 mins [15:26:59] going to get food, back in a bit [15:29:22] hey paravoid do you know when the server problems started? [15:30:08] approx. at 13:55 [15:30:10] UTC [15:30:30] thanks, have you seen any other issues the last couple days at all? [15:31:38] we're still not out of the woods yet, I'll catch up with you later on the postmortem [15:31:51] kk thanks! will leave you alone for now [15:43:02] I'm here now meganhernandez [16:48:51] meganhernandez: we're clear to reenable banners [16:50:12] thanks Jeff_Green [16:50:35] however, the crosswiki hide banners feature is currently disabled [16:50:48] aww, [16:50:50] okay. [16:51:00] hey jessicarobell & the-wub we're good to enable. are one of you available to put the low level campaigns back up? [16:51:10] I've asked what the plan is there, will let you know as soon as I hear [16:51:28] yeah meganhernandez I can do it. just the low-level? [16:52:18] ok good news. thanks meganhernandez and the-wub [16:52:28] yeah just low level [16:52:47] thanks the-wub [16:52:49] are we putting mlWW back up too? because we disabled it earlier but I think it should be fine [16:53:33] meganhernandez: ^ [16:55:04] ok let's put it back up & check the rates again [16:56:00] cool. enWW and mlWW low-level campaigns are both back up [16:57:31] which countries are these banners for? [16:57:34] english-speaking? [17:24:31] meganhernandez: ? [17:40:51] paravoid: you can see the targeted countries at https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&method=listNoticeDetail¬ice=C14_enWW_frm_FR [17:52:31] (PS1) Ssmith: Fix margin on error page for worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127016 [17:52:39] (CR) jenkins-bot: [V: -1] Fix margin on error page for worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127016 (owner: Ssmith) [17:58:10] are banners enabled now? [18:02:03] (PS1) Mwalker: Remove overriding narrative statement [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127021 [18:02:10] (CR) jenkins-bot: [V: -1] Remove overriding narrative statement [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127021 (owner: Mwalker) [18:02:13] K4-713, ^ if you would please [18:02:43] * K4-713 wonders what an overriding narrative statement is [18:08:51] (PS1) Mwalker: Empty commit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127022 [18:08:56] (CR) jenkins-bot: [V: -1] Empty commit [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127022 (owner: Mwalker) [18:09:07] K4-713, https://gerrit.wikimedia.org/r/#/c/127022/ [18:09:11] rrrrrrrrr. [18:36:31] (PS1) Katie Horn: Testing another english i18n value. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127027 [18:36:50] (CR) jenkins-bot: [V: -1] Testing another english i18n value. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127027 (owner: Katie Horn) [18:37:32] mwalker: ^^ English is broken. [18:37:59] K4-713, but is it just english or all of them? [18:38:06] Happy to find out. [18:38:15] ...one moment. :) [18:42:25] Okay, maybe longer than that. [18:44:41] crickets in mediawiki-i18n [18:47:25] #1346: (MW) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1346 [18:48:25] #1564: (MW) TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1564 [18:48:25] #1564: (MW) AT:MW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1564 [18:48:56] mwalker: Okay, I have confirmed that we have no tests based on non-english output at this time. [18:49:19] ...because wfMessage has some kind of static setting I have to figure out how to wipe at the end of every test, apparently. [18:49:31] hmm? [18:49:36] It's all en, all the time. [18:49:47] ...probably because something inits in en. [18:49:56] it's determined by wgLang; it also will return an object that you can $this->message->inLang() [18:50:22] sorry; in something with a contextprovider (any special page); you can $this->message('id')->inLang() [18:50:42] wfMessage should also be providing an object I think [18:51:08] Who sets wgLang? [18:51:20] something far down in the bootstrap [18:51:23] mhm [18:52:03] ah yes; wfMessage('code')->inLanguage('ru') will work [18:52:58] I'd rather not change our whole... oof. [18:53:00] K4-713, ... "<+Nikerabbit> mwalker: I merged a code recently which no longer loads php shims" [18:53:10] I may have found the smoking gun [18:53:11] But... how would... [18:53:19] hm. [18:53:35] I mean, yes: It seems likely that any change in that area would explain... something. [18:56:53] K4-713, you should join #mediawiki-i18n [18:59:45] (PS1) Nikerabbit: Fix paths to i18n files [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127079 [19:00:36] (CR) Siebrand: [C: 1] "Ugh. Probably my fault. Thanks for fixing, Niklas." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127079 (owner: Nikerabbit) [19:01:00] (CR) Mwalker: [C: 2] "Whoo" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127079 (owner: Nikerabbit) [19:01:08] (PS2) Mwalker: Empty commit rawr Change-Id: I65527c8ac7fd87655e2290f46e10f893835dc648 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127022 [19:01:47] (Abandoned) Mwalker: Empty commit rawr Change-Id: I65527c8ac7fd87655e2290f46e10f893835dc648 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127022 (owner: Mwalker) [19:02:03] (PS2) Mwalker: Remove overriding narrative statement [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127021 [19:06:55] (PS1) Mwalker: Fix paths to i18n files [extensions/DonationInterface] (wmf/1.24wmf1) - https://gerrit.wikimedia.org/r/127123 [19:08:37] (CR) Mwalker: [C: 2] Fix paths to i18n files [extensions/DonationInterface] (wmf/1.24wmf1) - https://gerrit.wikimedia.org/r/127123 (owner: Mwalker) [19:14:46] (PS2) Katie Horn: Testing i18n legal messaging in en and fr. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127027 [21:16:40] (CR) Mwalker: [C: -1] "I'm not entirely convinced that the language subclassing is required..." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127027 (owner: Katie Horn) [21:17:09] (PS2) Mwalker: Fix margin on error page for worldpay. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127016 (owner: Ssmith) [21:30:26] #1565: (AG) O:AW|TS:B|P:NtH|TT:CT|IU:N|TA:D|BG:#Maef|BC:#Mtsotdp|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1565 [21:48:40] (CR) Mwalker: [C: 1] "I cant actually test this on my local because I cannot reproduce. But it looks good." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127016 (owner: Ssmith) [23:12:12] !log updates antifraud rules in payments [23:12:20] Logged the message, Master