[17:51:57] atgomez: if u wanna chat about CiviCRM tasks, any time works for me [17:52:23] yeah sounds good. my day is sort of crazy, but i just threw a meeting on the calendar for after standup [17:52:56] k, accepted. [17:53:11] We don't have to finish the conversation, just a few minutes will be helpful. [17:53:29] yeah for sure! [18:03:25] #1566: (AG) O:AG|TS:B|P:SH|TT:S|IU:N|->Sprint 49|BG:#Maef|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1566 [18:20:30] mwalker: we should merge this: https://gerrit.wikimedia.org/r/#/c/122620/1 [18:21:01] I still haven't investigated why the world has not burned down already... but fixing is obviously a good idea [18:21:12] Hopefully it's just deploy lag saving us [18:21:32] (PS2) Adamw: Fix missing variable declaration [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/122620 [18:22:20] (CR) Mwalker: [C: 2] Fix missing variable declaration [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/122620 (owner: Adamw) [18:28:29] (PS1) Adamw: bump PayPal "classic api" version [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/127672 [20:22:53] pizzzacat: oh, sad. I checked the wmf-labs distribution, and they only provide nodejs-0.6.12 [20:24:06] blerg [20:24:07] what? [20:24:15] labs pulls from apt.wm.o... [20:24:29] and that definitely has node 0.8 [20:24:56] mwalker: aha, thx. standard non-standard packages [20:26:05] confirmed, 0.8.2 [20:42:25] #1151: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [20:42:25] #1151: (AW) Needs limbo queue data created by DonationInter... B:B -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1151 [20:43:03] hey K4-713 [20:43:25] #1468: (S) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1468 [20:43:25] #1561: (S) FCbmBcircwastcrMcpmwtaeatPfMccbvMciCajSBepmGIhcabMAtMbitBmWIaetbMTtMfsiacfBTtBcsbcSMccbvGIhcabMAtMbitBmAthvi:1WIvarpTtMbidTIvarpTtMbihSMcsmwGIhcabFAtFbitTmAtFbcrtmwftarAttari$WIvarpTtFbidTtbcctt"SM... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1561 [20:43:26] #1561: (S) FCbmBcircwastcrMcpmwtaeatPfMccbvMciCajSBepmGIhcabMAtMbitBmWIaetbMTtMfsiacfBTtBcsbcSMccbvGIhcabMAtMbitBmAthvi:1WIvarpTtMbidTIvarpTtMbihSMcsmwGIhcabFAtFbitTmAtFbcrtmwftarAttari$WIvarpTtFbidTtbcctt"SM... -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1561 [20:43:26] #1468: (S) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1468 [20:44:58] hey sumanah. What's up? [20:45:07] Woah, slander went nuts. [20:45:38] K4-713: I hereby ask how your doc stuff is going [20:46:22] slander: disable backronym generation [20:46:32] sumanah: It's... stalled pretty solidly, probably at least for the remainder of the week. [20:47:01] I'm actually out most of this week. [20:47:19] K4-713: OK. Hope you are vacationing! [20:47:55] I remain in readiness to help out by asking naive questions - K4-713 or another person, lemme know if/when it would be handy. [20:51:34] sumanah: Thanks. I'll definitely let you know when we have something to look at. :) [20:52:27] Thanks! [20:52:30] Enjoy your week! [20:53:26] (CR) Mwalker: [C: 2] Upgrade to Drupal 7.27 upstream [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/127411 (owner: Adamw) [20:53:44] (CR) Mwalker: [C: 2] Merge contrib [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/127413 (owner: Adamw) [20:54:36] (CR) Mwalker: [C: 2] "Whooo" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/127414 (owner: Adamw) [21:03:25] #1472: (S) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1472 [21:03:25] #1472: (S) TS:PCR|MtRtDo:(s -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1472 [21:10:12] (PS5) Mwalker: Add a UI for attaching mixins to banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120157 (owner: Adamw) [21:10:29] (CR) Mwalker: "I rebased and moved the messages into the JSON format." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120157 (owner: Adamw) [21:32:09] ! log updated payments: af35b7b175bbe232 --> 2819549ab853ddd44c025 [21:32:30] Where did my robot go? [21:33:00] K4-713: whitespace error [21:33:06] !log updated payments: af35b7b175bbe232 --> 2819549ab853ddd44c025 [21:33:13] Logged the message, Master [21:33:15] unimaginative robot! [21:33:18] ...oh, for the... [21:33:35] ...love of... porcupines. [21:33:43] >:[ [21:34:08] Anyway, WP is updated. [21:34:12] Please beat it up. [21:34:23] awight, pizzzacat, mwalker ^^ [21:34:38] I'm going to pretend I'm not totally broken and tail some logs while you do that. [21:34:51] mwalker: what would you think about eliminating the inst-args property in SmashPig configs? [21:35:22] mwalker: instead, objects would have access to their own configuration node [21:35:47] K4-713: anything in particular we should be prying at? [21:36:19] Er. Anything we think we fixed last week? [21:36:34] You probably know your changes better than I do. [21:36:41] awight, we can talk about it; I 'had' to do it the way I did it to support multiple different configurations of the same object (e.g. for logging) [21:36:47] Pretty much all the Round 1 feedback. [21:38:03] K4-713, what all did you end up cherry picking? [21:38:06] pizzzacat: placeholders are still in quotes [21:38:26] mwalker: Everything that wasn't purely tests. [21:38:26] and italics are getting trimmed on FF 26 [21:39:02] donation form vs jimmy quote is much nicer [21:39:08] mwalker: For a more... reasonable answer: https://git.wikimedia.org/log/mediawiki%2Fextensions%2FDonationInterface/refs%2Fheads%2Fdeploy-payments_1.22 [21:39:08] (than in GlobalCollect) [21:39:42] mwalker: Everything after "WorldPay: Updating supported currencies list" ( 6c78b6a) [21:40:33] We still have the Frankenerror issue, where the donor can receive both an alert and inline errors simultaneously [21:40:52] Is that a problem? [21:41:19] pizzzacat, more annoyingly; in tab order I go to 'postal code' and then 'state' [21:41:30] CC field errors are not parallel: the card number error is a full sentence, the exp date error is just the name of the field, in lowercase, and the CVV error is a noun phrase [21:41:51] mwalker: why is that wrong? [21:42:29] addresses are written City, State, Zip code; not City, Zip code, State? [21:42:42] so I can't tab complete my way through the form in a natural order [21:42:52] Those fields for cc errors are coming from translations [21:43:44] is there a patch that these comments can be attached to, or should I just start a new one? you are right awight, I didn't change the quotes. [21:44:44] Nah, we're just spew-testing [21:45:02] mwalker, in my form the tab advance seems correct [21:45:21] pizzzacat: I made most of these comments on patches already, so sorry to deja-who u [21:46:04] pizzzacat: mwalker was just explaining what he meant: usually the order is city, state, zip [21:46:55] ok, I see what he's saying now. [21:53:20] for the record: the form should alert me on entry that "the session has expired", not after I fill in my info again [21:55:15] I also need to have there be a "in progress" alert and have the submit button grey out after the first click [21:57:23] pizzzacat: word yes. [22:06:13] (PS1) Mwalker: Check fraud results after transaction post process call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 [22:06:21] (CR) jenkins-bot: [V: -1] Check fraud results after transaction post process call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 (owner: Mwalker) [22:07:48] (PS2) Mwalker: Check fraud results after transaction post process call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 [22:07:54] (CR) jenkins-bot: [V: -1] Check fraud results after transaction post process call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 (owner: Mwalker) [22:54:26] #1558: (AG) O:AG|TS:DR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1558 [22:54:26] #1558: (AG) AT:AG|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1558 [22:54:26] #1558: (AG) TS:PCR -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1558 [22:54:26] #1558: (AG) TS:PD -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1558 [22:54:26] #1558: (AG) *Deployed* -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1558 [22:54:26] #1526: (AG) ->Sprint 49 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1526 [23:02:54] (PS3) Mwalker: Check fraud results after transaction post process call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 [23:03:26] mwalker: I was just looking at that. [23:03:35] yeeeeup [23:03:43] Are you faking out the headers now? [23:04:04] no; I'm just testing my assumption that it's minfraud that's killing me [23:04:11] hmmmm. [23:05:16] well... it is... but... it causes other things to fail [23:05:35] https://integration.wikimedia.org/ci/job/mwext-DonationInterface-testextensions-master/342/testReport/junit/(root)/DonationInterface_Adapter_WorldPay_WorldPayTestCase/testAntiFraudHooks/ [23:05:54] (CR) jenkins-bot: [V: -1] Check fraud results after transaction post process call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 (owner: Mwalker) [23:06:46] so how am I supposed to fail someone, and pass someone [23:06:55] I think this is actually simple to fix... hang on a minute. [23:08:26] I mean, it looks like you've got a test that expects somebody to fail, correct? [23:10:09] I... think so [23:10:28] I'm not entirely sure what adam was trying to do with this test [23:10:53] Actually, it's hella creepy that this ever passed with no cvv at all. [23:11:09] ...which... says to me that you totally fixed the issue. [23:13:16] ya; also; my test box is definitely storing and passing the cvv around [23:13:23] so I'm not sure what's happening with that on the server [23:13:32] What do you mean by "storing"? [23:13:49] it calls the store_cvv_in_session() function [23:14:04] okay, so... as expected. [23:14:07] and then it correctly calls the get_cvv_from_session() function during the authorize call [23:14:18] and both of those have the value I entered [23:24:33] mwalker: I can see the issue with the tests. [23:24:42] that's good; because I really really dont [23:24:49] It's... assigning things as expected with the antifraud filters. [23:25:00] yep; but how to fix that? [23:25:07] without breaking the adapter [23:25:15] Let me test something real quick... [23:27:49] do you mind if I just... amend that patch set? [23:27:57] It's contained in the test. [23:28:01] ya; sure [23:29:53] argh... gerrit is being special with me again. Hang on. :/ [23:31:23] (PS4) Katie Horn: Check fraud results after transaction post process call [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 (owner: Mwalker) [23:32:59] I dont understand [23:33:02] but... ok [23:33:21] mwalker: So, in a nutshell, in the most confusing way possible, we have defined all the fraud rules in FraudFiltersTestCase.php [23:33:50] ...you get 42 points just for having an @wikimedia.org email address. [23:33:57] Which, you know: Default. [23:34:25] #1567: (S) AT:S|O:S|TS:DR|P:MH|TT:OA|IU:N|TA:S|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1567 [23:35:34] (CR) Mwalker: [V: 1] "... for fraud" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 (owner: Mwalker) [23:38:25] #1521: (S) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1521 [23:38:41] (CR) Katie Horn: [C: 2] Check fraud results after transaction post process call (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127806 (owner: Mwalker) [23:45:37] (PS1) Katie Horn: Check fraud results after transaction post process call [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/127831 [23:45:42] (CR) jenkins-bot: [V: -1] Check fraud results after transaction post process call [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/127831 (owner: Katie Horn) [23:45:57] lol, jenkins fail on git review for deploy. [23:46:00] Because, of course. [23:46:08] * K4-713 hates everything [23:46:41] ...this is going to happen for everything. [23:47:31] * awight continues snacking on popcorn and observing epic battle [23:47:41] (CR) Katie Horn: [C: 2] "+2 for deploy branch" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/127831 (owner: Katie Horn) [23:47:45] (CR) jenkins-bot: [V: -1] Check fraud results after transaction post process call [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/127831 (owner: Katie Horn) [23:47:53] (CR) Katie Horn: [V: 2] "+2 for deploy branch" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/127831 (owner: Katie Horn) [23:48:13] * awight runs over to Jenkins with a cold washclosh [23:48:15] th [23:48:48] I... don't suppose we can make that non-voting for branches called "deploy_"[something], can we? [23:48:55] yes. I'll work on that [23:49:18] Woo. [23:50:25] #1526: (S) N:WDSfPW Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1526 [23:51:01] (PS1) Adamw: Disable unit tests in deploy branch [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/127832 [23:51:23] K4-713: ^^ simple approach seems to work [23:51:24] (CR) Mwalker: [C: 2] Add a UI for attaching mixins to banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120157 (owner: Adamw) [23:51:34] (Merged) jenkins-bot: Add a UI for attaching mixins to banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120157 (owner: Adamw) [23:51:45] awight: That's... sort of surprising. [23:51:58] Surprising and Cool. [23:52:01] it's horrible. [23:52:09] ...that the easy thing worked? [23:52:21] just... that I'm helping the codebases diverge [23:52:33] I'd rather that phpunit was being used to autodiscover tests... [23:52:34] * mwalker cries in a corner [23:52:58] if (!tests_exist()) might bite us in master, though. [23:53:12] * K4-713 deletes all tests, goes home.  [23:53:55] * awight coaxes survivors into giant stadium... [23:57:25] #1528: (S) N:Bmfgtdfd Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1528 [23:59:25] #1568: (S) O:S|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1568