[00:00:45] !log updated payments from 2819549ab853ddd44c02519d4084580cb8572e7b --> 4811f6d3d80d126c8b3c89c11d20cc6416cb58f6 [00:00:51] Logged the message, Master [00:01:07] Round 2. [00:01:22] awight, mwalker, pizzzacat: ^ [00:01:23] K4-713: for us to test WP? [00:01:24] ok [00:01:26] #1470: (S) N:PtfwfPPv Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1470 [00:01:28] :) [00:03:40] hmm.... [00:03:46] Well, that appeared to work from my end. [00:03:58] You get an error page? [00:04:02] ya [00:04:06] killed by fraud [00:04:11] CVV error [00:04:23] 125.1 total. [00:04:40] Thank you, minfraud, for the one-tenth. [00:05:06] I think i'm going to need jeff to help me debug this one [00:05:12] I'm wondering if it's just not making it to memcache [00:05:26] #1569: (S) O:S|TS:B|P:MH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1569 [00:05:28] That seems probable. [00:05:35] or actually; I wonder if we have the map wrong [00:06:11] Yeah, I guess if we were sending the wrong thing, we couldn't see it in the logs because argh. [00:06:18] CVNMatch 1 [00:06:34] Oh, THAT map. [00:06:52] What happens when you send nonsense? [00:08:38] uh; good question; one second [00:09:18] CVNMatch 2 [00:09:18] ...2, apparently. [00:09:21] bam [00:09:39] Did you also send nonsense in other fields? [00:10:20] ya; that was a 4111111111111111 card [00:11:21] K4-713, did pats move the Payment Methods folder? [00:11:25] in the fundraising share? [00:11:58] er. [00:12:00] I have no idea. [00:12:07] She did seem to think they were in the wrong place. [00:12:16] I disagreed. [00:12:18] mwalker i dont think I did [00:12:31] so... where are those documents now? [00:12:34] mwalker you want me to [00:12:43] oh hmmm [00:13:04] payments? [00:13:10] mwalker u talking about the WP reports? [00:13:25] no; the user guides for worldpay [00:13:40] mwalker regardless I didnt move anything :) [00:14:36] Let's see if I can get there at all, today. [00:15:36] Hmm. [00:15:55] Looks like they've moved out of fundraising to "payment processing". [00:16:02] ??? [00:16:07] The other share. [00:16:58] K4-713 i keep some suff there, but I put it myelf [00:17:13] totally dont remember removing from fundraisng and bringing to Payment Processing! [00:17:26] but if i did-sorry :) [00:17:27] (PS1) Ssmith: Remove placeholder quotes and de-italicize labels [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127838 [00:17:37] mwalker what do you need? I can get it back to fundraising [00:17:44] ppena; it's fine [00:17:45] or… u also have acccess to Paym Processng [00:17:49] I just needed to mount the right share [00:18:02] mwalker let me know if you need me to do anything [00:18:05] ok; K4-713 wherever you have the CVN map stuff defined; it's incorrect [00:18:06] K4-713: before you all get too far on the witchhunt, pls look at Fundraising/Tech [00:18:09] a '1' is a 'Match' [00:18:17] Nothing has moved. [00:19:08] mwalker: Ah. [00:19:24] Okay, that's all in... DonationInterface.php, I think... [00:20:04] Hmm. The comments look right. [00:20:14] Maybe we're boolean-flopped. [00:20:18] I hate when that happend. [00:21:11] wt.... no, gc is the way one would expect. [00:21:18] no one calls this function [00:21:30] Nothing would directly. [00:21:57] directly or not; I just recursively grepped through all of donationinterface; the only places "getCVVResult" is used is in the adapters [00:22:02] You have to enable the filter function in an array that gets walked. [00:22:27] (CR) Adamw: [C: 2] Remove placeholder quotes and de-italicize labels (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127838 (owner: Ssmith) [00:22:34] If it wasn't getting called, it wouldn't be represented in the fraud log. [00:23:28] CustomFiltersFunctions global... [00:23:46] you're killing me k4; absolutely killing me [00:24:44] I get that a lot. [00:24:46] (lately) [00:25:20] ...oho [00:25:36] this comes in as a string; and we;re assuming it's an int [00:25:41] I hate php too [00:25:59] I was thinking it might be some kind of trueish bullcrap. [00:26:21] mwalker: so, I want to look at the EmptyQueueToDump job... it's on the new jenkins? [00:26:32] cos I cannot log in there, I get an infinite login loop. [00:26:50] awight, that's correct; I don't know why you're getting the loop though [00:27:31] mwalker: when u get the chance pls see if you can log in. [00:28:23] Er. Funny story. I'm not seeing where we actually pull cvv_result from the xml response. [00:28:39] it's on line 864 [00:29:02] Oh, right, with the closure-thingys. [00:31:56] awight; I can log in [00:32:21] OK [00:32:23] wow [00:32:50] you have all the same permissions as I do [00:33:08] no explanation then. [00:33:17] want to change your password? [00:33:23] that's the only other thing I've got [00:33:58] nope [00:34:15] I see two calls to http://updates.jenkins-ci.org/update-center.json.html?id=default&version=1.424.6 [00:34:23] then a 403 forbidden [00:34:31] on http://localhost:8005/updateCenter/byId/default/postBack [00:34:51] maybe it is remembering the last page I visited? [00:36:13] I've no idea [00:36:18] yep. I emailed JG [00:38:04] awight, in the meantime do you want to come over and see how these jobs are configured? [00:39:35] K4-713, addData doesn't add it to the unstaged array so getData_Unstaged_Escaped() wont work [00:39:38] *doh* [00:39:52] oho [00:39:57] That would do it. [00:40:27] mwalker: I'm not too worried, but an email wd be nice [00:40:32] Wait, but... [00:40:33] thanks for doing that! [00:40:42] it doesn't... [00:40:54] /me burbles lightly [00:41:03] okay, weird. [00:42:14] No, that's handled in... refreshGatewayValueFromSource(). [00:46:06] mwalker: I'm writing a test for this. [00:46:54] It does seem to exist in the unstaged array. [00:47:00] K4-713, refreshGatewayValueFromSource only will update the unstaged data if there was already a value in it [00:47:34] Yeah, but the first thing you do in addData is put one in there. [00:48:38] (PS1) Adamw: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/127844 [00:48:51] (CR) Adamw: [C: 2] Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/127844 (owner: Adamw) [00:50:04] (CR) Adamw: "well OOPS" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/127844 (owner: Adamw) [00:57:13] K4-713 http://geekologie.com/2014/04/i-said-bake-me-cookies-droid-r2-d2-measu.php [01:00:54] (PS1) Adamw: put .gitreview on the correct branch [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/127846 [01:01:32] (PS1) Adamw: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/127847 [01:01:51] (CR) Adamw: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/127847 (owner: Adamw) [01:02:07] mwalker: pls CR https://gerrit.wikimedia.org/r/127846 [01:03:01] (CR) Mwalker: [C: 2] put .gitreview on the correct branch [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/127846 (owner: Adamw) [01:03:03] (CR) jenkins-bot: [V: -1] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/127847 (owner: Adamw) [01:03:33] (PS1) Mwalker: Expunge CVV from the data object after use [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127848 [01:04:13] (PS1) Katie Horn: WorldPay: Fixing a badly wounded antifraud check. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127849 [01:04:32] atgomez: *squee!* [01:05:26] (CR) Mwalker: [C: 2] WorldPay: Fixing a badly wounded antifraud check. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127849 (owner: Katie Horn) [01:05:32] (Merged) jenkins-bot: WorldPay: Fixing a badly wounded antifraud check. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127849 (owner: Katie Horn) [01:06:50] mwalker: Am I doing another deploy now? [01:07:16] Actually, let me rephrase. [01:07:28] What I meant to say is "I'm going home". [01:07:33] +2 [01:07:41] no taking it back. [01:08:03] I knew this was going to be a bad monday [01:08:06] at like 8 this morning [01:08:36] (CR) Adamw: "Jenkins-bot, where are u?" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/127847 (owner: Adamw) [01:08:42] (CR) Adamw: [V: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/127847 (owner: Adamw) [01:10:01] (CR) Katie Horn: [C: 2] Expunge CVV from the data object after use [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127848 (owner: Mwalker) [01:11:08] !log update from 7dafce5f8fe265fb0ab6c96e01e59fc4362ea5b4 to cfe34fe0b10861167199a8f72bba279b9cac5e6e [01:11:17] Logged the message, Master [01:16:44] !log nevermind previous update. [01:16:53] Logged the message, Master [01:26:56] (PS2) Adamw: WIP (FR #1392) check queues for expired messages and remove them according to disposition [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/126874 [01:28:53] (PS1) Ssmith: Reorder city, state, zip. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127856 [01:44:13] (PS1) Ssmith: Add more credit card imgs to form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127857 [17:21:54] !log update crm from 7dafce5 to cfe34fe [17:22:01] Logged the message, Master [17:45:17] (CR) Mwalker: [C: 2] Reorder city, state, zip. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127856 (owner: Ssmith) [17:46:37] (CR) Mwalker: [C: 2] Add more credit card imgs to form. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/127857 (owner: Ssmith) [17:49:25] #1570: (AW) O:AW|TS:B|P:E|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [17:49:25] #1570: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [17:49:27] ccogdill: here is the card ^^ [17:50:04] awesome, thanks! [17:50:18] ccogdill: thanks for catching this! [17:50:25] #1570: (AW) bwsotqwtrf:n Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [17:51:37] (PS1) Mwalker: Do not allow state to be selected [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/128953 [17:51:54] (CR) jenkins-bot: [V: -1] Do not allow state to be selected [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/128953 (owner: Mwalker) [17:56:59] (PS2) Mwalker: Do not allow state to be selected [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/128953 [17:57:14] (CR) Ssmith: [C: 2 V: 2] Do not allow state to be selected [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/128953 (owner: Mwalker) [17:58:32] pizzzacat, ^ although I appreciate your quick merging; this patch actually causes the unit tests to fail... [18:01:37] hey pizzzacat did you get a chance to look at the GC data? [18:02:40] I'm looking at it now. I'll respond soon! [18:03:27] mwalker, need me to fix this on my end somehow? [18:03:46] pizzzacat, nah; I'll either figure out what's wrong with the tests or revert it [18:03:49] and have any tips on knowing this kinda thing for the future? [18:04:00] don't use Verify +2; let Jenkins do that [18:04:10] oh, should I use +1? [18:04:37] if you're going to use it at all; yes -- but most of us typically just leave it alone [18:05:28] * pizzzacat is confused [18:06:46] oh you're saying "Code-Review" is ok to +2, but "Verified" is not? [18:06:50] *nods* [18:06:54] I've been doing this wrong all along. :( [18:07:07] luckily, verify +2 does not override Jenkins [18:07:10] so I just ignore that section [18:07:14] awight, yes it does... [18:07:22] I don't think it's been merged [18:07:33] pizzzacat, unless.... you're in a repo that doesn't have unit tests [18:07:54] which I need to just know from knowing the code base? [18:08:36] pretty much... alternatively; if you spot a repo without at least linting; you can add it -- I'm just really bad at doing that [18:08:50] so what is the actual job of "Verified"? [18:09:35] and also I seem to remember you or awight saying you don't code review by actually, like, running the code…? [18:09:44] which is seeming ronger and ronger [18:12:25] #1570: (AW) ->Sprint 48|bwsotqwtrf:n -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [18:12:25] #1570: (AW) BG:#Maef|BC:#Iit|bwsotqwtrf:n -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [18:13:25] #1570: (AW) bwsotqwtrf:n -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [18:13:43] pizzzacat, the foundation uses verified as an automated unit test marker [18:13:55] awight and I should be running the code locally [18:14:08] *mostly [18:14:17] (cf. deployment branches) [18:14:21] eh? during code review? [18:14:45] I rarely run unit tests unless debugging... [18:14:58] nah; I trust jenkins to run the unit tests [18:15:22] about half the time I'll run the code through a couple happy paths just to make sure it works the way I think it should [18:15:26] I see [18:16:25] #1570: (AW) TODO: resultswitcher loglines match adapter std... bwsotqwtrf:n -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [18:20:25] #1532: (AW) AT:AW|TS:ID -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1532 [18:35:02] atgomez: how do I get to the open source strategy board? [18:45:17] sent you an invite! [18:49:16] * awight trudges back thru the snow [18:49:52] no! [18:52:11] atgomez: oh dear, sorry I have not been receiving email notifications [18:52:17] I see it in the UI tho! [18:52:24] ok :) [18:52:40] as of 6 min ago :D [18:52:55] fyi pizzzacat mwalker i sent you and k4 an invite as well to a trello board that captures our notes from the open source mtg [18:55:24] thx atgomez [18:57:03] atgomez: does trello let u write an overview paragraph for boards and lanes? [18:59:08] you know.. i don't think it does [19:04:32] awight we could make something kludgy [19:06:48] atgomez: lol such as a thousand characters of smaller font dangling at the end of the title? [19:06:52] (PS1) Ssmith: Disable WorldPay form submit button once clicked. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/128968 [19:06:59] ... maybe [19:07:03] (CR) jenkins-bot: [V: -1] Disable WorldPay form submit button once clicked. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/128968 (owner: Ssmith) [19:07:11] atgomez: or just have the first card by convention be an intro? [19:07:17] actually though, i just added a card to the top of a couple of the lists. it's not ideal, but it's potential [19:07:21] ly useful [19:07:21] wouldn't work for boards tho? [19:07:24] junx. [19:07:26] nope [19:07:27] er jinx [19:07:29] ha [19:12:37] atgomez: cool! [19:21:17] atgomez: maybe we should just have one introductory card, with all metadocumentation. [19:23:40] (PS1) Ssmith: Provide more descriptive cc error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129014 [19:25:43] (CR) jenkins-bot: [V: -1] Provide more descriptive cc error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129014 (owner: Ssmith) [19:33:20] (CR) Siebrand: Provide more descriptive cc error messages (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129014 (owner: Ssmith) [19:35:31] atgomez: aha, I found why the lists were not being formatted: must be preceded with a blank line. [19:36:08] oooh gotcha [19:36:09] thanks! [19:39:25] #1532: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1532 [19:58:02] (PS1) Mwalker: Make fix_dropdowns more intelligent [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129021 [20:07:25] #1571: (AW) O:AW|TS:B|P:NtH|TT:CT|IU:N|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1571 [20:08:25] #1571: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1571 [20:45:15] (PS1) Mwalker: AVS Forcing and Removal of Server Address Check [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129033 [20:45:25] #1532: (AW) N:Rts Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1532 [21:04:02] mwalker: u left CentralNotice mixin for my deployment pleasure, no? [21:04:32] awight; no; I left it for the train [21:04:42] also; I haven't yet looked at the banner diet mixin [21:04:43] ah, good. [21:05:03] yeah I think you're past that anyway. BannerDateDiet seems like the current norm. [21:05:52] sorry; that's the one I meant -- I looked at it briefly but I didn't test it [21:06:14] Cool, thanks. I did test locally. [21:11:39] pizzzacat: wrt my csv test results, do you think it would be convenient or insane if each test were broken out into its own JSON file? [21:13:02] awight, I didn't follow up on this: I need more context about this project [21:13:26] what are we trying to do here? etc [21:13:32] pizzzacat: k, no worries. I'll explain in person [21:14:30] sorry. I couldn't infer from the card :-/ [21:14:41] hehe, good point, I will elaborate there. [21:15:09] * pizzzacat is curious [21:15:44] is it basically that whatever is generated from the script mentioned in the title will be going into a csv? [21:16:56] so I'd need to change a script's output function and just make sure it's being run by Jenkins periodically? and that the data is indeed showing up in some place we deem correct? [21:17:29] or are you saying you'd prefer to explain these questions IRL tomorrow? whichever works for you, I'm happy to help [21:18:25] #1532: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1532 [21:19:11] pizzzacat: this is just another version of ecom. The theory was that reports built using this data would be able to reference live cells, so results will continuously update. Any repetitive tasks can be automated... [21:20:27] I updated the card to reflect the reality, that we are just doing a rescue mission to start with. My goal is to provide a simple and maintainable alternative to ecom and its derivatives. [21:20:41] ah ok. [21:21:31] so theoretically this could even be used as a module inside the dashboard [21:21:39] However we will eventually present these numbers is distant from this work. I was mostly wondering, can I kludge together a simple numeric grid view for prototyping... which I guess answers my question about JSON. [21:21:47] yes [21:22:54] cool! yeah let's talk about what you want to see then. are you in tomorrow? [21:24:44] Looks like Friday [21:26:24] #1532: (AW) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1532 [21:28:47] hey awight is there a card for the DO_NOT_HONOR thing you're talking about? [21:34:25] #1570: (AG) bwsotqwtrf:n -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [21:34:28] atgomez: no [21:59:02] aw|lunch gotcha. just talked to caitlin and she's making the card :) [22:00:18] thx! [22:01:21] awight, you might know the answer to this -- if I wanted to tag a revision of a mediawiki page with some metadata (after the edit so it cant be part of the page), without using functionality only in core, how would I do it? [22:01:31] *using functionality only in core [22:01:53] mwalker: I haven't seen that done yet. [22:02:11] do you know how tagged revs did it? [22:02:19] pizzzacat2 awight mwalker i'm unfortunately going to be in transit during standup - could we either do it early or one of you take notes? [22:02:55] mwalker: there is ChangeTags::addTags [22:03:05] atgomez: sure, I can scribe [22:03:11] awight thank you [22:03:14] np [22:03:53] hah! I was looking at the class without knowing ip [22:03:56] mwalker: looks like you would have to define a tag first however, so it's basically boolean data? [22:04:28] that... could work [22:04:51] mwalker: awight: wanna do IRC standup? [22:05:19] copy + paste [22:05:21] sure [22:05:54] I have this theory that we can do a lightning standup using IRC. everyone just type your notes all at once... [22:06:09] we can even have the last one to finish be declared loser. [22:06:40] +1 +1 +1 [22:07:03] Outcome: Everyone writes like five words of notes. [22:07:16] erm or you could just have them prepared [22:07:21] and whoever is the loser 14 times in a row has to buy a pizza party [22:07:34] -in a row [22:07:35] YES we need commensurate punishments [22:07:37] 14 times [22:07:49] yes there is not enough punishment around here [22:07:58] :) you must be the new kid [22:09:00] https://www.youtube.com/watch?v=sQiNYtkwuyw [22:09:03] last season's winners [22:43:48] (PS1) Adamw: Clean up live-analysis code [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/129056 [23:00:50] (PS2) Adamw: Clean up live-analysis code [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/129056 [23:01:14] (PS1) Adamw: revive dump_tests, using new config and logging api [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/129062 [23:08:25] #1572: (C) O:C|T:TI Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1572 [23:23:25] #1573: (C) O:C|T:TI Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1573 [23:25:59] (PS1) Adamw: move the FrTest module into its own file [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/129071 [23:31:45] (PS2) Adamw: move the FrTest module into its own file [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/129071 [23:32:24] (PS1) Adamw: explicitly ignore some columns when checking spreadsheet schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/129073 [23:33:25] #1570: (C) We have only seen one donor complain about this... bwsotqwtrf:n -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1570 [23:51:54] awight: Haha, I love it [23:58:17] marktraceur: my lack of github fu? [23:58:36] No, the insane abbreviations [23:58:46] It reminds me of omgwtfbbq [23:59:04] oh hah [23:59:13] it's been getting weird around here... [23:59:19] "getting"? [23:59:42] A 100-character or so backronym came in yesterday, still no clue from whence. [23:59:52] No way