[18:30:52] (CR) Adamw: [C: 2] "Oh yay. That improves Adyen as well." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129033 (owner: Mwalker) [18:31:51] #1537: (C) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1537 [19:03:51] #1575: (AG) T:TT -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1575 [19:03:51] #1575: (AG) P:MH -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1575 [19:04:51] #1575: (AG) BG:#Maef -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1575 [19:05:51] #1575: (AG) ->Sprint 49 -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1575 [19:33:50] #1497: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1497 [19:49:51] #1576: (AG) O:AG|TT:CT|TA:C|BG:#Idda|T:TT Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1576 [19:50:52] #1576: (AG) Description changed -- https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1576 [20:35:00] atgomez: fyi, I just recorded standup notes from Tues [20:35:09] thanks! [20:35:12] We tried "blitz" standup, which IMO worked nicely. [20:36:27] It was over IRC, and we all blurted our reports at once. The usual tangents occurred, but nobody was left waiting to give their standup! [21:01:35] !log updating payments from 4811f6d3d80d126c8b3c89c11d20cc6416cb58f6 to e6d188f0dfcd57406acb58aa2b5bf45e48117c33 for donationinterface / worldpay updates [21:01:42] Logged the message, Master [21:06:01] awight, PPena; are we tracking any problems with ideal? [21:06:13] I currently cannot load the ideal form on payments; not sure if this is a new problem or not [21:10:07] hokay... definitely not a new problem [21:36:08] (PS1) Mwalker: Useful log output for the form select code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129580 [21:36:53] (PS1) Mwalker: Empty values to not select the first item [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129581 [21:37:36] awight, ^ if you have time [22:25:24] mwalker: sure [22:26:16] mwalker: can u explain what this regex is supposed to do? [22:26:36] in code; or here? [22:26:36] looks like it grabs a random option.value entry [22:26:41] whatev [22:26:48] but, each option has a value, do? [22:26:49] no [22:26:50] ? [22:27:22] it used to... it's supposed to only process the [22:27:32] ah. what is select.value? [22:27:35] but if the value attribute of the select was empty; it would take the value of the first option [22:27:48] select.value is the value of the entire dropdown (the selected entry) [22:27:53] https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select [22:27:59] there is no such attribute [22:28:04] ah; well then we made it up :p [22:28:12] but we at least use it consistently [22:28:22] hehe well.... [22:28:26] seems like a really bad idea. [22:28:37] ya; I can actually get the value from the data object [22:28:43] ok. [22:28:50] shall I wait, or u wanna push this through anyway? [22:29:26] might as well wait for it [22:29:45] sounds good, thx [22:32:40] (PS2) Mwalker: Empty values to not select the first item [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129581 [22:32:46] hokay; update [22:32:52] also; if you're joining us for standup? [22:34:04] standup: nofing to report, I am off duty today [22:35:26] mwalker: we are assigning the select.id to $value. That's weird and looks wrong. [22:36:22] nah; I'm assuming that the value of select.id is the name of the field that we're assigning to value [22:36:36] which is reasonable because it's what used to happen in https://gerrit.wikimedia.org/r/#/c/129021/1/gateway_forms/RapidHtml.php,unified [22:38:00] mwalker: no, it used to be the option.name [22:38:18] or err, the value of the selected option. [22:45:43] oh; I see what you're getting at [22:45:44] hmm [22:45:50] that's more tricky [22:45:57] I'll have to do a lookup array [22:47:07] well actually; probably not [22:48:18] the only forms that have id="mos" and id="year" are the payflow forms [22:50:19] and I cannot map off of name because I removed that attribute from the WorldPay forms [22:50:26] that whole function is an evil joke... [22:50:40] RapidHtml is an evil joke [22:50:49] IMO the selects should be generated. [22:51:04] if they are not, we should set the selected option using js. [22:51:54] in the future form tpls, we'll be generating for sure. [22:53:14] (CR) Ssmith: [V: 2] Useful log output for the form select code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129580 (owner: Mwalker) [22:53:29] (CR) Ssmith: [C: 2] Useful log output for the form select code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129580 (owner: Mwalker) [22:53:48] awight, agreed; but for now; thoughts on the best path forward? [22:54:01] doing it in JS doesn't really seem like a great option [23:07:58] mwalker: seems like a good option to me, we already require js. [23:08:22] the amount of form JS I'd have to change for that is what makes it unappealing [23:08:34] * awight toothpicks eyes open and forces self to read fix_dropdowns again [23:09:50] I can hash it over with k4 tomorrow too [23:10:28] DomDocument, hehe [23:11:06] awight: DOM Model! [23:11:55] marktraceur: with prejudice ;) [23:12:50] mwalker: to repair this crappy function, yeah we just have to straighten out the stupid regexen. [23:13:18] marktraceur, believe me; I thought about running it through a dom parser [23:13:33] the currently selected value has to come from params, not from the html [23:13:44] oh god. now I see that is what the value= was for :( [23:14:00] mwalker welcome to the spectacle [23:14:02] awight: No no, "DOM Model" like "ATM Machine" and "PIN Number" [23:14:31] ya; the horror deepens [23:15:54] we can continue using the same stupid hack. argh. [23:16:08] marktraceur: yes, I was thinking HIV virus but it seemed less amusing [23:16:17] :(((( [23:16:23] (but good example!) [23:16:26] (but sad.) [23:20:55] Somehow, this is strangely fittingly parallel to currently pulling the bathroom plumbing apart to fix a clog. [23:22:10] mwalker: so, the only problem with the current hack is that we need to use [^>]+ rather than .* after select.id [23:22:34] cos, isn't regex greediness usually back-to-front? [23:23:14] hehe; yep; thats the only problem with the current hack [23:23:51] it's taking the first lazily greedy match [23:23:57] which means that everyone ends up with a default state of AK [23:23:58] can u ask SS her thoughts about using JS to select an option? [23:24:04] aha [23:24:12] that's why u hadn't noticed til now :D [23:24:17] psh [23:24:30] nah; when I tested I apparently had data in my session [23:24:33] or something [23:25:44] mwalker don't turn around [23:25:50] hehe [23:25:55] i can imagine... [23:27:13] mwalker: wait. back to the request data. Did we already elminate that? Seems like that is the least insane thing to do. [23:27:36] So, select_value = $params[$select_id] [23:27:48] atgomez, what was happening behind me? [23:27:57] cameras roughly 12 inches back [23:28:06] oh; so much fun [23:28:08] they're stealthy [23:28:24] I really hope they dont show that b-roll; I had cluster error and exception logs open [23:28:31] I don't think they show anything [23:28:32] but... [23:29:25] we can always ask them not to... [23:29:29] i have the dudes card [23:30:19] awight, what request data? [23:32:14] atgomez, I don't know if awight and I are going to resolve this dropdown issue tongiht; you might as well send out and email and tell people they can go and poke at it again [23:32:29] mwalker what's the issue? [23:32:46] the issue is that the state selection drop down will automatically select AK instead of showing 'State' [23:33:10] oh ok [23:33:20] for the US form? [23:33:38] ya; for the US form (and the CA and GB forms for GlobalCollect) [23:34:02] PPena, so I sent an email to ananth asking how to get the CVV /AVS data in the console; but otherwise it's just another search; so I'm not inclined to think that it's a blocker [23:34:31] "Your transaction could not be accepted. [23:34:32] Please try again, try one of our other ways to give, or contact us at problemsdonating@wikimedia.org [23:34:32] Thank you for your support! [23:34:33] " [23:34:49] mwalker not a blocker, but its something that is useful for donor services, so we should try to get it right :) [23:35:22] mwalker i'm using amex... tried both the US and FR forms [23:35:50] atgomez, and you got rejected? [23:35:56] yeah... [23:37:40] PPena, we're supposed to be able to accept amex here in the US right? [23:37:52] absolutely [23:38:02] most countries actually [23:38:10] depending on currency [23:39:00] atgomez did u JUST try? its not even in the system yet.. [23:39:05] I cant see the reason :) [23:39:16] even though atgomez you have login too, so you can check [23:41:51] mwalker: by request data, I mean the POST data [23:41:59] RapidHtml already has access to that stuff [23:42:21] it would require going through each form and making sure the select id matches the value=@param_name [23:42:39] ppena yes i just tried. we'll get it worked out. [23:42:58] mwalker let's just wait to send out an update until we have something that we feel like we could show to belgium [23:43:13] awight, sure; but we don't always know if the data is in the request; it could be in the session and we couldve come back from an error page [23:43:19] well.. nvm. i'm being ridiculous. we want people to test amex, yeah? [23:43:33] atgomez, well... maybe we should wait until ananth gets back to us [23:43:39] alright. i'll send something tomorrow [23:43:41] mwalker: we would use the existing RapidHtml logic, same stuff that populates the phony value attribute in the first place. [23:43:42] or monday [23:44:54] atgomez, ah... k4 was testing with mastercard [23:44:56] ah crud. there flops the crm schema update I was worried about the other day. [23:45:26] awight, the phony value attribute is added in the template source [23:45:38] so there isn't really any already existing logic [23:45:39] mwalker: yes, and the template is evaluated by rapihhtml [23:45:59] !log perform crm schema update 7018 [23:46:06] Logged the message, Master [23:46:33] awight, um... yes... but the template looks like: element that I know of [23:46:52] right, all I'm suggesting is exactly what you were doing with $this->getEscapedValue [23:47:10] (and thanks for doing that update) [23:47:32] I'm suprised it hasn't blown up before now [23:47:41] geez, lemme read your last patchset to see if it was already what we need. [23:47:53] /facepalm [23:47:56] yes it was. [23:48:04] why didn't you smack me! [23:48:22] (CR) Adamw: [C: 2] Empty values to not select the first item (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129581 (owner: Mwalker) [23:48:31] becuase you had a legit complaint about assuming that id was the name of the field [23:48:42] yes it's something to check [23:48:58] I'll do that since I just wasted your hour... [23:49:19] heh; you can do it later [23:49:23] nothing is going to break immediately [23:49:31] the assumption is sound for worldpay and globalcollect [23:49:52] it's your day off! to fix plumbing apparently; but still! [23:50:03] so... many stupid forms... [23:52:10] mwalker: yep they all check out. [23:52:46] shiney [23:52:49] deploying it [23:53:38] * mwalker grumbles again about git cherry being backwards [23:54:28] (PS1) Adamw: add the latest migration to the new install script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/129616 [23:54:30] (CR) jenkins-bot: [V: -1] add the latest migration to the new install script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/129616 (owner: Adamw) [23:55:02] no idea why jenkins thinks that is not after master [23:55:30] oh! [23:55:53] I forgot that updates were not just picked up automatically [23:55:56] nor why ... QC is melting down [23:56:09] mwalker: oh that patch is just for fresh dev installs, no worries. [23:56:24] shit [23:56:25] but seriously... /me investigates payment instrument [23:56:35] want me to kill jenkins? [23:56:54] mwalker: yes [23:56:56] i see the issue [23:57:35] (PS1) Adamw: give credit card payment instruments correct naming convention [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/129620 [23:58:24] I'm gonna edit those using sql... [23:58:53] (CR) Mwalker: [C: 2 V: 2] add the latest migration to the new install script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/129616 (owner: Adamw) [23:59:30] (CR) Mwalker: [C: 2] give credit card payment instruments correct naming convention [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/129620 (owner: Adamw)