[00:23:23] (PS2) Mwalker: Base WorldPay Order ID on CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130671 [00:23:25] (PS1) Mwalker: Tickling Contribution Tracking [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130986 [00:23:32] (CR) jenkins-bot: [V: -1] Base WorldPay Order ID on CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130671 (owner: Mwalker) [00:23:36] (CR) jenkins-bot: [V: -1] Tickling Contribution Tracking [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130986 (owner: Mwalker) [00:46:03] (CR) Ssmith: [C: 2 V: 2] Use apache style listen syntax [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/130411 (owner: Mwalker) [00:48:23] (PS2) Mwalker: Tickling Contribution Tracking [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130986 [00:48:30] (CR) jenkins-bot: [V: -1] Tickling Contribution Tracking [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130986 (owner: Mwalker) [00:57:17] awight, really dumb question; how've you been getting phpunit to run on donationinterface? [00:57:38] are you using the mediawiki test runner? or JPs test runner? [00:59:17] mwalker: oh. [01:00:24] mwalker: somehow, I think the cd is important: cd mediawiki-core/tests; php phpunit/phpunit.php --group DonationInterface [01:01:07] that makes sense... but it's not actually running any tests [01:01:20] (basically that's how I would run tests for any other extension) [01:01:20] mwalker: and, of course, I can't verify that for u cos I seem to have the PHAR phpunit [01:01:34] your DonationInterface is definitely enabled in LocalSettings? [01:01:38] oh yes [01:02:19] that should do it [01:02:21] shouldn't matter how you installed phpunit; tests/phpunit/phpunit.php is something we wrote that then calls out to phpunit [01:02:28] hah. [01:02:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=58881 [01:03:18] the real kicker is, you can't even download an older phpunit any more. Sebasstian Bergmann only provides phars now. [01:04:24] ya; but I've run tests before; this VM isn't exactly new [01:04:31] * mwalker goes and runs the centralnotice tests to make sure he's not insane [01:06:53] *facepalm* I just realized something... we're going to need a new thank you letter from Lila; and we're going to have to remember to switch the from address on our thank you emails [01:07:12] in any case; centralnotice tests run... [01:07:19] but... that is in a different version of core [01:08:26] aaaaan [01:08:34] for some reason doing nothing differently it works [01:08:43] FTS [01:10:27] Well, if you're feeling good about the world again, http://wiki.civicrm.org/confluence/display/CRMDOC/Internationalisation+for+Developers#InternationalisationforDevelopers-Localisedfieldsschemachanges [01:11:00] I just learned that Civi alters the schema when a field is localized, and I'll leave it to the reader to guess how that is handled during schema upgrades. [01:12:34] uhhhh [01:12:50] why is this a good idea? [01:13:37] there is a plan to do the Drupal thing, to have one row per language, after we figure out how to make lead float [01:21:32] (PS1) Mwalker: asdfasdf [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131000 [01:22:05] (Abandoned) Mwalker: asdfasdf [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131000 (owner: Mwalker) [01:25:40] awight, but but but... maybe I'm not understanding what's going on... this is changing the name of a row in a database according to some random localization [01:25:46] omg [01:25:47] what is that trying to accomplish beyond confusion? [01:25:58] It's known to cause ulcers [01:26:30] somehow, this is the least disturbing thing to happen this week. [01:28:06] o_O [01:28:25] I just caught up in here. [01:33:34] ^^ excellent reaction [02:24:13] (PS3) Mwalker: Tickling Contribution Tracking [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130986 [02:53:29] (PS3) Mwalker: Base WorldPay Order ID on CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130671 [17:52:49] (PS4) Mwalker: Base WorldPay Order ID on CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130671 [17:56:50] (PS1) Mwalker: Actually reset OrderID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131090 [17:58:37] (PS5) Mwalker: Base WorldPay Order ID on CTID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/130671 [18:12:49] atgomez, was there a card for something like "fix contribution tracking for worldpay" or "fix orderids for multiple accounts for worldpay" [18:13:01] because I just did both of those [18:13:53] i definitely didn't make one for multiple accounts [18:13:58] but yay! [18:14:09] hokay; I shall add cards and move them to PCR [18:14:15] thanks! that's super awesome :) [18:14:57] for sprint planning monday - could you make sure that the next set of WP things are in mingle? [18:20:48] I'm totally not creating cards for all the work I've done over the last couple of weeks [18:20:49] noooo [18:20:50] >.> [18:20:51] <.< [18:21:13] because I'm not! [18:21:21] I'm only creating cards for things that are still stuck in code review [18:21:25] because I've forgotten the rest [18:26:44] PPena, have you gotten the merchant admin credentials from dante yet? [18:56:00] meganhernandez: There's no rush for you to actually do something, but did my email about your (lack of) labs account make sense? [19:53:37] mwalker not yet [20:42:58] awight, I looked briefly at omnipay; and given your email I'm wondering if you think our direction should be to integrate the bits of smashpig that omnipay is missing into that? [20:43:13] basically instead of continuing with smashpig start making omnipay work for us? [20:46:00] mwalker: that's a tough call. I think it really depends on the conversation with Omnipay's maintainer. [20:46:29] SmashPig is mostly the awesome infrastructure stuff, which should be make into a component anyway, you think? [20:46:54] It happens to be exactly the stuff that Omnipay is lacking, although I suppose there are some weaker Symfony2 equivalents... [20:47:11] not sure how easy it would be to componentize without going all symfony on it; but we could trye [20:47:41] we could certainly wrap omnipay [20:48:44] I don't think we want to wrap omnipay, cos that doesn't add anything for existing omnipay users, nor does it increase the community size. [20:48:59] Some kind of merge makes sense, but I donno what yet. [20:49:28] Tangentially, what's your reading on WMF's willingness to get all symfony on it? [20:49:51] I see we're moving towards being less stupid about composer :D [20:50:33] basically the reason I didn't just write smashpig as all symfony libraries is because of the code review task; once you start using the big symfony stuff you start having a lot of dependencies [20:50:45] but if there's a big enough gain I don't see it as a huge problem [20:50:46] right [20:51:21] symfony is actually pretty good about not cascading the dependencies, but even single components get unwieldy to review, for sure. [20:51:59] I'm definitely leaning in the other direction, however: if we want to try a merge, we should break smashpig into in-house components. [20:52:16] those can be integrated under omnipay, and will give it the robustness we would need. [20:52:26] ah; I see where you're going [20:52:31] just a thought. [20:52:32] probably could work [20:52:51] cos, SP is currently a mini-framework with a bit of listener code [20:53:11] we would need to do some stuff along the lines of the Log PSR (https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md) [20:53:23] basically start defining well defined standard interfaces that anyone can interface with [20:53:25] hey, we were just talking about that yesterday! [20:53:28] yes, agreed. [20:55:27] sorry, gotta run for now. ciao! [22:07:58] (PS1) Mwalker: Remove calls to configuration global [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/131225 [22:09:23] (PS1) Mwalker: Note the current config view in logging / failmail [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/131226 [22:35:25] mwalker https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1582 [23:56:03] (PS1) Mwalker: Add new NullDataStore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/131240