[00:22:35] (PS1) Shirayuki: i18n: Fix link text [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/131639 [00:33:11] (PS1) Adamw: WIP JP Morgan upload and more generalization [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131642 [01:27:32] (PS1) Mwalker: More Updates to Configuration [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/131648 [01:55:04] (PS1) Ssmith: Add basic test framework [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/131649 [01:56:22] (CR) Ssmith: [C: -2] "This is a draft. But documentation recommends not using *actual* drafts feature. So." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/131649 (owner: Ssmith) [02:01:36] (PS1) Mwalker: 'Fix' the DiskFileDataStore [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/131650 [04:17:01] (PS1) Katie Horn: New Queue Consumer(s) for two new "fredge" queues [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131655 [04:19:02] (CR) Katie Horn: [C: -1] "Ugh. This wasn't supposed to change any submodule pointers...." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131655 (owner: Katie Horn) [04:29:06] (PS2) Katie Horn: New Queue Consumer(s) for two new "fredge" queues [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131655 [06:22:37] (CR) Siebrand: [C: 2] i18n: Fix link text [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/131639 (owner: Shirayuki) [06:22:57] (Merged) jenkins-bot: i18n: Fix link text [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/131639 (owner: Shirayuki) [08:44:39] (PS2) Adamw: JP Morgan upload and more generalization [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131642 [08:46:35] (PS1) Adamw: Move payment instrument lookup to the normalization method [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131668 [08:46:55] (PS3) Adamw: JP Morgan upload and more generalization [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131642 [17:02:42] (CR) Mwalker: [C: 2] Move payment instrument lookup to the normalization method [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131668 (owner: Adamw) [17:28:45] (CR) Mwalker: [C: 2] JP Morgan upload and more generalization (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131642 (owner: Adamw) [17:30:24] (CR) Mwalker: [C: 2] Use better require/jquery [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/131544 (owner: Ssmith) [17:30:31] (CR) Mwalker: [V: 2] Use better require/jquery [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/131544 (owner: Ssmith) [19:18:01] (PS2) Ssmith: Add basic test framework [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/131649 [19:18:34] (CR) Ssmith: [C: 1] "Fixed." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/131649 (owner: Ssmith) [20:19:37] (CR) Mwalker: [C: -1] New Queue Consumer(s) for two new "fredge" queues (14 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131655 (owner: Katie Horn) [20:20:45] pizzzacat1, with your change above; ideally I would like to see jenkins trying to run the tests (even non voting) before I accept it [20:23:26] pizzzacat1: Hey, you want a preview of the schema for the new db tables? [20:31:22] K4-713: yes [20:31:25] :) [20:31:53] mwalker: ah yeah. I guess I need to set up Jenkins/etc [20:33:10] pizzzacat, you'll need the ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config.git and the ssh://gerrit.wikimedia.org:29418/integration/zuul-config.git repos [20:33:51] (CR) Katie Horn: "PS3 on the way. Many comments addressed inline" (8 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131655 (owner: Katie Horn) [20:33:56] look at how the OfflineContentGenerator jobs are done [20:34:46] yeah Adam was showing me yesterday [20:34:56] thanks mwalker :) [20:41:57] mwalker: I simply submit patches to those repos to add my configurations? [20:42:13] (PS1) Katie Horn: Change all noscript blocks to reference the code-generated block. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131864 [20:45:38] pizzzacat: Sorry, got totally distracted. I can show you when I get done with... one patchset. [20:45:50] But it looks like you're popular today, so... [20:45:51] no worries [20:46:57] pizzzacat, yep; push up a patch in both repos; and then ping either marktraceur or krinkle, or hashar if he's still online [20:47:21] Ugh [20:47:28] Haven't I taught you how to do that yet, mwalker? [20:47:39] word [20:47:47] do what, marktraceur? [20:47:57] The JJB/Zuul magic [20:48:18] whaaa [20:48:28] do tell [20:48:31] marktraceur, well; I can do the JJB submission (sometimes; when jenkins behaves itself); but I dont have permissions to do the zuul thing [20:48:38] wut? [20:48:47] pizzzacat: https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder https://www.mediawiki.org/wiki/Continuous_integration/Zuul [20:48:50] I want pizza [20:49:04] * pizzzacat gives pizza to Krinkle [20:49:13] I want cat as well [20:49:27] * marktraceur goes to find mindspillage for Krinkle [20:49:29] * pizzzacat is but one cat [20:49:38] but a pizza will suffice [20:49:41] thx :) [20:49:43] ^_^ [20:50:24] mwalker: So, when you say I should store IP address in the db as an int... [20:50:29] too bad you weren't around a few weeks ago when I distributed mini Japanese gummi pizzas [20:50:44] thanks marktraceur [20:50:46] :) [20:50:48] ...what do I need to do to the standard string so the insert function won't barf on my shoes? [20:50:57] I was in SF for several weeks in Jan/Feb and March/April [20:51:46] ohh actually you might *have* been then. well. [20:51:53] mwalker: ...ip2long()? [20:51:56] It's fine if you don't like me :( [20:52:16] "Converts a string containing an (IPv4) Internet Protocol dotted address into a proper address" [20:52:25] And by "proper address" we mean... [20:52:35] K4-713, http://www.php.net/manual/en/function.inet-pton.php [20:52:39] psh pizzzacat is a friend to all friends of pizza [20:52:47] ip2long() only works for v4 addresses [20:53:41] I like how searching for "ip address" on php.net doesn't return that function. [20:53:53] Hm.. pizzzacat or phuedx ? [20:53:53] searching is hard [20:54:20] Oh, sorry. wrong s smith [20:54:22] K4-713, I'm also not totally sold on the decimal(20,2) thing; there are currencies with more than 2 decimal places [20:54:37] * K4-713 sighs [20:54:40] (like bitcoin) [20:54:45] So... basically I'm making it match civi. [20:54:56] Because... [20:54:59] * K4-713 gives up completely.  [20:55:17] We should have awight upstream that observation. [20:55:44] I'm sure that will meet with no resistance. [21:04:29] mwalker: How about a regular float? [21:04:43] In other news, drupal schemas are my new least favorite thing. [21:07:43] K4-713, I'd be OK with a regular float -- but if civi is using the 20,2 thing; meh [21:08:12] Let me... 4x check that. [21:08:23] I may have had a stroke or something. [21:09:00] it's not unreasonable; but a bit shortsighted [21:09:06] decimal(20,2) across the board, yes. [21:09:10] a bit like them assuming everyone has a first, last, and middle name [21:09:22] Oh, well and they didn't do tha... oops. :p [21:09:56] Yeah, all the amount_whatever fields are decimal(20,2). [21:10:23] But you bring up an interesting cryptocurrency-related point. [21:10:55] Is everybody just converting to... USD or something? [21:11:27] atgomez, https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1609 [21:11:46] thanks! I assume you just made this one? [21:11:53] nice boxes, btw. [21:12:00] K4-713, I have no idea how its done in other things; but internally bitcoins are represented as satoshi's; which are 1/100,000,000 of a bitcoin [21:12:09] and stored in a UINT64 [21:12:15] atgomez, yep; just made it [21:12:46] thanks mwalker for that card :) [21:13:07] mwalker pizzzacat1 what is this related to? fredge? [21:13:27] also, didn't we resolve this issue once? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1608 [21:13:43] atgomez, ya; it's a fredge related thing [21:13:50] atgomez: the dash connecting to the fredge [21:13:54] pizzzacat, ya; I thought we did too [21:14:03] or rather, authentication into the dash [21:14:15] mwalker pizzzacat on 1608 - it's still a thing... i just checked it. Maybe it's back? [21:14:36] a merge-stake? [21:14:45] 1609 - is this something that you plan/want/need to complete soon or is this something that'll come up next sprint? [21:15:11] atgomez, yes we want it now.. [21:15:25] ok! adding to ze sprint [21:15:25] was my understanding (mwalker correct me if I'm wrong) [21:15:57] though I suppose it could wait until next sprint, since we aren't trying to add users to it yet. [21:16:06] up to you I suppose, mwalker [21:16:47] * mwalker glances at k4 [21:16:52] *shrugs* [21:16:55] whahappened? [21:17:06] card 1609 [21:17:09] this sprint; or next [21:17:34] ...what are you doing right now? :p [21:17:45] (this sprint plz) [21:17:59] I'm reading a document dante just sent me on going live [21:18:21] K4-713 i'm trying to test the country prefilling issue, but i don't actually know how to get to the WP form without already being on the right page... [21:18:29] ...wait. [21:18:31] like to get there from a banner/donate. [21:18:34] Is this worldpay, or globalcollect [21:18:49] It seems to be globalcollect. [21:19:09] K4-713 the issue that caitlin, etc. are reporting is on GC. but you asked that it be tested in WP as well... i don't know how to do that [21:19:11] :/ [21:19:17] aha [21:19:22] ah; it works in WP; because that's what I tested my stuff in [21:19:28] so GC is broken [21:19:30] because [21:19:31] i don't even see a country in the WP form [21:19:32] why not [21:19:47] Well, you probably wouldn't, if it's geolocating to the US. [21:19:47] atgomez, you wouldn't; I tested the state dropdown [21:19:59] But. [21:20:04] Wanna see a trick? [21:20:06] yes [21:20:09] Load the US WP form. [21:20:11] always! is that even a question? [21:20:21] mmhmm [21:20:33] this one? https://payments.wikimedia.org/index.php?title=Special:WorldPayGateway&appeal=JimmyQuote&ffname=worldpay&recurring=&uselang=en¤cy=USD&country=US&gateway=worldpay&amount=3&payment_method=cc [21:20:34] In the address bar... change country=US to... [21:20:46] ...iono. Somewhere it should be whitelisted. [21:20:55] yeah that's what i did before [21:21:02] And it's not doing anything? [21:21:17] oh no, it totally did things. [21:21:26] ahh i see. i'm chasing myself in circles. [21:21:28] I get a white screen [21:21:31] * atgomez sulks [21:21:35] wat [21:21:46] How did you get a whitescreen? [21:22:09] easy [21:22:12] I can't make it do that. [21:22:17] change the country to something that it shouldn't allow [21:22:18] like CA [21:22:43] yeah.. white screen for ES [21:22:51] Ah. That actually makes some degree of sense. [21:22:58] i was just thinking that [21:23:12] ...we make no attempt to redirect you across gateways if you enter something crazy. [21:23:36] If WP had a form for ES + everything else you put in there, though, it would land you there. [21:23:51] yeah... so should we consider a redirect to something that does make sense for cases like this? [21:23:53] Hence a card I created hella long ago, that was "Make a form that says we don't have a form." [21:24:06] ahhhh ok [21:24:19] This was fun. We should do this again sometime. [21:24:27] ha.. but back to the GC issue [21:24:38] So, I think I know why this is happening. [21:24:58] There's this function in RapidHTML that selects dropdown values on the backend for things like state, country, whatever. [21:25:12] If the data is there when you load the form. [21:25:26] Because dropdowns suck and require extra attention. [21:25:50] Only, when we went to integrate worldpay, somebody helpfully removed the "name" attribute from all the form elements. [21:26:23] So, we had to switch the dd fixer code to key off another attribute, that I'm betting isn't present in all the old forms or something. [21:27:19] :D because it shouldn't have been keying off of name anyways [21:27:36] found it! https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/426 [21:27:44] We are morally correct and broken. [21:27:50] haha [21:27:52] ^^ new slogan [21:28:02] I still like Testing is for assholes [21:28:31] * K4-713 erases what I was typing, because that's better [21:28:48] atgomez, pizzzacat; I hope you're both aware of https://office.wikimedia.org/wiki/Bash [21:29:04] Did the proper person get credit for that one? [21:29:29] Oh good, it's just all of us. [21:29:31] I think it just says; heard from the fundraising cube area [21:29:32] As it should be. [21:30:01] oh well.. that's delightful [21:30:44] mwalker: yes haha [21:31:09] hahaha: [21:31:11] Oliver: Toby, I have a question for you... [21:31:12] Toby: Yes, you will go blind. [21:31:23] yeah that one is defintely good. [21:33:00] Hmm. [21:33:03] HMmmm. [21:33:06] HMMM. [21:33:17] Okay, this is weirder than I thought. [21:34:19] mwalker amex config is complete from their side! should i test? [21:35:55] suuuuure [21:35:59] oh wait [21:35:59] not [21:36:06] *you'd have to do it from my machine [21:36:11] unless it just magically works [21:36:16] but then I'd be taking crazy pills [21:36:22] which I might ahve gotten from the guys in the ally [21:37:24] I just caught up on this conversation [21:37:44] so we're saying that the pre-fill issue is GC and is not replicable? [21:41:15] It's GC, and it's doing it on my local and everywhere else. [21:41:43] It's still weirder than I thought, but... w/e. Dead bug walking. [21:42:41] * mwalker considers running away once she sees what I did to the munge dropdown functions [21:42:51] * K4-713 squints [21:43:01] Maaaybe I'll start there, then. [21:43:07] hmm [21:43:19] try globalcollect ffname cc-vmad [21:43:26] ...if you can't replicate [21:43:31] If you're trying. [21:44:46] (PS4) Mwalker: WIP: WorldPay Multiple Accounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129855 [21:44:53] (CR) jenkins-bot: [V: -1] WIP: WorldPay Multiple Accounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129855 (owner: Mwalker) [21:46:10] mwalker: eeeYeah, so, the regex is creating an array of empty arrays on the GC forms. [21:46:32] well that's fun [21:46:32] Probably because id isn't the first attribute. [21:46:39] * K4-713 squints more [21:47:49] atgomez: Why is WP spamming us? [21:48:00] K4-713 huh? [21:48:00] Are they planning on emailing us every time we get a donation? [21:48:12] ... [21:48:15] are you not getting these? [21:48:26] no? [21:49:58] Well, that's fun. [21:50:42] PPena: Are you getting emails from WP about donations happening? [21:50:46] Or, is that just me? [21:51:01] K4-713 sorry ive been burried on Legal emails [21:51:05] let me have a look [21:51:15] It... kind of looks like they're testing that amex is working with different currencies or something. [21:51:26] Which is nice. [21:51:33] But they can stop emailing me whenever. [21:53:11] K4-713 guess its just you? [21:53:15] K4-713 what does it say? [22:05:16] "when you walk around PayPal Pond, you will gain an elevation of 26 feet" [22:06:25] you guys wanna go hiking http://alltrails.com/tracks/paypal-pond [22:06:29] ?? [22:07:23] Rachel V. is the mayor [22:07:41] 8 check-ins in the last 60 days [22:08:03] Kevin Charles says there's good fishing!! [22:54:04] mwalker: IRL for a second? I probably need to go to regex school. [22:55:01] The Fighting Non-Capturing Groups [22:55:11] Or no, the Fighting Lookbehinds [22:56:22] Awesome. Go write a fight song. [23:14:45] Uh-oh. I'm about to do something incredibly annoying. [23:22:18] (PS1) Katie Horn: Altering the fix_dropdowns function to use DomDocument parsing for some things. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131900 [23:23:14] mwalker: ...you may note, that the most recent patch depends on the find-and-replace rodeo I had earlier. [23:23:34] I... can't auto-test the broken form without it. [23:24:56] K4-713, I am really beginning to like adam's "beer and ice cream" philosophy from yesterday [23:25:19] We should keep tallies somewhere of who owes who, what. [23:27:02] ...that was disturbing. Somebody just called my phone. [23:27:10] I didn't even know my phone had a phone in it. [23:27:32] I thought it was just a figure of speech. [23:29:44] seriously; root beer floats [23:29:47] it should happen [23:32:52] (CR) Mwalker: [C: 2] "wth are all these forms anyways?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131864 (owner: Katie Horn) [23:32:58] (Merged) jenkins-bot: Change all noscript blocks to reference the code-generated block. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131864 (owner: Katie Horn) [23:46:44] haha "I didn't even know my phone had a phone in it" [23:47:05] obviously I am down with anything ice-cream related [23:47:15] (CR) Mwalker: [C: -1] Altering the fix_dropdowns function to use DomDocument parsing for some things. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131900 (owner: Katie Horn) [23:47:39] K4-713, ^ [23:48:50] pizzzacat, apparently we need to go to http://www.yelp.com/biz/wexlers-san-francisco#query:root%20beer%20float [23:49:03] (CR) Katie Horn: Altering the fix_dropdowns function to use DomDocument parsing for some things. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131900 (owner: Katie Horn) [23:49:42] ummmmm heaven [23:49:56] though I think I make the best root beer floats. [23:50:15] when we went to the ice cream bar that day you didn't go on the hike with us, I ordered a root beer float [23:50:34] :'( [23:50:37] it was likeā€¦..90% ice cream and 10% root beer. but it did have a toasted marshmallow on top.. [23:50:58] ok; what materials do you need? [23:51:01] but I didn't want a toasted marshmallow. I wanted root beer. I wanted ice cream floating in the root beer. [23:51:03] I need to go to walgreens for stamps anyways [23:51:15] ha now? [23:51:25] I actually have to leave at 5 :'( [23:51:51] ah damit and you're going to "Switzerland" tomorrow [23:52:08] but besides. you can't get the good ice cream at Walgreen's. [23:52:25] next Weds. Root beer float party. [23:52:29] done [23:52:33] I'll bring the stuff. [23:52:54] you could have come to "Switzerland" too! [23:53:15] but now I'm going to "Wikimania"# hash tagg [23:54:57] that looks suspiciously like perl to me [23:57:36] (PS1) Ssmith: Fix loading issues [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/131909 [23:58:45] (PS2) Katie Horn: Altering the fix_dropdowns function to use DomDocument parsing for some things. PS2: 1 character regex change for lazy lookaheads [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131900