[00:00:28] <K4-713>	 Okay, back to the fredge.
[00:00:43] <K4-713>	 Now I just have to... delete everything and manual-test the install.
[00:00:47] <grrrit-wm>	 (CR) Mwalker: [C: 2] Altering the fix_dropdowns function to use DomDocument parsing for some things. PS2: 1 character regex change for lazy lookaheads [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131900 (owner: Katie Horn)
[00:00:47] <K4-713>	 :/
[00:00:53] <grrrit-wm>	 (Merged) jenkins-bot: Altering the fix_dropdowns function to use DomDocument parsing for some things. PS2: 1 character regex change for lazy lookaheads [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/131900 (owner: Katie Horn)
[00:01:19] <mwalker>	 K4-713, drupal stores a record of what it's installed somewhere in the database
[00:01:21] <mwalker>	 delete that row
[00:01:24] <mwalker>	 and your tables
[00:01:31] <mwalker>	 and then you can rerun the updat
[00:01:32] <mwalker>	 e
[00:01:39] <K4-713>	 I think it's slightly more annoying than that.
[00:01:47] <K4-713>	 ...I *HAD* an install testing module.
[00:04:13] <K4-713>	 Oh right, I was going to add more indexes, too...
[17:31:05] <grrrit-wm>	 (PS5) Mwalker: WIP: WorldPay Multiple Accounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129855
[18:15:19] <grrrit-wm>	 (PS3) Katie Horn: New Queue Consumer(s) for two new "fredge" queues [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131655
[18:20:42] <grrrit-wm>	 (CR) Mwalker: [C: 2] "cool" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131655 (owner: Katie Horn)
[18:23:56] <K4-713>	 agh, how is our burnup chart looking *worse*.
[18:24:26] <K4-713>	 srsly, every time I go in there, it's even more divergent.
[20:14:57] <awight>	 !log crm updated from cfe34fe0b10861167199a8f72bba279b9cac5e6e to 1740219e38091ba4f7afe6545ea189b27340bf86
[20:15:03] <morebots>	 Logged the message, Master
[20:16:53] <awight>	 !log bad call: drush en wmf_fredge_qc -- need to rollback the module schema version and try again with "fredge" creds
[20:17:00] <morebots>	 Logged the message, Master
[20:17:30] <awight>	 !log drush pm-uninstall wmf_fredge_qc
[20:17:37] <morebots>	 Logged the message, Master
[20:49:32] <K4-713>	 !log revlocked payments to 4811f6d3d80d126c due to strange errors during an attempted deploy of a7fa0d64da2c56586
[20:49:38] <morebots>	 Logged the message, Master
[20:50:00] <K4-713>	 It's just going to be one of those days.
[21:00:29] <K4-713>	 !log synchronized payments from 4811f6d3d80d126c to a7fa0d64da2c56586
[21:00:33] <morebots>	 Logged the message, Master
[21:28:35] <awight>	 ^^^ teehee
[21:36:45] <grrrit-wm>	 (CR) Adamw: [C: -1] "You would need to get me very very drunk first." (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/125046 (owner: Mwalker)
[21:36:54] <awight>	 mwalker: ^^ seriously.
[21:37:46] <K4-713>	 !log updated payments from a7fa0d64da2c56586c83cf92babb65bac857be2e to 3be44f5d14c00a893a985f3aad86b6b59507a987
[21:37:53] <morebots>	 Logged the message, Master
[21:56:40] <mwalker>	 awight, I'm not opposed to reimplementing -- but I have no idea how to do it cleanly... define an array of all the folders with i18n files and load everything *.json?
[21:57:41] <awight>	 mwalker: can't we just load the target language?
[21:57:53] <awight>	 but yeah.  discovering the files is nasty.
[21:58:16] <awight>	 mwalker: See https://gerrit.wikimedia.org/r/#/c/122664/5/maintenance/generateJsonI18n.php,unified
[21:58:17] <mwalker>	 we cant JUST load the target language because the fallbacks aren't in it
[21:58:28] <awight>	 hrmphs.
[21:58:45] <mwalker>	 agreed
[21:58:54] <awight>	 Sounds like we should zap the i18n team to write a MilkShake Lite PHP component.
[21:59:09] <mwalker>	 or have them generate the php files again for this extension
[21:59:46] <awight>	 ARGH
[21:59:47] <awight>	 right?
[22:00:27] <awight>	 Yr patch is fine, the only part I want to veto is calling out to an unknown and demonstrably unstable shim function
[22:07:55] <awight>	 mwalker: ^^ u agree?
[22:08:13] <awight>	 Even copy n pasting the shim would be enuf for now.
[22:12:10] <mwalker>	 cant copy the shim because it calls out to some mediawiki functions
[22:13:03] <awight>	 mwalker: u are already calling the shim, and stubbing those classes.
[22:13:13] <mwalker>	 oh; that's what you mean
[22:13:16] <mwalker>	 ya, could do that
[22:13:43] <awight>	 Just that, the shim is prone to being changed and merged without any of our team being alerted :{
[22:14:56] * mwalker  grumbles

[22:15:12] <awight>	 The odds of that happening are roughly 100%
[22:18:36] <mwalker>	 but... the shim's API has to be backwards compatible
[22:18:45] <mwalker>	 so... shouldn't anything that happens in the shim be sort of transparent?
[22:19:14] <mwalker>	 they could go back and change 1.17+; but I dont see them wanting to do that
[23:04:35] <grrrit-wm>	 (PS4) Adamw: JP Morgan upload and more generalization [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131642
[23:04:51] <grrrit-wm>	 (CR) Adamw: [C: 2 V: 2] "Rebased previous patchset" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/131642 (owner: Adamw)
[23:06:01] <awight>	 !log update crm from 1740219e38091ba4f7afe6545ea189b27340bf86 to 237d463ed3e275c217a4f497ed30d2f7f20100eb
[23:06:09] <morebots>	 Logged the message, Master