[18:53:39] hey PPena - just FYI I moved our checkin for next week because monday is a holiday [19:15:05] atgomez cool [19:15:08] atgomez what abt this week? [19:15:40] atgomez ahhhhh never mind :) [19:15:54] atgomez i thought u were changing today! [20:54:22] (PS6) Mwalker: WIP: WorldPay Multiple Accounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129855 [20:54:35] (CR) jenkins-bot: [V: -1] WIP: WorldPay Multiple Accounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129855 (owner: Mwalker) [20:55:25] (PS1) Mwalker: Validate form fields using element ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/134245 [20:55:33] (CR) jenkins-bot: [V: -1] Validate form fields using element ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/134245 (owner: Mwalker) [20:56:15] (PS7) Mwalker: WIP: WorldPay Multiple Accounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129855 [20:56:17] (PS2) Mwalker: Validate form fields using element ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/134245 [20:56:22] (CR) jenkins-bot: [V: -1] WIP: WorldPay Multiple Accounts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/129855 (owner: Mwalker) [20:57:04] (PS3) Mwalker: Validate form fields using element ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/134245 [21:11:48] awight, at your leisure: https://gerrit.wikimedia.org/r/#/c/134245/2 [21:26:08] (CR) Adamw: "Yuck, thanks. The previous code was using both ID and name!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/134245 (owner: Mwalker) [21:26:15] (CR) Adamw: [C: 2] "Yuck, thanks. The previous code was using both ID and name!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/134245 (owner: Mwalker) [23:08:59] awight: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=113449&oldid=113447 I don't know what happened [23:09:26] And now that I look at it "K4" is totally not an IRC nick [23:14:19] marktraceur: nice one, it's especially hilarious cos I had nothing to do with it [23:14:25] Heh [23:14:31] awight: I hope you knew it was happening! :P [23:14:43] not really! [23:14:58] I am now looking forward to it tho [23:15:40] mwalker: interesting. Did you know we were publishing banner tests on wikitech:Deployments? [23:16:11] looks like greg-g did it [23:16:38] odd, it is reserving an hour of deployment window as well [23:17:04] awight: Likely that it was in the long-term plan and got added "automatically" [23:17:09] awight: it's an hour long thing, so I put it down for an hour so others know [23:17:25] * greg-g did it [23:17:31] and K4 was close enough [23:17:34] greg-g: ah hey, I was beginning to ping u elsewhere ;) [23:17:44] :) [23:17:56] megan told me about it, as I requested last time things blew up :) [23:18:15] AFAIK we aren't planning to need any deployment resources but that's a good point: we might kill all the sitez ;) [23:18:27] yeah, deployment calendar isn't just about scap [23:18:47] gerrit updates etc are also on there [23:19:04] for a reason :) [23:19:13] greg-g: makes sense, thanks for the explanation [23:19:19] np [23:19:21] We will try not to break all the things [23:19:25] thankyou :) [23:19:34] hehe. There was already a 100% banner test today. ssh! [23:19:53] I'm a little concerned that the Email Greg system is a bit fragile. [23:20:16] it is, it'd be better if ya'll just scheduled the way everyone else does, but I was told that isn't ok :) [23:20:44] but, I have to run to a bus, you and I chat soon re this? [23:20:46] hrm. That sounds ok with me, I'm not sure tech was asked. [23:20:51] yah catch that! [23:20:58] I just spoke with Katie and Megan [23:21:02] * greg-g packs up [23:21:05] by "sounds ok" i mean, we can add the events ourselves [23:21:05] k [23:23:24] oh, hah, just realized I did adamw instead of awight, whatever ;) [23:23:47] (also, I just put random people's names who I thought someone could ping to find out more if something broke) [23:28:32] yes that definitely worked! I like the slight indirection anyway, it discourages rubbernecking [23:36:20] (PS1) Adamw: Failmail module [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134275 [23:36:27] mwalker: ^^ at your leisure [23:37:01] (PS1) Adamw: Failmail on recoverable errors during PayPal audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134276 [23:55:46] awight, why did you decide to go with the handwritten one over the logging one? [23:58:13] mwalker: that is a difficult question to answer. I wouldn't exactly call that handwritten, we were going to need about 50% of that code even in a facade around logging.* [23:58:43] and at that point, it seemed much wiser to just send the email than to set up random logging handlers... [23:59:10] iono; /me likes automatically sending failmail ala smashpig [23:59:21] but /me looks at how you integrated it into paypal [23:59:30] I don't think we are using "logging" anywhere else in the scripts... [23:59:52] There is a problem BTW with both the SP and this approach: mailflood.