[07:17:29] !log updated tools from ee31fc94b17c11a48ddac19aabfcdaab69fd2f72 to d2437564c56881f6b879403f2f6f2f554b6b0391 [07:17:34] Logged the message, Master [07:19:29] (PS1) Adamw: typo [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134567 [07:21:19] (PS2) Adamw: Failmail on recoverable errors during PayPal audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134276 [07:22:49] (PS1) Adamw: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134568 [07:23:03] (Abandoned) Adamw: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134568 (owner: Adamw) [07:23:54] (CR) Adamw: "Ping! This is an annoying one." [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/133769 (owner: Adamw) [07:24:37] (PS1) Adamw: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/134569 [07:24:50] (CR) Adamw: [C: 2 V: 2] "deploy branch" [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/134569 (owner: Adamw) [07:25:32] !log updated tools from d2437564c56881f6b879403f2f6f2f554b6b0391 to c1f50f6909b04768f3a8faa50b25e88a43f89606 [07:25:35] Logged the message, Master [16:35:54] how'd the test go this morning? [17:00:59] It seem to have gone well greg-g. thanks! meganhernandez - anything you want to add? [19:34:57] mwalker: low priority, but... easy: https://gerrit.wikimedia.org/r/#/c/134567/ [19:45:43] (CR) Mwalker: [C: 2] typo [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134567 (owner: Adamw) [19:52:15] (PS1) Adamw: rip contribution_tracking checks out of the PP listener [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/134670 [19:53:59] (PS1) Adamw: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134671 [19:54:14] (CR) Mwalker: [C: 2] "death!" [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/134670 (owner: Adamw) [19:54:20] (CR) Mwalker: [V: 2] "death!" [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/134670 (owner: Adamw) [19:54:36] mwalker: can u hit that .gitreview thing with a stick, too? [19:54:39] killin me... [19:55:07] (Abandoned) Adamw: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134671 (owner: Adamw) [19:55:08] what .gitreview thing? [19:55:32] (PS1) Adamw: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/134673 [19:55:38] oh; is the deploy branch fuxled? [19:55:45] (CR) Adamw: [C: 2 V: 2] "deploy branch." [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/134673 (owner: Adamw) [19:56:25] !log updated tools from c1f50f6909b04768f3a8faa50b25e88a43f89606 to 73921d4b4a7ba69b703340ed56e513f8ae8e0bb5 [19:56:30] Logged the message, Master [20:36:15] (PS1) Adamw: deprecated embedded stomp.py, for now [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134725 [20:39:21] (PS1) Adamw: payflow-audit reads config from /etc/fundraising [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134726 [20:41:53] (PS1) Adamw: read config from /etc/fundraising [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134728 [23:18:23] (PS1) Adamw: read config from /etc/fundraising [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/134763 [23:26:20] mwalker: what would you prefer wrt. SmashPig configuration--get the config_default from the code dir, and local config from /etc, or get them both from /etc? [23:27:05] I'm leaning towards the latter for consistency with unix style, but that's a bit annoying to deploy... [23:28:27] but we could symlink for convenience. [23:33:19] (PS1) Adamw: read configuration from /etc/fundraising/SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/134767 [23:33:23] (CR) jenkins-bot: [V: -1] read configuration from /etc/fundraising/SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/134767 (owner: Adamw) [23:34:17] (PS2) Adamw: read configuration from /etc/fundraising/SmashPig [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/134767 [23:36:57] default config ships with the code [23:37:03] so it has to be in the code directory [23:37:33] awight, ^ [23:43:53] ok we're on the same page [23:44:08] and the normal unixy thing is /etc/defaults/app-config [23:44:36] cos admins like to have their global and local overrides, and it makes the file more visible [23:45:17] we could compromise by ln -s ...SP/config_default.php /etc/fundraising/SP/