[17:08:02] <grrrit-wm>	 (PS1) Awight: fix a warning about unused 'cancel' param [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137351
[17:54:46] <grrrit-wm>	 (PS1) Awight: Fix timezone issues in recurring calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137362
[22:04:04] <grrrit-wm>	 (PS1) Awight: WIP Simplify recurring code a bit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137467
[22:21:18] <grrrit-wm>	 (CR) Mwalker: [C: -1] fix a warning about unused 'cancel' param (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137351 (owner: Awight)
[22:22:42] <grrrit-wm>	 (CR) Katie Horn: [C: 2] "This seems depressingly straightforward." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137362 (owner: Awight)
[22:23:17] <K4-713>	 awight: You want to, ah, deploy the recurring datepicking patch?
[22:23:46] <K4-713>	 I don't want it to get to 12. :p
[22:23:49] <grrrit-wm>	 (CR) Mwalker: [C: 2] Fix timezone issues in recurring calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137362 (owner: Awight)
[22:24:19] <K4-713>	 ...first.
[22:24:34] <mwalker>	 heh
[22:24:42] <grrrit-wm>	 (CR) Awight: fix a warning about unused 'cancel' param (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137351 (owner: Awight)
[22:25:22] <awight>	 K4-713: that reminds me... I need more nov/dec tests...
[22:25:25] <grrrit-wm>	 (CR) Mwalker: [C: 2] "gross" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137351 (owner: Awight)
[22:25:40] <K4-713>	 No.... vember... tests?
[22:25:50] <awight>	 cos we month++
[22:26:19] <K4-713>	 30 days hath November.... yeah. I mean, usually I pick on February.
[22:27:24] <K4-713>	 January 31 is a good day to start a recurring subscription.
[22:27:38] <mwalker>	 why not feb 29?
[22:27:46] <K4-713>	 Because MArch has a 29th.
[22:28:02] <K4-713>	 Not as interesting even with leap years.
[22:28:05] <mwalker>	 sure; but if you test 12 months forward
[22:28:22] <mwalker>	 both are valid; we should have both
[22:28:24] <K4-713>	 Oh, I suppose.
[22:28:25] <K4-713>	 heh
[22:28:47] <K4-713>	 I'd like to have a Something-31st test that runs the function 12 times.
[22:29:31] <K4-713>	 We're just going to make a huge table, aren't we?
[22:30:06] <awight>	 YES
[22:30:11] <awight>	 I don't mind
[22:30:41] <atgomez>	 standup in 3?
[22:33:17] <atgomez>	 awight mwalker K4-713 pizzzacat ^  :)
[22:33:49] <pizzzacat>	 yep we are here
[22:33:55] <atgomez>	 in the hangout?
[22:51:05] <atgomez>	 hey awight ... what's the story on this one? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1671
[22:52:26] <atgomez>	 and also would you like me to make a card about prioritizing dedupe batches by country?
[22:56:15] <awight>	 atgomez: sure, that would be helpful, thx!
[23:00:24] <atgomez>	 ok! i'll put it...2  sprints out?
[23:01:03] <awight>	 atgomez: meh, these are not exactly sprintly things, they just need to be associated with the dedupe work :(
[23:01:18] <atgomez>	 yeah but i mean.. if it's going to happen later vs now...
[23:02:37] <awight>	 hehe later then
[23:02:44] <atgomez>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1684
[23:02:46] <atgomez>	 :)
[23:02:51] <awight>	 awesome!
[23:30:09] <grrrit-wm>	 (PS2) Awight: WIP Simplify recurring code a bit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/137467