[00:11:35] (CR) Mwalker: Make geolocation parsing rules stricter (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (owner: QChris) [07:52:46] (PS1) Awight: Thank-you generation: shout at obvious mistakes [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138787 [08:20:54] (PS2) Awight: Thank-you generation: shout at obvious mistakes [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138787 [08:24:01] (PS2) QChris: Avoid encoding issues by fetching GeoIP cookie through jquery.cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 [08:24:03] (CR) jenkins-bot: [V: -1] Avoid encoding issues by fetching GeoIP cookie through jquery.cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (owner: QChris) [08:25:43] (PS3) QChris: Avoid encoding issues by fetching GeoIP cookie through jquery.cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 [08:27:47] (CR) QChris: Avoid encoding issues by fetching GeoIP cookie through jquery.cookie (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (owner: QChris) [13:52:41] (PS2) Amire80: Show rtl collapsible arrow in rtl languages [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120312 (https://bugzilla.wikimedia.org/36795) [14:42:35] (PS4) QChris: Avoid encoding issues by fetching GeoIP cookie through jquery.cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (https://bugzilla.wikimedia.org/66478) [16:01:00] (CR) Mwalker: Avoid encoding issues by fetching GeoIP cookie through jquery.cookie (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (https://bugzilla.wikimedia.org/66478) (owner: QChris) [16:03:29] (CR) Mwalker: [C: 2] "It would be wonderful if this could run as we were downloading things but before we wrote them to disk; but this is a great start." [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138787 (owner: Awight) [16:23:49] Okay, who did https://meta.wikimedia.org/w/index.php?title=Fundraising/Translation/Thank_you_email_20140606/pl&diff=next&oldid=8821569 ? [16:25:24] Pcoombe (WMF) apparently did that. [16:26:05] jessicarobell: ^^ [16:32:04] hi twkozlowski. Yes, we unfortunately had to change the tag for the matching gifts. Sorry about this inconvenience [16:33:19] jessicarobell: You also had to add tvars for URLs [16:33:37] That should have been done before you ever send the request for translation to volunteers. [16:33:44] sent* [16:40:24] Yes, we are sorry that the change was made this late twkozlowski [16:41:24] jessicarobell: Are there any steps taken to make sure this will not repeat next year or next month? [16:41:53] For instance, have you got a step-by-step manual for people to follow when preparing text for translation? [16:42:57] Some parts of https://meta.wikimedia.org/wiki/Tech/News/Manual might be helpful for you guys, I guess. [16:45:50] We will do our very best to avoid that it happens again tomasz. there are guidelines in place but somewhere down the line this got missed. thanks for your understanding [16:50:16] jessicarobell: Are the guidelines public by chance? [16:53:17] a lot of it is documented here twkozlowski https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_administration#changes [16:54:09] (CR) Awight: "@mwalker: Excellent idea, it will be tricky however cos I want to reuse thank_you_render without dipping into the low-level stuff. I'm no" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138787 (owner: Awight) [17:37:32] (CR) Awight: "Crap, this was accidentally merged on -deployment" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138787 (owner: Awight) [17:41:16] (PS1) Awight: New TY translations for ca, es, sv [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138853 [17:47:14] (PS1) Awight: additional TY translations ready to publish [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138856 [17:50:25] I am offended by Mingle's overnight changes. [17:54:01] jessicarobell: Do you have a Gerrit account? The es, ca, and sv TY translations are waiting for code review... [17:54:33] K4-713: What did they do this time? [17:55:14] This is going to sound stupid, but they changed the font styling for the headers on card wall view. [17:55:23] awight: I don't have a gerrit account no. Should I get one? [17:55:37] well... it will be useful in situations like this. [17:55:55] jessicarobell: https://wikitech.wikimedia.org <-- I think if you create an account here, that gives you gerrit access. [17:55:56] marktraceur: That coupled with all the icons they pepper around each column, makes the lane titles look broken and disjointed from bits of themselves. [17:56:09] Oh right [17:56:12] well. ok, let me look into that then. Thank you. [17:56:30] I'm logged in and it looks like (-) Pending Code [17:56:35] Review / (9) [17:56:49] K4-713: omg I just clicked a [17:56:51] "-" [17:56:52] NOOOO [17:56:56] K4-713: That looks right [17:57:02] Or wrong [17:57:03] Whatever. [17:57:10] * awight pants a bit. OK it comes back [17:57:12] USELESS [17:57:21] awight just killed "In development". [17:57:26] ...just kidding, it's fine. [17:57:36] as per Lisa's request, we need to make sure that there is a link to https://wikimediafoundation.org/wiki/Matching_Gifts/form in the footer. I think Peter will have to add that before we publish? [17:57:48] K4-713: Obviously the problem is that they reported the bug in Mingle but then were so paralyzed by the intimidating lane titles to do anything about it [17:58:22] jessicarobell: yeah and that will take a spot of tech work as well, to add the new tag. [17:59:00] marktraceur: This wouldn't be so bad if they hadn't just made a several-month effort to make the borders between every pane ("pane" works for this as a design term, right? iono) completely go away, presumably to make it look like everything is falling off into everything else. [17:59:11] jessicarobell: I don't have the letter from Lisa, just email *about* her response... Can I ask if she has been informed that the database is incomplete, therefore might fool a lot of people into thinking they do not have a matching employer when they in fact do? [17:59:38] Step 1: Make everything look like it's falling into everything else. Step 2: Make every distinct thing look like it's falling off of itself. [18:00:02] Step 3: Implode [18:00:31] I am beginning to suspect the endgame is "drop all tables and see if anybody notices". [18:00:49] awight: ah. that's important information. I didn't know that and I am *assuming* Lisa doesn't either.. [18:02:46] marktraceur: My favorite thing they've done in a while is "turn header background from bright, recognizable orange into everything-background white, but apply a horizontal rainbow gradient so subtle, you have to be at a wrong viewing angle for your monitor to even notice". [18:03:23] Wait what [18:03:27] Why did they I don't even. [18:03:38] I guess it makes more sense to not use the link then.. Let us ask her on the email thread [18:04:08] There's not a gradient [18:04:08] marktraceur: For instance: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/overview [18:04:16] You have firebug? [18:04:25] Normal ff dev tools [18:05:14] Oh, wait, the tabs? [18:05:21] Check for a background between "All" and "Project admin", yes. [18:05:27] WHY. [18:05:40] Yeah I've seen that [18:05:49] I thought it was my display dying at first [18:06:35] https://d3ngpuh23r8dku.cloudfront.net/images/bg-rainbow.png [18:06:40] The guys caught me frowning and squinting and moving around looking at Mingle... [18:06:48] ...sort of like trying to see through a SEP field. :p [18:07:02] It's like a magic eye [18:07:04] Mingle eye [18:07:10] eeeek [18:07:13] I don't want that. [18:07:18] awight: in your view, is there a huge discrepancy between the actual list of matching gift companies and the ones listed in the database? Do we update this regularly or was it updated a long time ago and noone has had time to do it for a while..? [18:07:51] marktraceur: It does make me want to come up with backgrounds intended to make people think their monitors have some new kind of burn-in, though. [18:08:03] K4-713: Dead pixel backgrounds [18:08:05] position:fixed [18:08:33] Everything is perfectly white except for one pixel, which is neon green [18:10:23] And there's a really, really faint image of an attacking bear that you can only see from a bad angle. Yes. [18:13:00] K4-713: It'll give people nightmares, I love it [18:13:46] I'll get right on that. [18:14:31] Inspired by Mingle. [18:15:21] You know, maybe this is a ploy to get people to stop knocking the fundamental structure. You get so wrapped up in the superficial issues that you completely forget to talk about the fundamental ones. [18:18:25] Heh [18:19:44] mwalker: Link to Thing: https://collab.wikimedia.org/wiki/Fundraising/Engineering/Fun_SQL_Queries#Donation_amount_popularity_in_a_campaign_range.2C_aggregated_to_whole_USD_amounts [18:19:46] (CR) Pcoombe: [C: 2] New TY translations for ca, es, sv [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138853 (owner: Awight) [18:21:08] K4-713: Sadly a flickr search for CC-BY-SA images with "bear attack" in the title comes up with like three bears looking for fish, one fluffy dog, and like a billion pictures of people next to a stuffed bear [18:21:22] And a duck. [18:21:28] bahaha, wut. [18:21:41] I guess if cameramen get attacked for a bear, they... try to get paid? [18:21:54] Er. Not *for* a bear. *By* a bear. [18:22:38] ...try "duck attack". [18:29:29] awight, it looks like Peter reviewed the code. so es, ca, and sv are published then? [18:39:59] (PS1) Awight: Thank-you generation: shout at obvious mistakes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/138881 [18:40:01] (PS1) Awight: New TY translations for ca, es, sv [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/138882 [18:40:25] mwalker: ^ these two need are already reviewed, it's just a cherry-pick... from deployment to master :-/ [18:40:31] s/need// [18:41:28] !log updated crm from b6815d29de97b80a0ab65db576213a604f0c7cb9 to c38296add61421f87e12cb5b4f3dd68bdf2340db [18:41:33] Logged the message, Master [18:42:18] awight, it would be wonderful if you used gerrit's cherry pick functionality to do this in the future [18:42:23] (CR) Mwalker: [C: 2] Thank-you generation: shout at obvious mistakes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/138881 (owner: Awight) [18:42:30] (CR) Mwalker: [C: 2] New TY translations for ca, es, sv [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/138882 (owner: Awight) [18:42:51] mwalker: it's too scary. Can you give it the destination branch? [18:42:56] yes [18:43:00] ok then. [18:43:22] (CR) jenkins-bot: [V: -1] New TY translations for ca, es, sv [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/138882 (owner: Awight) [18:43:42] and thank you for letting me know that this terrible piece of software has a halfway helpful feature :p [18:43:49] (CR) Mwalker: [V: 2] New TY translations for ca, es, sv [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/138882 (owner: Awight) [18:44:54] (PS5) Ori.livneh: Avoid encoding issues by fetching GeoIP cookie through jquery.cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (https://bugzilla.wikimedia.org/66478) (owner: QChris) [18:52:01] (CR) Mwalker: [C: 1] "Looks good; should be tested before +2" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (https://bugzilla.wikimedia.org/66478) (owner: QChris) [18:58:38] (CR) Mwalker: [C: 2] "I don't have varnish to do the full workflow; but I set a cookie by hand locally and it worked." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (https://bugzilla.wikimedia.org/66478) (owner: QChris) [19:05:49] (PS1) Mwalker: Merge remote-tracking branch 'gerrit/master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/138892 [19:06:04] (CR) Mwalker: [C: 2] Merge remote-tracking branch 'gerrit/master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/138892 (owner: Mwalker) [19:06:18] (Merged) jenkins-bot: Merge remote-tracking branch 'gerrit/master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/138892 (owner: Mwalker) [19:39:40] (CR) Pcoombe: [C: 2] additional TY translations ready to publish [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/138856 (owner: Awight) [19:47:06] (PS1) QChris: Harmonize format of GeoIP cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138900 [19:49:08] (CR) QChris: Avoid encoding issues by fetching GeoIP cookie through jquery.cookie (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138748 (https://bugzilla.wikimedia.org/66478) (owner: QChris) [21:36:00] (CR) Ori.livneh: [C: 1] Harmonize format of GeoIP cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138900 (owner: QChris) [21:40:03] (CR) Mwalker: [C: 2] Harmonize format of GeoIP cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138900 (owner: QChris) [21:40:11] (Merged) jenkins-bot: Harmonize format of GeoIP cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/138900 (owner: QChris) [21:40:40] (PS1) Mwalker: Harmonize format of GeoIP cookie [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/139001 [21:44:02] sweet words [22:09:45] (CR) Mwalker: [C: 2] Harmonize format of GeoIP cookie [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/139001 (owner: Mwalker) [22:09:52] (Merged) jenkins-bot: Harmonize format of GeoIP cookie [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/139001 (owner: Mwalker) [23:21:26] (PS1) Awight: slander tail fixups [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139029 [23:21:28] (CR) jenkins-bot: [V: -1] slander tail fixups [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139029 (owner: Awight) [23:41:10] (PS1) Awight: pep8 fixes [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139037 [23:41:12] (CR) jenkins-bot: [V: -1] pep8 fixes [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139037 (owner: Awight) [23:43:29] (PS2) Awight: pep8 fixes [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139037 [23:43:31] (CR) jenkins-bot: [V: -1] pep8 fixes [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139037 (owner: Awight) [23:44:38] (PS3) Awight: pep8 fixes [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139037 [23:49:02] !log updated SmashPig from 98b1f348aa55f6a3aac441db08a59ca309fade7a to 22e2923a3a030b17815181574f9ca99b38c5f2dc [23:49:07] Logged the message, Master