[00:22:30] <grrrit-wm>	 (CR) Awight: "Inline comment either clarifies or muddies the issue :)" (1 comment) [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139567 (owner: Awight)
[00:26:26] <grrrit-wm>	 (Abandoned) Awight: Rough notes towards modular donation data field management [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/118297 (owner: Awight)
[00:34:12] <grrrit-wm>	 (CR) Awight: [C: 1] Simplify fundraising maintenance mode (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140959 (owner: Ejegg)
[00:47:18] <grrrit-wm>	 (CR) Awight: [C: 2] "Small things inline. Also noticed that you are doing many different date manipulations, enuf that you might want a DateHelper to contain " (4 comments) [wikimedia/fundraising/dash] (StyleTemplating) - https://gerrit.wikimedia.org/r/135720 (owner: Ssmith)
[00:50:15] <grrrit-wm>	 (CR) Awight: [C: 2] "Cool, thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/120312 (https://bugzilla.wikimedia.org/36795) (owner: Amire80)
[00:52:35] <grrrit-wm>	 (CR) Awight: [C: 2] Add jquery flot and d3 libraries (1 comment) [wikimedia/fundraising/dash] (StyleTemplating) - https://gerrit.wikimedia.org/r/136266 (owner: Ssmith)
[16:30:57] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Good stuff" [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139567 (owner: Awight)
[17:02:09] <atgo>	 PPena jessicarobell meganhernandez the-wub we are having technical issues (what else is new)
[17:02:11] <atgo>	 be there soon
[17:02:27] <jessicarobell>	 ok atgo!
[17:10:10] <awight>	 headed to BARF.  cya in an hour++
[17:10:48] <marktraceur>	 Bay Area Rapid Frustration
[17:23:55] <grrrit-wm>	 (PS1) Mwalker: Put files into the SFTP remote root [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/142591
[17:33:02] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Logging updates look good" [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139559 (owner: Awight)
[17:33:06] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] deal with logfile rotation [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/139567 (owner: Awight)
[18:27:44] <atgo>	 K4-713 when you get a chance - forward me all the PCI consultant stuff?
[18:28:03] <K4-713>	 That's going to possibly take some time. Unless I threw it on collab.
[18:28:09] <atgo>	 i'll look
[18:28:52] <atgo>	 nope
[18:28:55] <atgo>	 but i did find this...https://collab.wikimedia.org/wiki/Comprehensive_list
[18:28:57] <K4-713>	 d'oh.
[18:28:57] <atgo>	 ...?
[18:29:14] <atgo>	 here's a link version: https://collab.wikimedia.org/wiki/Comprehensive_list
[18:32:02] <atgo>	 awight which transitions did you say were broken for you? sprints?
[18:32:22] <grrrit-wm>	 (CR) Katie Horn: "Great! The only comment of substance I have, is that we usually use the getGlobal static function in gateway objects to get our globals, s" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142176 (owner: Ejegg)
[18:32:47] <K4-713>	 ejegg: review comments for you. ^^
[18:33:03] <grrrit-wm>	 (PS3) Ejegg: Simplify fundraising maintenance mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140959
[18:35:33] <awight>	 atgo: I'm missing all the buttons for "move to current sprint", etc
[18:35:43] <atgo>	 hmm ok
[18:35:44] <atgo>	 check now
[18:35:45] <atgo>	 ?
[18:35:57] <K4-713>	 awight: Log in? :p
[18:36:02] <atgo>	 they disappeared when i reconfigured the Supertasks
[18:36:11] <K4-713>	 orly.
[18:36:15] <K4-713>	 That's... huh.
[18:36:31] <K4-713>	 I've got them.
[18:37:40] <atgo>	 i think i just fixed it
[18:37:42] <atgo>	 :P
[18:38:04] <awight>	 atgo: u fixed it.
[18:38:12] <atgo>	 woo! see K4-713 , i 'm learning
[18:38:14] <awight>	 It's now equally broken as before :p
[18:38:21] * atgo sigh
[18:38:40] <K4-713>	 Hey: Steady states are better than running off a cliff.
[18:39:02] <atgo>	 i feel like that should be on a cheesy inspirational posted
[18:39:04] <atgo>	 poster
[18:39:05] <K4-713>	 ...unless you've normalized to cliff-ejection mode.
[18:39:10] <K4-713>	 :/
[18:39:14] <K4-713>	 HAPPY FRIDAY.
[18:47:46] <atgo>	 awight would you like me to convert your "upgrade civiCRM" card into a supertask?
[18:48:37] <awight>	 atgo: I... sure if you have the time
[18:48:45] <atgo>	 that's what i'm here for :P
[18:48:50] <awight>	 don't say that
[18:49:06] <grrrit-wm>	 (CR) Ejegg: "Proposal below would call it from validateForm, letting you turn on fallback currencies and optional interstitial notifications for any ad" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142176 (owner: Ejegg)
[18:50:55] <grrrit-wm>	 (CR) Katie Horn: "Works for me! Let's do it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142176 (owner: Ejegg)
[18:51:02] <grrrit-wm>	 (PS1) Awight: (FR #1726) Wrap HTML attachment as a full document [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/142615
[18:54:10] <awight>	 K4-713: ejegg: ^^ this is an emergency thing
[18:54:21] <K4-713>	 a whatnow?
[18:54:33] <K4-713>	 awight: looking
[18:54:35] <awight>	 that CR is for the jp fubar
[18:54:35] <awight>	 yah
[18:54:36] <awight>	 th
[18:54:38] <awight>	 x
[18:54:45] <K4-713>	 huh
[18:55:07] <K4-713>	 No redundant tags?
[18:55:22] <awight>	 redundant.  eh?
[18:55:39] <awight>	 There is an encoding on the mime-attachment
[18:55:39] <K4-713>	 Like, if the html snippet already has <html><head><whatever>
[18:55:42] <awight>	 oh
[18:55:44] <awight>	 no it won't
[18:55:45] <K4-713>	 explode.
[18:55:47] <awight>	 grr
[18:56:12] <awight>	 ok that's a great point, but luckily that cannot happen yet.
[18:56:33] <K4-713>	 I'd be happier if it checked for <html> already being present... could you at least throw a TODO in there to that effect?
[18:56:40] <awight>	 yes that sounds good
[18:56:48] <K4-713>	 woot
[18:56:59] <awight>	 sort of...
[18:57:25] <K4-713>	 Also, you get +5 points for use of the word "recalcitrant".
[18:57:34] <grrrit-wm>	 (PS1) Jforrester: [WIP] Add a grunt linting checker for jshint, jscs, csslint, and banana and pass them [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616
[18:57:46] <K4-713>	 OOOH.
[18:57:53] <K4-713>	 And then, that happened too.
[18:58:51] <awight>	 I don't understand.  It was our gateway js which was really killing the lint
[18:59:19] <K4-713>	 We're being coaxed into the future. Just let it happen.
[18:59:47] <K4-713>	 Actually, it's the future mixed with some reasonable middling version of the past.
[19:00:27] <K4-713>	 I'm told we'll be able to use banana to verify that translations we think we need, are present in certain languages.
[19:01:07] <awight>	 that sounds like a milkshake ingredient.
[19:01:16] * K4-713 will never stop giggling because of banana-related phrases
[19:03:18] <K4-713>	 awight: Am I waiting for PS2 with upgraded commentary?
[19:03:35] <K4-713>	 Wait. I should say "I am waiting for [that]. Should I stop, or wait longer?"
[19:04:02] <grrrit-wm>	 (PS2) Awight: (FR #1726) Wrap HTML attachment as a full document [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/142615
[19:04:27] <K4-713>	 awight: Oooh, even better. Thank you.
[19:04:47] <grrrit-wm>	 (CR) Katie Horn: [C: 2] (FR #1726) Wrap HTML attachment as a full document [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/142615 (owner: Awight)
[19:04:52] <K4-713>	 There y'go.
[19:04:58] <awight>	 than yee
[19:05:07] <awight>	 thank theee
[19:05:21] <K4-713>	 I autocorrected that correctly. Heh.
[19:05:35] <K4-713>	 Do we need to email guinea pigs now?
[19:05:45] <K4-713>	 Or, rather, after the deploy...
[19:06:10] <awight>	 Both would be ideal, but to avoid confusion you agree we should just send the fixed version?
[19:06:26] <grrrit-wm>	 (PS1) Awight: (FR #1726) Wrap HTML attachment as a full document [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/142619
[19:06:38] <grrrit-wm>	 (CR) Awight: [C: 2 V: 2] (FR #1726) Wrap HTML attachment as a full document [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/142619 (owner: Awight)
[19:07:15] <K4-713>	 awight: I don't see why we wouldn't want to do that.
[19:07:20] <K4-713>	 Then again, I'm not the email expert.
[19:07:27] <awight>	 !log update crm from e2fe03a9cd51e30206d9a1114d62dfbd6960816b to 340c43a15a84a9392ad5ef9fc2782243ff140deb
[19:07:31] <morebots>	 Logged the message, Master
[19:07:44] <K4-713>	 awight: I'm probably not even the email journeyman apprentice.
[19:10:21] <grrrit-wm>	 (PS2) Jforrester: [WIP] Add a grunt linting checker for jshint, jscs, csslint, and banana and pass them [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616
[19:11:15] <atgo>	 awight that was fast!
[19:11:47] <K4-713>	 I'm about to assign some Scotty-heavy Classic Trek episodes as required viewing for the weekend.
[19:12:01] <K4-713>	 Actually, scratch that. Just watch Wrath of Khan.
[19:12:07] <K4-713>	 It's all there.
[19:12:26] <K4-713>	 Though... also the beginning of 3.
[19:12:42] <awight>	 atgo: /me gives upside-down sign of cross.  Testing.
[19:13:12] <atgo>	 anyone want to go get food?
[19:13:16] <awight>	 y
[19:13:41] <K4-713>	 Me too.
[19:13:48] <atgo>	 ejegg? ccogdill ?
[19:13:55] <K4-713>	 awight: You in a good place to go now?
[19:14:03] <K4-713>	 Or, is there something to monitor?
[19:14:21] <ccogdill>	 I brought food
[19:14:28] <ccogdill>	 but I’ll be at the table when you get back!
[19:14:48] <awight>	 K4-713: I can go
[19:15:01] <K4-713>	 okay, let's break for it.
[20:26:22] <grrrit-wm>	 (PS3) Jforrester: [WIP] Add a grunt linting checker for jshint, jscs, csslint, and banana and pass them [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616
[20:38:00] <awight>	 ccogdill: well, I confirmed that it is the HTML attachment which is being mangled.  bad.
[20:38:09] <ccogdill>	 poop
[20:38:38] <ccogdill>	 Sisolak seems like he has some sort of idea to test… we’ll see if he comes back with anyway
[20:38:41] <ccogdill>	 *anything
[20:41:08] <ccogdill>	 don’t know if you saw his rather unhelpful email just now, awight
[20:41:17] <awight>	 ccogdill: it was a help
[20:41:22] <ccogdill>	 whew
[20:41:25] <ccogdill>	 awesome
[20:45:49] <grrrit-wm>	 (PS1) Awight: (FR #1726) Attempt cheesy quoted-printable encoding... [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/142705
[20:46:03] <awight>	 K4-713: ^^
[20:46:17] <K4-713>	 awight: Oooh, I like cheese.
[20:46:19] <K4-713>	 ...wait.
[20:46:38] <awight>	 more holes in that code than a block of swiss...
[20:46:40] <K4-713>	 I'm... going to need a minute with the internet.
[20:47:44] <K4-713>	 Oh, *that* stuff. Ugh.
[20:47:51] <awight>	 yeah.
[20:48:00] <awight>	 this will probably fix our unsub links
[20:48:13] <awight>	 but might wreck the encoding for some other large population
[20:48:17] <K4-713>	 mmmh
[20:48:26] <K4-713>	 hrrrrrrngh
[20:48:43] <awight>	 hehe reviewer angst
[20:48:51] <K4-713>	 ...graaaaaannnNNNGH.
[20:49:14] <grrrit-wm>	 (CR) Katie Horn: [C: 2] "urrrrrr" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/142705 (owner: Awight)
[20:49:26] <K4-713>	 awight: Let me know when you want the revert reviewed. :p
[20:49:39] <awight>	 yeah... thank you for understanding :p
[20:55:06] <grrrit-wm>	 (PS1) Awight: (FR #1726) Attempt cheesy quoted-printable encoding... [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/142719
[20:55:13] <atgo-lunch>	 awight does it make sense to have a "source metadata" supertask?
[20:55:16] <grrrit-wm>	 (CR) Awight: [C: 2 V: 2] (FR #1726) Attempt cheesy quoted-printable encoding... [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/142719 (owner: Awight)
[20:55:33] <awight>	 atgo-lunch: not really, cos it's already implemented
[20:55:45] <awight>	 it's more of a tag now, perhaps?
[20:55:47] <atgo>	 well there are a few cards still lurking
[20:55:49] <atgo>	 ok
[20:56:01] <awight>	 ccogdill: heads-up, we will probably get a lot of complaints after this change I'm about to make...
[20:56:06] <awight>	 in many languages :p
[20:56:27] <awight>	 atgo: u want to define what a supertask is?
[20:56:34] <ccogdill>	 haha yaaaay… no way to get around that, I suppose?
[20:56:34] <awight>	 (on a wiki page)
[20:56:39] <atgo>	 yeah.. i need to think about that one for a bit
[20:56:43] <atgo>	 and then yes
[20:56:48] <K4-713>	 We have a mingle use page.
[20:56:49] <awight>	 ccogdill: maybe.  but we need the data :)
[20:57:06] <K4-713>	 I made it to prepare for atgo taking this job.
[20:57:20] <ccogdill>	 hah okay. well I’ll let you know when/if things blow up
[20:57:21] <K4-713>	 atgo:  ...hopefully I sent it to you at some point.
[20:57:26] <atgo>	 yeah you did
[20:57:30] <awight>	 !log updated crm from 340c43a15a84a9392ad5ef9fc2782243ff140deb to 17439326ca4488ece843a263fc14859b38cff0e9
[20:57:32] * K4-713 looks relieved
[20:57:33] <awight>	 ccogdill: buckle up!
[20:57:36] <morebots>	 Logged the message, Master
[20:58:16] <awight>	 ccogdill: u can send the poor donor another letter, now
[20:58:47] <ccogdill>	 okay. waiting to hear back from them before I blow them up with email :)
[20:58:56] <ccogdill>	 but do that before sending the Silverpop version I take it?
[20:59:02] <ccogdill>	 or both
[20:59:02] <awight>	 I think so, yes
[20:59:09] <awight>	 up to you
[20:59:19] <awight>	 I would only worry about confusing the two
[20:59:29] <ccogdill>	 awight^
[20:59:40] <awight>	 ccogdill: yes, I was replying to u
[21:00:12] <ccogdill>	 ohh sorry :D
[21:00:25] <ccogdill>	 okay, depending on their eagerness I’ll decide if they can handle 1 or 2
[21:00:29] <awight>	 hehe good plan
[21:00:42] <awight>	 maybe send half of the group A and the other half B
[21:01:11] <awight>	 K4-713: argh.  Matt did say something IRL about quoted-printable when we talked about it in the unsub context, > 1 year ago
[21:01:15] <awight>	 mwalker|away: ^^
[21:01:33] <K4-713>	 Was it "OMG DON'T DO THAT"?
[21:01:48] <awight>	 it was something along those lines, maybe more capitalized
[21:01:58] <K4-713>	 ...oops.
[21:07:18] <awight>	 K4-713: I'm gonna review #1698, are you in there?
[21:07:25] <K4-713>	 In where?
[21:07:33] <awight>	 already reviewing that feature?
[21:07:52] <awight>	 or if you wish to, I will cede the honor
[21:08:02] <K4-713>	 We already did a round.
[21:08:10] <K4-713>	 Unless I missed a patch set...
[21:08:17] <K4-713>	 ...I'm still waiting for a couple things.
[21:08:26] <awight>	 ok great
[21:08:40] <awight>	 Possibly I am procrastinating too hard
[21:08:46] <K4-713>	 I can't imagine why.
[21:09:06] * awight wanders towards... kitchen...
[21:45:09] <grrrit-wm>	 (PS5) Ejegg: Add Amazon USD interstitial, make it and Paypal's optional [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142176
[21:58:59] <atgo>	 awight can i invite myself to your banner mixin call on monday?
[21:59:01] <atgo>	 i am curious
[21:59:40] <awight>	 atgo: yes pls sorry I though you were optional already
[22:00:58] <grrrit-wm>	 (PS1) Katie Horn: DonationData: cleanup of basic data retrieval [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142731
[22:01:23] <K4-713>	 awight: You busy? :) ^^
[22:03:06] <K4-713>	 I like how the differ thinks that "production" and "destruction" were originally the same word.
[22:04:00] <awight>	 haaar
[22:09:48] <grrrit-wm>	 (CR) Awight: [C: 2] DonationData: cleanup of basic data retrieval (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142731 (owner: Katie Horn)
[22:10:03] <grrrit-wm>	 (Merged) jenkins-bot: DonationData: cleanup of basic data retrieval [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142731 (owner: Katie Horn)
[22:10:58] <K4-713>	 awight: That was fast.
[22:11:11] <K4-713>	 Thanks.
[22:11:35] <K4-713>	 Also, I got to thinking... there are now a lot of opportunities for individual gateways to inject their own rules.
[22:11:52] <K4-713>	 ...gonna let that one sit for a bit, I think.
[22:12:16] <grrrit-wm>	 (CR) Krinkle: [WIP] Add a grunt linting checker for jshint, jscs, csslint, and banana and pass them (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616 (owner: Jforrester)
[22:14:05] * K4-713 giggles at banana again
[22:14:24] <awight>	 K4-713: want to whiteboard how that will work?
[22:14:34] <K4-713>	 What? The gateway overrides?
[22:14:45] <K4-713>	 I'm sort of on a slightly other planet at the moment.
[22:14:47] <awight>	 like, how we want data handled
[22:14:49] <awight>	 me too
[22:14:55] <awight>	 looking for procrastination
[22:15:03] <K4-713>	 oic
[22:15:05] <awight>	 I am on planet 3rd basement floor of purgatory
[22:15:26] <K4-713>	 Is that where you're just floating in silence?
[22:15:37] <atgo>	 awight you need something to procrastinate with? :P
[22:15:53] <awight>	 atgo: I am so busy with a thing I do not like
[22:16:08] <atgo>	 i seeeee
[22:16:12] <awight>	 ... continuing dedupe port into Civi...
[22:16:16] <atgo>	 ahh
[22:16:30] <atgo>	 which card is that one?
[22:16:34] <awight>	 :p
[22:16:44] <awight>	 atgo: 1637
[22:16:58] <atgo>	 man dedupe is so hairy.
[22:17:27] <grrrit-wm>	 (CR) Krinkle: [WIP] Add a grunt linting checker for jshint, jscs, csslint, and banana and pass them (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616 (owner: Jforrester)
[22:17:33] <awight>	 atgo: it's fine as long as I'm just prototyping :)
[22:17:40] <atgo>	 ha
[22:17:54] <awight>	 but yeah it's about to get all heuristical
[22:18:44] <grrrit-wm>	 (CR) Katie Horn: "Okay. Aside from one last thing, this looks ready to go. The last thing is this: Global defaults need to be defined in DonationInterface.p" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142176 (owner: Ejegg)
[22:19:32] <grrrit-wm>	 (PS9) Awight: initial port of the dedupe review UI [wikimedia/fundraising/crm] (dedupe) - https://gerrit.wikimedia.org/r/134998
[22:20:34] <awight>	 ccogdill: pls do feel free to forward me any responses from Japanese-speakers over the weekend... I'll be working a tiny bit, and knowing one way or another will be nice.
[22:20:49] <ccogdill>	 okay cool, will do!
[22:26:13] <grrrit-wm>	 (CR) Awight: initial port of the dedupe review UI (13 comments) [wikimedia/fundraising/crm] (dedupe) - https://gerrit.wikimedia.org/r/134998 (owner: Awight)
[22:30:59] * K4-713 opens patchset, burbles, runs away
[22:31:42] <K4-713>	 *only* 2500 lines of code?
[22:32:15] * awight sweat into hairshirt
[22:32:20] <awight>	 ^sweats
[22:32:58] <K4-713>	 I am going to need some kind of... fortification.
[22:33:05] <K4-713>	 Oh, but look: It's standup time.
[22:45:59] <grrrit-wm>	 (CR) Jforrester: [WIP] Add a grunt linting checker for jshint, jscs, csslint, and banana and pass them (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142616 (owner: Jforrester)
[23:00:15] <grrrit-wm>	 (PS4) Ejegg: Simplify fundraising maintenance mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140959
[23:07:49] <grrrit-wm>	 (PS6) Ejegg: Add generic currency fallback with optional notification [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142176
[23:09:45] <grrrit-wm>	 (CR) Awight: [C: 2] "DEPLOYMENT: Must be deployed config-first" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142176 (owner: Ejegg)
[23:09:53] <grrrit-wm>	 (Merged) jenkins-bot: Add generic currency fallback with optional notification [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/142176 (owner: Ejegg)
[23:14:18] <atgo>	 ccogdill you saw where to find that error code doc in the server, yeah?
[23:14:21] <atgo>	 in case you need it
[23:14:41] <ccogdill>	 yep! fileserv > fundraising > tech > gc?
[23:14:44] <atgo>	 mhmmm
[23:14:48] <ccogdill>	 cool
[23:15:32] <awight>	 !log deploymed payments config
[23:15:37] <morebots>	 Logged the message, Master
[23:17:27] <atgo>	 awight in the interest of tracking, would you like/make a card for the research you just did for megan?
[23:20:29] <awight>	 atgo: no :p
[23:20:31] <awight>	 definitely not