[09:39:20] (CR) Hashar: [C: 2 V: 2] .gitreview [wikimedia/fundraising/LanguageTag] - https://gerrit.wikimedia.org/r/120996 (owner: Awight) [18:24:09] (PS1) Ejegg: Fix quotes so converted currencies are logged [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143065 [18:25:09] (CR) Katie Horn: [C: 2] Fix quotes so converted currencies are logged [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143065 (owner: Ejegg) [18:25:17] (Merged) jenkins-bot: Fix quotes so converted currencies are logged [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143065 (owner: Ejegg) [18:29:57] ejegg: lol nice one ^^ [18:30:14] ejegg: btw, do you have access to the logs yet? [18:30:20] d'oh! got a little carried away with the single quotes [18:30:50] It's a really silly convention. I seriously doubt it improves PHP interpretation performance [18:31:04] think I should have access, but I don't actually know where to look [18:31:09] I'd rather just use the quotes according to semantic consistency [18:40:47] ejegg: btw, I'm deploying your amazon changes now, you might want to test when I'm done [18:41:07] OK, will do [18:41:47] !log updated payments from a8138fefd940ba41812e5c07ca6bc74b63cb9bcf to a04e536b6923f2228bb7f5fbf2caeed64a888742 [18:41:50] Logged the message, Master [18:42:10] ejegg: ^^ that was the deployment [18:44:28] No errors so far. I'll let you know if I see your currency conversion get logged... [18:46:24] OK, seems to be converting 1000 JPY to 9 USD just fine. NotifyOnConvert is set to false, correct? [18:47:56] lemme see. it should be. [18:48:18] hmm I don't see the logstring yet. [18:48:22] maybe mirror lag [18:49:11] ejegg: yep, false for both PayPal and Amazon [18:50:08] rats, amazon_gateway: 18443109:3544895232 Unsupported currency $oldCurrency forced to $defaultCurrency [18:51:11] ejegg: ah sorry, I didn't deploy a submodule bump for that. [18:51:37] Eh? [18:52:04] Oh, because that wasn't in the same commit? [18:52:53] ejegg: payments deployment is annoying. We have to merge or cherry-pick the change from master to deploy-payments_1.22, then go to the mediawiki-core checkout and add the submodule change to the fundraising/REL1_22 branch [18:53:46] Ah, got it. [18:54:10] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/143072 [18:54:12] (PS1) Awight: Fix quotes so converted currencies are logged [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/143073 [18:54:14] (CR) jenkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/143072 (owner: Awight) [18:54:21] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/143072 (owner: Awight) [18:54:26] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/143072 (owner: Awight) [18:54:47] (CR) Awight: [C: 2] Fix quotes so converted currencies are logged [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/143073 (owner: Awight) [18:54:54] (Merged) jenkins-bot: Fix quotes so converted currencies are logged [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/143073 (owner: Awight) [18:59:50] the-wub: This is a state-of-the-art banner? http://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B14_0630_enjaJP_pm_ctrl [19:00:24] ah, totally different diet function... [19:09:23] awight: yup. https://meta.wikimedia.org/wiki/MediaWiki:CentralNotice/Resources/BannerShowHideCountDate.js is the cookie diet [19:09:42] the-wub: luckily, it's incredibly complex ;) [19:16:22] !log updated payments from a04e536b6923f2228bb7f5fbf2caeed64a888742 to 2b6c527617dcde154cc298dd9697c9d57c9f3620 [19:16:27] Logged the message, Master [19:16:46] ejegg: ok would you mind beginning that workflow again? [19:17:56] awight: sure thing [19:18:39] amazon_gateway: 18443109:3544895232 Unsupported currency JPY forced to USD [19:18:47] woot! [19:18:53] good stuff [19:19:13] we probably want the amounts... it can wait though [19:19:38] you'd be surprised how often people email us to ask about the $10,000 donation they accidentally made... [20:22:22] (PS2) Ssmith: Submit form when return is pressed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140815 [20:24:36] (PS2) Ssmith: Fix expiration date message translation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140950 [20:25:59] if anyone has time, ^ these quick patches are good to go [20:26:58] I think we should try some of these techniques. j/k. http://www.john-foreman.com/blog/facebooks-solution-to-big-datas-content-problem-dumber-users [20:27:16] ejegg and pizzzacat i think it's just you 2 for standup (at 303)... you have the collab space over by the other side of the floor [20:28:13] atgo cool. maybe we'll just do IRC standup.. ejegg is that cool with you? [20:28:21] Sure, that works [20:28:40] how was the conference? [20:33:14] (CR) Awight: [C: 2] Submit form when return is pressed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140815 (owner: Ssmith) [20:34:09] (CR) Awight: [C: 2] "Please help us remember to delete the old string, it is unused now?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140950 (owner: Ssmith) [20:35:46] (CR) Ejegg: [C: 1] "Looks good, but do we want to add a check for the button being disabled before submitting?" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140815 (owner: Ssmith) [20:35:46] (Merged) jenkins-bot: Submit form when return is pressed [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140815 (owner: Ssmith) [20:35:50] (Merged) jenkins-bot: Fix expiration date message translation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140950 (owner: Ssmith) [20:36:15] (PS1) Awight: WIP mixin for the newer diet algorithm [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/143108 [21:10:53] hey ccogdill can you tell me more about this silverpop thing? [21:12:00] (CR) Awight: "Needs to be tested. Automated tests, ideally." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/143108 (owner: Awight) [21:19:14] hey atgo, yeah. I’m in a meeting with Pats but will tell you as soon as I can [22:11:12] hey atgo [22:11:16] want to talk about Silverpop? [22:14:16] can i swing by your desk in 15? [22:14:45] ohh you’re with MG [22:15:03] yeah I’ll see you in 15 [22:58:19] (PS1) Awight: add is_2014_donor to export view [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/143187 [23:01:37] (CR) Katie Horn: [C: 2] "Can't wait to see if it's really that simple." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/143187 (owner: Awight) [23:01:49] K4-713: yah mwalker|away did the work already, this was just a glitch [23:02:10] I can't tell if I should be happy or sad. [23:02:42] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/143190 [23:02:42] ...so I'm going to pour some coffee on it. Can we generate the file and spot-check the results? [23:02:50] yep i'm on it [23:02:58] groovy. [23:03:01] (CR) Awight: [C: 2 V: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/143190 (owner: Awight) [23:03:03] * K4-713 looks for a bucket of coffee [23:03:49] !log update tools from e894f1f77674b6b101ae0e1644e363ca52e319d9 to d605bdc2aaaef2d4b296a4d9567ed2831db86756 [23:03:55] Logged the message, Master [23:08:42] pizzzacat: shall I delete the row "Analytics - new"? I guess that is entirely covered by Dash? [23:09:14] maybe…though I still will be doing non-Dash-related analytics viz [23:09:30] pizzzacat: ah ok great [23:09:31] like public reports and slides and whatever [23:09:44] yes I'll leave the entry then, I'm convinced :p [23:09:53] :) [23:11:48] K4|coffee: ok, the export is running w/ fix, I'll ping you when it's ready to spot-check [23:12:17] awight: eta? [23:12:22] < 1hr [23:12:31] Oh good. [23:15:36] K4-713 did you see megan's email about the canada emails? [23:16:03] atgo: I saw that I had email. [23:16:11] ...340 unread. [23:16:27] yeah... so... today is apparently "atgo hassles everyone all day day" [23:16:33] "how hard would it be to have a different version of the thank you email for Canada only? It looks like it's just the footer text we'd need to change for Canada. " [23:16:39] is the question... [23:16:52] atgo: ...54? [23:16:57] mm yes [23:16:58] 54 Difficult. [23:17:06] i'd estimated 58, so that's good [23:17:10] :) [23:17:33] For what it is, it would have to be a pretty serious thing to warrant a 54 being worth the effort. [23:17:54] ok so.. basically we can't send any emails in canada as is because of their new anti-spam laws [23:17:57] including TY [23:18:01] *any* emails? [23:18:08] F..... [23:18:12] well, unless we remove the shop info [23:18:16] ...or goodness sake. [23:18:34] When does that requirement kick in? [23:18:38] as a charitable organization, we are potentially exempt from the "opt in" to emails [23:18:45] but it can't have any commercial stuff [23:18:59] I should let you know that if you say "yesterday" I might actually jump out the window. [23:19:08] ermm [23:19:12] i'm not totally sure [23:19:25] the new laws go into effect july 1 (gasp), but there is definitely some sort of grace period [23:19:48] atgo: K4-713: anyone want to bounce cookie ideas for a minute? [23:20:01] Not only is this going to be 54 Difficult to rectify, it's going to be, like, 8 Difficult to not have TY emails just to Canada. [23:20:03] so we'll have to either add a clumsy checkbox to have people opt into emails (has to be default unchecked) or remove the "shop" stuff from the mailers [23:20:20] We have never had to turn them off for a country before. [23:20:30] yeah that's what i figured [23:20:33] awight in a few minutes? [23:20:33] So, we'd have to put some thought into how we don't lie to ourselves in the dataabse. [23:20:42] yeah [23:20:54] Also in the database, which is more important. [23:20:58] could it not be a bit like a new language? [23:21:03] but they both happent o be in english [23:21:16] atgo: sure. I'm also mining my inbox for emails about this, but they are scant [23:21:28] I suppose if en_CA had... missing things? [23:21:42] Like, it's not substantially different text, right? Just missing sections? [23:21:53] exactly [23:21:58] i think it would just have to be missingt he shop part [23:22:17] atgo: I have that one. Is that it? [23:22:24] as far as i can see [23:22:29] awight ^ [23:22:38] atgo: rats. It sure sounds like there was an earlier conversation. [23:22:54] awight give me a minute [23:23:12] K4-713 do you have the email from stephen that megan forwarded? [23:23:23] I have a lot of things. [23:23:27] ...let me look. [23:23:34] subj is "fwd: Canada" [23:23:55] Yes. [23:24:01] atgo: wrt the new hiding cookie, what I'm most interested in are the intentions driving the change [23:24:10] awight we can chat about that IRL [23:24:11] easier [23:24:19] K4-713 the idea would be basically to remove a number of htings [23:24:23] awight: Didn't we already do this? [23:24:31] so.. if we just did it as a different language that would work [23:24:33] i think? [23:24:41] awight: Nothing changed. Though, I may have hallucinated that you were there. [23:24:56] atgo: ok, I think I found it [23:25:12] K4-713: already had a recap? [23:25:29] awight: re the hide cookie changes? Yes. [23:25:34] The initial cap, and then the recap. [23:25:42] the baseball cap [23:25:44] I think there was also a re-recap... [23:25:48] hah. Anyway, the email I wanted was " cookie questions [23:25:54] was "couple cookie questions" [23:26:14] sounds suspiciously like a Scottish hate group [23:26:32] o_O [23:26:45] awight: While you're here, can we talk about TY letter translations for a minute? [23:26:52] ah yes [23:26:54] Apparently Canada is being a problem. [23:26:58] oh hah [23:27:04] awight K4-713 would this be easier IRL? [23:27:12] I... don't know. [23:27:25] ok. here's the shortest version [23:27:26] awight: There's backscroll... [23:27:31] Like, right here. [23:27:33] canada has new anti-spam laws [23:27:34] aargh ok reading [23:27:40] called CASL [23:28:32] K4-713: making a sentence optional is real easy. [23:29:19] awight: Oh, thank Zeus. [23:29:31] awight there's a bit more.. i'm forwarding you the email [23:29:38] K4-713: we just have to add a tag to the contribution, then it gets picked up in the letter template [23:29:41] atgo: thx [23:30:02] we could also switch on a contact tag. [23:30:03] awight: So, it's not in... Canadian English or something? [23:30:12] K4-713: hah that would be a nasty kludge [23:30:21] Would it? Because it's actually for Canada. [23:30:24] boo. here i thought i was being clever [23:30:35] I thought that's what locality is supposed to do as its #1 thing. [23:31:07] first thing I'd like to know is, does CASL affect people with country of web origin=CA, or people with a billing address in CA? [23:31:31] cos we only have language variant based on country of web origin [23:31:47] awight i'm looking [23:31:48] >:[ [23:32:08] if it affects both, which would be the most logical guess, then we definitely need a little logic to make the calculation. [23:32:12] * K4-713 silently registers own guess [23:32:40] omg my brain must be melting I apparently said "logic" not only once but twice in a sentence [23:32:51] yodawg [23:32:59] <_< [23:33:00] >_> [23:34:03] i am having trouble finding that info [23:34:11] i'll have megan ask stephen about it [23:34:35] ok. meanwhile I guess we should add the machinery to hide the stupid link [23:34:40] well.. hang on. [23:34:43] and figure out how to light the fuse later [23:34:45] let's make sure that's the move. [23:36:16] do we have any other questions? [23:36:51] atgo: from my perspective, just * who does it affect * what do we have to do * when is the deadline / consequences for non-compliance [23:37:09] * awight checks to see if that was an ejegg_ trigger [23:37:28] consequences for non-compliance are HUGE fines [23:37:38] you mean 'compliance?' heh [23:38:21] $10mil for corporations. [23:38:46] well that answers that. We change our business model to, finding corporations breaking this rule. [23:38:51] hahahaha [23:40:15] K4-713: ejegg_: I know it is hellish, but I need a new warmbody to take over mwalker|away's review of https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1637 [23:41:33] awight: I'll keep looking through it, and probably bug you with basic civi questions tomorrow [23:41:45] think i'm gonna call it an evening for now though [23:41:46] ejegg_: ah ok thanks for taking up that gauntlet [23:42:21] * K4-713 abandons all hope of editing code today [23:42:24] hah [23:42:32] hide cookie? [23:42:55] * K4-713 hides cookie in computer bag [23:43:07] ...oh. Wait. [23:44:39] K4-713 awight the silverpop fix: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1756 [23:45:00] That's a mingle card. [23:45:23] * K4-713 looks deeply stupid for several seconds. [23:46:30] Maybe if the... office warmness wasn't so... [23:46:34] ...melting. [23:46:42] atgo: yes is there a question about that, or this is just a jyi? [23:46:44] jfyi [23:47:04] I'm testing the fix now, ETA to confirm is 5:30 or so [23:48:19] atgo: 10M? Really? [23:48:47] awight K4-713 no.. just so you can move it when it's done :) [23:48:51] K4-713... yes [23:49:05] atgo: ok heh I accidentally marked it "Deployed" already :p [23:49:51] atgo: So... we really should make this impossible to screw up, huh? [23:49:59] that would be ideal. [23:50:17] we need more ifno from megan/legal