[04:36:02] (PS1) Awight: new translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/143568 [04:36:45] (PS1) Awight: new translations [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/143569 [05:42:48] (PS1) Awight: remove "commercial activity" paragraph from thank-you letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/143570 [05:43:27] (PS1) Awight: remove "commercial activity" paragraph from thank-you letters [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/143571 [08:13:48] I suppose pcoombe is sleeping? [14:42:16] (CR) Pcoombe: [C: 2] new translations [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/143569 (owner: Awight) [14:42:35] (CR) Pcoombe: [C: 2] new translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/143568 (owner: Awight) [18:26:09] awight: ...so. Thank You emails? [18:28:11] K4-713: aaaaaargh. Yes, that is top o' the list [18:51:51] K4-713 awight the plan is to take that paragraph out of all the languages, yeah? [18:52:01] I'm reviewing the thing right now. [18:52:02] Yes. [18:52:52] ...if I can get past the Diff All Side-By-Side windopocalypse. Sheesh, this is like playing Missile Command. [19:01:07] K4-713: awww, I just saw rebase fail [19:06:06] (PS2) Awight: remove "commercial activity" paragraph from thank-you letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/143570 [19:16:29] K4-713: ^^ [19:17:08] Already on it. [19:17:38] (CR) Katie Horn: [C: 2] "Yep." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/143570 (owner: Awight) [19:18:54] (PS2) Awight: remove "commercial activity" paragraph from thank-you letters [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/143571 [19:25:53] (CR) Awight: [C: 2 V: 2] remove "commercial activity" paragraph from thank-you letters [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/143571 (owner: Awight) [21:03:27] static $gotten in adapter::getGlobal makes testing kinda annoying. Would it be much slower to move the static cache to a protected class static so the testing subclass can clear it? [21:04:40] ejegg: sounds great [21:04:53] rockin [21:05:14] ejegg: It would be really slick if we had a way to either register all static vars, or use reflection to identify them. and clear during testing as u say. [21:11:03] awight: yeah, that would be nifty. Sounds like an opportunity for me to learn PHP reflection [21:11:33] It's not as bad as it looks. And supposedly performant, fwiw. [21:11:40] at least, relative to the rest of PHP [21:11:47] heh, nice [21:13:50] (PS1) Ejegg: GC: Check XML for CVV result, use blanks if missing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143764 [21:14:00] (CR) jenkins-bot: [V: -1] GC: Check XML for CVV result, use blanks if missing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143764 (owner: Ejegg) [21:19:49] (PS2) Ejegg: GC: Check XML for CVV result, use blanks if missing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143764 [21:33:47] ejegg standup? [22:18:13] pizzzacat3 there are 3 of you?! [22:20:02] (PS1) Awight: Job config may include regexes to give emitted lines a final massage [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/143776 [22:24:56] atgo I don't know what you're talking about. 8-) [22:25:23] there was a cat there, I saw it! look, you can still see its toothy smile... [22:45:02] (PS1) Awight: Upgrade to CiviCRM 4.2.17 upstream [wikimedia/fundraising/crm/civicrm] (contrib) - https://gerrit.wikimedia.org/r/143781 [22:46:31] K4|meeting: ejegg: sorry for the context switch... this is an urgent security thing tho ^^ [22:47:48] awight: taking a look now [22:48:35] thanks! [22:50:18] (PS1) Awight: Merge contrib into HEAD [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/143783 [22:51:28] (PS1) Awight: update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/143784 [22:51:52] (PS1) Awight: update civicrm submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/143785 [22:57:15] awight: Where do you pull the 4.2 branch updates from? [22:57:25] Ah ;) excellent question... [22:57:40] ejegg: one moment, I'm finishing the documentation about that [22:58:55] ejegg: https://wikitech.wikimedia.org/wiki/Fundraising/tech/crm/Upgrade_CiviCRM [23:00:00] thanks! [23:01:31] K4|meeting: new documentation! ^^ [23:01:39] Woooo [23:15:54] awight: CRM/Core/Page/AJAX/Location.php - does the updated getPermissionedLocation still let you guess a user ID and include it in the querystring as uid to use their permissions? [23:16:44] ejegg: oooh, let me look [23:19:37] ejegg: ow. fyi there is also #civicrm for the askin' [23:19:39] oh, never mind, that's the user id of the person you want to look up. Then they validate a checksum that should be on the request too [23:19:42] ok, cool [23:20:40] awight: Do you need anything from my general direction in the next... 40 minutes or so? [23:21:00] ejegg: yep you are right about validateOnlyChecksum, I think [23:21:03] K4-713: no! [23:21:10] Woah [23:21:23] K4-713: if you are bored ;) there is helping review my Translation permission thing [23:21:23] ...I'm just gonna run with that. :) [23:21:26] ok heh [23:21:38] I remember being bored once. [23:21:42] It was weird. [23:21:47] TV. [23:22:06] That's exactly what happened, yes. [23:22:11] How did you know? [23:38:15] This is the last major hurdle to having our new TY translations workflow: https://gerrit.wikimedia.org/r/#/c/141595/ [23:38:27] seems to work locally, but the hack is sooo horrible... [23:54:19] hey awight ... do i need chromium to do this? [23:54:29] atgo: no, any browser [23:54:30] because chrome incognito is showing the access denied page [23:54:33] aargh [23:54:37] yeah that's bad [23:54:53] I was hoping it was completely locked down. I'll email poor jgreen [23:54:57] wait... it might work [23:55:11] work, as in does not show the Drupal access denied page? [23:55:21] chrome has certificates it keeps trying to throw at it and i'm not sure that i've managed to persuade it [23:55:39] so... safari (when i deny it access to the keychain) says "safari can't open the page" [23:55:46] hmm [23:55:59] well that might be safari's behavior when it knows you have a cert [23:56:07] can you use incognito mode or something? [23:56:17] tested on non-wmf machine and it shows the Drupal access denied page [23:56:18] :( [23:56:39] ok that is what I was afraid of. This is the .frdev one, right? [23:56:47] yup [23:56:54] kthx! [23:56:56] want me to test the non-frdev? [23:57:47] nah we already know that one is dangling in the wind [23:57:51] deeelightful [23:59:07] K4-713 did you see sebastiaan's latest & greatest? [23:59:46] I just replied. Yes. :) [23:59:50] CALLED IT. [23:59:54] atgo: aww, I'm totally not on that thread. /me kicks the empty fun bucket.