[00:06:19] (CR) Ejegg: [C: 2] "I think I see how this fixes the anonymous user data leakage, but I don't know much about Civi permissions so I'm hazy on the privilege es" (1 comment) [wikimedia/fundraising/crm/civicrm] (contrib) - https://gerrit.wikimedia.org/r/143781 (owner: Awight) [00:06:56] ejegg: herculean! take a day off! [00:07:01] heh [00:07:26] (CR) Awight: [C: 2] Merge contrib into HEAD [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/143783 (owner: Awight) [00:08:53] awight: phew, I thought that contrib merge was another huge set of contributed modules or something! [00:13:28] awight: I'll take a look at the translate stuff tomorrow [00:13:50] awight, K4, pizzzacat, atgo: have a good evening! [00:20:22] (CR) Awight: [C: 2 V: 2] update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/143784 (owner: Awight) [00:20:41] (CR) Awight: [C: 2 V: 2] update civicrm submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/143785 (owner: Awight) [01:01:19] (CR) Awight: "@QChris: I don't see removeCookie() defined anywhere. Maybe this patch depends on a newer version of jquery.cookie than is bundled in mw-" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/139357 (https://bugzilla.wikimedia.org/66478) (owner: QChris) [01:08:16] (CR) Awight: [C: -1] "Can you split this patch into whitespace, getGlobal static, and the actual subject?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143764 (owner: Ejegg) [01:22:17] (CR) Awight: GC: Check XML for CVV result, use blanks if missing (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143764 (owner: Ejegg) [13:56:10] (CR) Jgreen: [C: 1] Job config may include regexes to give emitted lines a final massage [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/143776 (owner: Awight) [16:11:59] (CR) Mwalker: [C: 2] Job config may include regexes to give emitted lines a final massage [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/143776 (owner: Awight) [16:47:38] (CR) Ejegg: [C: 2] Job config may include regexes to give emitted lines a final massage [wikimedia/fundraising/slander] - https://gerrit.wikimedia.org/r/143776 (owner: Awight) [17:47:53] (PS1) QChris: Use proper cookie removal for the WM's current jquery-cookie version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/143923 [17:48:39] (CR) QChris: "Yikes! Thanks. You're right." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/139357 (https://bugzilla.wikimedia.org/66478) (owner: QChris) [17:58:28] (CR) Mwalker: [C: 2] Use proper cookie removal for the WM's current jquery-cookie version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/143923 (owner: QChris) [17:58:34] (Merged) jenkins-bot: Use proper cookie removal for the WM's current jquery-cookie version [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/143923 (owner: QChris) [22:16:18] http://38.media.tumblr.com/f36373be357a72d3318f910d35f603e8/tumblr_n5zlnmUi8Q1r6n45qo1_400.gif [22:23:16] awight: ...thank you. [22:24:03] http://www.theguardian.com/science/2014/jul/03/electric-shock-preferable-to-thinking-says-study [22:25:01] Now I'm sad. [22:25:18] (PS3) Ejegg: GC: Check XML for CVV result, use blanks if missing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/143764 [22:28:18] ... The Internet made me do it [22:57:05] (PS1) Katie Horn: Cleaning up payments error logs, part 1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144080 [22:59:12] ejegg: Hey, you around for some CR? [22:59:20] This is sort of pressing. [22:59:27] yeah, the zip code thing? [22:59:36] Indeed. It's that one. [22:59:46] on it [23:00:06] Thanks. :) Let me know if I need to explain myself. [23:06:16] (CR) Ejegg: [C: 2] "Looks good" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144080 (owner: Katie Horn) [23:06:30] (Merged) jenkins-bot: Cleaning up payments error logs, part 1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144080 (owner: Katie Horn) [23:12:11] (PS1) Katie Horn: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/144083 [23:12:13] (PS1) Katie Horn: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/144084 [23:12:15] (PS1) Katie Horn: Cleaning up payments error logs, part 1 [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/144085 [23:13:02] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/144083 (owner: Katie Horn) [23:13:22] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/144084 (owner: Katie Horn) [23:13:35] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/144085 (owner: Katie Horn) [23:22:08] !log updated payments to c5689f385b2f0a7bdc55c5752010e9eb [23:22:12] Logged the message, Master [23:59:08] I just found the best error code. [23:59:33] Apparently, GC can return a well-formed response to a request, containing the error SYSTEM_MALFUNCTION.