[16:05:31] ejegg: Good morningish! [16:09:51] K4: And hello to you too! [16:12:36] ejegg: You have a lot in Pending Code Review, correct? [16:13:17] K4: you mean for me to review, or my stuff to be reviewed? [16:13:49] oh hey, there are a bunch of new incoming Hashar chart things [16:14:01] ooo. [16:14:45] ejegg: I was mostly talking about stuff I should review for you. Do you know if there's anything of yours that's outstanding, that awight didn't get to yet? [16:15:31] He asked that I split the CVV thing up, which I just did recently [16:15:59] mwalker: Since when are you even *conscious* this early [16:16:24] marktraceur: It happens sometimes. Always makes me nervous. [16:16:36] Something is obviously wrong, right [16:16:42] Sometimes I get here and awight is already at his desk. That's scarier. [16:17:28] My immediate thought is always "What melted and why didn't my Red Alert go off?!?" [16:18:11] marktraceur, this is my usual time to get into the office actually [16:18:17] I oscillate between 915 and 945 [16:18:53] (CR) Ejegg: [C: 2] typo: method must be static [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/144255 (owner: Awight) [16:19:13] I swear you were doing like 11:30 for a while [16:20:06] Not unheard of in fundraising. But it's been a while. [16:20:30] And those same people usually make commits or do deploys at midnight on a Saturday, so... [16:20:53] * K4-713 shrugs [16:21:49] Understandable :) [16:22:07] There was this awful time in which pg and I got into this evil early-escalation. I'd get in 15 minutes earlier to mentally prepare for everybody showing up, and then he would show up 5 minutes earlier every day until we were coming in at the same time, so I'd move it up... [16:24:10] marktraceur, on mondays that'll happen if I overnighted in the south bay; I work remote until the traffic dies down [16:24:57] ...aw shoot. Goodbye for pretty much the rest of Monday. [16:25:24] Not as fun as lazytown. [16:25:27] Or swingtown. [17:05:50] My browser is advertising, in a hilariously ironic fashion: "Customize Firefox with your nation's flag and celebrate the global spirit of community." [17:05:55] awight - good morning! [17:06:03] WE'RE NUBMER ONE (in education...) [17:06:06] atgo: ohai [17:06:12] haha [17:06:30] just a quick check on the TY issues for hebrew... it seems like we're good now...? [17:06:37] atgo: afaik yes [17:06:43] cool, thanks :) [17:06:55] atgo: my recommendation is another round of testing [17:07:06] awight sounds good. i'll push for that [17:07:41] atgo: I would say I'm 75% comfortable with the fixes we have in place... um on that note, let me get some code review so we actually have those fixes in place... [17:08:04] ha alright... so is it possible for jessica to test at this point or do we wait until we hear from you [17:08:05] ? [17:08:35] atgo: lemme poll devs... [17:08:48] atgo: testing at this point will be missing the fixes [17:09:24] ok sounds good. no hurry, just want to make sure i have a good sense of the situation [17:09:51] pizzzacat: https://gerrit.wikimedia.org/r/144254 [17:10:35] awight can you make card(s) for this TY problem please? [17:11:20] (CR) Ejegg: "Maybe add Urdu?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/144254 (owner: Awight) [17:11:55] ejegg: woot! [17:13:11] hi awight [17:13:48] (CR) Mwalker: Medium-heavy-handed RTL approach (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/144254 (owner: Awight) [17:17:36] ejegg: yeah I don't like this hardcoded language codes thing... [17:20:07] no language functions from PHP or Drupal we could use, huh? [17:22:27] mwalker: ok yeah I double-checked using html lang= alone, that isn't enuf for gmail [17:22:45] *sigh* that's dumb [17:22:56] ejegg: hehe, you mean like a useful function which does things we need? Do you want substr with funny parameter interpretation? [17:23:23] heh, are my expectations too hihg? [17:23:43] ejegg: you aren't the high one, it's the fools who designed php... [17:23:52] must have been a frat or something... [17:23:52] awight, if you want... http://stackoverflow.com/questions/20861663/detect-string-direction-from-string-in-php [17:23:56] zing [17:24:46] mwalker: that actually looks more fragile than using the language code, cos we will usually have a mix of code tables [17:27:17] awight, fair nuf: https://en.wikipedia.org/wiki/Right-to-left#RTL_Wikipedia_languages [17:33:08] (PS2) Awight: Medium-heavy-handed RTL approach [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/144254 [17:34:44] (CR) Ejegg: [C: 2] "Can't wait for our first Mazanderani thank you email" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/144254 (owner: Awight) [17:37:55] ejegg: hehe yeah I'm looking forward to the time-traveling Syriac donation traffic as well [17:41:00] (PS1) Awight: typo: method must be static [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/144488 [17:41:02] (PS1) Awight: Medium-heavy-handed RTL approach [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/144489 [17:41:12] (CR) Awight: [C: 2] typo: method must be static [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/144488 (owner: Awight) [17:41:19] (CR) Awight: [C: 2] Medium-heavy-handed RTL approach [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/144489 (owner: Awight) [17:41:26] (CR) Awight: [V: 2] Medium-heavy-handed RTL approach [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/144489 (owner: Awight) [17:44:01] (CR) Ejegg: "Three cheers for log cleanup! Just one phpdoc comment niggle." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144108 (owner: Katie Horn) [17:54:12] (CR) Krinkle: "Noticed in a blame that this changed coding style in upstream jquery.validate.js." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/23614 (owner: Siebrand) [17:55:20] wm-bot, help [17:55:26] morebots, help [17:55:26] I am a logbot running on tools-exec-09. [17:55:26] Messages are logged to wikitech.wikimedia.org/wiki/Server_Admin_Log. [17:55:26] To log a message, type !log . [17:55:33] ^ awight [17:55:41] mwalker: yes? [17:55:47] documentation on !log [17:55:54] hehe [17:56:56] atgo: jessicarobell: We've deployed all the pending RTL fixes, please go ahead with testing! [18:28:22] Great! Thank you atgo and awight [18:30:43] awight: the only way to test this is for an Israeli donor to make a donation, right? there is no way to force it? or, ccogdill, maybe you know..? [18:31:39] jessicarobell: you can use the test page in Civi [18:32:22] ok, awight, thanks for confirming. I thought that didn't give us the right version. [18:32:45] jessicarobell: it's the same as what will be emailed to donors [18:32:58] you mean using this page right awight https://civicrm.wikimedia.org/admin/config/thank_you/test [18:33:01] aargh. [18:33:02] yes [18:34:38] ok cool. thanks. since we had problems before were the unsubscribe link didn't work for the test version, but it worked for the real version that donors received, I had a doubt. thanks for solving this awight! :) [18:35:17] jessicarobell: I should eventually fix the unsubscribe thing, but it's quite involved and should be done along with other changes we have planned. [18:35:58] ok. the unsubscribe seems to be working from the he test email. [18:36:00] jessicarobell: teal deer is that there is no corresponding contact or contribution in Civi, so there is nothing to unsubscribe [18:36:10] jessicarobell: oh! [18:37:10] jessicarobell: sounds like the issue I just described might be getting confused with a simpler thing, where the translation recently had a bad token for $unsubscribeURL, which would cause the link to not render? [18:37:37] actually, no sorry. It doesn't, which is normal as you pointed out. [18:37:50] you get here http://fundraising.wikimedia.org/wiki/index.php/Special:FundraiserUnsubscribe?p=thankyou&c=-1&e=jrobell%40wikimedia.org&h=6c177f5af0cd3ab5b42afb78f736c054b876f2cd&uselang=he [18:38:08] which I think is normal since there is no donation on record as you said [18:38:31] jessicarobell: well, that's pretty good... but now I see that our UI has a big, fat untranslated thing [18:39:41] yes, that is weird. I have submitted the translation for that phrase, but maybe it needs to be added somewhere in addition. hmm. will look at this. [18:40:11] jessicarobell: "fundraiserunsubscribe" ? [18:40:26] jessicarobell: fwiw I just created a tracking card, https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1768 [18:42:59] Thanks awight! [20:37:13] awight: i split up that GC-CVV commit like you suggested [20:38:08] ejegg: oh thanks! It will make reverting much easier :p [20:38:24] also, i'm curious what populates the dedupe review queue [20:39:53] ejegg: aaaah. wikimedia/fundraising/tools.git -> dedupe/ [20:40:09] thanks! I'll take a look [20:41:07] ejegg: yeah I need to port outta there into that Civi extension... eventually... so 3rd-parties can use it [20:41:56] ok, but for now all that's an actual Civi extension is the batch assignment and marking them reviewed, right? [20:42:34] ejegg: yep. [20:42:49] ejegg: If you want, we can do a call and I'll show you the roadmap [21:04:14] K4-713: you are responding? If so I will do something else. [21:04:21] ? [21:04:25] refunds [21:04:32] putting the FUN in refunds [21:04:36] Is there something else? [21:04:52] yep it's floating under your inbox [21:05:02] Ah, got it. [21:06:17] K4-713: I would definitely include the currency fluctuation thing... [21:07:16] Because without fun, refunds are just the Reds. And Cincinnatti hasn't won a pennant since 1990. [21:08:09] :p [21:48:39] awight: were you about to say something? [21:49:25] ejegg: oh heh. Just repeating the "offer" to go over any dedupe stuff you are curious about. [21:49:52] oh, thanks! Just going through the python stuff now [21:50:03] ejegg: https://trello.com/b/f6BYQzoW/dedupe-roadmap [21:50:27] oh, cool, thanks! [21:54:16] brb, tornado warning (for Somerville???!!) [22:13:34] ejegg: the sky turn green? [22:13:51] nope, just really dark really fast [22:13:57] oh wow! [22:14:02] and now it's blue again [22:14:15] Guess there were some funnel clouds, but nothing touched down [22:16:08] I just read the news article, and apparently people who read that sort of thing "would also be interested in": Drunk mom drove with 6 kids on top of her car [22:16:13] * awight rolls eyes [22:16:18] only 6? that's nothin [22:16:44] dang, those are some talented kids [22:16:54] err nah they fell off [22:17:36] oh... well that sucks then [23:11:59] awight - did you get a chance to push along the cookie changes? [23:12:28] atgo: no :( [23:13:11] atgo: There is some stuff written already, it can be picked up by ejegg or K4-713 if they're willing... [23:13:39] If I lick that cookie, it's going to just sit on the tray. [23:13:40] fwiw, this is definitely not a safe change and demands local testing [23:13:49] same here, too salty [23:13:54] mm cookies [23:14:01] https://gerrit.wikimedia.org/r/143232 [23:14:06] Also, somebody already licked half of it. Gross. [23:14:16] haa [23:15:31] awight are you sidelined by the CB project? [23:15:54] atgo: so very. [23:16:19] alright :/ [23:16:51] atgo: the coding is minor, but there is a lot of stuff which is not ready for development... might be related to veil of secrecy [23:17:16] sure, i gotcha [23:17:48] ejegg - could you take the cookie? :P [23:17:54] who stole the cookie from the cookie jar.. [23:18:12] I like that we're talking about cookie licking with an actual cookie. [23:18:16] ejegg https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1703 [23:18:17] I donno how to fix that next time. I have most of the emails, I guess it's decently my fault for absenting myself from the conversation. [23:18:19] Usually it's all metaphorical. [23:18:48] awight it's all good. it'll get there [23:18:53] sorry, let me check that out [23:18:54] there's been 9 million emergencies. [23:19:31] thanks ejegg ! [23:20:41] ejegg: I added a few breadcrumbs to that card just now... [23:21:06] mostly, caching and deployment are the nasty considerations here. [23:22:02] thanks for the elucidation [23:22:05] ejegg: the banner controller will be cached for most clients, so we probably need to push a liberal decoder before we push the new cookie contents [23:22:35] * awight taps dollar-store flashlight which seems to be fresh out of elucidity [23:22:37] right, that makes sense. [23:24:05] ejegg: while we're piling emergency cookies on your plate, I need to keep this can rolling: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1603 cos it affects other people's work big-time [23:25:19] OK, I'll have a look at that too [23:39:30] awight K4-713 what tech area is the unsub page? [23:39:45] Buh. Bulk emails? [23:39:56] I'd put it there. [23:40:06] hehe call the librarian! [23:40:42] yeah re that: untranslated stuff is a pretty bad donation experience [23:51:30] (PS1) Awight: WIP (FR #1771) Coinbase file import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/144621 [23:52:34] atgo: do you know if we're getting custom reporting support from Coinbase? [23:52:43] awight what do you mean? [23:53:14] atgo: their guy just mentioned what sounds like generic reporting, but the template file I have is definitely something custom that's been worked out. [23:53:26] so, either he doesn't know about our arrangement, or I have the wrong template file. [23:53:38] yeah i was kind of wondering about that... [23:54:44] i think getting on a quick call with them would probably be the best [23:54:48] maybe weds? [23:54:54] atgo: honestly, I would prefer to use their builtin thing, I have no idea how we arrived at the template file I found. I couldn't find it referenced in email, I think someone pointed to it on my screen. [23:55:21] atgo: a custom solution will probably just cause more friction over time than it helps. [23:55:23] let me ask rosie about it [23:55:25] k