[00:31:12] (PS2) Awight: WIP (FR #1771) Coinbase file import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/144621 [00:37:11] (PS1) Awight: (FR #1771) Skip lines before the headers in malformed CSV files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145178 [00:37:13] (PS1) Awight: (FR #1771) Some UI cush to make uploading more pleasant [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145179 [00:37:15] (PS1) Awight: (FR #1771) Add "Bitcoin" payment instrument [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145180 [00:37:17] (PS1) Awight: (FR #1771) Only perform settlement conversion if != USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145181 [00:37:20] K4-713: ^^ that one [00:37:59] yow [00:39:35] awight: ...but that was part of the earlier thing I was looking at. [00:39:36] (PS1) Awight: Fix old schema migration so that it is idempotent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145183 [00:39:38] (PS1) Awight: (FR #1771) Coinbase report importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145184 [00:39:44] K4-713: yeah I split the patch up [00:39:51] cos... we might need to revert for example [00:40:08] Gotcha. So... should that patch be dependent on what it's dependent on? [00:40:29] the order is screwy, whatev. I can rearrange if anyone picks a bone with the predecessors [00:40:50] u can still CR+2 [00:40:58] k. Just making sure you knew that it wouldn't merge. [00:41:09] (CR) Katie Horn: [C: 2] (FR #1771) Only perform settlement conversion if != USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145181 (owner: Awight) [00:41:23] want to review the predecessors ? ;) [00:41:43] You're asking the wrong question. [00:41:46] Am I going to? Yes. [00:42:01] hehe this should be enuf to send us all home [00:42:16] I'm already home! [00:42:17] (PS2) Awight: (FR #1771) Coinbase report importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145184 [00:42:48] I sent myself. [00:43:35] that is honestly my biggest gripe with WFH: nowhere to turn for respite [00:43:59] Or a better penalty box? [00:44:33] Heh. I used to have an officeless job. Nowhere else to be but home. [00:44:40] Basically, I hated it. [00:45:02] yes, I see. You show up at 9 like a cuckoo clock. [00:45:34] heh [00:46:38] hmmmm... [00:46:42] awight: I don't get it. [00:46:43] https://gerrit.wikimedia.org/r/#/c/145178/1/sites/all/modules/offline2civicrm/ChecksFile.php [00:47:03] How does $numSkippedRows ever become nonzero? [00:47:51] K4-713: oh in a later patch :p [00:48:00] * K4-713 squints [00:48:17] I see how it is. ;) [00:48:30] phew. I was about to open gerrit and kill my browser [00:50:14] (CR) Katie Horn: [C: 2] "I am assured that this is just setup for a later patch in which the skipped rows are actually counted somewhere." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145178 (owner: Awight) [00:50:42] point taken, I went too granular with those patches [00:51:05] Actually, I'm a fan of the overall direction... [00:52:05] So long as no single patch causes breakage if taken alone, I'm fine. [00:52:17] Just... might need some commentary. [00:52:26] that is true [00:52:35] aargh this is exposing all sorts of weird things. [00:52:42] heh [00:52:44] we assume 2 decimal places... [00:52:52] Yeah, well... [00:53:14] * K4-713 points emphatically at stale CLDR card [00:53:19] (PS3) Awight: (FR #1771) Coinbase report importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145184 [00:53:25] meh, it's worse than cldr [00:53:55] No, I mean, I'd worry about the 2 decimal places if DonationInterface (upstream) didn't do the same thing... which CLDR would change. [00:55:11] oh? I think a few currencies have three places [00:55:34] "source" preserves the original info, at least. [00:55:46] Yeah. [00:55:55] CLDR knows about decimal places. [00:56:12] That's how DI was going to know, too. [00:56:31] That, and a zillion other things we should have sane defaults for. [00:56:45] omg, Civi uses php money_format internally [00:56:55] * K4-713 eyebrows [00:57:14] That's... cute. [00:57:34] i know, after all the rogue framework-buildign [00:58:06] (CR) Katie Horn: [C: 2] (FR #1771) Some UI cush to make uploading more pleasant [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145179 (owner: Awight) [00:59:00] (CR) Katie Horn: [C: 2] (FR #1771) Add "Bitcoin" payment instrument [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145180 (owner: Awight) [00:59:18] (Abandoned) Awight: WIP (FR #1771) Coinbase file import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/144621 (owner: Awight) [00:59:40] (CR) jenkins-bot: [V: -1] (FR #1771) Only perform settlement conversion if != USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145181 (owner: Awight) [00:59:55] huh [01:00:00] * awight is looking [01:00:45] Console... not... found? [01:00:52] K4-713: oh it just needs 145180 to be submitted [01:01:05] * awight goes and kicks all the dominoes [01:02:29] Still says V -1, but it's merged now. [01:02:34] uhrm. [01:02:45] it was just the dependency, i think [01:03:00] Yeah, but that shouldn't happen. [01:03:55] (CR) Katie Horn: [C: 2] Fix old schema migration so that it is idempotent [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145183 (owner: Awight) [01:04:46] Now the real one. :) [01:09:01] (PS1) Ssmith: Add about page [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145193 [01:09:12] eeeeeeee, so exciting. [01:09:26] (PS1) Awight: (FR #1771) Source data fields for check imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145194 [01:09:29] K4-713: one more [01:09:31] pizzzacat's thing, I meant. :p [01:09:42] if anyone feels like doing CR on that….I can get it up on lutetium and everyone will know wtf is up with Dash :) [01:09:55] K4-713: heckyeah! You can port forward lu:8087 and take a look! [01:09:58] * K4-713 goes ~squee~ [01:10:02] oh what pizzzacat said [01:10:05] noo not yet it's borked [01:10:11] awight you're ruining my plan [01:10:17] I'm not going yet. [01:10:30] * awight livetweets that it's perfect and ready [01:10:36] hahaha [01:10:53] when I merge that patch in, I'll send out an email so people can see the barren Dash with technical infos writ upon it [01:11:06] I'm all stuck reviewing file reformatting, and nobody else can get there. [01:11:13] then next time it will contain actual freaking widgets :p [01:11:49] * K4-713 goes ~squee~ again [01:12:20] I am the excitement. [01:12:40] Not the walrus? [01:13:01] Coo Coo Cachoob... or something. [01:15:10] K4-713: can you also take a look at https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1771 and let me know if there are any obviously missing breadcrumbs you'll need when you are compelled to deploy this tomorrow? [01:15:17] Sure. [01:15:20] And while you're here: [01:15:26] rtrim( number_format( floatval( $msg['original_gross'] ), 10 ), '0'); [01:15:29] baahahaha [01:15:32] what [01:15:50] I have some new emotions now. [01:15:51] * awight turns up the volume on Institutionalized [01:16:58] ...which brings me up to seven total. [01:17:23] I just... kept adding bad things until the output was right [01:17:25] awight: Did that 10 come from somewhere definitive, or did you just throw a dart? [01:17:28] but you know that. [01:17:46] K4-713: sure, cos bitcoin is usually handled at a minimum of 8 decimals [01:18:01] eg [01:18:02] https://bitcointalk.org/index.php?topic=8657.0 [01:18:34] the 8 is not a hard limit, they say. So I made us 20 years future compatible [01:18:46] and then Civi rounded to the nearest $40 [01:19:00] bahaha [01:20:01] awight: I guess I was hoping that somebody did something so that we know how frequently we're going to have to do a schema change to fit all the numbers in civi's occasionally surprising mysql data type choices. [01:20:19] But, F it, I guess. [01:20:35] oh. dear I hadn't gone that far down. I stopped at money_format, which truncates to two unless you smack it. [01:20:49] Well, then really F it. [01:20:57] you are correct: `original_amount` decimal(20,2) DEFAULT NULL, [01:21:31] To its defense, decimal is a much better storage type than float. [01:21:37] for money. [01:22:53] I suppose it might be a good idea to... wrap something in something that will scream when we hit that wall. [01:23:10] And be *very* precise about what to do next. [01:23:31] Precisely where that should go, I'm not entirely sure yet. [01:23:44] Normalization seems like a not-evil choice for placement. [01:26:13] But then you can't really do that float incantation in the import file definition thingy. [01:27:06] sorry. i became horizontal. [01:27:25] I understand. [01:27:50] The digits thing is limited by the bitcoin protocol, so we're okay for the immediate future [01:28:53] grumble grumble endlessly inflationary grumble [01:29:23] for some reason I can never find it... but the long-term trend of bitcoin is only down... [01:29:24] Or rather, the other one. [01:30:07] I always want inflation and deflation to mean the opposites of what they actually... [01:30:13] ...yeah. [01:30:40] inflation is when rich people screw us, and deflation is entirely similar :p [01:30:55] coz, if your dollar inflated (like, with a bicycle pump), you'd have a bigger and presumably more formidable dollar. [01:31:11] hah [01:31:22] It's all backwards. [01:32:00] (CR) Katie Horn: [C: 2] (FR #1771) Coinbase report importer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145184 (owner: Awight) [01:32:19] You keep committing things. [01:32:27] it's the frosting. [01:33:14] Oh! That. Well, of course. [01:33:36] (CR) Katie Horn: [C: 2] (FR #1771) Source data fields for check imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145194 (owner: Awight) [01:34:56] Is that all the requirements? Assuming that the test import they sent us gets processed correctly? [01:35:05] (PS1) Awight: (FR #1771) Skip lines before the headers in malformed CSV files [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145201 [01:35:07] (PS1) Awight: (FR #1771) Some UI cush to make uploading more pleasant [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145202 [01:35:09] (PS1) Awight: (FR #1771) Add "Bitcoin" payment instrument [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145203 [01:35:11] (PS1) Awight: (FR #1771) Only perform settlement conversion if != USD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145204 [01:35:13] (PS1) Awight: Fix old schema migration so that it is idempotent [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145205 [01:35:15] (PS1) Awight: (FR #1771) Coinbase report importer [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145206 [01:35:16] K4-713: I hope so. [01:35:17] (PS1) Awight: (FR #1771) Source data fields for check imports [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145207 [01:35:24] Stampede! [01:35:29] K4-713: I'm gonna run a live test using the data we have so far... [01:35:35] Do it. [01:35:39] K4-713: refunds are untested. Scary. [01:35:51] Wait, they didn't throw a refund in there? [01:35:53] hopefully the failmail will be nonfatal. [01:36:05] maybe they aren't appearing in the file we need to use. [01:36:07] Or, do we need to wait a few and have them refund one of the test transactions from round 1? [01:36:15] Or, rather, more than one. [01:36:26] No, no refunds at all [01:36:34] Actually, we should test the refund workflow ourselves. [01:36:39] PPena wanted to wait until the first stuff settled or something [01:36:43] Friday [01:36:54] I want to make sure that works as intended. [01:37:12] (CR) Awight: [C: 2 V: 2] (FR #1771) Skip lines before the headers in malformed CSV files [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145201 (owner: Awight) [01:37:20] (CR) Awight: [C: 2 V: 2] (FR #1771) Some UI cush to make uploading more pleasant [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145202 (owner: Awight) [01:37:26] Bah, Friday. [01:37:36] (CR) Awight: [C: 2 V: 2] (FR #1771) Add "Bitcoin" payment instrument [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145203 (owner: Awight) [01:37:45] (CR) Awight: [C: 2 V: 2] (FR #1771) Only perform settlement conversion if != USD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145204 (owner: Awight) [01:37:52] (CR) Awight: [C: 2 V: 2] Fix old schema migration so that it is idempotent [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145205 (owner: Awight) [01:38:00] (CR) Awight: [C: 2 V: 2] (FR #1771) Coinbase report importer [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145206 (owner: Awight) [01:38:12] K4-713: that way, it can be an emergency [01:38:19] (CR) Awight: [C: 2 V: 2] (FR #1771) Source data fields for check imports [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145207 (owner: Awight) [01:38:35] ...emergency inflation. [01:38:41] hehe [01:40:05] well, I think I'm going into monitoring mode. I'll hang out if you're deploying and testing now, though. [01:40:24] !log update civicrm from 108802336e4d5f4aab9a6dbfa0ea434bddae0060 to 15cf86cb109a448f1982da9c91215eec73f28499 [01:40:30] Logged the message, Master [01:40:33] And there it goes. :) [01:40:37] K4-713: that would be awesome if u want to keep a finger by the red button [01:40:44] yep [01:40:47] which would enable me to go home [01:40:56] oooh [01:41:01] Yeah, totally. [01:41:04] Relocate [01:41:06] !log update crm schema to wmf_civicrm 7020 [01:41:10] Logged the message, Master [01:41:41] If anything goes off, I'll disabled jobs and we can clean up later. [01:41:48] perfect [01:42:07] eff. whitescreen [01:42:15] orly [01:42:17] How? [01:42:21] Nothing... [01:42:21] iknow. stupid drupal registry [01:42:25] oh [01:42:28] gah [01:42:44] Looks fine to me now. [01:42:58] after attempted import... [01:43:04] oic [01:43:11] et voila. [01:43:19] Checks import complete. 22 imported, not including 0 duplicates. [01:43:58] 22 results in the search. [01:44:16] K4-713: woot. [01:44:19] remote hi-5 [01:44:43] :) [01:45:23] Heh, and it's sending Thank You emails. [01:45:35] excellent [01:45:46] does it say "BTC 0.00" ? [01:45:49] I bet. [01:45:55] that will be embarrassing. [01:46:15] There's that new emotion again. [01:46:36] ...in addition to the "embarrassing". [01:47:19] It's the way I feel about currencies that are expressed in *five more decimal places* than any of the other currencies in anywhere, have. [01:47:57] And six more than your CRM assumes. [01:48:20] Oh, but this is an interesting thing to raise... [01:48:48] ...Donors in the US will need the USD amount on those Thank You letters to do the tax write off. [01:48:56] eff. [01:49:05] Because: Property needs the currency value. [01:49:15] Funny Joke. [01:50:12] Ok. I have to put my head in the sand now. Good luck tomorrow. [01:50:25] bahahaha... yeah. Thanks. [01:50:33] K4-713: are you sure about the USD thing? That might save us a lot of heartache. [01:50:42] And, can we do the same thing for donors abroad? [01:50:46] I'm going to go ahead and be sure tonight and ask questions tomorrow. [01:50:56] hehe. [01:51:28] Very interesting. OK I might knock that out tonight if nobody has licked it. [01:51:42] I'm good with that. [01:51:58] I'm certainly not going to touch it. :D [01:52:10] cya [05:53:52] !log edit CRM Drupal permissions [05:53:57] Logged the message, Master [06:25:06] (PS1) Awight: Correct money rule to accept any decent decimal [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/145227 [06:25:32] (PS1) Awight: update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145228 [06:38:27] (PS1) Awight: symlink of convenience [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145230 [07:06:44] (PS1) Awight: WIP (FR #1771) Never send tax letter in virtual currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145231 [07:22:12] (PS2) Awight: (FR #1771) Never send tax letter in virtual currency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145231 [07:30:00] (PS1) Awight: typo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145233 [07:36:42] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/145028 (owner: Ejegg) [16:31:57] (PS3) Ejegg: Add dates to banner-hiding cookies (client side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144853 [16:32:14] (CR) jenkins-bot: [V: -1] Add dates to banner-hiding cookies (client side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144853 (owner: Ejegg) [16:35:18] (PS4) Ejegg: Add dates to banner-hiding cookies (client side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144853 [16:41:01] (PS3) Ejegg: Add dates to banner-hiding cookies (server side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144991 [16:48:40] (CR) Ejegg: "With this new change, close button clicks will begin sending a reason along with the duration as soon as the client-side portion is live. " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144991 (owner: Ejegg) [17:45:17] (CR) Ejegg: [C: 2] "Looks good for now. Could make the list of virtual currencies configurable in case we start taking other cryptocoins/frequent flyer miles" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145231 (owner: Awight) [18:55:21] mwalker is all this failmail anything to worry about? [18:55:43] I dont actually know... [18:56:05] hmm [18:56:11] alrighty [18:56:27] I was wondering that earlier [18:56:35] but given that I have failmail from last night [18:56:46] I figured if awight or k4 thought it was a problem they would've disabled things [18:56:56] k4 is home sick and awight is OOO [18:57:04] i assume it's no big deal [18:57:20] it looks like somethign is leaving a bunch of extra zeroes at the end of the dollar amount [18:58:25] oooh maybe this is the same AZ lockbox thing rosie brought up [18:59:00] I thought that was different; that there the agents couldn't log in to civi [18:59:04] yeah you're right. [19:00:14] ccogdill do you know anything about all this failmail we've been getting? [19:00:28] I assumed that was a result of BTC [19:00:32] but haven’t had a chance to look into it [19:00:53] given the extra zeros that seems likely; and there was an update to civi yesterday [19:00:58] but I dont know if its safe to revert it [19:02:08] because we updated the database schema [19:02:20] hmm ok [19:02:25] that's what i figured too [19:03:07] hmm [19:03:10] nevermind atgomez [19:03:17] huh? [19:03:17] first one I pulled up is an amazon transaction [19:03:27] yeah... but maybe it's something that changed with the BTC work [19:03:28] I thought these were all btc test transactions [19:03:31] okay [19:03:47] will these make it into civi properly once the BTC stuff is fixed? [19:04:09] i'll follow up on it... i'm not actively worried about it [19:04:14] this could be a bit of a concern for email sends, so wondering if it’ll still be happening next week [19:04:32] we don’t want to email people who contributed (even if the contrib isn’t in civi) [19:04:41] yeah [19:05:04] i mean, the overlap there is in all likelihood quite small, but i get what you're saying. once adam and/or k4 are online i'm sure we'll get a quick answer [19:05:14] cool [19:05:29] as long as we can talk about it by the standup and let Megan and Jessica know, I think that’s fine [19:43:50] (CR) Ejegg: "Maybe /(^-?\d+(\.\d+)?$)|(^-?\d*\.\d+$)/ to filter out numbers with a trailing decimal point (e.g. '15.')?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/145227 (owner: Awight) [20:13:09] (CR) Ejegg: [C: 2] "+2 for meditation among kangaroos" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145193 (owner: Ssmith) [21:34:53] ejegg standup? [22:18:02] pizzzacat1 do you want me to move the prototype review? [22:18:02] (CR) Ejegg: "Some random comments, but mostly looks good." (4 comments) [wikimedia/fundraising/crm] (dedupe) - https://gerrit.wikimedia.org/r/134998 (owner: Awight) [22:18:07] just make the event editable :) [22:18:30] right. doing now :) [22:19:24] ok atgomez: all set! [23:17:03] ejegg did you figure out if the decimal thing you were looking at was related to this? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1782 [23:17:10] i'm trying to sort out if this is a requirement for btc [23:18:25] yeah, I'm pretty sure it was [23:19:14] pretty sure which? :P [23:20:03] the decimal issue was on the list of 'More Bitcoin review' that Adam sent out last night [23:20:31] ahh cool [23:20:32] And the old code does seem to be angry with the extra digits [23:23:31] atgomez did you want to change that meeting? I think I opened it up for editing but let me know if I flubbed it [23:24:00] ahh i didn't change it. will do! [23:24:07] yeah there was some anger happenign for sure [23:34:18] (PS1) Ssmith: Redesign main page to employ sidebar [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145468