[00:19:52] (PS2) Ssmith: Redesign main page to employ sidebar [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145468 [00:26:15] (PS3) Ssmith: Redesign main page to employ sidebar [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145468 [01:15:57] (PS1) Awight: Logging; whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145480 [01:15:59] (PS1) Awight: (FR #1771) Always round money before handing off to Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145481 [01:16:01] (PS1) Awight: Slightly stronger assertion during contrib amount normalization [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145482 [01:16:03] (CR) jenkins-bot: [V: -1] Logging; whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145480 (owner: Awight) [01:16:05] (CR) jenkins-bot: [V: -1] (FR #1771) Always round money before handing off to Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145481 (owner: Awight) [01:16:07] (CR) jenkins-bot: [V: -1] Slightly stronger assertion during contrib amount normalization [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145482 (owner: Awight) [01:16:39] (PS2) Awight: (FR #1782) Always round money before handing off to Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145481 [01:16:41] (CR) jenkins-bot: [V: -1] (FR #1782) Always round money before handing off to Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145481 (owner: Awight) [01:22:38] (PS3) Awight: (FR #1782) Always round money before handing off to Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145481 [01:22:40] (PS2) Awight: Logging; whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145480 [01:22:42] (PS2) Awight: Slightly stronger assertion during contrib amount normalization [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145482 [14:17:48] (CR) Ejegg: [C: 2] Logging; whitespace [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145480 (owner: Awight) [16:35:15] ejegg: Good morning. [16:37:06] Hi K4. Feeling better? [16:37:23] A bit, yes. [16:37:27] Thanks for asking. :) [16:37:40] How's it going? Did I miss anything good yesterday? [16:37:59] not a lot - getting some of the first paypal stuff in [16:38:07] paypal stuff? [16:38:09] but we need to push a decimal update [16:38:14] sorry, bitcoin [16:38:25] Ah, yeah. That. [16:38:27] was just looking at paypal... [16:38:46] The great sprint hijacker. I saw all the decimal explosion-related failmail. [16:39:00] ...good thing it didn't require any tech work. ;) [16:39:28] hey atgomez. [16:39:37] hey there! [16:40:01] I was just about to ask ejegg if anybody had sent him docs to look at for the other potential new thing that we shouldn't call out by name in public. [16:40:11] >_> [16:40:12] <_< [16:40:30] ha i was working on that yeseterday and then things happened [16:40:34] and i didn't [16:40:36] Ahh, no docs sent to me but I started peeking at the online instructions [16:40:43] coooool [16:40:46] Heh. [16:41:11] So, the biggest problem I can see at the moment, is making sure we can actually get GC working with virtual one-time cards. [16:41:27] They assure me it won't be an issue as far as processing goes. [16:41:33] I'll believe it when I see it. [16:42:18] hmm, I would hope they get the same name/address data as a real card [16:42:50] ejegg that's what they sau [16:42:51] say [16:42:54] Also, because of the way the GC implementation goes, we need to come up with a GC form for them that *only* works with virtual one-time cards, because we will be sending the card data via api through our backend instead of doing the iframe stuff. [16:43:29] If we get any real credit cards coming in that way, we get nailed to the wall by all our extremities, because PCI. [16:43:52] ...which is, you know, exciting. And not in a good way. [16:43:55] ejegg smb://filesrv1/fundraising/Tech/Google Instant Buy [16:44:01] but.. bring the spaces with you [16:44:08] heh, cool [16:44:19] thanks, I'll check it out! [16:44:38] atgomez: ejegg: Before we go any farther with this, we *NEED* to get some kind of client-side validation that prevents sending real cc data back to us. [16:45:01] Which sort of depends on them coughing up some kind of function we can run. [16:45:14] ...to be able to tell if these cards are one-time or not. [16:45:27] ooh, that may be a challenge [16:45:29] With any luck, there will be a predictible BIN range or something. [16:45:31] Ha. [16:45:35] ^^understatement [16:45:44] BIN? [16:45:44] If we can't get that, we can't do it with GC. [16:45:54] Then we have to use WP. [16:46:13] Yeah, it's... the first 4 of a credit card or something. [16:46:18] Usually signifies the bank. [16:46:24] word [16:48:03] So, yeah. I'd say don't do anything else with that unless we can get confirmation that we can not shoot ourselves completely in the foot. [16:48:25] ejegg much research :) [16:48:29] ...in the form of "Here is a formula that tells you exactly what one-time cards always look like". [16:48:52] Then we should aggressively block both frontend and as early as possible in the backend if we see anything else. [16:48:56] ...in that workflow. [16:49:27] Or, you know... start talking to WP about this. [16:50:00] hmm, looks like we make an initial wallet API call that gives us back BIN + last 4 digits, before even redirecting the donor to their site [16:50:31] So we just check that those match the full number we get back later [16:50:55] Great. Just make 100% that can't be circumvented. [16:50:58] *sure [16:51:01] Wordmissing. [16:51:06] ejegg K4-713 to further complicate things with this... and potentially furthur frustrate, we need to wait before legal clears the contract before we can really begin this work in earnest... :( [16:51:17] * K4-713 headdesks [16:51:22] OK, I'll just inform myself for now [16:51:24] K4-713.. i know [16:51:26] hahaha [16:51:31] i. know. [16:51:49] That's it. I'm going to use the elevator phone. [16:51:55] ...they said "any problem". [16:52:04] heh [16:52:46] i... yeah. [16:52:52] so ejegg go forth with all the researching! [16:53:04] Cool. [16:55:31] Oh, I was wrong about the initial API call... It's for the order review screen, and actually gives the network (i.e. Visa/Mastercard/Discover) and the last 4 of the ACTUAL card they'll use, so we can show them which card before they hit the final submit button [16:56:06] But then we make an API call to get the virtual card, rather than taking those details in from get/post variables [16:56:33] So unless goog starts returning real card numbers from the API call we should be safe [17:00:40] ejegg: u got time for https://gerrit.wikimedia.org/r/#/c/145481/ ? [17:00:53] That should stop the failmails, at least... [17:02:14] ejegg: also, wrt 144853 and other things that the whole team might be interested in, you can add the fr-tech group as a reviewer and it will include us all [17:02:48] if you want a list of sig figs for each currency, there's one in my interview code task! [17:03:02] ejegg: oh woot! [17:03:32] hey, what's the etiquette/procedure for collaborating on an unmerged changeset? [17:03:46] ejegg: good question. lots of communication [17:05:17] ejegg: do you have a PS in mind? [17:05:45] was going to tack the sig figs list into that one [17:05:57] But for now I'll just +2 it, since it's an improvement [17:06:02] and needs deploying asap [17:06:22] ejegg: ah yes that sounds right in this case [17:06:32] (CR) Ejegg: [C: 2] (FR #1782) Always round money before handing off to Civi [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145481 (owner: Awight) [17:09:11] awight: for the 'slightly stronger assertion' change, was something BTC-related making us now get just one of gross/currency populated? [17:09:39] ejegg: meh, no, it's just something I noticed while in there [17:09:57] (CR) Ejegg: [C: 2] Slightly stronger assertion during contrib amount normalization [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/145482 (owner: Awight) [17:11:29] (PS1) Awight: (FR #1771) Never send tax letter in virtual currency [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145590 [17:11:31] (PS1) Awight: Logging; whitespace [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145591 [17:11:33] (PS1) Awight: (FR #1782) Always round money before handing off to Civi [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145592 [17:11:35] (PS1) Awight: Slightly stronger assertion during contrib amount normalization [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145593 [17:11:55] (CR) Awight: [C: 2] (FR #1771) Never send tax letter in virtual currency [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145590 (owner: Awight) [17:12:03] (CR) Ejegg: [C: 1] "Looking good! Should remove npm-debug.log, though. Maybe add some cursor style for the sidebar links too?" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145468 (owner: Ssmith) [17:12:05] (CR) Awight: [C: 2] Logging; whitespace [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145591 (owner: Awight) [17:12:10] (CR) Awight: [C: 2] (FR #1782) Always round money before handing off to Civi [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145592 (owner: Awight) [17:12:18] (CR) Awight: [C: 2] Slightly stronger assertion during contrib amount normalization [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/145593 (owner: Awight) [17:23:36] (PS4) Ssmith: Redesign main page to employ sidebar [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145468 [17:25:50] (CR) Ejegg: [C: 2] Redesign main page to employ sidebar [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145468 (owner: Ssmith) [17:33:31] (CR) Awight: [C: -1] "Minor issues. You'll also want to coordinate a patchset in operations/mediawiki-config : wmf-config/CommonSettings.php" (6 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144853 (owner: Ejegg) [17:53:11] (CR) Awight: "Why would we want to filter those out? I think that's a legit edge case." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/145227 (owner: Awight) [18:04:58] (CR) Awight: [C: 1] "This is awesome! I'm withholding merge until the prerequisites are deployed, alternatively, you could create a topic branch for this and " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144991 (owner: Ejegg) [18:07:02] (PS2) Awight: Cleaning up the payments error logs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144108 (owner: Katie Horn) [18:07:22] (CR) Awight: [C: 2] Cleaning up the payments error logs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144108 (owner: Katie Horn) [18:07:31] (Merged) jenkins-bot: Cleaning up the payments error logs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144108 (owner: Katie Horn) [18:17:23] awight: for the special: HideBanners comment about breaking out the 'donate' assumption, did you mean add in the Request->getText('reason') with 'donate' as the default, even in the first commit? [18:18:03] ejegg: nah, it's really minor but I was suggesting a variable $reason = 'donate', with a short comment explaining what the placeholder is for. [18:18:20] It's just in case other devs find issues, look at our code, want to understand... [18:18:21] Oh, we also need to update the img tags on the thank you page [18:18:57] yes! [18:18:59] add reason to them so we know which requests are coming from old JS [18:19:14] That's just a regular metawiki page, right? [18:19:18] there used to be an onwiki thing to cause HideBanners requests on all sister sites [18:19:38] ejegg: I can't remember. That's really something that should be added to our documentation. [18:20:03] * awight gives employers another dollar to see what happens [18:20:39] you know you can just hit the page... [18:21:15] ejegg: ah! [18:26:25] awight: aha! {{Hide banners}} [18:26:30] http://wikimediafoundation.org/w/index.php?title=Template:Hide%20banners&action=edit [18:28:06] ejegg: nice spelunking. Endocument por favor! [18:28:24] any suggestion where to put this doc? [18:28:37] wikitech.../Fundraising... [18:28:42] will do [18:28:48] um that is weird. English-only? [18:29:04] Maybe this isn't the right thing? [18:29:05] whoa, that IS odd [18:29:31] I did see that the current bannerController code reads from a list of sites to hide on... [18:30:04] the weak sauce. wgNoticeHideUrls [18:30:13] yeah, that's just for the close button though [18:30:14] roughly the same list. [18:30:17] hrmph. [18:30:29] I can't imagine either of these actually DTRT [18:36:19] ejegg: u know... I think this is actually explainable, the cookie must be a domain-wide wildcard. [18:38:04] oh, cool [18:44:56] it is domain wide [18:45:06] great! [18:45:07] we actually use the CentralAuth cookie domains [18:45:51] (PS5) Ejegg: Add dates to banner-hiding cookies (client side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144853 [18:53:00] (PS4) Ejegg: Add dates to banner-hiding cookies (server side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144991 [19:05:34] (PS1) Ssmith: Merge branch 'master' into HEAD [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/145615 [19:05:37] (CR) jenkins-bot: [V: -1] Merge branch 'master' into HEAD [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/145615 (owner: Ssmith) [19:06:48] (CR) Ssmith: [C: 2 V: 2] Merge branch 'master' into HEAD [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/145615 (owner: Ssmith) [19:06:55] (CR) jenkins-bot: [V: -1] Merge branch 'master' into HEAD [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/145615 (owner: Ssmith) [19:08:23] pizzzacat, to answer your question more fully; a git merge driver for gerrit probably wouldn't be that hard to write; you would in some way detect if a merge commit was needed and run the gerrit commit hook on that [19:08:32] but... I've never written a merge driver [19:08:38] so I dont know how hard it would actually be [19:09:24] might be a cool side project [19:09:39] that I could do when I'm done with all my other million sideprojects [19:10:13] I sympathize completely :) [19:15:38] yeah I have this flying pizza drone I'm working on [19:23:10] yo team - i'll be back in the afternoon and may miss standup. Hopefully reachable by email until then :) [20:10:16] (PS5) Awight: DO NOT DEPLOY: Add dates to banner-hiding cookies (server side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144991 (owner: Ejegg) [20:10:31] ejegg: ^^ tweaked the comment for safety [20:11:33] (CR) Ejegg: [C: 2] "Ok, so long as those don't perplex Civi." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/145227 (owner: Awight) [20:12:33] ah,thanks! [20:12:37] ejegg: shall I merge? [20:13:13] go ahead with the client side [20:13:20] awesome [20:13:44] ejegg: there's also the operations/mediawiki-config change... [20:14:00] I can walk u through deployment if you want. [20:14:24] oh right, that would be grwat [20:14:50] (CR) Awight: [C: 2] "We still need to deploy an operations/mediawiki-config change to make the durations match existing configuration. That should happen befo" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144853 (owner: Ejegg) [20:15:03] (Merged) jenkins-bot: Add dates to banner-hiding cookies (client side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144853 (owner: Ejegg) [20:15:26] ejegg: first step is to merge or cherry-pick from CentralNotice -master into the wmf_deploy branch [20:16:16] ejegg: then, we have the option of deploying manually, or letting the change go out with the weekly "train" [20:16:27] https://wikitech.wikimedia.org/wiki/Deployment [20:16:40] https://wikitech.wikimedia.org/wiki/How_to_deploy_code [20:16:59] ok, let me skim those [20:17:22] https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Case_1b:_extension_changes specifically [20:18:00] i may be slow - am sshed in from phone. [20:18:05] ha! [20:18:21] locked self out of apt :P [20:18:38] but roommate is on the way [20:18:55] ejegg: u should push the config change first, you can add that to the semidaily "SWAT" deployment calendar and make yrself available on IRC [20:19:12] ejegg, can we do tues from noon pdt? or are you coming back from something? [20:19:12] ejegg: ok good time to do some dry reading then ;) [20:19:54] meeting about shop finiahes at noon tues,so that works [20:21:51] ^^ is that re: deployment, or something else? [20:24:29] awight, it's about fixing up the centralnotice proxy rfc [20:24:37] sumanah has been poking me about it for ages [20:24:55] and you threw it at elliot the other day; so i figured he'd be interested in the conversation [20:25:12] mwalker: oh cool. I'd like to sit in, too, I still have thoughts about how I'd like that to work [20:27:04] awight: that will be one config puah to add the new var, then another post-deploy to remove the old one, right? [20:28:06] never mind, of course it would be [20:28:15] ejegg: exactly [20:49:02] ejegg: u need an irc cloak! [20:49:37] ah, true! I think I applied for one - let me see what happened with that [21:19:08] (PS10) Awight: initial port of the dedupe review UI [wikimedia/fundraising/crm] (dedupe) - https://gerrit.wikimedia.org/r/134998 [21:19:53] (CR) Awight: initial port of the dedupe review UI (4 comments) [wikimedia/fundraising/crm] (dedupe) - https://gerrit.wikimedia.org/r/134998 (owner: Awight) [21:43:06] thks, [21:43:12] awight [21:43:44] *thanks [21:46:04] ejegg: uh oh, 4 whaat? [22:29:13] (CR) Ejegg: [C: 2] "Looking good, warriors" [wikimedia/fundraising/crm] (dedupe) - https://gerrit.wikimedia.org/r/134998 (owner: Awight) [22:29:40] wary...oars..? [22:30:37] come out and play-ee-ay [22:31:41] www.imdb.com/title/tt0080120 [22:32:39] damn. that is the danger of making references--explaining to uncultured coworker [22:33:33] worth watching. also, streets of fire [22:34:19] ejegg: that does remind me of the brush fire we encountered in Haarlem... [22:34:48] oh dang, that's right! [22:34:57] volunteer NYFD [22:35:53] ejegg: one more crazy thing to know about deployments: http://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap [22:36:18] ejegg: also, if you're curious, I just got schooled in wikimedia-dev, apparently there is this very useful beta cluster which I was not aware of [22:37:49] oh rly? let me scroll back -dev a bit... [22:38:24] teal deer, you can make config changes to the -labs files and it will be deployed by Jenkins [22:39:01] sort of annoying, but it beat the previous process, which AFAIK was apparently making changes in production config and selectively deploying to test. Which I imagine didn't work at all. [22:54:56] pizzzacat: I am eating the sugar pills. [22:55:15] awight go for it, I couldn't stomach them [22:55:52] most effective placebo [22:55:59] I'm hoping for placebo [23:03:46] awight on this one that you just changed... that was deployed in september 2012 [23:03:48] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/502 [23:04:44] atgo: crap. well we need a new iteration, I'll make a new card. [23:05:00] ok [23:06:51] * awight grumbles about atgo having an RSS feed [23:07:11] this is owl country... [23:07:20] hehehe [23:07:28] this is helpful! otherwise you never would've found it :P [23:08:31] atgo: RSS has no authentication, btw, it's interesting what else you can subscribe to... [23:08:51] oh? [23:09:25] meh, I pretty much wardial my newspaper feeds and that seems to work [23:10:20] awight tech area? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1787 [23:11:05] atgo: done. we have to do something about the tech areas. [23:11:11] ok! i'm down. [23:11:25] also, I don't have privs to do this, but the quick card creation form needs to include all the fields we require. [23:11:40] i agree [23:11:44] and also.. i will look into it [23:12:15] atgo: yeah I did look at the area issue a few times, and I think the difficulty is mostly that our code is actually straddling multiple pieces of functionality [23:12:23] * awight dies of adverbs [23:12:29] ha [23:12:32] well.. we can change i [23:12:32] t [23:13:10] Maybe the right approach is to draw the ideal component boundaries and use those as tech areas? [23:13:15] blargh. [23:13:41] yeah... we can chat about it more [23:13:51] i am not sure that i CAN move the properties into the defaults [23:14:12] atgo: now? that would be better than doing my job. [23:14:48] ha yeah.. i mean k4 set it up in the first place so i'd want her reasoning and she seems pretty deep into something [23:15:08] ok fair [23:15:35] although I think we can safely say it was a good first pass and all she will say upon emerging from the current thing is, "awesome, fix it" [23:15:44] probs [23:15:48] let's look at it on monday [23:16:05] i'm trying to figure out the other thing you want changed [23:16:11] * awight scratches fleas [23:16:31] i heard a thing once (that i am skeptical of, but will share nonetheless) [23:16:49] that honey's breed came about in part to sleep in beds with people and attract the fleas away from tehm [23:16:56] nonsense [23:16:57] because she's a big pile of fuzzy flea haven [23:17:04] but I wouldn't put it past filthy europeans [23:17:49] K4-713... quick question about mingle if you've got a chance. no worries if not [23:18:13] atgo: Sure. IRL? [23:18:35] either way... just.. is it possible to change what properties are shown on the "add new card" box? [23:18:41] Yep. [23:18:50] And it's in *the* stupidest place. [23:19:03] ... [23:19:04] oh YAY [23:19:20] That's all I remember: That it's somewhere intensely, unbelieveably stupid. [23:19:34] I know this doesn't narrow anything down. [23:19:36] ...wait 1. [23:19:39] * awight saws a bit at the chains binding us to Mingle [23:19:54] At this point, you're better off chewing on arms. [23:21:51] * awight chews on live arms, in that case [23:22:26] awight [23:22:30] new stupidity. [23:22:36] * awight raises gnawed arm [23:22:47] in order for somethign to show up on the "add card" modal.... [23:22:53] it has to have a set default value. [23:22:56] i . just. ugh. [23:23:29] * awight sniffs a bit [23:23:40] is it 6:30 yet [23:24:02] ...I'm going to put that one back in the memory vault so I don't have to think about it anymore. [23:24:10] it is in CST [23:24:18] omg [23:24:19] win [23:26:05] https://www.youtube.com/watch?v=X_7wdpGvTms [23:26:14] for the best line, get to about 2:20 [23:26:20] 2:30 for the punch line [23:27:27] atgo: wow, thank you [23:27:35] WWJBD [23:27:38] i KNOW [23:27:40] and then THERE HE IS [23:27:52] "come to think of it, it's always on 5 in margaritaville" [23:31:56] mingle just did another useless UI thing [23:32:04] "project admin" is now a tab [23:32:08] it's a tabbier tab than the actual tabs [23:32:50] * awight strokes evil tabby and is bitten for my trouble [23:42:09] could i.. borrow someone's phone to make my phone work? [23:42:22] i have to call AT&T and they wouldn't accept it when i did it from my laptop. [23:42:30] else i run to the store, which is also NBD [23:52:16] awight what tech area? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1372 [23:53:05] atgo: all of them, plus analysis [23:53:13] buh [23:53:25] * awight carves an escape tunnel of soap [23:54:21] and this one? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1783 [23:55:04] thanks [23:55:09] done and done :) [23:55:21] may all be a lie