[16:23:02] ejegg: Good morning. [16:23:07] What up? [16:28:43] Hi K4-713! [16:29:15] How's it going over there? [16:29:45] I'm probably going to disappear for most of the day, because at some point I thought "Meeting Mondays" were a nice idea. [16:29:54] pretty good. How was your weekend? [16:30:04] Get the pain over with early in the week? [16:30:07] K4-713: I don't know what you were smoking, but I want some [16:30:30] ejegg: Well, I got a depressingly small patch of my yard weeded. [16:30:33] ...Unrelated to marktraceur's question. [16:30:44] She says, defensively. [16:30:50] Yeah, I mean, the thought was that I'd get all the meetings out of the way on Monday. [16:30:56] I didn't know they'd just make more. [16:30:58] Hah! Anyone want to review a settings change for banner cookie changes? https://gerrit.wikimedia.org/r/#/c/145736/ [16:31:25] speaking of meetings... K4-713 i've got a few PCI calls coming in :/ [16:31:36] atgo: ohai. Yeah, I saw that. [16:31:41] Uhm. [16:31:46] Anything today? [16:32:16] ejegg: I'm looking at the banner thing now. [16:32:24] woot [16:32:29] K4-713 i think not... will let you know as i sift through these [16:33:22] atgo: Thanks. I can't... seem to remember when anything is supposed to happen unless it's in my calendar, so events would really help in the area of... my head not falling off. [16:33:42] yeah me too [16:33:47] :) [16:33:48] i'm going through the emails now. w [16:34:00] for PCI, we are "SAQ A - Card-not-present merchant", right? [16:35:30] I think so. But, they published a whole lot of new rules in February, and we're trying to figure out if we have to jump down to level D or something. [16:35:44] ah, gotcha [16:35:59] So, I want to... pay somebody to tell us these things. [16:36:38] imho, it's sort of insane that we (fr-tech engineers) were left to sort it out for this long. [16:36:58] really, it's not even the legal department? [16:37:07] If by "sort of" I actually mean "BLARHGAHRDBGH." [16:37:40] I think they have some comments sometimes. [16:37:50] But, not nearly often enough for my sanity. [16:37:58] eek [16:38:11] Right? [16:38:39] i mean, sure, ask us to review the technical claims [16:38:57] I'd worry if they didn't. [16:39:00] So either a consultant for PCI compliance or additional funds for K4-713's therapist [16:39:06] heh [16:39:13] marktraceur: Accurate! [16:39:58] I'm just saying, if I suddenly move up a deserted mountain and chop wood for 8 hours a day for the rest of my life, nobody gets to be surprised. [16:41:38] ejegg: So, these cookie durations are... the TTL? I guess I could look at the other commit you reference. [16:42:18] yeah, they're both the expiration and a JS-readable value [16:42:28] Perfect. :) [16:45:52] hey Jeff_Green! [16:45:55] hey [16:47:22] howdy! have you had a chance to look at the zendesk thread at all? [16:47:29] I just saw it yeah [16:47:33] responding [16:47:35] ahh cool... thank you [16:48:42] urf [16:49:13] Hi Jeff_Green. I... don't have anything else. Just "hi". And Good Aftermath. :) [16:49:24] hi! [16:49:38] did we ever come up with the appropriate response to Good Aftermath? [16:49:45] I feel like there should be something... [16:49:47] Hmm... [16:49:49] Yeah, like... [16:50:09] I'll think about it. [16:50:10] and we praise our corporate overlords? [16:50:13] hahaha [16:50:16] hmm. [16:50:27] and our ducks are not in a row! [16:50:43] :D [16:50:48] Nonlinear ducks. [16:51:03] Jeff_Green: Are you going to Wikimania this year? [16:51:22] hmm, wasn't planning on it. in fact I haven't even thought about considering it. [16:51:29] it's in London or something? [16:51:32] Yep. [16:51:43] tempting. I've never been there. [16:52:02] you going? [16:52:17] Yep! So is pizzzacat. I could come up with something we should work out on pub napkins pretty easily. [16:52:34] +1 [16:52:36] ha [16:52:46] i think it's not feasible for me [16:52:52] Yeah, it's pretty close. [16:52:56] summer is a f'ing pita with kids [16:53:08] Oh, right. Those. [16:53:09] camps [16:53:31] Heh. I remember being a kid and thinking summer camp was a huge time investment. [16:53:34] the kids are great, the scheduling and carpooling and madnesses make things more complicated than school year [16:53:39] And now I'm like: "Only a week?" [16:53:46] exactly! [16:54:08] constant schedule adjustment [16:54:17] I drove 4 kids in a minivan today [16:54:28] (some not mine) [16:54:43] Aaaaaha. [16:54:56] I remember subjecting other people's parents to that sort of thing. [16:55:37] ...demanding they play animated feature soundtracks on repeat the whole way. [16:55:54] hahahahah [16:56:08] yeah not while I'm bus driver [16:56:47] K4-713 i'm heading upstairs :) [16:56:48] You don't want a vanload of kids singing in their best toddler mouse voices? [16:56:51] hehe [16:56:53] Yeah, me too. [16:57:01] i hear frozen soundtrack is ALL THE RAGE [16:57:07] atgo: K4-713: pizzzacat: want to whiteboard about "tech area" after mtg? [16:57:08] indeed it is [16:57:08] * K4|meetings makes rageface [16:57:24] awight sure... but i'm in meetings until 1230ish [16:57:27] LET IT GO! LET IT GO! [16:57:29] blaaargh [16:57:32] so this afternoon yes [16:57:34] LET IT GO! [16:57:36] Drop it like it's hot? [16:57:38] i know awight. i know. [16:57:41] untz untz [16:57:45] hahaha [16:57:53] If somebody does that mashup, I'll give them at least five american dollars. [16:57:59] ...okay, I'm really gone now. [16:58:00] there's a website for that [16:58:01] fiverr.com [16:58:05] my son is in some kind of school-of-rock camp though [16:58:08] you can get people to do things for $5 [16:58:13] *inane things [16:58:40] they're working on Down Under along with some Imagine Dragons song I don't know [17:52:13] (CR) Awight: [C: 1] "Leaving merge for K4-713 as mentioned earlier." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140959 (owner: Ejegg) [17:53:07] ejegg: I won't ask you to do this unless it sounds fun, but it would make sense if ^^ were split into two patches: the handleRequest refactor, then the business logic part [17:53:38] Yeah, that makes sense. Let me see how much of a pain that would be [17:53:51] It's fine to not split, too, maybe ask K4|meetings if it's anxiety-provoking or not [17:54:53] awight, what's your procedure for splitting commits? [17:55:16] ejegg: lately I've been using the procedure described in man git-rebase, which is to "git reset HEAD^" [17:55:33] (with or without the rebase -i step) [17:56:06] then use add -p to get specific parts of files in a commit? [17:56:07] (CR) Awight: [C: 2] Whitespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144179 (owner: Ejegg) [17:56:17] ejegg: exactly [17:56:17] cool [17:56:20] (Merged) jenkins-bot: Whitespace [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/144179 (owner: Ejegg) [17:58:39] (CR) Awight: [C: 2] Add a 'No valid form' RapidHtml form (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/145028 (owner: Ejegg) [17:58:48] (Merged) jenkins-bot: Add a 'No valid form' RapidHtml form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/145028 (owner: Ejegg) [17:59:42] Thanks for all the reviews, awight! [18:00:12] ejegg: I should probably test that last one... U are doing things I have not seen before [18:00:39] oh? what was so novel? [18:01:16] the %-| args, and form shared across gateways. Too bad about RapidHtml, though. [18:01:48] ah, I got the args from the cc error form [18:02:05] Oh, I should check in the forms config change, too! [18:03:11] ah! I'd like to see how that's related... [18:03:31] just adds the new error form to the whitelist [18:03:43] oked for all gateways [18:04:12] hmm... [18:04:37] another thing I have not seen done yet ;) [18:09:03] you [18:09:16] 'll want this if you want to test locally, awight: https://gerrit.wikimedia.org/r/146145 [18:09:38] doing a deployment, will check in a few [19:09:20] (PS1) Ejegg: Fix @covers code coverage annotation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146168 [19:30:48] (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/146172 [19:31:01] (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/146172 (owner: Awight) [19:41:29] (PS1) Ejegg: Move gateway form logic from execute to handleRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146175 [19:41:36] (CR) jenkins-bot: [V: -1] Move gateway form logic from execute to handleRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146175 (owner: Ejegg) [19:46:51] (PS2) Ejegg: Move gateway form logic from execute to handleRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146175 [19:50:28] (PS5) Ejegg: Simplify fundraising maintenance mode [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140959 [19:52:24] (CR) Ejegg: "Rebased and split into two commits, one for the execute->handleRequest change, and one to actually check for maintenance mode in GatewayFo" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/140959 (owner: Ejegg) [21:15:12] hey pizzzacat1 [21:15:19] heyo [21:16:10] what's up atgo-meeting [21:16:27] (PS1) Katie Horn: Stop sending realtime Direct Debit messages to civi. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146269 [21:16:36] awight|lonch: Bam. ^^ [21:20:09] atgo-meeting: I see what happened. It's this: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1760 [21:20:19] Stuck in triage. [21:20:23] ahhhh [21:20:26] ok... my bad :P [21:20:29] I added the commit link, though. [21:20:33] fixing it now [21:20:37] kewl [21:20:54] Probably can deploy today if awight|lonch can do it while I'm yakking at people. [21:22:40] atgo hi [21:22:46] hey [21:22:46] sorry [21:22:57] do you have cards for the new widget? i see nada in the sprint [21:23:02] just czeching [21:23:18] oh ha nope I did not add it. thanks for reminding. [21:24:22] also atgo I don't know if you noticed, but I pulled card #1609 out from deployed and back into the current sprint…. [21:24:50] i vaguely saw that [21:24:51] and was confused [21:24:57] it needs to go into backlog I guess. basically the proxy wasn't built to allow the right access [21:25:05] but i see your comment [21:25:14] ok... i think we kick it back to "in dev" [21:25:21] Jeff was under the impression that the Dash wasn't retrieving sensitive data [21:25:27] oohhhhh [21:25:30] yeah [21:25:31] I don't know who you want to assign it to [21:25:40] since Matt is leaving [21:25:42] hmmm [21:25:45] right [21:25:52] and it's not something I know like…..anything about [21:25:57] gotcha [21:26:07] erm..... mwalker any ideas? ^ [21:29:03] hmm, there is a Drupal module called 'Proxy' [21:29:54] it wasn't very good when I looked at it [21:30:01] it made lots of assumptions [21:33:15] awight|lonch K4-713 [21:33:18] standup? [21:33:26] ack [21:33:27] brt [21:52:54] K4|meeting awight when that DD thing goes out, let me know please? [21:52:58] ejegg https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1789 [21:53:01] for IB [21:53:06] thanks! [21:53:38] K4|meeting: what/am I reviewing? [21:53:56] https://gerrit.wikimedia.org/r/146269 [21:54:30] K4|meeting just moved that into PCR [21:54:31] K4|meeting: sorry to be a jerk. Can you comment the line out and explain the reason inline? [21:55:36] awight: I thought about that, but even if we want to...shoot, I'm going to be late. [21:56:25] awight: Even if we want it to tell civi something in realtime, we're probably going to want to nuke the limbo message and do a new kind of hook. [21:56:29] K4|meeting: ok [21:56:39] K4|meeting: I'll just make a new patch to add a comment in there [21:56:57] (or just wave wands at limbo and have civi consume that, because YES LETS DO THAT NOW.) [21:57:07] durr. [21:57:10] Okay, gone. [21:57:11] (CR) Awight: [C: 2] Stop sending realtime Direct Debit messages to civi. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146269 (owner: Katie Horn) [21:57:20] (Merged) jenkins-bot: Stop sending realtime Direct Debit messages to civi. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146269 (owner: Katie Horn) [22:10:07] ejegg: did you have a config patch for review? [22:10:32] awight: https://gerrit.wikimedia.org/r/146145 [22:10:42] that was the form config [22:10:55] Katie reviewed the cookie config [22:11:21] atgo: should I create a card for "see if the durn recurring DD payments come in through audit"? We would need that before launching Austria. [22:11:43] awight do you think it's insufficient to check this with the test tomorrow? [22:12:00] atgo: oh. live test... sure, what me worry :p [22:12:08] no i mean, if we should test it more, that would be best. [22:12:26] austris is supposed to have a 2 hr test tomorrow, but we can push it if we need to [22:12:33] The only mitigating factor is, it's a huge PITA to test. [22:12:43] hm [22:12:53] well.. whatever you and K4|meeting think is best/necessary/safe [22:13:04] we do get a relatively low volume of DD to start with [22:15:23] atgo: well... I'm fine with the live test, there should be no data loss if we're diligent. [22:15:53] so we just need to make sure to follow up once the DD should come in, right? [22:15:54] like.. in a week? [22:16:00] because it's slow [22:16:04] yeah exactly [22:17:35] ok i'll add a card to the next sprint for that so we can check it first thing [22:17:37] sound good? [22:17:54] thx! [22:19:58] ejegg: uh, oh: //index.php/Special:GatewayFormChooser?uselang=en&language=en¤cy=EUR&country=ZA&paymentmethod=amazon [22:20:28] oh? let me see [22:20:30] ejegg: your no-form does work, though [22:20:40] I guess this is just Amazon adapter fail [22:21:09] ejegg: o wait, the error page is missing OWTG for some reason [22:21:26] OWTG? [22:21:31] oh, other ways to give [22:21:42] oops, let me take a look at the i18n file [22:21:56] ejegg: sorry, submodule not updated. lemme get back to you [22:22:28] ejegg: //Special:GatewayFormChooser?uselang=en&language=en¤cy=EUR&country=ZA&paymentmethod=foo [22:23:28] yeah, perhaps I should replace that redirect with the same form [22:23:44] ejegg: interesting, the issue is donate_interface-error-no-form-html vs donate_interface-error-no-form [22:23:52] was that intentional? [22:24:19] awight to check things in Civi, specifically the DD transactions coming in, which tech area makes sense? Civi: Core? [22:24:20] I added the html one for RapidHTML since the existing one was wikitext [22:24:41] let me see how hard it is to render that form from the chooser [22:24:48] atgo: "civi/drupal modules" [22:24:54] awight thanks! [22:25:08] "civi core" should be something that, long story short, we plan to upstream. [22:25:23] oooh ok that makes sense [22:25:37] so the big bucket will be civi/drupal modules moving forward probably? [22:26:02] * awight eagerly looks at pie chart [22:26:10] ohh youa lready changed them! [22:26:18] oh man. that pie chart is ridiculous. [22:27:00] that's way more awesome, though. [22:27:09] I was sort of in the crosshairs until now. [22:27:14] yeah much more usable [22:27:30] it also feels like it reflects real dev effort [22:27:35] mhmm [22:27:35] which I suppose is a good sign [22:27:40] hehe [22:27:59] well, just that we're prioritizing issues at about the same rate they occur [22:29:55] yeah [22:30:19] awight FYI here's the card about the DD change: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1760 [22:30:31] so you can kick it over to pending/deployed when it's there [22:32:15] atgo: ok, I was wondering if I was supposed to deploy. Will do. [22:32:23] atgo: also: refresh the pie chart! [22:32:26] awight i think so? if it's reviewed [22:32:33] oooh pie [22:32:40] looks way way more digestible [22:32:46] and also.. we need to set all those missing Tech Area cards [22:32:54] without the crust pre-sawn [22:33:00] * awight feigns deafness [22:34:41] awight if you feel so inclined... https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/list?columns=Priority%2CEstimate%2CTech+Status%2CTech+Type%2CTech+Area%2CBusiness+Capability%2CBusiness+Goal&filters%5Bmql%5D=Type+%3D+%27Tech+Task%27+AND+%27Tech+Status%27+%21%3D+Deployed+AND+%28%28%27Reviewed%27+IS+NULL%29+OR+%28%27Business+Capability%27+IS+NULL+AND+%27Business+Goal%27+IS+NULL%29+O [22:34:41] R+%27Tech+Area%27+IS+NULL%29&order=asc&sort=Priority&style=list&tab=All [22:34:44] awight: WHAT? [22:34:47] wow that is hideous. [22:34:54] ur1.ca atgo [22:35:13] thakns marktraceur [22:35:16] awight http://ur1.ca/hr6xp [22:35:31] those are all the ones missing tech rea [22:39:03] (PS1) Awight: Clear gateway adapter globals cache after tests [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146310 [22:39:05] (PS1) Awight: GC: Check XML for CVV result, use blanks if missing [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146311 [22:39:07] (PS1) Awight: Whitespace [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146312 [22:39:09] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146313 [22:39:11] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146314 [22:39:13] (PS1) Awight: Consistent use of ellipsis [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146315 [22:39:15] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146316 [22:39:17] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146317 [22:39:19] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146318 [22:39:21] (PS1) Awight: Add a 'No valid form' RapidHtml form [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146319 [22:39:23] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146320 [22:39:25] (PS1) Awight: Cleaning up the payments error logs [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146321 [22:39:27] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146322 [22:39:29] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146323 [22:39:31] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146324 [22:39:33] (PS1) Awight: Stop sending realtime Direct Debit messages to civi. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146325 [22:39:39] (CR) Awight: [C: 2] Clear gateway adapter globals cache after tests [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146310 (owner: Awight) [22:39:42] (CR) Awight: [C: 2] GC: Check XML for CVV result, use blanks if missing [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146311 (owner: Awight) [22:39:49] (CR) Awight: [C: 2] Whitespace [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146312 (owner: Awight) [22:39:55] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146313 (owner: Awight) [22:39:59] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146314 (owner: Awight) [22:40:05] (CR) Awight: [C: 2] Consistent use of ellipsis [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146315 (owner: Awight) [22:40:13] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146316 (owner: Awight) [22:40:19] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146317 (owner: Awight) [22:40:24] (CR) Awight: [C: 2] Add a 'No valid form' RapidHtml form [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146319 (owner: Awight) [22:40:30] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146318 (owner: Awight) [22:40:38] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146320 (owner: Awight) [22:40:44] (CR) Awight: [C: 2] Cleaning up the payments error logs [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146321 (owner: Awight) [22:40:49] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146322 (owner: Awight) [22:40:54] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146323 (owner: Awight) [22:40:59] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146324 (owner: Awight) [22:41:05] (Merged) jenkins-bot: Clear gateway adapter globals cache after tests [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146310 (owner: Awight) [22:41:07] (CR) Awight: [C: 2] Stop sending realtime Direct Debit messages to civi. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146325 (owner: Awight) [22:41:09] (Merged) jenkins-bot: GC: Check XML for CVV result, use blanks if missing [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146311 (owner: Awight) [22:41:15] (Merged) jenkins-bot: Whitespace [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146312 (owner: Awight) [22:41:19] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146313 (owner: Awight) [22:41:25] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146314 (owner: Awight) [22:41:28] (Merged) jenkins-bot: Consistent use of ellipsis [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146315 (owner: Awight) [22:41:32] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146316 (owner: Awight) [22:41:36] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146317 (owner: Awight) [22:41:40] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146318 (owner: Awight) [22:41:45] (Merged) jenkins-bot: Add a 'No valid form' RapidHtml form [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146319 (owner: Awight) [22:41:51] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146320 (owner: Awight) [22:41:55] (Merged) jenkins-bot: Cleaning up the payments error logs [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146321 (owner: Awight) [22:41:57] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146322 (owner: Awight) [22:42:01] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146323 (owner: Awight) [22:42:06] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146324 (owner: Awight) [22:42:10] awight did you fix the clipping on the pie chart!? [22:42:10] (Merged) jenkins-bot: Stop sending realtime Direct Debit messages to civi. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146325 (owner: Awight) [22:42:29] atgo: yah that was the crust issue I was referring to [22:42:37] ahhhh amazing! [22:43:19] you'll have to show me how somtime. [22:43:42] atgo: the stupid branded logo to the right of the missing pie chart, in the Edit pane [22:43:51] yeah that thing i know [22:43:58] atgo: hey, can you make me a "infrastructure" tech area? [22:44:02] i tried to futz with the size of it a while back and it didn't work [22:45:17] awight sure... will K4|meeting disagree? :P [22:45:33] hah [22:45:44] WWK4MD? [22:45:52] he [22:46:11] it's tjere [22:46:21] currently below Drupal, but i can move it around if you want [22:50:14] K4|meeting: atgo: DD change is deployed [22:50:21] ejegg: the no-form is deployed [22:51:10] awight thanks! [22:51:29] moving both to "deployed" [22:51:47] awight can you show me how you changed the mingle thing with the margins? [22:52:02] when i do it it still clips.. just addsa bunch of space to the right [22:52:04] awight: thanks! [22:52:32] for a different chart [22:56:41] atgo: plot-x-offset ? [22:57:03] not sure if that should go up or down. [23:03:21] (PS2) Ssmith: Add gauge lib and gauge widget view/template [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/145739 [23:10:30] ejegg: link to code on https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1032 ? [23:11:11] ejegg: same for 1370 [23:11:27] ah, will do. Sorry, I'll remember in the future [23:11:52] no worries! I'm just trying to sort out what I deployed a moment ago [23:13:22] awight are you cowering? [23:13:42] SERIOSly [23:13:50] I only perked up at "firing" [23:13:56] go on... [23:14:08] hehe [23:20:06] ejegg: I don't know if you're doing this, but definitely add fr-tech to the reviewers on any patch that is ready to hand off [23:20:35] (CR) Awight: [C: 2] "Do we have coverage analysis working?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146168 (owner: Ejegg) [23:20:37] sounds good [23:20:55] ah, was about to tag that one! [23:20:56] ejegg: and sorry. we're bookkeeping over here to avoid real work... [23:20:59] hehe [23:21:22] heh, you call a big old deploy like that bookkeeping? [23:21:35] aaargh! [23:21:50] missed something? [23:22:23] this morning's wmf-config deploy was the most painful. There were ordinary stumbles, then I learned 30 min into my window that my gerrit pubkey would not work from the deployment box... had to workaround... [23:22:29] (Merged) jenkins-bot: Fix @covers code coverage annotation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146168 (owner: Ejegg) [23:22:31] that is all [23:23:16] whoa, that's odd. [23:52:52] atgo: did you figure out how to change the properties in the quick add form? [23:54:19] the only way is by setting a default [23:54:24] so that sucks [23:54:27] bug [23:54:32] buh huh bug [23:54:53] * awight overclocks mingle to watch it write garbage across the drivesen [23:55:39] Huh. [23:55:39] i mean.. we could do that, but i don't think it's a great plan to have a default, you know? [23:55:56] atgo: I think it's fine: the default can be "Not Set" [23:56:00] atgo: I should clean up payments logs more often. :/ [23:56:04] or :-/ "NULL" [23:56:12] yeah but that doesn't really help with anything else [23:56:22] i'm going to email them and see what lame response they have for now [23:57:01] awight don't you need the description also? [23:57:33] atgo: Somebody had a payment end because they didn't have a currency set, and it looks like they came from a legit campaign. [23:57:36] atgo: do I? :p [23:57:49] yes, awight. yes you do :P [23:57:57] i mean, i'm just as likely to hassle you about that as the TA [23:58:38] well... the description is much more likely to get filled out in the full view. I suppose I could stop using any fields at all in the quick form. That's about how I handle the stupid quick view form. [23:59:00] well that's kind of why i don't want to add a "not set" because it's much less trackable for me [23:59:09] when you don't do it ;) [23:59:45] atgo: really? You can just have a filter which searches for "not set" or is null