[00:00:03] i mean i could... but it's definitely a lot more overhead [00:00:07] it's not the end of the world [00:00:11] It's horrible, I know. All I want is for it to be systematically easy to enter new cards. [00:00:15] yeah [00:00:20] well i just emailed them, so we'll see [00:00:31] i like it [00:00:49] i bet $5 that they're like "oh yeah, i mean that was intentional duh" [00:01:39] I would never take u up on that bet unless you gave me 1:20 odds or something [00:02:23] urf [00:02:38] haha [00:28:38] (PS1) Ejegg: Add Paypal tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146361 [00:32:15] (PS1) Mwalker: Adding known devices to database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146362 [00:33:04] (CR) jenkins-bot: [V: -1] Adding known devices to database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146362 (owner: Mwalker) [00:35:17] (CR) Awight: Adding known devices to database (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146362 (owner: Mwalker) [00:35:19] (PS2) Mwalker: Adding known devices to database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146362 [00:36:16] awight, what's your question in the patch file? [00:37:05] mwalker: is it idempotent? [00:37:07] (PS3) Mwalker: Adding known devices to database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146362 [00:37:33] (CR) Mwalker: Adding known devices to database (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146362 (owner: Mwalker) [00:37:51] yes; but not obviously; the updater saves the name of the patch in a table in the database and wont run it again [00:37:53] mwalker: great, thanks! [00:38:05] (CR) Awight: [C: 2] Adding known devices to database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146362 (owner: Mwalker) [00:38:13] (Merged) jenkins-bot: Adding known devices to database [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146362 (owner: Mwalker) [00:38:24] awight, see modifyField() in includes/installer/DatabaseUpdater.php [00:50:56] (PS1) Awight: WIP script to backfill missing recurring contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/146364 [00:51:00] (CR) jenkins-bot: [V: -1] WIP script to backfill missing recurring contributions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/146364 (owner: Awight) [14:29:34] (PS1) Ejegg: Add regex match assertion to verifyFormOutput [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146460 [14:31:53] (PS2) Ejegg: Add PayPal tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146361 [15:57:59] (CR) Mwalker: [C: 2] Add regex match assertion to verifyFormOutput [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146460 (owner: Ejegg) [15:58:09] (Merged) jenkins-bot: Add regex match assertion to verifyFormOutput [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146460 (owner: Ejegg) [15:59:06] (CR) Mwalker: [C: 2] Add PayPal tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146361 (owner: Ejegg) [15:59:15] (Merged) jenkins-bot: Add PayPal tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146361 (owner: Ejegg) [17:24:20] K4-713 planet earth is SO GOOD!! i wish i was around on tuesdays :( [17:24:32] also at first i typed that as tuesdyays, which may have actaully been better. [17:24:41] Are you not around today? [17:24:53] yay for tuesdy! [17:24:55] Science TuesdYAYs. [17:25:19] atgo: But seriously, are you remote today? For the thing? [17:25:25] Somehow I missed that. [17:25:36] THE THING [17:25:47] * K4-713 twiddles [17:26:19] atgo: Also, I have something funny to tell you. About the nightly GC processing. [17:26:50] atgo: Apparently we're not even trying to get direct debit that way. Never have. [17:26:53] So... [17:27:25] ...should I wire that up today, then? [17:30:31] Oh man. I killed her. [17:31:08] no i'm here [17:31:11] just not on the evenings [17:31:15] Oh! [17:31:17] sorry.. was getting an english muffin [17:31:19] nommmms [17:31:25] I completely understand. [17:31:34] So... nightly. [17:31:40] oh yeah.. we should proabably do that [17:31:43] that seems like a good thing [17:32:24] * K4-713 nods [17:32:49] * K4-713 makes this face http://media.tumblr.com/tumblr_lxvd86okBz1qj373v.png [17:33:02] hahah [17:33:53] K4-713: I hope you have that bookmarked [17:33:53] K4-713 we also need to shove that 0 back into the zip field for DD at some point [17:34:10] marktraceur: I can find it again. :p [17:34:25] atgo: Why? [17:34:35] Is asking for the actual zipcode a problem? [17:34:35] beacuse people are getting rejected for a NULL VALUE on the zip [17:34:40] ... [17:34:41] well we don't require it [17:34:50] When was the last time you saw that in the console? [17:34:54] literally right now [17:35:00] wtf [17:35:04] yeah [17:35:08] it changed like a month ago [17:35:11] No... [17:35:12] argh [17:35:29] apparently we used to put a 0 in it but then pats noticed and asked GC and they were like "yeah you used to send us a 0" [17:35:30] I added the required field to our form literally minutes after I noticed it was happening. [17:35:39] hm [17:35:43] Which was simultaneous with Pats emailing GC about it. [17:35:46] these are definitely happening yesterday [17:35:51] grammer [17:35:52] grammar [17:35:53] damn. [17:36:05] Are they coming from payments, or from dd trying to recur from civi? [17:36:20] uuh [17:36:26] not sure how to check.. i would guess from payments [17:36:35] because they're all nestled in with the austria ones [17:36:37] Well, we will have logs to back that up. [17:36:52] I'll look. [17:37:06] they're definitely austrian [17:37:10] But, yes: We should be asking for zip. We're asking for the entire remainder of the address. [17:37:13] i has country code [17:37:15] Are they *only* AT? [17:37:33] there's on DE [17:37:40] oh.. no you are right. [17:37:45] just hte first 4 i looked at were AT [17:37:51] so... let me do a quick tally [17:38:34] 5 AT, 4 NL, 1 DE [17:39:05] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=dd&recurring=¤cy=EUR&country=AT&amount=1.33 [17:39:08] Zip is on there. [17:39:14] See if you can get past validation with nothing in there. [17:39:24] do i just invent an acct? [17:39:27] Sure [17:39:39] The do_bankvalidation fires after the frontend validation. [17:39:57] worked [17:40:00] oops. i put a hting. [17:40:02] that was dumb [17:40:04] let me do that again. [17:40:16] yeah it says "please enter your zip code" [17:40:28] but like... it's clearly also not working that way, right? [17:40:30] * K4-713 sighs [17:40:55] Is it possible that the outliers are currently people trying to abuse the system? [17:41:04] I mean, people are getting through, correct? [17:41:11] That was not the case before. [17:41:17] yeah people are getting through [17:41:29] Here's another one. [17:41:36] The people who are failing. Are they trying again? [17:41:46] there are 2 other rejections (that seem legit) and then 62 others that look OK [17:41:49] how can is ee that? [17:41:54] Well... [17:42:09] If you send me the contribution tracking ID, I can look at payments logs. [17:42:21] Also, I can get the ctid from the order ID. [17:42:44] Also... are you completely sure that those two rejections are because of zip not being there? [17:43:17] no the 2 rejections are "not authorised" so that's different. then there are 10 for the zip [17:43:34] This doesn't feel like legit people at this point. [17:48:13] If we cached payments, I'd think it might be that. But we don't. [17:48:18] Maybe somebody else does, though. [17:48:55] atgo: ^^ [17:49:05] hm. [17:49:34] If the amount was one offered in a radio button... [17:49:39] ...it's possible. [17:49:46] they're mostly for 3 EUR [17:49:53] there's one for 1 and one for 10 [17:49:57] and one for 5 [17:50:03] Are those all campaign values? [17:50:11] i assume? [17:50:11] but not sure [17:50:29] jessicarobell - what are the radio buttons for the campaign in AT? [17:50:39] One doesn't appear to be on donate that way. [17:50:54] But, banners could do pretty much anything. [17:52:02] atgo: You can see pictures of the banners here, with the radio button values https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AphVIE-Yv6AndFlzZWJhMlNmVDloWF9ad3JWSkJWU2c&usp=drive_web#gid=94 [17:52:34] I have an important meeting in 5 minutes, but will be back in about an hour if you need any clarification. [17:53:07] atgo: At any rate, this is no longer a blocking issue. I have a hard time believing that a hard refresh wouldn't solve it for everybody. [17:53:47] I would be interested, though, to see if anybody has contacted Donor Services that couldn't be walked through it. [17:54:15] K4-713 hm.. ok. and you're sure it's a caching thing? the amounts in the banner are mostly reflective of the problematic donations, except there's no 1 euro ask [17:54:27] I'm not sure, but I can't explain it any other way. [17:54:39] and 3 only appears on 1 banner... so maybe it's a problem with that one? [17:54:44] And I can't reproduce the problem. [17:54:49] truth [17:54:51] It can't be the banners. [17:54:58] It's contained completely on payments. [17:55:02] hm. [17:55:19] I asked if it was a radio button value, because that has a higher probability of being cached by some intermediary. [17:55:42] gotcha [17:55:45] ...which we have always had a hard time getting a handle on, and oh dang, meeting time. [17:55:50] :P [18:56:22] mwalker: hi there [18:56:41] I'm fine with us simply chatting here inchannel and don't need a videochat unless you do [18:56:47] same [18:56:54] :) [18:57:00] I just have google calendar add hangouts automatically because I always forget [18:57:05] * sumanah can wait a few min so you can finish other stuff up before noon [18:57:07] the converse is that I forget to remove them too [18:57:12] no prob, me too [18:57:21] ok, I'll just follow along here [18:57:46] :) hi ejegg [18:57:54] Hi Sumanah! [18:58:50] ejegg: Jeff_Green mwalker https://www.mediawiki.org/wiki/Requests_for_comment/CentralNotice_Caching_Overhaul_-_Frontend_Proxy is what we're talking about, right? [18:59:04] yep [18:59:48] mwalker: so https://www.mediawiki.org/wiki/Talk:Requests_for_comment/CentralNotice_Caching_Overhaul_-_Frontend_Proxy#IRC_meeting_2013-10-02_34156 & https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2013-10-02 [19:00:28] basically if I understand correctly we should derive your TODOs from that meeting in Oct and then you should do them, yes? [19:00:29] sumanah: ok. following too [19:01:54] yepyep [19:02:34] sumanah, do we have a transcript of that meeting? [19:02:47] oh yes; that was the first link [19:04:17] mwalker: so, do you do composition better in Etherpad, GDocs, onwiki, your text editor, or someplace else? [19:04:25] let's do etherpad [19:04:38] http://etherpad.wikimedia.org/p/CentralNoticeRfC [19:05:24] sumanah, do you know why it automatically reformats the text? [19:05:34] Etherpad can be weird about linebreaks :/ [19:05:51] when copying and pasting into Etherpad [19:06:18] grrrrr [19:06:41] mwalker: yeah. I would not blame you for choosing a different medium at this point [19:07:59] https://docs.google.com/document/d/1EzLf7elO4zSLdaPBI6BsfFOOJ1FzZoKhMiosb77UBt8/edit [19:08:11] ok! [19:08:45] ok, here we go. [19:08:53] Sounds like the first thing you ought to address is the role of Varnish [19:08:58] mwalker: that sound like a good 1st step? [19:09:23] I'm rereading the discussion; what question prompted that? [19:09:47] I also have what URL this is served under as a point of confusion [19:10:39] ah; this was marks suggestion that we have a frontend varnish direct to a backend via a vcl_pass [19:13:26] hmm, also will have to address the contentsecuritypolicy question by Tyler [19:15:39] ok, mwalker lemme know when to look at new prose [19:15:58] *thumbs up* [19:16:12] I think you may have accomplished your primary purpose; I'm now looking at the document :) [19:16:23] :) [19:16:25] do you see any additional questions that I missed apart from those above? [19:23:39] Looking. [19:23:53] mwalker: benchmarking [19:24:46] mwalker: "but that part will be semi-static JS?" -- yes; the bit in the head will be as small, simple, and static as I can make it [19:24:46] "Where does the 200GB figure come from?" CN has a potential space of all projects, languages, countries, user states, buckets, and slots -- which comes to a large number which is then multiplied by the average size of a fundraising banner and varnish overhead [19:24:56] I assume you need to put those answers into the RfC itself. [19:25:19] k [19:25:31] mwalker: do you need to address the "different domain name" discussion? [19:25:42] yes; that's actually what I'm tackling first [19:25:47] because it'll have ramifications on varnish [19:26:19] I have to figure out a way to request a per wiki URL that varnish can identify to pass on to the backend [19:26:53] I may have to ask mark if it's OK to pollute the root with virtual paths; e.g. //en.w.o/banners [19:28:04] mwalker: I don't actually see the phrase "LVS" anywhere in the doc, in case you want to use it [19:28:39] also you may want to address the redirecting/round-trip questions that people asked [19:28:42] that's probably a complicating detail considering no matter what I do will not require a change to LVS (unless I had a new domain name but that's implied) [19:29:01] mwalker: if you describe (in ASCII art or text or something) how the data flow will work, I will Inkscape up a terrible diagram [19:29:44] ideally that's what the proposed caching strategy image is supposed to be doing [19:30:12] now the question is; do I still have the source [19:30:48] oh it is an svg! [19:30:57] that IS source [19:31:17] well; it's actually a dia document; but yes; I converted it to an SVG because we cant render DIAs [19:31:26] ohhhh [19:31:43] misunderstood, sorry [19:31:58] nothing to misunderstand actually; that wasn't mentioned anywhere on wiki :p [19:32:11] is that SVG editable in inkscape? [19:32:17] * mwalker installs inkscape to see [19:33:40] ah; it is editable but it's a horrible experience [19:34:09] do you want the dia document? [19:34:09] ok [19:34:28] mwalker: I can take the dia document, although I would not be surprised if you find it easier to edit it yourself than to tell me how to edit it [19:34:38] heh; that may be true [19:34:59] remind me; did we replace bits.wm.o? or did we just change where that was being served from? [19:35:12] I think we just removed the bits cluster and now it's all served from the app cluster [19:35:20] Jeff_Green: ^ maybe you know this? [19:35:35] ejegg: I don't know whether this is interesting or edifying to you at all :/ [19:35:59] just doing a bunch of side reading looking up stuff mentioned in the talk page / IRC log [19:36:34] not knowledgeable enough about the environment to kibitz just yet! [19:37:21] OK :) No prob, just wanted to check in. If you have any questions about RfCs in general I may be able to help [19:37:29] ok, thanks! [19:38:43] btw ejegg you may enjoy these performance guidelines https://www.mediawiki.org/wiki/Performance_guidelines especially the bit about caching layers https://www.mediawiki.org/wiki/Performance_guidelines#Caching_layers [19:39:14] ahh, good to know [19:39:59] whoa, are we actually using LocalStorage for ResourceLoader in production? [19:40:13] yep [19:40:20] nice [19:40:23] it has some problems... [19:40:32] oh? [19:40:37] like; we dont actually know when we cant put any more things into LocalStorage [19:40:48] ah, dang [19:40:52] and... other things want to put things into LocalStorage but now cant [19:40:56] if LS is full... [19:44:14] sumanah, I have a question otu to chris about this; but do you know anything about our plans to deploy a content security policy [19:44:30] if we do that I'm likely going to have to redraft my JSONP call strategy [19:44:57] https://wikitech.wikimedia.org/wiki/Bits says: "The "bits cluster" is no longer in use. It used to be the servers that served ResourceLoader. But now that work is simply spread amongst the entire mediawiki app server cluster. This improves redundancy/spike proofing. " last updated June 2014 [19:45:33] mwalker: I am now doing a Wikimedia technical content search for Content Security Policy via http://hexm.de/mw-search [19:45:55] this is all I see https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Removing_inline_CSS.2FJS_from_MediaWiki [19:46:11] so that does not sound like a Plan [19:48:37] true; and bullet point 2, of removing the inline JS for resourceloader will be... a problem [19:52:37] ok; so I've read a lot of things and this is what I'm going to change -- I'm going to unify the URL to bits.wikimedia.org; varnish will initially serve the request before forwarding that to a backend; I'll add a bit to talk about CSP and how I dont currently care about it w/ justification that the first load is REALLY important; I'm going to add a note on where the 200GB comes from [19:53:08] man; it took me 50 minutes just to come up with that... /me allocates another hour to this task [19:53:43] apparently my context switcher needs an SSD or something :p [19:53:57] heh [19:54:10] mwalker: it's a big RfC with a lot of moving parts, I am glad you can allot the attention you need to it [19:54:59] ejegg, while I'm in this space; do you have any questions about what this is going to do? [19:55:15] and/or how its going to work? [19:55:17] not just yet [20:18:23] K4-713 will this get resolved with sepa for all countries or just the ones that are SEPA? [20:18:39] mwalker: going ok? [20:18:57] yep; still chugging along [20:19:14] while getting pulling into other things along the way [20:19:28] also CN related because kaldari is on a bugroll today [20:20:31] bugroll. that sounds liek the worst kind of suhi [20:20:32] sushi [20:26:48] eeew. [20:26:53] Though, arguably, shrimp... [20:30:35] (PS1) Kaldari: Adding missing jquery.json depenency needed for dismissing banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146591 (https://bugzilla.wikimedia.org/68064) [20:32:13] (PS2) Kaldari: Adding missing jquery.json depenency needed for dismissing banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146591 (https://bugzilla.wikimedia.org/68064) [20:35:00] (CR) Mwalker: [C: 2] Adding missing jquery.json depenency needed for dismissing banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146591 (https://bugzilla.wikimedia.org/68064) (owner: Kaldari) [20:35:41] (Merged) jenkins-bot: Adding missing jquery.json depenency needed for dismissing banners [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/146591 (https://bugzilla.wikimedia.org/68064) (owner: Kaldari) [20:37:41] ejegg, you'll do me a tremendous favour if you'' merge ^ into the deploy branch and add it to the swat for wmf12 and wmf13 [20:38:33] will do. Thanks for catching that! [20:38:46] I need to read up on resourceloader deps... [20:49:58] sumanah, I just updated the wiki page [20:50:03] mwalker: awesome! [20:50:17] mwalker: I updated the CSP thing in https://www.mediawiki.org/wiki/Talk:Requests_for_comment/CentralNotice_Caching_Overhaul_-_Frontend_Proxy#IRC_meeting_2013-10-02_34156 [20:50:39] the only thing I haven't touched on is the performance question -- but I think gwicke and I have slaughtered that in other RfCs and we don't have much of a choice given mark's comments on the talk page (e.g. doing this in a VMOD is highly discouraged) [20:51:10] "I'm going to unify the URL to bits.wikimedia.org; varnish will initially serve the request before forwarding that to a backend; I'll add a bit to talk about CSP and how I dont currently care about it w/ justification that the first load is REALLY important; I'm going to add a note on where the 200GB comes from" [20:51:13] did you do all that, then? [20:51:19] I think so [20:51:51] cooool [20:53:48] mwalker: sorry, not sure I'm doing this right: "git branch --track wmf/1.24wmf12 origin/wmf/1.24wmf12" tells me the upstream branch doesn't exist [20:54:08] (in CentralNotice) [20:55:41] correct [20:55:46] those branches do not exist in centralnotice [20:55:56] we only have one deploy branch which is called wmf_deploy [20:56:02] Ah, I thought it was automatically created... [20:56:05] OK [20:56:10] it is; for all extensions but special ones [20:56:12] like CentralNotice [20:56:23] because we have a need to always be in sync on the cluster [20:56:35] OK, gotcha [20:56:39] thanks! [20:57:02] Thanks mwalker - I have told wikitech-l to take a look [20:58:35] Have a great day! Glad we did this [20:58:49] (PS1) Ejegg: Adding missing jquery.json depenency needed for dismissing banners [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/146599 (https://bugzilla.wikimedia.org/68064) [21:00:01] yepyep [21:00:06] thanks for poking me until it was done [21:04:32] (CR) Ejegg: [C: 2] Adding missing jquery.json depenency needed for dismissing banners [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/146599 (https://bugzilla.wikimedia.org/68064) (owner: Ejegg) [21:12:09] mwalker: the jquery.json dependency needs to go in the swat even though the rest of the CentralNotice cookie update is not yet in wmf_deploy? [21:12:33] um... yes; so you'll have to cherrypick [21:13:04] yeah, I cherry picked it in. It has to go first because of resource loader caching? [21:22:42] mwalker: sorry to pester, I just want to make sure I understand why we're pushing the dependency before the code that uses it. The current code in CentralNotice/wmf_deploy doesn't use $.toJSON anywhere [21:30:44] (PS1) Katie Horn: Additions to WR1 processing to support Direct Debit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/146610 [21:33:37] ejegg, oh! [21:33:40] I didn't know that [21:33:51] so only master has the problem? [21:33:57] in that case we dont need to push it [21:47:26] ejegg: Want to look at some code? [21:47:55] The first thing is over here in... this repo you may have never seen before: [21:47:56] https://gerrit.wikimedia.org/r/#/c/146610/ [21:48:03] wikimedia/fundraising/tools [21:52:56] snagging it now, K4 [21:59:04] (PS2) Katie Horn: Additions to WR1 processing to support Direct Debit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/146610 [22:00:12] (PS3) Katie Horn: Additions to WR1 processing to support Direct Debit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/146610 [22:00:42] hey K4-713 ... pats was able to reproduce the DD problem. i'll show you [22:00:45] ...just kidding. [22:00:49] What? [22:00:50] Where? [22:01:01] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=dd-recurring&recurring=true&payment_method=dd&utm_source=fr-redir.default~default~default~default~control.dd&utm_medium=spontaneous&utm_campaign=spontaneous&utm_key=&referrer=&language=en&country=AT&returnto=Thank_You%2Fen&amountGiven=¤cy_code=EUR&frequency=monthly&amount=5&uselang=en [22:01:09] RECURRING. [22:01:12] wait 1. [22:01:41] ffname=dd-recurring is the part of the URL of interest, here. [22:05:07] atgo: Gee, wouldn't it be swell if we had a templating system that reused code between forms? [22:05:25] interesting thought there, K4-713 . interesting. [22:09:15] (PS1) Katie Horn: Add zip field to Direct Debit Recurring form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146620 [22:09:43] ejegg: Got a second? I should probably deploy this DI patch ASAP. [22:11:11] sure - the zip code? [22:11:14] yep. [22:11:35] It's just adding the zip field to the form, just like we already did with the dd (not recurring and basically identical) form. [22:12:02] * K4-713 is sad that these are two separate forms for no reason [22:12:12] (CR) Ejegg: [C: 2] Add zip field to Direct Debit Recurring form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146620 (owner: Katie Horn) [22:12:14] yeah, looks fine to me [22:12:19] Groovy, thanks. [22:12:23] (Merged) jenkins-bot: Add zip field to Direct Debit Recurring form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/146620 (owner: Katie Horn) [22:12:34] I'll, ah, see about getting that live, now, then. [22:12:57] don't we have some reuse in the forms? I thought I was stepping through some transclusion code yesterday [22:13:24] We do. [22:13:32] ..."some" being the operative term. [22:13:55] ah, gotcha. could have it more places, just don't yet. [22:14:15] And it's pretty sad how many form functions say "This function isn't used anywhere anymore" that would, you know, make things orders of magnitude more simple. [22:15:18] hmm, dead code cleanup task in our future? [22:15:48] I wish. [22:15:58] I really, really wish. [22:16:15] Though, in this case, I left the functions in as another form of wish. [22:16:38] oh, you meant that using them would be the simpler solution! [22:16:44] Oh my, yes. [22:17:24] And at some point, they were deliberately forsaken for the sake of... copy/pastepocalypse. [22:17:26] I didn't do it. [22:23:55] (PS1) Katie Horn: Add PayPal tests [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146625 [22:23:58] (PS1) Katie Horn: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146626 [22:24:00] (PS1) Katie Horn: Add zip field to Direct Debit Recurring form [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146627 [22:24:22] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146625 (owner: Katie Horn) [22:24:39] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146626 (owner: Katie Horn) [22:24:43] (CR) Katie Horn: [C: 2] "+2 for deploy" [extensions/DonationInterface] (deploy-payments_1.22) - https://gerrit.wikimedia.org/r/146627 (owner: Katie Horn) [22:35:30] atgo: Want to try to reproduce that issue now? [22:35:55] !log synchronized payments to afa12be34769000bf8 [22:36:00] Logged the message, Master [22:42:43] hmm. [22:42:55] atgo sublimated. [22:43:20] * K4-713 looks sad [22:52:13] yaaay! [22:54:02] (PS1) Katie Horn: Changes to the WR1 processor to accept Direct Debit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/146636 [22:54:52] Oh no, atgo can't sublimate, we need her for her board game [22:56:28] srsly [22:59:17] don't worry, the game is still there [22:59:34] * K4-713 looks more sad [23:03:48] Agreed K4-713 [23:24:43] K4-713: is there code checked in that actually uses the Wr1Parser, or is that just in some cron scripts on prod machines? [23:57:07] /quit