[17:43:13] ejegg: how do you feel about deploying the CN cookie thing today? [17:43:52] ejegg: mwalker wants to merge a bunch of other CN commits and is wondering whether he should cherry-pick around the cookie? [17:44:48] He's going right into prod, and not onto beta? [17:44:56] beta already has it [17:44:58] beta runs master [17:45:03] Oh, cool. [17:45:11] but I haven't tested it [17:45:23] also; wed is likely better because that has the best deploy window [17:46:14] OK, let me try to see it on beta. You don't happen to know a URL to use, do you? [17:46:37] meta.wikimedia.beta.wmflabs.org [17:46:42] thanks! [17:46:45] also; create an account there and I'll give you the permissions you need [17:47:51] hey awight ejegg K4|away ... just a reminder on the cookie deploy if possible [17:48:05] hah! we were just talking about that [17:48:06] atgo: synchronicity! [17:48:31] ok mwalker, created account ejegg on meta-beta [17:48:56] atgo: I'm just about to bang on it in beta and see if it's good [17:49:57] ejegg: yes, fwiw beta should already have all the -master code. [17:50:16] oh u covered that. good [17:50:25] ejegg, ok; you have all the rights [17:50:41] awesome! thanks guys! [17:50:51] awight: does that happen automatically, or did you guys deploy CN master there? [17:51:21] mwalker: thanks, will put up a test banner! [17:51:32] ejegg, it happens automagically [17:51:35] unless jenkins is broken [17:54:41] ejegg: http://meta.wikimedia.beta.wmflabs.org/wiki/Special:Version [17:55:08] ah, very helpful. [17:55:12] Verified that the code is current. [18:08:01] awight! did you see joel's email 9 minutes ago? maybe this was hapening on friday too! [18:09:25] atgo: awesome. That probably was the issue. Meanwhile, I can't connect to my personal email server today! Boohoo... [18:09:36] I'll have to do work or something in the meantime. [18:13:01] egads [18:18:42] awight which tech area? https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1818 [18:18:50] there are so many civis now :P [18:21:25] atgo: oh awesome. If you have two tabs open to a card and change the description in one, you lose property changes made in the other. [18:21:37] yeah it's a super cool feature [18:21:46] REALLY BAD PROGRAMMING [18:21:49] ahem [18:24:15] http://beastmodaldomains.files.wordpress.com/2012/03/bear-wave.gif [18:26:05] awight,mwalker: client-side cookie stuff is looking good on beta as far as I can tell. [18:27:59] ok; so lets deploy on wed in the 1400-1600 PST window? [18:28:12] Sounds good [18:29:45] ejegg: you might want to prepare a revert patch and strategy just in case of fire... [18:31:18] ok, push it to a DO NOT USE topic or something? [18:51:10] K4|away: a thing we should remember when the DD-success stuff is all sorted out: we're going to go way over the thank-you grace period, we should have a special case for these transactions. [18:52:16] ejegg: yep, prefix the commit summary with DO NOT MERGE perhaps [18:52:30] cool [18:52:34] ejegg: awesome to hear it works on beta! [18:53:09] even in IE6! (though that browser can't see the png close button) [18:53:56] oh wow, that was a high-quality browser. u know we have a crossbrowsertesting account, btw? [18:54:10] Oh, what's this? [18:54:45] you can spin up all sorts of virtual museum pieces [18:55:16] I have no idea how you are running IE6 without such a tool! [18:55:33] just... setting your system clock to 10MHz and 1992 ? [18:55:46] ram = 512kB [19:01:59] (PS3) Awight: WIP Simplify main message processing function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/147004 [19:04:43] special CR request: https://gerrit.wikimedia.org/r/147857 [19:06:15] (CR) Mwalker: [C: 2] just... one test passes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/147857 (owner: Awight) [19:16:55] (PS1) Ssmith: Fix requirejs loading + add SQL string to popover [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/148145 [19:18:04] (CR) jenkins-bot: [V: -1] Fix requirejs loading + add SQL string to popover [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/148145 (owner: Ssmith) [19:24:14] (PS1) Ssmith: Add timepicker subview/make widget header smaller [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/148158 [19:24:16] (CR) jenkins-bot: [V: -1] Add timepicker subview/make widget header smaller [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/148158 (owner: Ssmith) [19:24:57] K4|away: atgo: ok backlogger: FUD! [19:25:04] backloggers [19:26:19] yeah it's foodtime [19:26:28] I failed hard at breakfast [19:26:33] so hard [19:26:37] sank like a rock [19:26:58] Most Depressing Breakfast of 2014 [19:38:26] ok I gotta go cos there is a thing at 1 [20:47:24] ejegg: heeeey... Want to learn about Drupal upgrades? [20:47:30] * awight is obviously hiding a joy buzzer [20:53:14] https://wikitech.wikimedia.org/wiki/Fundraising/tech/crm/Upgrade_Drupal [20:59:10] awight meeting in Diderot? [20:59:16] oh there you are [20:59:19] you're here [20:59:52] awight: sorry i didn't see your message till now. Hope I haven't missed the fun! [21:16:20] ejegg: oh you didn't miss anything [21:16:38] ejegg: the instructions are pretty detailed, and I've been looking for someone to test them... [21:16:48] and, I'm a bit crunched for dev time this week... [21:16:57] ejegg: but you can refuse! [21:17:05] hey ejegg - things have been really meetingsy out here... cool to do IRC standup? [21:17:38] IRC standup is fine. [21:17:51] cool! we can do that in like 20? [21:17:53] normal time [21:18:00] Sure. [21:18:04] thanks :) [21:18:29] awight: let me see just how messy a commit this gives me [21:19:11] atgo: oh can you make me an admin on that board? [21:19:16] yeah [21:19:19] ejegg: hehe yep [21:19:38] awight just made it public [21:19:44] rad [21:20:10] also made you an admin [21:23:02] awight FYI: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1807 [21:23:10] if you have any more btc cards, we can add them here [21:23:47] atgo: btw, this is the "high engagement" week with Fuzion. [21:23:54] .. yeah [21:24:00] what does that require from you? [21:24:18] just a bunch of time. [21:25:17] eileen: Hi! [21:25:20] ok :/ [21:25:28] awight hi [21:25:54] eileen: I was wondering how u want to pace this project, also. [21:26:50] eileen: can u add me to your roadmap as an editor? [21:27:15] Or, I wanted to add "universal donation form" as the first item in "decouple presentation layer" [21:28:36] eileen: btw, pretty much everything we're doing can be public, with the exception of potential integrations with new payment processors. [21:29:04] awight I guess I'd like to spend a couple of hours today just figuring out everything that is there [21:29:11] absolutely. [21:29:23] Well, fwiw my schedule is mostly Mon/Wed/Fri [21:29:53] I can make lots of time to chat and coordinate with our team, but having warning about the schedule will be helpful. [21:30:09] cool - maybe a 2-3 hours every second day for me would be good - because then I can mull things over too [21:30:20] okay that sounds ideal to me, too [21:30:33] make sure to charge us for mulling ;) [21:30:39] ok - & I'm make it a morning thing at our end [21:30:47] great, thx [21:31:26] PPena: you get Daniel's latest email about downloads? [21:31:42] I was worried they would say that... [21:32:01] cos, bitcoins <3 encryption... [21:32:26] so, on refunds [21:32:47] (since we started talking about that - even though it's the very last thing on the list :-) [21:33:01] hehe. We haven't prioritized yet... [21:33:13] it's definitely an important feature that will free up people's work days here. [21:33:56] OK - so, at the moment you do a refund & then have to update CiviCRM *somehow*? [21:34:42] eileen: well, that has been improving recently. The situation is currently, we have to do a refund in the processor's console, then CiviCRM will get updated via an automatic process. [21:34:42] presumably some processors allow refunds by code & some only permit by logging into the interface? [21:34:47] Either audit or listener. [21:35:00] eileen: I think they will all allow us to refund by API. [21:35:10] some will - I know paypal does [21:35:19] & I think that is already in CiviCRM [21:35:42] at the moment what is the automatic process? [21:35:48] yes! But we are not integrated with any of the built-in Civi PAymentProcessor classes. [21:36:09] the automatic process is either an IPN listener, or a nightly audit script. [21:36:25] Both generate queue messages which are imported by the wmf_civicrm module [21:36:31] OK - but I'm trying to get my head around whether being able to do the refund from the CiviCRM api is one of the outcomes [21:36:46] from the civicrm console I mean [21:36:57] it is a thing we want. currently we cannot though, for any processor. [21:37:11] ok - not in CiviCRM & not in the media wiki interface [21:37:53] yep. only on the processor's console [21:38:40] ok - is this the wmf_civicrm module - https://github.com/wikimedia/wikimedia-fundraising-crm-civicrm [21:38:49] ah no - it's just civi [21:39:07] https://github.com/wikimedia/wikimedia-fundraising-crm/tree/master/sites/all/modules [21:39:18] queue2civicrm and wmf_civicrm are the main players [21:41:27] OK - so the obvious top one - document internal process - that's just a todo at this stage / that wiki page is what exists on it? [21:42:03] hehe. [21:42:06] * awight gulps [21:42:32] there is a lot of scattered wiki documentation. also, there is a semiprivate wiki we need to get you access to: collab.wikimedia.org [21:43:00] Actually, that's full-private. [21:43:10] * K4-713 frowns [21:43:19] K4-713: well, contractors have access [21:43:35] I think it's the... WMF-employee-contractor kind, though. [21:43:42] oooh. rats [21:43:55] Yeah, that might be a problem. [21:43:55] well we need to push anything relevant to open sourcing out to wikitech, then [21:44:05] Hey K4-713! [21:44:08] Well, that's totally a thing anyway. :) [21:44:11] Hi eileen! [21:44:16] how goes? [21:44:25] yeah that's the me-kind awight K4-713 :) [21:44:28] hi eileen !! [21:44:36] eileen: Oh, it goes. Heh. [21:44:46] How have you been? [21:45:22] eileen: I don't have the language to couch this sufficiently: https://wikitech.wikimedia.org/wiki/Category:Fundraising [21:45:29] Don't... trust anything you read ;) [21:46:21] hi all :-) [21:47:17] looks like an illustration from one of my kids books - https://wikitech.wikimedia.org/wiki/File:DonationPipeline_201302.png [21:47:44] eileen: lol, yes we'll send you a sweatshirt. that chart is our mascot. [21:47:57] heh [21:48:02] :-) [21:48:02] I need to update that... [21:48:36] too many of the faces are smiling? [21:48:57] That is one of the inconsistencies with reality, yes. :D [21:48:59] haha eileen [21:49:14] so - if we look at the main payment processor flows [21:49:22] 1) collect payment data onsite [21:49:30] 2) redirect to collect payment data [21:49:35] are you using both? [21:49:42] yes there is an iframe method as well [21:50:00] there are also fully offline methods, where we just find out later. [21:50:24] K4-713 awight would it make sense for eileen to watch k4's wikimania video for an overview of the system? [21:50:45] i at least foudn it immensely helpful, but i also knew nothing about anything at the time [21:50:51] * awight admits to not having watched, sadly [21:51:06] atgo: can u paste that to our Training wiki? [21:51:14] well - if it's immensely helpful that seems good :-) [21:51:25] https://wikitech.wikimedia.org/wiki/Fundraising/tech/Training or something [21:51:31] will do [21:51:36] meh that's the wrong page [21:51:43] nvm [21:52:08] here's the link.. you'll want to click to 26:45 (there'sa link in the descriptIon) [21:52:09] https://www.youtube.com/watch?v=21lR4kYXRmw [21:52:23] awight where do you want it? [21:52:52] atgo: I really donno. we have a "new fr-tech engineers page" somewhere [21:53:13] hmm [21:53:13] did you send it to ejegg ? [21:53:19] Ugh, that thing is so fill of lies. [21:53:21] *full [21:53:45] We should, you know, delete those. [21:53:49] whoa I just had KALX and K4's talk at the same time [21:53:53] I've looked around there [21:54:02] updated a tiny bit, like the activemq version [21:54:22] ejegg do you have the link soemwhere handy? [21:54:23] cool. [21:54:29] thanks for updating as you go :) [21:54:32] Also: Wow. I should give, you know, another talk. [21:54:40] Or something. [21:54:56] awaigh - according to the fundraising link you know about everything "-) [21:55:02] oh dear [21:55:07] that must be out of date [21:55:09] *Everything*. [21:55:26] well I thought I knew everything when I was younger... [21:55:34] yeah my kids do.... [21:55:46] Does that mean we need interns? [21:56:17] eileen: FYI, if you start typing someone's nick, then press tab, it will type the rest for you - aw is faster and more accurate than awight :) [21:57:29] marktraceur: you need a longer and more foreignly-spelled name to really drive that point home :p [21:57:30] marktraceur: someone told me that but I never remember - but now I see why you pointed it out :-) [21:57:35] awight yes [21:57:50] awight: What, like ToAruShiroiNeko or something? :P [21:58:10] T: yes [21:58:26] ok - I'm going to go & watch that youtube for a bit [21:58:43] awight: Maybe I should stick to European names, though. Something Norse maybe. :) [21:58:53] runic [21:59:23] I love the Internet, I can search for "badass norse names" and come up with hundreds of results" [22:01:07] omg /me quickly closes browser window [22:01:46] awight: ... [22:02:03] si? [22:02:08] I really should re-hang that monitor mirror. [22:03:28] K4-713: did I miss some really creepiness?? [22:03:39] No, but it looked like I might have been. [22:03:45] or you just want to watch the back of my head out of one eye :p [22:04:12] ... or u want to see yourself giving a talk in D.C. a year ago while you work [22:04:35] Actually, I never want to watch that video. [22:04:47] well I totally missed it :-/ I was about to give that guy a shoulder rub. [22:04:57] o_O [22:05:10] * awight keeps rest of rap to self [22:12:49] AAArgh. phpunit dataproviders can't access member variables. This is terrible! [22:13:21] wow, that's lame [22:13:22] * K4-713 squints [22:13:39] * awight writes the stupid test as a loop [22:14:37] well, that worked. [22:41:10] (PS4) Awight: Simplify main message processing function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/147004 [22:42:48] (CR) Ejegg: [C: 2] simplify calling signature [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/146978 (owner: Awight) [22:43:08] (PS5) Awight: Simplify main message processing function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/147004 [22:43:58] (PS6) Awight: Simplify main message processing function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/147004 [22:53:48] hey ccogdill [22:54:34] have a min to chat about your JCB errors? [22:55:12] I really do enjoy when people put the version "FINAL" on a draft [22:56:02] "FOR REAL, THOUGH". [22:56:15] FINALv3 [22:56:36] PPena: can you put through a donation with non-ascii characters for us? [22:56:42] (using coinbase) [22:58:24] hey atgo [22:58:36] I have a meeting at 4 but may be able to chat… [22:59:20] hmm ok [23:00:01] can we chat on here? [23:02:02] (PS1) Ejegg: Upgrade to Drupal 7.29 upstream [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/148261 [23:02:06] (CR) jenkins-bot: [V: -1] Upgrade to Drupal 7.29 upstream [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/148261 (owner: Ejegg) [23:03:34] ejegg: ah hrm, I think the branch should be "contrib" [23:03:48] ccogdill sure! so i think this is probably one of 2 things [23:04:01] ah, thanks awight! [23:04:10] k atgo. anything bad/ [23:04:11] ? [23:04:22] so i'm just trying to figure out the problem [23:04:27] ejegg: we should possibly fix the .gitreview (in a separate commit) [23:04:39] or just git push gerrit HEAD:refs/for/contrib [23:05:23] ccogdill it's because we're not requiring cvv [23:05:29] so people aren't typing it in [23:05:45] I had the impression JCB didn’t require it [23:05:49] is that wrong? [23:05:57] I don’t really know where that came from to be honest [23:06:13] hmm [23:06:39] this is 38/how many? [23:07:13] of status 100 rejections or total transactions? [23:07:20] total is like 10-15k [23:07:23] so really it’s small [23:07:26] just weird [23:07:45] so... it's 38 rejections out of 10-15k attempted JCB? [23:08:03] no all attempts over the past few days. I’ll have to pull a new report of just JCb [23:08:25] because.. that's... like nothing [23:08:42] ahh ok.. could you? i'm not as good at GC console... [23:10:09] (Abandoned) Ejegg: Upgrade to Drupal 7.29 upstream [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/148261 (owner: Ejegg) [23:10:39] (PS1) Ejegg: Upgrade to Drupal 7.29 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/148266 [23:11:28] ejegg: anything else you want to do or can I review? [23:11:40] review away! [23:11:48] Oh, I'll update the .gitreview too [23:12:00] (CR) Awight: [C: 2] "Looks good!" [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/148266 (owner: Ejegg) [23:12:22] yeah atgo I think I’m planning on sending this email anyway [23:12:22] also, is there a way to tell git to fetch submodules over ssh rather than https? [23:12:30] ccogdill yeah that sounds like the right thing to do. [23:12:46] ejegg: wrt the .gitreview, we just have to remember to null merge that commit so it never gets pushed to master. [23:12:49] you know what we couuuuld d [23:12:50] o [23:12:51] ccogdill [23:13:06] null merge, huh? Sounds exotic [23:13:08] ejegg: um, fetching submodules... good question, I think you have to go into each and edit the remotes. [23:13:12] ejegg: you have issues with https? [23:13:29] ccogdill > https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/790 [23:13:38] let's make one there that says "try again with your cvv" [23:13:41] ejegg: hehe. it's just a merge with strategy "ours" so git know that it should always take the local branch... [23:13:42] just had to change the remote url to let me git review [23:13:56] ejegg: ooh. u tried git review -s? [23:14:45] yeah, but that died copying the commit hook for some reason and I had to copy it from elsewhere [23:14:51] ejegg: you might be getting bitten by this stupid bug: http://www.gossamer-threads.com/lists/wiki/wikitech/481791 [23:15:21] although, I did manage to upgrade to git-review 1.24 and have no issues any more. [23:15:30] maybe pip install --upgrade setuptools ? [23:16:15] hmm, ok. looks like i am on v 1.23 [23:17:05] donno. We've definitely had all kinds of variations on this bug though. [23:17:16] and it asks you for your https login?: [23:17:22] yeah [23:17:27] ugh [23:18:15] is git review automatically supposed to switch origin url? [23:18:24] atgo what about card 790? sorry for the delay [23:18:32] we can make a custom error message for this [23:18:39] in the future [23:19:02] ccogdill ^ [23:19:16] ejegg: I think it's supposed to just run off of the "gerrit" remote [23:19:16] okay [23:19:27] are you pretty sure we can tell the donors something helpful in the message? [23:19:30] please retype cvv? [23:19:40] yeah "go back and actually enter your cvv" would be pretty close [23:20:25] the error type is "Customer input error" so if we just tell them how to do it right, that would probably solve it [23:20:46] oh, maybe my problem is that my remotes are all 'origin' [23:24:11] ejegg: that's sketchy [23:24:28] no idea what would cause that, though. [23:26:04] okay. Well how should we proceed with that atgo? Do you want me to draft something? [23:26:39] ccogdill yeah if you could and throw it in that card, that would be great. we won't get to it in time for your email, but we'll attack that card at some point and this can go in that effort [23:27:10] okay sounds good [23:28:33] also atgo do you happen to know why I don’t seem to be able to pull silverpop files from the server anymore? I had a problem with this on friday andagain today [23:28:51] hm [23:28:54] that's weird. [23:28:55] tried to start pulling the info over 2 hours ago and it’s still running [23:29:02] anyone I can talk to about it? :D [23:29:06] we need it asap [23:29:10] Jeff_Green might this have anything to do with stuff you've been on? [23:31:05] ccogdill... the one confusing thign about the GC issue is that it's not possible for anything to be >4 and also <0 [23:31:11] per their error message [23:31:21] "REQUEST CVV VALUE 1 OF FIELD ******* IS NOT A NUMBER WITH MINLENGTH 4, MAXLENGTH 0 AND PRECISION {5} ." [23:31:30] ha [23:31:39] thx for that [23:31:43] K4|away: ^^ enjoy! [23:32:11] hah I know. gc is always puzzling [23:32:13] I emailed them too [23:32:23] ok.. that's what i was going to suggest [23:37:02] yeah. so… any thoughts on this data issue? we were trying to send email in 30 minutes but it’s looking like that can’t happen if I can’t update the data [23:37:22] no i have no idea.. is that server ours or silverpops? [23:37:36] ejegg|away: oh, a step u might want to take after pushing the submodule patch is to test the "drush updatedb" on staging... [23:40:42] ours, pulling data from civi atgo [23:40:47] hm. [23:40:51] this command: bash /srv/tools/silverpop_export/update.sh [23:40:55] on lutetium [23:42:04] how bad would it be to not send tonight? [23:42:13] that’s what I’m thinking we have to do [23:43:16] how long does it normally take you to pull the data? [23:43:26] 45 minutes to an hour on a bad day [23:43:39] it still says “regenerating db table” in my terminal window [23:43:40] do you usually run the same time of day? [23:43:45] not necessarily [23:43:59] so this time of day could be slower because the db is dealing with audit files that come in at UTC midnight [23:44:55] (PS1) Awight: (FR #1819) Updated Coinbase report format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/148272 [23:45:34] let me check... at this rate probably you can't send at 5 though [23:46:34] no probably not [23:51:37] when's the next window for you to send? [23:51:42] same time tomorrow [23:51:49] ok [23:52:05] mwalker might you know why the silverpop file download isn't working? [23:52:11] (PS2) Awight: (FR #1819) Updated Coinbase report format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/148272 [23:52:36] atgo: It's stuck in the generation phase, isn't it? [23:52:43] atgo: he has been given socks! We'll figure it out. [23:52:55] ...huh? [23:53:04] K4-713: the jenkins jobs actually have useful logs for that process [23:53:17] atgo: harry potter: Dobby thing... [23:53:22] atgo: awight translation: Matt has been set free. [23:53:23] K4-713 is that a question for ccogdill ? [23:53:27] oooooooh [23:53:28] thx [23:53:35] :) [23:53:36] yeah... he just wrote it in the first place so figured i'd check [23:53:47] atgo, silverpop file download? [23:53:49] atgo: I'm very certain mwalker hasn't been jiggling anything in there. [23:53:51] you mean the upload? [23:53:57] yep [23:54:01] Before the file moving, though. [23:54:06] yes [23:54:11] download, i think... right? [23:54:17] It's the data grinding bit. [23:54:25] interesting... is jenkins giving any errors? [23:54:38] I think ccogdill ran it manually. [23:54:46] with bash /srv/tools/silverpop_export/update.sh [23:54:52] oh; ya [23:54:58] don't do it manually any more [23:55:01] it's not going to work [23:55:09] but we were having trouble with the data on the automated file [23:55:10] orly [23:55:16] with the question marks in the first names [23:55:20] and yeah news to me haha [23:55:22] mwalker: jenkins only, now? [23:55:40] jenkins only now -- awight I thought you were going to look at the encoding issue thing? [23:55:43] mwalker: feel free to hand off to me. [23:55:44] yeah exactly. [23:55:51] it's simple. [23:55:55] like very simple. [23:56:05] but alas, there are also many other things. [23:56:16] so data won’t be available for now? [23:56:19] so.. is there a workaround for the download? [23:56:32] We can fire it off. [23:56:34] ...right? [23:56:36]