[00:00:06] we're using a different DB now [00:00:11] it's in the silverpop db [00:00:13] instead of mwlker [00:00:23] so silverpop db is totally safe -- only the script has write there [00:00:31] *only jenkins script [00:00:32] excellent [00:01:13] now that I have enjoyed Katie's lovely voice ... can you point me to where it decides what form to display? / how the payment component is calle [00:01:34] (the dulcet tones... of Katie [00:01:37] s voice) [00:01:38] haha [00:01:40] eek [00:01:51] eileen: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/special/GatewayFormChooser.php [00:01:52] awight, so; the "quick" solution is to take https://git.wikimedia.org/tree/wikimedia%2Ffundraising%2Ftools/53e3ac98fb30a5c8f7f49969cc17fd000f35551f/silverpop_export and move back the export_all.sql and export_unsubscribes.sql and tear out the update stuff from update.sh [00:02:12] eileen: and what do u mean by "payment component"? [00:02:20] awight, the not so quick solution is to figure out if it's the python mysql client out the file writer that's screwing up the encode [00:02:22] the part that makes API calls to the processors? [00:02:42] mwalker: I think that (not so quick) is the approach I'd take [00:03:12] but. should be quick. [00:03:56] awight mwalker - fyi ccogdill was meant to send an email today to japanese donors but can't because she can't get the contacts... is there some timeline that we can give her at all? [00:04:17] yes, that can be emergency work and I can do later tonight. [00:04:32] but, sending today is probably not in the cards [00:04:36] yeah totally [00:04:46] i mean we already passed the time :P [00:04:50] eileen: So, it's complicated. [00:05:16] eileen: Mostly, we try to send people through the form chooser, which will pick an enabled form based on the parameters they arrive with. [00:05:31] But, that's not required... [00:05:44] ok - I tried & wound up at a global collect iframe [00:05:53] Ah, that seems legit. [00:06:06] ...unless you picked paypal. [00:06:34] eileen: Did somebody explain donate wiki yet? [00:07:02] no. [00:07:06] ah, okay. [00:07:33] So, there's this whole other wiki that donors are expected* to hit before they show up at payments wiki. [00:07:37] ok awight i increased the priority of this to emergency. is this the right card or is there some other? [00:07:37] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1772 [00:08:01] * - (unless they come through a banner that takes care of it and sends people straight to payments, but... that's sort of half of another story) [00:08:06] atgo: that's it. thank you! [00:08:27] cool... thanks for taking care of it awight. i know today's been a whirlwind [00:08:27] so at this point https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/special/GatewayFormChooser.php#L67 [00:08:42] it is generating the url https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vma&recurring=&payment_method=cc&utm_source=donate.default~default~default~default~control.cc&utm_medium=sidebar&utm_campaign=C13_en.wikipedia.org&utm_key=&referrer=http%3A%2F%2Fen.wikipedia.org%2Fwiki%2FMain_Page&language=en&country=NZ&returnto=Thank_You%2Fen&amountGiven=¤cy_code=NZD&frequency=onetime&amount=3& [00:08:48] atgo: oh no worries, I don't know why I was a jerk in that meeting. [00:08:58] ? [00:09:03] eileen: The point of donate wiki is: 1) To be cachable, and 2) to geolocate people and present options to that donor that make sense. Then they come to the form chooser. [00:09:31] eileen: And, yeah... that doesn't look surprising. [00:09:57] Every payment gateway has its own special page. [00:11:05] ffname=cc-vma is the way we know what form to display. [00:11:28] In this case: Credit card, with visa, mastercard, and... "a". [00:11:32] ...oh. Amex. [00:11:35] It's been a long day. [00:11:44] hey meganhernandez, are you around? [00:11:56] hi ccogdill i’m here [00:12:07] can I come find you? somewhere on 6th? [00:12:07] im over at pats desk [00:12:18] stole her charger and chair [00:12:30] & from what I understand part of the desire is that rather than having it's own page it would not be duplicate pages ? [00:12:48] "Universal form? TBD" [00:13:08] eileen: I don't know that we want to go that far... but the .html we load can stand to be a LOT more universally usable. [00:13:10] Like, at all. [00:13:16] Right now, it's a copy/paste rodeo in there. [00:13:23] :-) [00:13:54] The special pages probably need to stay distinct at this point. [00:14:06] But, we can totally share templates. [00:14:17] right [00:15:28] I think our last agreement about the templates was, we wanted to control block visibility using very simple arguments to the templates, booleans. These would be like "has cvv check". [00:16:27] A big consideration, though, is that we are going to need those things to be easily overrideable. [00:16:38] hey atgo - just talked to Megan about this email issue [00:16:53] we can put off email if this is disrupting your/awight’s work [00:17:01] eileen: We need to be able to A/B test forms against eachother. [00:17:03] I didn’t think that was okay but we think it is [00:17:11] ccogdill: it's fine to do later tonight, no worries! [00:17:36] eileen: Usually what we do for that is just have a banner use a hard-coded ffname for both samples. [00:17:37] okay, well thank you awight! but if you get into it and it’s more difficult than you thought somehow, keep this in mind [00:18:03] sure. hehe i would never miss a chance to drop difficult work :p [00:20:14] so - I still don't know I've spotted the bit of code that actually renders the payment form - the bit I was lookiing at was choosing the form [00:20:25] yep [00:20:49] eileen: Actually, that's one of those things that's probably buried in mediawiki core. [00:21:29] But, a better and more actionable answer is to work backwards from RapidHTML.php. [00:22:05] That's in DonationInterface. [00:23:19] RapidHTML started out as a "simple" templating mechanism that... can no longer be reasoned with and doesn't feel pain. [00:23:31] :-D [00:24:34] aha https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/68badbd65ba8e167302b1830160662d267a7a334/gateway_forms/RapidHtml.php [00:24:45] Also... there's a Gateway_Form class (which RapidHTML inherits from) and a GatewayForm class (which exists to confuse people). [00:26:15] why wouldn't there be :-) [00:29:05] what does utm stand for? [00:29:23] Good question. It was there when I got here. [00:29:49] ...heh, actually, it's some kind of universal tracking... [00:29:51] * K4-713 googles [00:32:58] eileen: So, apparently we borrowed the utm parameter naming scheme from google analytics, even though I've never seen anybody actually use google analytics in this place, because privacy. [00:33:27] And nothing I've been able to find in three minutes explains what the acronym means. [00:33:29] Awesome. [00:33:51] But. [00:33:56] useful thing maybe [00:34:07] We use them internally to track campaignish things about donations. [00:34:14] or - Unique Trouble Maker [00:34:19] I like it. [00:34:31] It is blazingly useful in spotting fraud. [00:34:50] "Oh, you just donated from a campaign we haven't run in three years, eh?" [00:35:39] But, yeah... they just describe very general things about how the donor came to, and moved through, the donation pipeline. [00:36:36] ok - so the page I got to is GlobalConnect. I presume I can just swap that in the url to see the others - [00:36:54] Ha, kind of. [00:37:03] It's easier to add a gateway=parameter to the form chooser. [00:38:00] Otherwise, you'll have to blank most of the params in the URL or it will complain loudly about trying to load... say, a direct debit form in paypal, which isn't a thing. [00:38:39] ah right [00:38:55] The nice thing about the form chooser, is that it will work with as many parameters as you want to explicitly provide. So, if you leave something out, it'll make an educated guess about what you're trying to do. [00:39:35] And then, you know, send you somewhere that exists. [00:40:20] ok - so Global Collect is an iFrame for credit card, paypal is a redirect to offsite [00:40:28] yeah. [00:40:42] Actually, there are more GlobalCollect payment methods that don't use an iframe. [00:40:56] You'll probably have to change countries to see them, though. [00:41:32] I'll get my round the world ticket :-) [00:41:42] GC supports a ton of... extremely local payment methods. [00:42:45] Example: https://payments.wikimedia.org/index.php?title=Special:GatewayFormChooser&form_name=RapidHtml&appeal=JimmyQuote&recurring=¤cy=EUR&country=NL&amount=1.33&paymentmethod=dd [00:42:46] right - so when I see Bpay (from Australia) is that from GC? [00:42:51] Yep! [00:43:55] & GC renders the form back to your site & you put it in an iFrame? [00:44:24] GC just sends us a link that we use to populate the iframe. [00:44:35] We never see or have the opportunity to interact with the content. [00:44:47] ...but that's just for credit card. [00:44:52] ok & the link has html in it? [00:45:01] oh right DD is different? [00:45:34] Yeah, we only do the partially-hosted thing for credit card so we never have the opportunity to touch credit card numbers. [00:45:42] Easier on the PCI requirements for us. [00:47:13] right - so that Netherlands one actually submits back to your site not GC? [00:47:50] Yep. And we handle the backend communication with GC via a series of API requests. [00:48:38] And, ah... communicate the best answer for the transaction result that we have at the time. [00:48:45] Some of these payment methods take weeks to actually settle. [00:49:56] ok - & so does GC return that form for DD too - or is there somewhere in rapidhtml that determines what is required for ti [00:49:56] it [00:50:10] That's all us. [00:50:22] Basically, we decided to come at it form-first. [00:50:53] So, there will be a dd.html template somewhere in DonationInterface that is enabled for certain localities [00:51:41] And, while that form is automatically translated, there are certain localities that need overrides for blocks of the form, so RapidHTML takes care of that as well. [00:52:13] ...things like whether or not address elements should be displayed, mostly. [00:52:41] Frequently, they're not hard requirements by the gateway itself. [00:53:16] There is one piece of the puzzle you may be missing, though... [00:53:29] ...and that is what html form templates are enabled for what payment methods. [00:53:47] That's in sort of a funny place: It only lives in the fundraising-only branch of mediawiki core. [00:54:23] ok - & what would cause me to get the Adyen gateway? [00:54:27] heh [00:54:37] At this point, nothing. [00:54:40] We disabled it. [00:55:04] ah [00:55:10] But, if we add it back in to the enabled forms and gateways, you might end up there. [00:55:35] There is a mechanism in there for defining priority weights when multiple things do what you are requesting. [00:55:43] Ok - So I've seen a few instances of GC, I've seem Paypal (redirect) on all, I've seem Amazon on the US. [00:55:51] ...we were hoping to someday expand that to have automatic failover for payment methods. [00:55:53] (also redirect) [00:56:19] so, I guess I haven't seen adyen (disabled), Worldpay, payflow pro [00:56:32] We haven't used payflow pro in... [00:56:38] ...over three years. [00:57:12] At this point, we either need to fix it up, or have a payflowproectomy. [00:57:19] It's probably unusable. [00:57:20] :-) [00:57:38] Worldpay... [00:57:42] ...let me see. [00:59:35] WorldPay works in BE. [01:00:25] https://payments.wikimedia.org/index.php?title=Special:GatewayFormChooser&gateway=worldpay¤cy=EUR&amount=1.33&country=BE [01:00:45] OK & stomp? [01:00:49] Aha [01:01:34] Stomp is how we format all our queue messages. [01:01:45] And queue messages are the glue between all the different systems. [01:02:15] So, something happens on payments that is safe to record in realtime, and we send a stomp message to the queue server. [01:02:44] Elsewhere, a queue consumer fires off every two minutes and dequeues messages that describe new donations, into civicrm. [01:03:24] That way, we can take donations faster than our database can record them. [01:04:40] If it's not safe to record in realtime (like, we don't know if we're really going to get the money or not), we construct messages that land in the same queue, from things that either listen for updates, or parse nightly reconciliation files. [01:05:45] K4-713, I vote for blasting payflopro into bits [01:06:03] ...man, I want to do that. [01:06:06] I really do. [01:06:17] * K4-713 eyes the disintegrator button [01:06:17] ok - so when I loook at worldpay it *looks* like it actually submits credit card data to your site [01:06:25] Tricky, isn't it? [01:06:31] but, I'm wondering it maybe some JS intercepts [01:06:33] (yep) [01:06:46] They call it "Silent Post". [01:07:19] We like it because we still don't touch credit card numbers, but we have control over our entire form. [01:07:49] I mean, everybody knows iframes are horrible. [01:08:18] I dislike it because it's a stupid design -- it could've been soooo much easier; but noooo first I have to do a JS call to us to store data, then POST to worldpay, then process a worldpay response and get stuff out of the session that I'd rather not be storing [01:08:32] I'm not bitter [01:08:34] Also, latency. [01:08:42] I know you love latency. [01:08:52] "More round trips!" you always said. :D [01:09:00] let me just do a loop [01:09:16] hmm - I'm missing something - when I look at WorldPay html I don't see it saying to post to their form [01:09:34] So, there's this mediawiki thing, called ResourceLoader. [01:09:56] It exists to fly in things like javascript. [01:10:07] ...and css, and translations... [01:10:11] eileen, I construct a virtual form to submit to worldpay; because of the above stupid [01:11:04] OK - so there is a js intercept in there? [01:11:15] the flow is; "validate data on the client", "submit to our server and validate the bits we care about (and store stuff in session)", "mangle the form and POST to worldpay" [01:11:24] yes; there is a JS intercept [01:12:11] ie https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/68badbd65ba8e167302b1830160662d267a7a334/worldpay_gateway/forms/js/worldpay.js [01:12:23] that's exactly it [01:12:33] OK - that's the way Stripe (another pp) likes you to do it - although they actually host the js script themselves [01:12:51] huh [01:13:12] (off topic kind of but stripe is the processor EFF is using) [01:13:30] so, before it submits to your server you remove the credit card data & substitue i a token? [01:13:51] + t + n [01:14:30] hah; hahah; hahahahaha [01:14:32] no [01:15:14] Looks like validateServerSide calls out the only things we send back to ourselves... [01:15:29] we validate [01:15:29] then request a token [01:15:29] then add that to the form that we post to worldpay [01:16:41] you'll see in validateServerSide() that I never submit the whole form to the WMF [01:16:46] only the bits I want to see [01:16:55] sorry - I meant before the html form submits to your server [01:17:37] do you retain tokens ? [01:17:45] we retain the token in the session [01:17:52] but not in the database yet [01:18:01] we will need to store them in the DB when we support recurring with worldpay [01:18:09] ok - because you don't store details about donors at the payment level do you? [01:18:25] wrt your previous question; server side validation and getting a token from WP happen in the same call to WMF servers [01:18:44] no; we don't store payment level information yet [01:18:49] worldpay will be our first [01:19:09] (we sort of do it though with GC; but it's a subscription ID there that we trigger) [01:19:19] ok & so for worldpay you'll store a token & every month a process will run teslling WP to process another payment? [01:19:25] *nods* [01:23:14] OK so something else - you specifically mentioned EFF as the sort of org you think could benefit from open-sourcing your library - have you been speaking to anyone there? [01:23:30] awight: ^^ :) [01:23:43] Actually, I need to go home more or less now. [01:23:58] sure - & my brain is getting full [01:24:45] one last q - but it can be for later - upcoming payment processors - do they follow any of the formats of existing processors? [01:24:50] eileen: we've only talked about the general idea, there was nothing to sell them yet though. I can poll them for interest level if that's helpful [01:25:37] awight - OK -I thought it would be interesting to hear how they thought it might 'look' [01:25:57] eileen: Ha. New integrations are totally all over the place. But, if we're doing what we need to do in DonationInterface, we normalize everything that we handle. [01:26:41] eileen, the only consistent thing between processors appears to be that they're all insane, and they all will allow you to submit details about a flight plan and accompanying baggage [01:26:53] * K4-713 nods emphatically [01:27:02] ok - so we have 4 different style interfaces - redirect, build iframe off their data, build post form (no cc details) for dd & intercept form with JS & handle from there [01:27:06] oh; and the documentation sucks [01:27:14] :-) [01:27:54] Yeah, we don't really build iframe content. That's totally just a window to whatever they're hosting. [01:28:06] we have a processor in NZ that cut a website off because they were processing too many donations... [01:28:12] ! [01:28:25] I think the first time we turned on donations with GC, it got a little tense. [01:29:12] Ops people of theirs were called. [01:29:16] sure - because they aren't in the business of processing loads of donations.... [01:29:22] heh [01:29:39] Apparently, having extremely seasonal patterns is not something they are used to dealing with. [01:29:44] (PS7) Awight: Simplify main message processing function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/147004 [01:29:46] (PS4) Awight: (FR #1819) Updated Coinbase report format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/148272 [01:30:08] eileen, there is a type of GC redirect where we collect personal info (name and email) and then redirect [01:30:39] https://donate.wikimedia.org/w/index.php?title=Special:FundraiserLandingPage&country=RU&uselang=en&utm_medium=spontaneous&utm_source=fr-redir&utm_campaign=spontaneous [01:30:43] ^ e.g. yandex or webmoney [01:31:20] okay, I'm really going home now. Hopefully our setup is less confusing now... [01:31:32] see ya K4-713 [01:32:01] Later! [01:32:11] mwalker - & that is also based on an html response from GC? [01:33:41] yes [01:35:58] FWIW - that one fails for me I get taken to https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=ew-webmoney&recurring=&payment_method=ew.ew_webmoney&utm_source=donate.default~default~default~default~control.ew.ew_webmoney&utm_medium=sidebar&utm_campaign=C13_en.wikipedia.org&utm_key=&referrer=&language=en&country=RU&returnto=Thank_You%2Fen&amountGiven=¤cy_code=RUB&frequency=onetime&amount=1 [01:38:13] stupid session details [01:38:30] you can goto donate.wikimedia.org/?country=RU and have it generate you a new form and things [01:38:43] we also have some bugs where if you change the payment type it can error out [01:38:54] back buttons are evil [01:39:59] nope - even when I tried NOT forgetting to click on an amount it still wouldn't get me to a form [01:40:52] clearly NZers that want to make donations as if they are in Russia have a problem.... [01:41:07] interesting [01:41:13] I don't know why that would be the case [01:42:24] & probably at this time of your day you're not really THAT interested :-) [01:44:16] well; and I've nominally escaped from fundraising [01:44:29] does the problem go away if you clear your session cookie? [01:45:04] (if it doesn't we can create a bug report; if it does it's just a symptom of the same big huge session management problem we know we already have) [01:45:53] well - it works if I paste the url in chrome so yeah - I think you can conclude it's session [01:49:09] shiney [01:49:58] (it still didn't redirect - but a different problem of some sort) [01:50:18] NB - you haven't escaped fundraising - here is the official deal http://wikimediafoundation.org/wiki/Staff_and_contractors [01:52:35] pah; do you believe everything the internet tells you? [01:52:43] * mwalker quickly creates a page on his personal web site [01:53:50] sure I do & I'm only doing this job until my long-lost Nigerian uncle sends me that money ... [01:54:44] man, you too! [01:55:08] crazy extended nigerian family [01:55:19] he was even a prince! [01:56:26] who knew there was royalty in the blood ay? [01:58:23] I bleed carmine! [01:59:11] that's actually somewhat true... what I actually meant was, I bleed ermine! [02:02:56] To prepare carmine, the powdered scale insect bodies are boiled in ammonia or a sodium carbonate solution, the insoluble matter is removed by filtering, and alum is added to the clear salt solution of carminic acid to precipitate the red aluminium salt, called "carmine lake" or "crimson lake." [02:04:31] it still impresses me how many things we make from insect bodies [02:05:30] :-) [02:07:24] hokay; it is now time for me to go home as well [02:07:37] presumably tty tomorrow [02:07:46] unless you ragequit [02:12:50] see ya [07:32:54] (PS1) Awight: Bump code verbosity and testability [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/148326 [07:32:56] (PS1) Awight: Database configuration is abstract [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/148327 [07:32:58] (PS1) Awight: Correctly uni-encoded CSV export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/148328 [08:12:36] jessicarobell: hi! [08:12:49] hi awight! [08:12:59] I'm calling it quits in a few minutes, but wanted to paste u some errors I'm getting while updating the TY letters: [08:13:02] WD make-than-you: cs -- Page Fundraising/Translation/Thank_you_email_20140606 / cs has never been [error] [08:13:05] published [08:13:56] great, that was the only one of those errors! [08:15:16] jessicarobell: thanks! [08:15:16] Great! Thanks. Just fixed the cs one. Thanks for catching that [08:15:35] I'll let u know in a minute if there are unconsumed tokens... [08:15:43] thanks.. [08:17:56] jessicarobell: once the dust settles from this last workflow "fix"... we should definitely chat again about how to improve this process. [08:18:20] sure. I'll be happy to do that. [08:18:34] WD thank_you: Found 1 likely tokens [$firstname] in thank-you translation [cs]. [error] [08:18:47] that's all [08:18:58] hmm. I'll look at that one. [08:19:18] Is that language a priority, or should I push the others? [08:20:11] jessicarobell: uh, oh. we have commercial activity paragraph... [08:20:33] maybe the wrong revision is getting pulled. [08:21:18] I think we're in that nasty limbo situation I was imagining, where the lack of automatic workflow state changes is making it hard to tell which revision is "published". [08:21:35] the cs now should be fixed now. [08:21:41] Can we look at the Catalan for a second? [08:22:09] I'm trying to tell which version was last marked published. [08:22:37] sigh. so hard to find that page... [08:22:47] Sure. I am on the Catalan now. [08:23:30] do you happen to have the page with review status history? [08:23:38] it's somewhere crazy... [08:24:32] jessicarobell: https://meta.wikimedia.org/w/index.php?title=Special%3ALog&type=translationreview&user=&page=Special%3ATranslate%2Fpage-Fundraising%2FTranslation%2FThank_you_email_20140606 [08:25:14] jessicarobell: yeah, so it's the lack of automatic state change thing. [08:25:23] ok, looking at that page. [08:25:45] anything I can do to help you here [08:25:57] ? [08:25:57] If you want to publish a new version of an already "published" translation, you have to set the state to something else, then toggle it back to "published". [08:26:05] does that make terrible sense? [08:26:16] ah, I see [08:26:28] so sorry. I was really hoping we wouldn't get stuck here. [08:26:43] So should I re-publish all the translations then? [08:26:44] once the auto thing works, it will make a lot more sense. [08:26:48] jessicarobell: yes. [08:26:55] No worries awight. we're getting there.. :) [08:27:03] Ok. will do that right away [08:27:34] jessicarobell: I can help, how about I work backwards alphabetically? [08:27:43] oh. crap actually I no longer have the permissions. [08:27:53] no worries. I'll do it [08:37:25] what a marathon! [08:38:58] hehe. Ok I am done. https://meta.wikimedia.org/w/index.php?title=Special%3ALog&type=translationreview&user=&page=Special%3ATranslate%2Fpage-Fundraising%2FTranslation%2FThank_you_email_20140606 [08:39:09] all the once on the list have been re-published. [08:39:18] looks ok to you? [08:39:41] whew! I'll just use the commercial activity paragraph as a rough indicator [08:40:07] ok. or get some sleep :) [08:41:54] jessicarobell: sq looks old, maybe that was not on th elist? [08:42:09] ok not on the list. [08:42:43] nope. sq is not on the list. I don't have the recurring issue paragraph for that one.. [08:42:48] working on that [08:44:40] jessicarobell: I see some more which are published, but not on the list: [08:44:45] # html/thank_you.bs.html [08:44:45] # html/thank_you.cy.html [08:44:45] # html/thank_you.mk.html [08:44:45] # html/thank_you.yi.html [08:45:14] shall I add them? [08:45:38] nvm, that's a terrible idea. [08:46:02] (PS1) Awight: New TY translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/148331 [08:48:05] (PS1) Awight: New TY translations [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/148332 [08:48:20] jessicarobell: can you shepherd these patches along tomorrow, with the rest of fr-tech? [08:50:14] awight: no, do not add the bs, cy, mk, yi please as these are not finished. [08:50:44] yep agreed [08:50:45] awight: can you shepherd these patches along tomorrow, with the rest of fr-tech? so sorry, but I am not quite sure what I should do here.. [08:51:12] just let them know the patches are ready, and what the urgency is [08:51:40] ah. I see. Sure! [08:51:43] I could send an email, but if you want these deployed it's probably best to nudge people directly [08:51:46] thx! [08:51:54] Thanks for your work on this! [08:52:07] now, get some sleep :) [08:52:09] Looking forward to the last lap here! [08:52:54] yeah. me too, we'll get there [08:53:26] I've taken a few classes lately in a room with this hilarious wall clock... the second hand is loose, but there's just enough friction that it will climb almost up to the :00, but then it falls backwards again each minute. [08:53:40] good entertainment when the class gets dull [08:54:33] haha. What classes are you taking? [08:55:16] just some blacksmithing stuff... [08:57:42] aha! [09:18:40] jessicarobell: good news, I have a fix for the automatic unpublishing thing. We'll probably have that deployed by Wed. [09:18:50] see ya! [11:05:44] (CR) Pcoombe: [C: 2] "Looks good, thanks Adam!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/148331 (owner: Awight) [16:14:57] (PS1) Ejegg: Merge 7.29 upgrade from branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/148396 [16:27:49] (CR) Mwalker: [C: 2] Bump code verbosity and testability [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/148326 (owner: Awight) [16:28:08] (CR) Mwalker: [C: 2] Database configuration is abstract [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/148327 (owner: Awight) [16:28:54] (CR) Mwalker: [C: 2] Correctly uni-encoded CSV export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/148328 (owner: Awight) [16:29:53] mwalker: can you take a look at that 7.29 upgrade merge for me? I got conflicts on all the .info files because contrib never got the 7.27 upgrade, and the patchset in gerrit looks very strange to me [16:30:38] it's showing the conflict resolution rather than the actual changes in master [16:30:52] https://gerrit.wikimedia.org/r/148396 [16:31:54] (CR) Awight: "Awww... Given the circumstances, this is a reasonable thing to do. Alternative is to make a new contrib branch, or revert 7.29 & then co" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/148396 (owner: Ejegg) [16:32:40] (CR) Awight: [C: 2] Merge 7.29 upgrade from branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/148396 (owner: Ejegg) [16:33:37] howdy awight! Glad to hear that's what the patchset is supposed to look like [16:35:11] ejegg: well, not really. But the only real detrimental effect is that it becomes less clear when there's a conflict in code we've actually customized. [16:35:47] Luckily, in drupal - core we only have one or two small hacks. [16:35:51] yeah, would be nice to see the actual diff [16:36:14] the only thing I had to take from master in the resolution was adding the NamespacedFile to system.info [16:38:15] That sounds like my hack. We should probably do the same thing as in civi, where un-upstreamed patches are stored as sofa [16:38:29] sofa? [16:38:36] That sounds like my hack. We should probably do the same thing as in civi, where un-upstreamed patches are stored as diff files for reference [16:38:45] Hehe phone phail [16:38:57] heh [16:39:07] i keep all my diffs under my mattress [16:39:45] That's the basic idea :when you can't trust the banker [16:40:23] hrm, locally drush updatedb complains a dozen or so times: X requires this module. (Currently using Unresolved dependency civicrm (Missing)) [16:40:45] did I nuke the civicrm symlink or something? [16:41:35] yep, so I did [16:56:53] the-wub, I'm getting ready to deploy petition [16:56:59] just having reedy double check me [16:58:12] (PS1) Ejegg: Update drupal submidule to 7.29 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/148411 [16:59:04] awesome, thanks mwalker [16:59:31] (CR) Ejegg: [C: 2] Update drupal submidule to 7.29 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/148411 (owner: Ejegg) [17:01:28] (PS2) Ejegg: Update drupal submodule to 7.29 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/148411 [17:19:44] the-wub, scapping [17:20:11] * the-wub makes excited noises [17:39:46] the-wub, ok; it's partially on foundationwiki [17:39:52] still waiting for the i18n files to drop [17:40:07] but you can get someone to add you to the petitionadmin group or whatever it was you called it [17:40:10] and test it out [17:40:27] cool, thanks matt. any idea when the i18n files will be live? [17:40:34] 10/20 minutes [17:40:50] ah great :) [17:41:13]