[00:04:27] (CR) Awight: "I really like it!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 (owner: Ejegg) [00:13:04] (PS3) Awight: Get innerHTML correctly in DI node assertions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/150897 (owner: Ejegg) [00:13:10] (CR) Awight: [C: 2] Get innerHTML correctly in DI node assertions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/150897 (owner: Ejegg) [00:13:23] (Merged) jenkins-bot: Get innerHTML correctly in DI node assertions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/150897 (owner: Ejegg) [00:14:44] (CR) Awight: Get innerHTML correctly in DI node assertions (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/150897 (owner: Ejegg) [00:15:05] (CR) Awight: "Still WIP?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/151673 (owner: Ejegg) [01:36:42] (CR) Ejegg: "I need to write test for something called 'Sofort', but that could totally be a different patch." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/151673 (owner: Ejegg) [01:37:03] (PS3) Ejegg: Test cases for Belgium [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/151673 [01:37:05] (CR) jenkins-bot: [V: -1] Test cases for Belgium [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/151673 (owner: Ejegg) [01:42:35] (PS4) Ejegg: Test cases for Belgium [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/151673 [01:45:23] (CR) Ejegg: "Yeah, to mark a specific external email as bounced will take some matching. Silverpop's bounces are tied to a specific mailing and email " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 (owner: Ejegg) [01:46:23] (CR) Awight: "Oh, great! Well in that case the interface here makes sense." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 (owner: Ejegg) [01:55:24] The number Coinbase donors living on "123 bob st" is hilarious [01:58:11] must be a pretty high tech tenement [01:58:30] the landlord accepts dogecoin yah [01:58:40] such wow [01:58:49] this is silly, we needa not collect addresses [01:59:18] yeah, wasn't that floated as a possibility in some email chain? [01:59:28] depending on amount [01:59:29] we're about to create a DOS attack on bob@me.com's inbox... [01:59:35] oh man [01:59:42] I was pushing for it but afair no response [01:59:43] that bob [02:00:20] well, there's always presenting the technical solution as a fait accompli [02:00:37] hehe ssshhhhh [02:00:40] <_< [02:00:41] >_> [02:01:20] but yeah i'm about to see if our sanitizer calls in quit [02:01:42] I mean... the report filename itself was pretty much a unicode attack. [02:01:43] coinbase generates new wallet addresses for each donation? [02:01:54] it contained FF20... [02:02:08] or do we have an address that's just not publicized? [02:02:09] um excellent question, I haven't figure that out yet [02:02:20] I think it's a one-time wallet [02:02:35] yeah, easier to track payments that way [02:03:23] huh, that seems like killing flies with an electrified tennis racket [02:03:46] i'm in Kendall square right now. Seeing as how they gave each MIT student $100 in BTC, a bunch of QR code stickers with the wp logo and our address could rack in some bux around here [02:03:59] euuush [02:04:08] that's exactly the fear, isn't it [02:04:23] that we're feeding the speculation [02:04:29] right, dollars coming in with no way to nag them for more [02:04:34] oh, that too [02:04:50] hehe !-1 nice point though [02:05:11] we'll send our repo guy to qwert main st [02:05:15] ok, gonna hop on the old steed and roll home [02:05:17] nice [02:05:21] cya [02:14:40] Hi awight! Thanks so much for reviewing the Campaigns patches and for augmenting the CN Mingle cards :) [02:15:02] AndyRussG: aww, I bare scratched the surface of the campaigns work you've done [02:15:18] pls do ping me if I let the backlog pile up like that again! [02:15:43] Or just any time it would convenient to have review-- I'll happily say no if it's a bad time ;) [02:15:54] Ah cool, thanks [02:16:05] For the CN stuff, I was gonna ask you if there are other cards I should be explicating? [02:17:43] Mmm it might be nice if there's some doc about Allocations and GlobalAllocations or something, to get a handle on 961, that's the only other one [02:17:53] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/961 [02:18:55] Yeah I was actually going a bit crazy part of last month, ended up having to bill less hours several times 'cause of my move... 8p [02:19:33] AndyRussG: this is all we have so far, https://www.mediawiki.org/wiki/Extension:CentralNotice/Allocation_history and https://www.mediawiki.org/wiki/Extension:CentralNotice/Allocation_system [02:20:12] I can give the whole spiel maybe over a call, or from a computer with a working spacebar ;) [02:20:33] "device [02:20:38] (...So totally np about the code review backlogging a bit...) [02:20:57] Ah cool, whatever's easiest for you is cool, anytime [02:20:59] yeah anintercontinental move w/ family blows my mind [02:21:09] I can just barely imagine [02:21:35] So, "device" is the viewer's browsing device class [02:21:51] there's a table that should be populated in yr db [02:22:08] one sec, family [02:22:09] Heh, if I hadn't been so caught up in the details of it all I would have spent a lot more energy just disbelieving that we actually made it :) [02:22:52] A few things aaalmost didn't work out but luckiy did :) [02:23:55] yeah inlaws for example ;) [02:24:10] 1111111111111111 [02:24:14] mari sez hi ^^ [02:24:16] Heh heh yeah [02:24:22] Hi mari! [02:24:46] The more organized and slighly more extreme version is Sage's... he's driving! I think successfully avoided 11th hour packing craziness, too [02:25:02] mari: that's a nice number! :D [02:25:08] y``````````````````````````````````````````````````````````````````````````````````````````````` [02:25:21] hehe u should see what she can doowith a root shell [02:26:04] Just don't leave any rm -rf's in your root bash history :) [02:26:17] so, device is a banner-level criterion, it just determines whether the banner can be shown or not [02:26:33] there are a few functions for dealing with devices, listing them and stuff [02:26:58] for Special:Allocations,it's pretty straightforward [02:27:30] for GlobalAllocations,we just have to do the devicefiltering in a slightly weird place, where all the other banner criteria are handled. [02:29:27] getBannerAllocationsVariantRow will have to know about devices [02:29:43] What's the difference between Allocations and GlobalAllocations? [02:30:17] Allocations is the old thing, it gives just one slice of allocation info for a single campaign selection context [02:30:46] GLobalAllocations was my attempt at replacing that with something that could show all allocations across the system,for a given point in time [02:30:59] filters are required for Allocations, and optional for GlobalAllocations [02:31:25] looking at #961 more, it's not as trivial as I was hoping--this will be the first banner-level criterion filter. [02:32:28] So I guess one approachwould be to filter out banners after the campaigns are dumped,but before the intersectionsare calculated [02:32:37] (addspaces liberally:() [02:33:50] Hmmm [02:34:08] All of that is code that I haven't dived into much yet [02:34:35] Does it make sense to leave that card for last, and use the simpler ones to get more familiar with the codebase? [02:34:36] jfyi, the campaign vs banner criteria thing is not actually recognizedin the code yet [02:34:42] it was something we realized late inthe game [02:34:49] AndyRussG: yeah that makes sense [02:36:57] I'd really like to make all the Criteria and SelectionContexts proper classes [02:37:39] Hmmm [02:38:13] What are they now? Is that also something that might come before card 961? [02:39:36] They are implicit assumptions buried in mountainsof code :D [02:39:47] That work could come before [02:41:33] gold in the mountains! [02:42:57] K that's a decision that's not for me at this point [02:43:18] Happy to do it whichever way [02:46:48] I can keep an eye out for refactoropportunities in any case [02:47:53] Will I understand more about what u mean by Criteria and SelectionContexts once I get more into the code and read that doc :) ? [02:49:13] hehehe no. [02:49:23] But we should talk whenever you're interested. [02:49:32] I think there is actually a lot of fun work to do :p [02:49:59] btw /me increasinglydistracted [02:53:12] in general, I'm quite happy to elaborate on any cards; they're mostly triage notes at this point [02:59:37] Ah cool thanks much... K, I guess I'll just take it as it comes... So maybe I'll try the other, low-hanging-fruit cards, learn the system a bit more, and then we talk refactor? [07:01:54] (PS1) Awight: get fancy with a log message /me wags eyebrows [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151817 [07:01:59] (CR) jenkins-bot: [V: -1] get fancy with a log message /me wags eyebrows [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151817 (owner: Awight) [11:34:18] (PS1) Hashar: Jenkins job validation (DO NOT SUBMIT) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151840 [11:34:36] (CR) Hashar: "check experimental" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151840 (owner: Hashar) [14:15:59] (CR) Hashar: "check experimental" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151840 (owner: Hashar) [17:33:43] (PS4) Ejegg: Track thank you emails to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151574 [17:33:45] (PS4) Ejegg: Classes to track external mailings to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 [17:37:50] (CR) Ejegg: "Most comments from PS3 answered inline" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151574 (owner: Ejegg) [17:38:29] (CR) Ejegg: "PS3 answers inline" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 (owner: Ejegg) [20:51:04] (PS5) Ejegg: Track thank you emails to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151574 [20:51:06] (PS5) Ejegg: Classes to track external mailings to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573 [20:57:08] (PS6) Ejegg: Track thank you emails to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151574 [21:32:35] ejegg i'm in the hangout :) [21:32:38] and AndyRussG [21:32:41] i think it's just us today [21:33:01] coming! [22:15:46] quick question 4 anyone out there: for this card: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/29 [22:15:46] How many campaigns is a banner typically assigned to? Just thinking about what sort of UI might be appropriate