[03:51:20] <grrrit-wm>	 (PS1) Awight: WIP hook_civicrm_post; step towards Mailer->Templating integration; large_donation overhaul [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[03:51:24] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP hook_civicrm_post; step towards Mailer->Templating integration; large_donation overhaul [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 (owner: Awight)
[07:42:51] <grrrit-wm>	 (PS2) AndyRussG: Schema change for comments on changes for logs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/152145 (https://bugzilla.wikimedia.org/31689)
[07:46:37] <grrrit-wm>	 (PS1) AndyRussG: Add comments on changes, for logs and revisions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689)
[07:46:43] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Add comments on changes, for logs and revisions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG)
[07:59:06] <grrrit-wm>	 (PS2) AndyRussG: Add comments on changes, for logs and revisions [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689)
[08:05:06] <grrrit-wm>	 (CR) AndyRussG: "Hi! Note: please don't merge this until the code that goes with it has been reviewed:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/152145 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG)
[11:51:40] <grrrit-wm>	 (CR) Siebrand: [C: -1] "i18n/L10n reviewed." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG)
[16:32:36] <grrrit-wm>	 (PS2) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[16:32:38] <grrrit-wm>	 (PS1) Awight: Get rid of thank-you synchronous mode [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153415
[16:32:40] <grrrit-wm>	 (PS1) Awight: Remove unused hooks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153416
[16:32:42] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 (owner: Awight)
[16:33:32] <grrrit-wm>	 (Abandoned) Awight: Remove old hooks. Get rid of thank-you sync mode. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/152994 (owner: Awight)
[17:53:08] <grrrit-wm>	 (PS3) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[17:53:10] <grrrit-wm>	 (PS1) Awight: Move HTML->plaintext conversion down to Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153422
[17:53:12] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 (owner: Awight)
[17:53:14] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Move HTML->plaintext conversion down to Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153422 (owner: Awight)
[17:55:24] <grrrit-wm>	 (PS2) Awight: Move HTML->plaintext conversion down to Mailer class. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153422
[17:55:39] <grrrit-wm>	 (PS4) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[17:55:41] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 (owner: Awight)
[18:03:48] <grrrit-wm>	 (CR) Awight: [C: -1] "Looks great, but varchar(255) is probably too restrictive. MW-core uses "tinyblob" to store comments." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/152145 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG)
[18:27:15] <grrrit-wm>	 (PS1) Ejegg: Tests for CiviMail helpers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153426
[18:27:18] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Tests for CiviMail helpers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153426 (owner: Ejegg)
[18:34:34] <grrrit-wm>	 (PS8) Ejegg: Track thank you emails to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151574
[18:34:36] <grrrit-wm>	 (PS7) Ejegg: Classes to track external mailings to CiviMail [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/151573
[18:34:38] <grrrit-wm>	 (PS2) Ejegg: Add activity records for individual thank you emails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/152208
[18:34:40] <grrrit-wm>	 (PS2) Ejegg: Tests for CiviMail helpers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153426
[18:39:19] <grrrit-wm>	 (CR) Ejegg: [C: 2] Accept anything callable as a callback, need not be a global function name. [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/111742 (owner: Awight)
[18:40:16] <grrrit-wm>	 (CR) Awight: "Inline comments for things I don't understand." (8 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG)
[18:41:21] <grrrit-wm>	 (CR) Ejegg: [C: 2] tweak to allow namespaced & static member getForm methods [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/130653 (owner: Awight)
[18:41:25] <grrrit-wm>	 (PS4) Awight: Comment that HHVM will mess up this code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/149468
[18:51:52] <grrrit-wm>	 (CR) Ejegg: [C: 2] Upgrade to Drupal 7.31 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/152976 (owner: Awight)
[18:53:43] <grrrit-wm>	 (Abandoned) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/152995 (owner: Awight)
[18:54:44] <grrrit-wm>	 (CR) Ejegg: [C: 2] Merge contrib [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/152979 (owner: Awight)
[18:55:11] <grrrit-wm>	 (CR) Ejegg: [C: 2] gitreview points to the contrib branch [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/152977 (owner: Awight)
[18:55:13] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Merge contrib [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/152979 (owner: Awight)
[18:57:49] <ejegg>	 awight: not sure what's up with the drupal contrib merge.  jenkins-bot says Verified-1, but it only lists phplint, and that was skipped
[19:02:37] <grrrit-wm>	 (CR) Ejegg: [C: 2] horrible thing to smooth out background noise during testing [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/151254 (owner: Awight)
[19:02:40] <awight>	 ejegg: ah, that's usually cos of rebase fail I think
[19:02:46] <awight>	 Thanks for the review spree!
[19:03:13] <ejegg>	 any time!
[19:03:38] <awight>	 FWIW, I should document LanguageTag somewhere more official than random Mingle cards, but the short story is that we're trapped between MediaWiki's slightly off language codes, and Civi's terrible unix locale style language codes.
[19:03:58] <ejegg>	 oh man, locale strings
[19:04:01] <awight>	 LanguageTag gives us some tools to normalize from either crazy language code system, and stores in a BCP format
[19:04:09] <ejegg>	 BCP?
[19:04:10] <awight>	 I'm pretty happy with the BCP though.
[19:04:14] <awight>	 best current practices
[19:04:22] <ejegg>	 ah, cool
[19:04:48] <awight>	 https://github.com/wikimedia/wikimedia-fundraising-LanguageTag
[19:04:54] <awight>	 http://tools.ietf.org/search/bcp47
[19:05:31] <awight>	 My theory is that Civi should be storing language as a freeform string, which using BCP-47 can encode null, one language of any specificity, or multiple languages in preference order
[19:05:59] <ejegg>	 is that derived from Extension:LanguageTag in any way?
[19:06:00] <awight>	 Unfortunately, the upstream is moving towards fixed multiple-choice lists of languages, cos that's the only real use case
[19:06:03] <awight>	 no
[19:06:06] <awight>	 What's that?
[19:06:14] <ejegg>	 http://www.mediawiki.org/wiki/Extension:LanguageTag
[19:06:25] <awight>	 Ah OK, no
[19:06:29] <ejegg>	 Oh, doesn't look like anything we'd need anyway
[19:06:55] <awight>	 But I do have to coordinate with Runa Bhattacharjee about this
[19:07:14] <ejegg>	 someone on the i18n team?
[19:07:17] <awight>	 yah
[19:07:28] <awight>	 She's been trying to rationalize the MediaWiki codes...
[19:08:15] <ejegg>	 noble effort
[19:09:29] <awight>	 I stopped pushing to integrate LanguageTag after I succeeded in making the language code nullable in Civi...
[19:10:05] <awight>	 Cos a discussion with Civi-core guy made the problem much harder--if I integrate upstream, I'll have to do it as an extension, rather than fixing core.
[19:10:20] <awight>	 And making that compatible with the bad fixed-list thing would be horrible.
[19:10:37] <ejegg>	 oh, they have reasons for keeping locale strings?
[19:10:47] <awight>	 urgh
[19:11:24] <awight>	 I don't think I can agree with the reasons, but the overall argument is decent: we're the fringe case.  Don't break other people's usage.
[19:11:53] <ejegg>	 bah
[19:12:06] <awight>	 By that measure, even the nullable language thing is not upstreamable, cos 3rd-party modules *might* expect (bad) default data in the preferred_language field
[19:12:40] <ejegg>	 so do we track preferred language in other ways?
[19:12:58] <awight>	 nah we ruthlessly hack Civi to do what I consider the right thing :)
[19:13:15] <ejegg>	 heh, ok
[19:13:15] <awight>	 actually, the primary source for donor language is contribution_tracking
[19:13:22] <awight>	 but it gets stored in civicrm_contact after donation
[19:14:52] <ejegg>	 oh, there's a civi meetup at fsf next tues.  I'd like to pick your brain about how we customize civi sometime before that
[19:19:36] <awight>	 ejegg: that would be great!  I'd like the opportunity to ramble about Civi customizations as well ;)
[19:20:15] <ejegg>	 rockin.  Let me know when works best for you.  I'll peruse our patches for starters.
[19:20:18] <awight>	 Every once in a while, I split out our patches to core so we can see what's happening, I should update those.
[19:20:34] <ejegg>	 oh yeah, that would be great
[19:21:30] <awight>	 Actually, we've been talking to the WMF staff charged with Civi admin duty recently.  We're hoping to have someone come in and give us a few Civi trainings, so we are informed enough to do more in-app customization.
[19:21:34] <awight>	 We need that badly...
[19:21:58] <awight>	 There's also a sort of huge project slowly underway, https://trello.com/b/HmPIQDhc/civi-major-gifts
[19:22:04] <ejegg>	 oh yeah.  i'd be happy if i could just get my local menus looking like production :)
[19:22:19] <awight>	 We'll be implementing a custom CiviCase workflow for Major Gifts to track interactions.
[19:22:33] <awight>	 ejegg: urgh.  What do they look like now?
[19:22:55] <awight>	 The top or sidebar menus?
[19:23:01] <ejegg>	 both
[19:23:13] <ejegg>	 but i haven't really tried much
[19:23:18] <awight>	 well, the sidebar is all Drupal admin/structure customization, you'd have to dump the db to get those
[19:23:21] <ejegg>	 so no big deal
[19:23:26] <awight>	 the top menu should better-behaved
[19:23:27] <ejegg>	 oh yeah
[19:23:50] <awight>	 The only big difference would be that the production site defaults to redirecting to /civicrm
[19:23:56] <awight>	 which has different menus than /admin
[19:24:02] <awight>	 (Civi vs Drupal admin menus)
[19:24:23] <ejegg>	 yeah, it's mostly similar - just mine always shows the drupal menu along with the civi menu
[19:24:28] <awight>	 OH
[19:24:33] <awight>	 that would be, bad
[19:24:51] <ejegg>	 just taking precious vertical space
[19:26:22] <awight>	 ejegg: do you have an accordion arrow at the right end of the menubar?
[19:26:28] <awight>	 That should collapse the Drupal options
[19:27:10] <ejegg>	 yeah, that hides the 'add content find content' bar, but the other drupal bar is still there
[19:27:30] <ejegg>	 dashboard | content | structure etc
[19:28:15] <awight>	 ejegg: what is your theme set to?
[19:28:24] <awight>	 I think production is using Bartik
[19:28:32] <awight>	 also check "admin theme"
[19:28:37] <ejegg>	 yep, same
[19:28:42] <awight>	 hrrm
[19:28:59] <ejegg>	 ehh, no big deal
[19:29:03] <ejegg>	 i'll figure it out
[19:32:22] <awight>	 Yeah lmk if you do, cos I'd sort of like to have that problem
[19:32:45] <ejegg>	 will do
[19:34:18] <atgo>	 hey awight  is 1855 redundant to 1830?
[19:34:39] <atgo>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1855
[19:34:41] <atgo>	 https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1830
[19:35:25] <awight>	 atgo: no, they're different tasks
[19:35:28] <grrrit-wm>	 (CR) AndyRussG: Add comments on changes, for logs and revisions (7 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG)
[19:35:36] <atgo>	 k
[19:37:48] <atgo>	 and awight  confirming i should delete https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1818
[19:37:49] <atgo>	 ?
[19:39:33] <grrrit-wm>	 (CR) Awight: [C: -1] "Only real blocker is the 255-character limit" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/153385 (https://bugzilla.wikimedia.org/31689) (owner: AndyRussG)
[19:39:46] <awight>	 atgo: y, thank you!
[19:41:26] <awight>	 ccogdill: jfyi, I'm ready to backfill the missing recurring globalcollect contributions.  My plan is to suppress thank-you letters, so the backfilling itself won't cause spamming.
[19:41:38] <awight>	 Once we have translations, we can release the letters one language at a time...
[19:42:29] <ccogdill>	 awight did you just ping me? I saw the notification but for some reason can’t see the message :/
[19:42:39] <awight>	 On that note... ejegg, atgo, heads-up, I'm gonna deploy some of the recent sketchy CRM work I've been doing.
[19:42:47] <awight>	 ccogdill: oh weird!  12:41 < awight> ccogdill: jfyi, I'm ready to backfill the missing recurring globalcollect contributions.  My plan  is to suppress thank-you letters, so the backfilling itself won't cause spamming.
[19:42:53] <awight>	 12:41 < awight> Once we have translations, we can release the letters one language at a time...
[19:43:18] <awight>	 If you're ok with that, I'll go ahead and backfill over the next hour.
[19:43:33] <atgo>	 thanks for the heads up awight
[19:43:34] <ejegg>	 yeah, those patches looked good to me
[19:44:06] <awight>	 ejegg: well... me too, but before and after I was chasing subtle bugs in circles, so my confidence is eroded
[19:44:28] <ccogdill>	 awight my IRC thing was being weird, still no messages. just signed out - can you resend one more time? :D
[19:44:30] <ccogdill>	 sorry about that
[19:44:36] <awight>	 hehe.
[19:44:40] <awight>	 12:42 < awight> ccogdill: oh weird!  12:41 < awight> ccogdill: jfyi, I'm ready to backfill the missing recurring  globalcollect contributions.  My plan  is to suppress thank-you letters, so the backfilling itself  won't cause spamming.
[19:44:44] <awight>	 12:42 < awight> 12:41 < awight> Once we have translations, we can release the letters one language at a time...
[19:44:47] <awight>	 I can email, too :p
[19:44:48] <ccogdill>	 yay I saw that ! thanks
[19:44:58] <awight>	 lol no worries
[19:45:13] <ccogdill>	 so this is related to that one long thread with Jessica, right?
[19:45:18] <awight>	 It's always nice to hear that technology hates someone more than me
[19:45:23] <awight>	 ccogdill: Yes
[19:45:28] <ccogdill>	 ohh I’m always around for that
[19:45:41] <awight>	 hehehe you should work on the 3rd floor
[19:45:47] <awight>	 we... have problems
[19:46:01] <ccogdill>	 and okay - so what do you mean by suppress TY letters? like they’ll go to spam for people?
[19:46:09] <awight>	 no, that we will not send them out
[19:46:12] <ccogdill>	 and I should!
[19:46:13] <ccogdill>	 ohhh
[19:46:14] <awight>	 the "no thank you" reason will be set
[19:46:26] <ccogdill>	 okay… that wasn’t the original plan, was it?
[19:46:29] <awight>	 then, we'll go and unset that flag for single languages as the translation is ready
[19:46:35] <awight>	 it's pretty much the original plan
[19:47:03] <awight>	 I mean, somewhere around email #17 we decided to do it this way
[19:47:15] <ccogdill>	 haha there was a lot of back and forth
[19:47:25] <awight>	 well, there are so many languages also...
[19:48:35] <ccogdill>	 so I think I’m just confused because I’m using a different set of terms to talk about this — when you say you won’t send TY’s out, you just mean temporarily until we have the translations for each language?
[19:48:39] <ccogdill>	 just confirming awight
[19:49:44] <awight>	 yes exactly
[19:49:55] <awight>	 The contributions will be recorded, but no TY letters will be sent
[19:50:05] <ccogdill>	 oookay
[19:50:07] <ccogdill>	 I’m on board!
[19:50:09] <ccogdill>	 sounds good
[19:50:14] <awight>	 great!
[19:50:16] <ejegg>	 ccogdill: TY messages will continue to go out for normal contributions
[19:50:20] <ccogdill>	 perfect
[19:50:24] <ccogdill>	 thanks awight and ejegg!
[19:50:25] <awight>	 yep that is important :)
[19:50:26] <ejegg>	 right, awight?
[19:50:32] <ejegg>	 gotcha
[19:50:33] <awight>	 mos def
[19:56:29] <awight>	 Accidentally read, http://valleywag.gawker.com/smiling-young-white-people-make-app-for-avoiding-black-1617775138
[19:56:50] <awight>	 Good reporting and saucy comments
[19:57:06] <ejegg>	 oh man, another one of those apps?
[19:57:22] <awight>	 "avoid ghetto"
[19:57:23] <ejegg>	 wasn't there just a stink about one last year
[19:57:35] <atgo>	 ugh
[19:58:46] <atgo>	 the comments are indeed saucy
[19:58:53] <ejegg>	 also, why not just use zillow's property price maps if you're so worried about seeing poor folks
[19:58:58] <awight>	 hehehe
[20:00:09] <awight>	 Wow, I can't even tell what's going on behind the photo of these masterminds... is that graffitti partially photoshopped off of the brick wall?
[20:00:22] * awight wipes tears
[20:00:29] <awight>	 are they handcuffed together?
[20:03:47] <grrrit-wm>	 (PS5) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[20:03:51] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 (owner: Awight)
[20:05:43] <grrrit-wm>	 (PS6) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[20:05:45] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376 (owner: Awight)
[20:06:32] <grrrit-wm>	 (PS7) Awight: WIP (FR #1855) Refactor import hook to lower level [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153376
[20:21:11] <grrrit-wm>	 (PS1) Awight: Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/153443
[20:21:27] <grrrit-wm>	 (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/153443 (owner: Awight)
[20:52:23] <awight>	 ccogdill: looks like we have not begun the process of having the UnrecordedCharge thing translated...
[20:52:30] <ccogdill>	 really?
[20:52:34] <awight>	 Yeah :(
[20:52:46] <awight>	 https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_20140606
[20:53:28] <ccogdill>	 hmnm, Jessica said it would go up for translation 6 days ago
[20:53:50] <awight>	 Eep.  /me checks that email
[20:54:45] <ccogdill>	 I think we just have to look at the entirety of last week as Wikimania
[20:55:17] <awight>	 hehe yeah
[20:55:23] <awight>	 I do see the email you're talking about.
[20:55:38] <awight>	 I don't know why that isn't reflected in the letter, though.
[20:56:39] <awight>	 Oh wow, nvm I see what happened.  OK good thing I checked, the conditional is wrong...
[20:58:38] <ccogdill>	 ohh yes, it’s right there
[20:58:49] <ccogdill>	 shouldn’t it have a new date?
[21:05:52] <awight>	 Well, I guess "earlier in 2014" will still work
[21:06:34] <awight>	 I'm okay with losing the earlier paragraph... for now... we can always add again if we need.
[21:06:46] <awight>	 Definitely not what I had planned, though.
[21:06:52] <awight>	 In fact, I'm just gonna add it again now.
[21:09:04] <awight>	 Done.
[21:09:29] <awight>	 I figure this is easier than letting the translations get stale...
[21:14:00] <grrrit-wm>	 (PS1) Awight: (FR #1623) Need to add a tag to track backfill [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153508
[21:14:40] <awight>	 ejegg|away: when you have a second ^^
[21:18:01] <grrrit-wm>	 (PS1) Awight: copy n paste typo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153521
[21:33:47] <atgo>	 awight ejegg|away AndyRussG standup?
[21:33:49] <awight>	 ejegg|away: atgo: AndyRussG: inerested in standup?
[21:33:53] <awight>	 hehe
[21:33:55] <atgo>	 JINX
[21:33:59] <awight>	 1
[21:33:59] <awight>	 2
[21:33:59] <awight>	 3
[21:34:00] <awight>	 34
[21:34:00] <awight>	 4
[21:34:02] <awight>	 5
[21:34:04] <awight>	 6
[21:34:06] <AndyRussG>	 yepooo
[21:34:07] <awight>	 7
[21:34:09] <awight>	 8
[21:34:12] <awight>	 89
[21:34:14] <awight>	 10
[21:37:41] <ejegg|away>	 sorry, network issues
[21:39:34] <ejegg|away>	 mind adding me by phone?
[21:40:56] <awight>	 ejegg|away: pm the cellie?
[21:50:07] <awight>	 ejegg|away: if u do get the chance, I could use emergency review on https://gerrit.wikimedia.org/r/153508
[22:00:51] <awight>	 AndyRussG: I see that both tinyblob and varchar255 are in use: grep _comment maintenance/tables.sql
[22:01:44] <awight>	 AndyRussG: oh, hah--tinyblob is 2^8 bytes.
[22:01:56] <awight>	 That's silly.
[22:02:27] <CaitlinVirtue>	 someone from Coinbase is here at the office with "something" for Pats
[22:02:50] <CaitlinVirtue>	 @awight are you expecting another USB from them?
[22:03:50] <grrrit-wm>	 (CR) Ejegg: [C: 2] (FR #1623) Need to add a tag to track backfill [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153508 (owner: Awight)
[22:04:07] <awight>	 CaitlinVirtue: argh, not on my calendar though.  Can you ask office IT to give you a loaner laptop to copy the report onto?
[22:04:30] <grrrit-wm>	 (CR) Ejegg: [C: 2] copy n paste typo [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/153521 (owner: Awight)
[22:04:46] <awight>	 Sorry for the hassle.  You could also copy to your local hard drive, if you want to take your chances :)
[22:04:50] <CaitlinVirtue>	 are you here???
[22:04:54] <awight>	 no!
[22:04:56] <CaitlinVirtue>	 ok
[22:06:34] <CaitlinVirtue>	 Yeah....you've exceeded my tech knowledge....i should get a laptop from IT and then do what with the file?  Oh god Gerrit--that's like for real engineer stuff
[22:06:49] <awight>	 CaitlinVirtue: hehehe
[22:06:58] <awight>	 CaitlinVirtue: no, just get a loaner laptop and copy the file onto it
[22:07:29] <CaitlinVirtue>	 OK, can do
[22:07:49] <awight>	 So sorry that I'm not around to field that, say "hi" to Adam White for me
[22:09:23] <CaitlinVirtue>	 done!
[22:09:31] <CaitlinVirtue>	 the saying hi, that is
[22:09:38] <awight>	 CaitlinVirtue: OH hah
[22:09:59] <awight>	 Safer you than me ;)
[22:10:02] <AndyRussG>	 awight: I was looking at this: https://upload.wikimedia.org/wikipedia/commons/thumb/4/42/MediaWiki_1.20_%2844edaa2%29_database_schema.svg/2500px-MediaWiki_1.20_%2844edaa2%29_database_schema.svg.png
[22:10:07] <AndyRussG>	 Not sure it's up to date tho
[22:10:12] <awight>	 cool!
[22:10:47] <awight>	 well, revision.rev_comment is tinyblob, but I see now that it's the same capacity as varchar(255)
[22:10:59] <AndyRussG>	 right
[22:11:05] <awight>	 So I'm quite wrong, no reason to change your code!
[22:11:11] <AndyRussG>	 recentchanges rc_comment is varchar 255, that's where I got it from
[22:11:17] <AndyRussG>	 I don't mind changing it :)
[22:11:30] <awight>	 ah.  yeah that's used like an index though, isn't it?
[22:11:57] <awight>	 but no there's no reason at all to change it
[22:12:43] <awight>	 I was going to wait for you to fix up docstrings and whatever else
[22:14:08] <grrrit-wm>	 (PS1) Awight: Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/153530
[22:14:19] <grrrit-wm>	 (CR) Awight: [C: 2] Merge remote-tracking branch 'origin/master' into HEAD [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/153530 (owner: Awight)
[22:16:10] <AndyRussG>	 awight: yeah there's that and some magical message details
[22:20:01] <AndyRussG>	 Found where I got the truncate code from:
[22:20:01] <AndyRussG>	 https://doc.wikimedia.org/mediawiki-core/master/php/html/EditPage_8php_source.html#l00745
[22:20:46] <AndyRussG>	 I wonder what happens if they're multibyte unicode characters? In English it adds a "..." on the end
[22:21:24] <awight>	 Yeah... seems like you cloned perfectly but might want to make a card to core assumptions later.  For example, we silently truncate a long summary?
[22:22:16] <AndyRussG>	 In English no, it does get the ... I'm just worried about whether the limit is characters or bytes
[22:22:38] <AndyRussG>	 As in, if it's 255 characters, in other languages that may not fit in the 255 bytes we're providing
[22:24:34] <awight>	 That is definitely an issue!
[22:27:04] <CaitlinVirtue>	 awight  i'm going to lock the usb up for now and let you all handle this when you're in this week
[22:27:27] <AndyRussG>	 awight: looks like we're covered! https://doc.wikimedia.org/mediawiki-core/master/php/html/classLanguage.html#a62032208696d13ef34ad83667233b0c2
[22:29:25] <awight>	 CaitlinVirtue: okay that's perfect!
[22:32:35] <awight>	 AndyRussG: oh, good.  The db should truncate safely, too, if necessary.
[22:33:42] <awight>	 !log update CRM schema to wmf_civicrm:7021
[22:33:47] <morebots>	 Logged the message, Master
[22:35:42] <grrrit-wm>	 (PS6) Ejegg: Add dates to banner-hiding cookies (server side) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/144991
[22:43:32] <atgo>	 awight - could you write up a collab page on how to do the coinbase import at some point? seems like good knowledge to share :)
[22:45:52] <awight>	 atgo: yeah that was a tragic failure on my part, but most of all, the report file format is still experiencing turbulence :(
[22:46:03] <awight>	 Just column name massaging... we'll get there.
[22:46:25] <atgo>	 yeah... perhaps if it was documented then we might be able to have other folks check it out as well? like if the names look wrong that's ok
[22:46:35] <atgo>	 and then CaitlinVirtue or someone could take a gander and see
[22:47:23] <awight>	 atgo: maybe.  This should only last another week or two
[22:47:28] <atgo>	 oh k
[22:47:29] <awight>	 Then it will be fully automated.
[22:47:42] * awight cuts more skilled jobs
[22:53:22] <awight>	 ccogdill: okay, we're ready to send TY's for the May 8 and July 28 recurring screw-ups.
[22:53:31] <ccogdill>	 awesome!
[22:53:38] <ccogdill>	 so are we doing English today?
[22:53:40] <awight>	 I can check what languages are published now, or we can coordinate with jrobell some more...
[22:53:43] <awight>	 sure!
[22:53:46] <awight>	 Your choice.
[22:53:56] <ccogdill>	 yeah let’s do English for now
[22:54:03] <ccogdill>	 that has to be a reasonably sized group anyway
[22:54:12] <awight>	 great, I'll ping you when finger on the button.
[22:54:18] <ccogdill>	 then ask Jessica tomorrow about the others
[22:54:22] <ccogdill>	 thanks!
[22:54:25] <awight>	 awesome, thank you
[22:54:55] <ccogdill>	 awight are you in the office?
[22:55:48] <awight>	 ccogdill: no, at home
[22:55:53] <ccogdill>	 ah okay
[22:56:12] <ccogdill>	 I saw Caitlin V’s email re the Coinbase USB and wanted to make sure it shouldn’t go down to you
[22:56:13] <awight>	 Planning to be at "work" at least another 1.5 hr
[22:56:24] <ccogdill>	 haha yep that sounds about right
[22:56:48] <awight>	 ccogdill: yeah.  I was waffling about whether to train more people on that-- cos the Coinbase upload is supposed to go away in a few weeks.
[22:57:43] <ccogdill>	 ohh really? well that’s good news! as long as I have access to the Coinbase portal, it’s not too bad to wait until Wednesday to get the data in Civi
[22:59:31] <awight>	 If anyone wants to take the chance, it's the same type of upload that rlewis is doing.  She can demonstrate...
[22:59:53] <awight>	 There's just... column name jiggling you might have to do.
[23:00:38] <ccogdill>	 I don’t think Rosie is in today
[23:00:44] <ccogdill>	 so we can look at it tomorrow?
[23:01:12] <awight>	 ccogdill: Wed is probably best!
[23:01:37] <grrrit-wm>	 (PS3) AndyRussG: Schema change for comments on changes for logs [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/152145 (https://bugzilla.wikimedia.org/31689)
[23:01:54] <ccogdill>	 okay
[23:04:23] <awight>	 ccogdill:
[23:04:24] <awight>	 +--------------+------+----------+
[23:04:24] <awight>	 | no_thank_you | lc   | count(*) |
[23:04:24] <awight>	 +--------------+------+----------+
[23:04:24] <awight>	 | withheld     | da   |        1 |
[23:04:26] <awight>	 | withheld     | de   |        3 |
[23:04:29] <awight>	 | withheld     | en   |      176 |
[23:04:31] <awight>	 | withheld     | es   |        7 |
[23:04:34] <awight>	 | withheld     | fr   |        2 |
[23:04:36] <awight>	 | withheld     | it   |        8 |
[23:04:39] <awight>	 | withheld     | ja   |       19 |
[23:04:41] <awight>	 | withheld     | nl   |       10 |
[23:04:44] <awight>	 | withheld     | pl   |        2 |
[23:04:46] <awight>	 | withheld     | ru   |        8 |
[23:04:49] <awight>	 | withheld     | sv   |        6 |
[23:04:51] <awight>	 | withheld     | zh   |        2 |
[23:04:54] <awight>	 +--------------+------+----------+
[23:04:56] <awight>	 244 total.
[23:04:59] <awight>	 here goes English...
[23:05:06] <ccogdill>	 yeah, I think english should definitely go alone
[23:05:08] <ccogdill>	 thanks!
[23:22:37] <awight>	 ccogdill: I just found a big hole in our quicksand... As many as 11,000 donations were affected since Jan 2013.  We haven't sent these donors a thank-you letter.
[23:23:02] <ccogdill>	 I don’t know if we want to resend if we’re already past that tax year
[23:23:10] <awight>	 I think what is happening is, these donations came in very late through auditing, and the TY grace period had already elapsed.
[23:23:20] <awight>	 yah.  There were 400 this year
[23:23:29] <ccogdill>	 maybe we should resend those
[23:23:34] <awight>	 I'm making a new card to check on this...
[23:23:41] <ccogdill>	 I think this is a conversation a few more people should be involved in
[23:23:50] <awight>	 yep
[23:23:59] <ccogdill>	 because maybe there’s legal stuff we don’t know
[23:24:33] <awight>	 Good point
[23:24:40] <ccogdill>	 so what do you mean TY grace period had already elapsed?
[23:24:57] <ccogdill>	 is that if a donation is reported a month past the initiation date ?
[23:25:25] <awight>	 yeah we have a thing to avoid sending embarrassingly late letters, it's usually set to 2 weeks
[23:26:02] <awight>	 I was going to increase that threshold so we could send out today's recurring GC errors, and noticed this new problem while looking at the donations waiting for a TY
[23:28:55] <awight>	 ccogdill: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1870
[23:29:21] <ccogdill>	 I know BT donations can take up to a month
[23:29:50] <ccogdill>	 so we should probably extend that
[23:30:00] <ccogdill>	 want me to start the email thread awight?
[23:30:05] <ccogdill>	 thanks for making the car
[23:30:08] <ccogdill>	 *Card
[23:34:52] <awight>	 ccogdill: oops, didn't see you, I just sent the email
[23:35:27] <ccogdill>	 ohh no worries! thanks for doin git
[23:37:09] <awight>	 ccogdill: if you play with the SQL in that card, you can get an idea of who was affected...
[23:38:00] <awight>	 ccogdill: So... when I send these letters out, some of the people impacted by this other TY bug will suddenly get a 3-month-old TY letter.
[23:38:22] <awight>	 ccogdill: u mind if we forgo the "sorry for the unexpectedly late TY" text?
[23:38:35] <ccogdill>	 so it’s going to send to *every* english contribution that hasn’t received one?
[23:38:44] <awight>	 yes, back to the grace period.
[23:38:50] <awight>	 erm... actually, this is dastardly:
[23:39:11] <awight>	 I could give all those people a *different* no_thank_you reason, as a bookmark to clean them up later.
[23:39:15] <awight>	 That's what I'll do
[23:39:29] <ccogdill>	 what would the different reasons be?
[23:39:47] <awight>	 like "mystery-FR#1870"
[23:39:48] <awight>	 :)
[23:49:30] <awight>	 ccogdill: okay the 176 en letters should be going out now
[23:50:04] <ccogdill>	 okay, on the lookout!
[23:50:14] <ccogdill>	 and thanks for separating the TY issues
[23:50:15] <awight>	 :)
[23:50:19] <awight>	 oh definitely.
[23:51:25] <awight>	 ccogdill:
[23:51:26] <awight>	 +--------------+------+----------+
[23:51:27] <awight>	 | no_thank_you | lc   | count(*) |
[23:51:27] <awight>	 +--------------+------+----------+
[23:51:27] <awight>	 | withheld     | da   |        1 |
[23:51:29] <awight>	 | withheld     | de   |        3 |
[23:51:31] <awight>	 | withheld     | es   |        7 |
[23:51:34] <awight>	 | withheld     | fr   |        2 |
[23:51:36] <awight>	 | withheld     | it   |        8 |
[23:51:39] <awight>	 | withheld     | ja   |       19 |
[23:51:41] <awight>	 | withheld     | nl   |       10 |
[23:51:44] <awight>	 | withheld     | pl   |        2 |
[23:51:46] <awight>	 | withheld     | ru   |        8 |
[23:51:49] <awight>	 | withheld     | sv   |        6 |
[23:51:51] <awight>	 | withheld     | zh   |        2 |
[23:51:54] <awight>	 +--------------+------+----------+
[23:53:20] <ccogdill>	 looks good! I’ll make a spreadsheet for us to use with Jessica and track these translations
[23:54:15] <awight>	 great!  I'll call it off for the day... That was enuf stress for now :)
[23:56:26] <ccogdill>	 really though!
[23:56:29] <ccogdill>	 have a good one